GNU bug report logs - #74135
[PATCH 1/2] gnu: Improve emacs-popwin definition.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 74135 <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition.
Date: Fri, 01 Nov 2024 15:28:14 +0100

Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

> gnu/packages/emacs-xyz.scm (emacs-popwin): No need to switch off tests during
> build and no native-inputs needed.

Thank you.

I disagree with the removal of "#:tests? #f". It is more meaningful than
simply omitting the keyword. It tells us that the package has tests, but
they are difficult or even impossible to run. Without the keyword, it
could as well mean: "I didn't bother to check if there are tests".
I have no opinion about the removal of native inputs.

I also think the change to version should go in the second patch.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.