GNU bug report logs - #74135
[PATCH 1/2] gnu: Improve emacs-popwin definition.

Previous Next

Full log

Message #20 received at 74135 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: Andrew Tropin <andrew <at> trop.in>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 74135 <at> debbugs.gnu.org
Subject: Re: [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition.
Date: Fri, 1 Nov 2024 20:40:05 +0100

[Message part 1 (text/plain, inline)]

Hello Nicolas,

>     (arguments
>      (list
>       #:tests? #f ; requires an attached terminal
>       ))
>     (native-inputs
>      (list emacs-ert-runner))
>
> "#:tests? #f" with a reason brings some valuable information. I simply suggest
> to keep that line.

If the default for #:tests? ever flips to #t, an explicit #:tests? #f
if overlooked, would prevent tests from running, even though everyone
might assume they are.

Until such a flip occurs, this snippet simply adds to the list of
native inputs without serving any real purpose, leading to unnecessary
use of electricity and computational resources. If the original author
intended to leave a note for future readers, a comment would be a more
suitable approach.

I'm sending you *two* patches: the first removes this redundancy, and
the second updates the emacs-popwin package.

Cheers,
Bost

[0001-gnu-Strip-unnecessary-clutter-from-emacs-popwin.patch (text/x-patch, attachment)]

[0002-gnu-Update-emacs-popwin-to-1.0.2.-2.58adcd0.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.