GNU bug report logs - #74132
31.0.50; thing-at-pt, ffap and Github markdown

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Madhu <enometh <at> meer.net>, 74132 <at> debbugs.gnu.org
Subject: bug#74132: Acknowledgement (31.0.50; thing-at-pt, ffap and Github markdown)
Date: Sat, 2 Nov 2024 15:04:19 -0700

Madhu <enometh <at> meer.net> writes:

> There was a typo in the patch I posted. It should instead look like this

Could you please resend the amended patch as an attachment?

Also, how about having some tests for this?

> ```
> diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
> --- a/lisp/thingatpt.el
> +++ b/lisp/thingatpt.el
> @@ -502,9 +502,15 @@ thing-at-point-bounds-of-url-at-point
>        (let* ((allowed-chars "--:=&?$+@-Z_[:alpha:]~#,%;*()!'[]")
>  	     (skip-before "^[0-9a-zA-Z]")
>  	     (skip-after  ":;.,!?'")
> +             (hard-beg (and thing-at-point-beginning-of-url-regexp
> +                            (save-excursion
> +                              (and
> +                               (re-search-backward
> +                                thing-at-point-beginning-of-url-regexp nil t)
> +                               (point)))))
>  	     (pt (point))
>  	     (beg (save-excursion
> -		    (skip-chars-backward allowed-chars)
> +		    (skip-chars-backward allowed-chars hard-beg)
>  		    (skip-chars-forward skip-before pt)
>  		    (point)))
>  	     (end (save-excursion
> ```

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.