GNU bug report logs - #74124
[PATCH] gnu: Add r-shinyvalidate.

Previous Next

Full log

View this message in rfc822 format

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: Ricardo Wurmus <rekado <at> elephly.net>, "74124-done <at> debbugs.gnu.org" <74124-done <at> debbugs.gnu.org>
Cc: "laurent.gatto <at> gmail.com" <laurent.gatto <at> gmail.com>, "zimon.toutoune <at> gmail.com" <zimon.toutoune <at> gmail.com>
Subject: [bug#74124] [PATCH] gnu: Add r-shinyvalidate.
Date: Fri, 3 Jan 2025 18:23:11 +0000

[Message part 1 (text/plain, inline)]

Hi Ricardo,

Thank you for the quick response. Is r-testthat now necessary across the board for all R packages? I do have a couple of other outstanding R patches that I can update if needed and ping the team.

Best,
Spencer
________________________________
From: Ricardo Wurmus <rekado <at> elephly.net>
Sent: Friday, January 3, 2025 12:20 PM
To: 74124-done <at> debbugs.gnu.org <74124-done <at> debbugs.gnu.org>
Cc: King, Spencer <spencer.king <at> wustl.edu>; laurent.gatto <at> gmail.com <laurent.gatto <at> gmail.com>; zimon.toutoune <at> gmail.com <zimon.toutoune <at> gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

--
Ricardo

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.