GNU bug report logs - #74124
[PATCH] gnu: Add r-shinyvalidate.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74124: closed ([PATCH] gnu: Add r-shinyvalidate.)
Date: Fri, 03 Jan 2025 18:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 03 Jan 2025 19:20:59 +0100
with message-id <87o70n69o4.fsf <at> elephly.net>
and subject line [PATCH] gnu: Add r-shinyvalidate.
has caused the debbugs.gnu.org bug report #74124,
regarding [PATCH] gnu: Add r-shinyvalidate.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74124: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74124
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "King, Spencer via Guix-patches via" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add r-shinyvalidate.
Date: Wed, 30 Oct 2024 22:35:31 +0000

[Message part 3 (text/plain, inline)]

[0001-gnu-Add-r-shinyvalidate.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 74124-done <at> debbugs.gnu.org
Cc: "King, Spencer" <spencer.king <at> wustl.edu>,
 "laurent.gatto <at> gmail.com" <laurent.gatto <at> gmail.com>,
 "zimon.toutoune <at> gmail.com" <zimon.toutoune <at> gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.
Date: Fri, 03 Jan 2025 19:20:59 +0100

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.