GNU bug report logs - #74093
[PATCH] doc: Explicitly mention --localstatedir and --sysconfdir configure flags.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74093 in the body.
You can then email your comments to 74093 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] doc: Explicitly mention --localstatedir and --sysconfdir
 configure flags.
Date: Tue, 29 Oct 2024 18:50:57 +0000

Prior to this commit, the terms localstatedir and sysconfdir were used without
being defined earlier. This commit clarifies that they are configure flags.

* doc/contributing.texi (Building from Git): Explicitly mention
--localstatedir and --sysconfdir configure flags.

Change-Id: I3e6edbbc1f2a342196e732e14257dbdf9a3f4303
---
 doc/contributing.texi | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index acdc303be6..d397410abe 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -240,12 +240,13 @@ Building from Git
 @end example
 
 @noindent
-... where @file{/var} is the normal @code{localstatedir} value
-(@pxref{The Store}, for information about this) and @file{/etc} is the
-normal @code{sysconfdir} value.  Note that you will probably not run
-@command{make install} at the end (you don't have to) but it's still
-important to pass the right @code{localstatedir} and @code{sysconfdir}
-values, which get recorded in the @code{(guix config)} Guile module.
+Optionally, @code{--localstatedir} and @code{--sysconfdir} can also be
+provided as arguments.  By default, @code{localstatedir} is @file{/var}
+(@pxref{The Store}, for information about this) and @code{sysconfdir} is
+@file{/etc}.  Note that you will probably not run @command{make install}
+at the end (you don't have to) but it's still important to pass the
+right @code{localstatedir} and @code{sysconfdir} values, which get
+recorded in the @code{(guix config)} Guile module.
 
 Finally, you can build Guix and, if you feel so inclined, run the tests
 (@pxref{Running the Test Suite}):

base-commit: a9c33e9f688fce88aed610ab04c650efb71b4ce6
-- 
2.45.2

Message #8 received at 74093 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 74093 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#74093] [PATCH] doc: Explicitly mention --localstatedir and
 --sysconfdir configure flags.
Date: Fri, 01 Nov 2024 11:17:50 +0100

Hello Arun,

Arun Isaac <arunisaac <at> systemreboot.net> writes:
> Prior to this commit, the terms localstatedir and sysconfdir were used without
> being defined earlier.

The word “earlier” in the commit message is misleading, since
Contributing is chapter 22 and localstatedir was mentioned in other
sections if someone were to read chapter by chapter.

But anyway, your contributing.texi’s new wording is much better!
Please push.

Regards,
Florian

Message #11 received at 74093 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 74093 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#74093] [PATCH] doc: Explicitly mention --localstatedir and
 --sysconfdir configure flags.
Date: Fri, 01 Nov 2024 11:49:38 +0000

Hi Florian,

>> Prior to this commit, the terms localstatedir and sysconfdir were used without
>> being defined earlier.
>
> The word “earlier” in the commit message is misleading, since
> Contributing is chapter 22 and localstatedir was mentioned in other
> sections if someone were to read chapter by chapter.

Good point. How about I say "without being defined earlier in this
section"?

Regards,
Arun

Message #14 received at 74093 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 74093 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#74093] [PATCH] doc: Explicitly mention --localstatedir and
 --sysconfdir configure flags.
Date: Fri, 01 Nov 2024 13:07:10 +0100

Arun Isaac <arunisaac <at> systemreboot.net> writes:
> Good point. How about I say "without being defined earlier in this
> section"?

Yes, that I understand.  The alternative I had thought of was removing
the word “earlier”, but that would actually be not true, because of
sections Invoking guix pack and The Store, which you reference.

Regards,
Florian

Message #19 received at 74093-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 74093-done <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>,
 pelzflorian <pelzflorian <at> pelzflorian.de>
Subject: Re: [PATCH] doc: Explicitly mention --localstatedir and
 --sysconfdir configure flags.
Date: Tue, 05 Nov 2024 22:51:30 +0000

Pushed, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.