GNU bug report logs - #74091
31.0.50; string-pixel-width in mode line disables region

Previous Next

Full log

Message #61 received at 74091 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: me <at> eshelyaron.com, 74091 <at> debbugs.gnu.org
Subject: Re: bug#74091: 31.0.50; string-pixel-width in mode line disables
 region
Date: Sun, 10 Nov 2024 07:50:47 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: me <at> eshelyaron.com,  74091 <at> debbugs.gnu.org
> Date: Sat, 09 Nov 2024 17:11:19 -0500
> 
> > I think we should instead ignore the permanent-local property of
> > variables.  How about the patch below?
> 
> Funny: I went through 3 different versions of a patch and ended up with
> basically the same patch as yours.

;-)

> > @@ -1170,7 +1171,7 @@ reset_buffer_local_variables (struct buffer *b, bool permanent_too)
> >  	      swap_in_global_binding (XSYMBOL (sym));
> >  	    }
> >  
> > -          if (!NILP (prop))
> > +          if (!NILP (prop) && permanent_too)
> >              {
> >                /* If permanent-local, keep it.  */
> >                last = tmp;
> 
> This should be an || rather than an &&, no?

No, I don't think so.  If the permanent-local property is nil, we
should not take this branch, even if permanent_too is non-zero.  Or
what am I missing?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.