Subject: [bug#74057] [PATCH v2 1/1] gnu: Add python-green.

From: Maxim Cournoyer <[email-masked]>
Date: Fri, 01 Nov 2024 22:58:46 +0900

Hi,

get-state <[email-masked]> writes:

> From: Wiktor Żelazny <[email-masked]>
>
> * gnu/packages/python-check.scm (python-green): New variable.
>
> Change-Id: I554e8a635ff51413c79e3834fc1b88b34bbda84b
> Signed-off-by: get-state <[email-masked]>

This is a cool collaboration :-).  I believe the correct trailer to
denote a review should be 'Reviewed-by: ...'.

> ---
>  gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
> index ba66b081a5..3d181c8f7e 100644
> --- a/gnu/packages/python-check.scm
> +++ b/gnu/packages/python-check.scm
> @@ -3003,3 +3003,27 @@ (define-public python-vulture
>  dead code.  Also, code that is only called implicitly may be reported as
>  unused.")
>      (license license:expat)))
> +
> +(define-public python-green
> +  (package
> +    (name "python-green")
> +    (version "4.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "green" version))
> +       (sha256
> +        (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
> +    (build-system pyproject-build-system)
> +    ;; python-coverage both in requirements.txt and requirements-dev.txt
> +    (propagated-inputs (list python-colorama python-coverage python-lxml
> +                             python-unidecode))
> +    (native-inputs (list python-black python-django python-mypy
> +                         python-testtools))
> +    (home-page "https://github.com/CleanCut/green")
> +    (synopsis "Clean, colorful, fast python test runner")
> +    (description
> +     "@code{green} is a python test runner which in addition to
> +being clean, colorful and fast describes itself as powerful, traditional,
> +descriptive, convenient, thorough, embedded, modern, portable and living.")
> +    (license license:expat)))

I've capitalized Python, adjusted the trailer and did a few improvements
to the description/style:

--8<---------------cut here---------------start------------->8---
1 file changed, 32 insertions(+), 9 deletions(-)
gnu/packages/python-check.scm | 41 ++++++++++++++++++++++++++++++++---------

modified   gnu/packages/python-check.scm
@@ -3015,15 +3015,38 @@ (define-public python-green
        (sha256
         (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
     (build-system pyproject-build-system)
-    ;; python-coverage both in requirements.txt and requirements-dev.txt
-    (propagated-inputs (list python-colorama python-coverage python-lxml
-                             python-unidecode))
-    (native-inputs (list python-black python-django python-mypy
-                         python-testtools))
+    (native-inputs
+     (list python-black
+           python-django
+           python-mypy
+           python-testtools))
+    ;; The python-coverage dependency appears both in requirements.txt and
+    ;; requirements-dev.txt.
+    (propagated-inputs
+     (list python-colorama
+           python-coverage
+           python-lxml
+           python-unidecode))
     (home-page "https://github.com/CleanCut/green")
-    (synopsis "Clean, colorful, fast python test runner")
+    (synopsis "Clean, colorful, fast Python test runner")
     (description
-     "@code{green} is a python test runner which in addition to
-being clean, colorful and fast describes itself as powerful, traditional,
-descriptive, convenient, thorough, embedded, modern, portable and living.")
+     "@code{green} is a Python test runner that describes itself as:
+@table @emph
+@item Clean
+Low redundancy in output.  Result statistics for each test is vertically aligned.
+@item Colorful
+Terminal output makes good use of color when the terminal supports it.
+@item Fast
+Tests run in independent processes (one per processor by default).
+@item Powerful
+Multi-target and auto-discovery support.
+@item Traditional
+It uses the normal @code{unittest} classes and methods.
+@item Descriptive
+Multiple verbosity levels, from just dots to full docstring output.
+@item Convenient
+Bash-completion and ZSH-completion of options and test targets.
+@item Thorough
+Built-in integration with @url{http://nedbatchelder.com/code/coverage/, coverage}.
+@end table")
     (license license:expat)))

[back]
--8<---------------cut here---------------end--------------->8---

And pushed as commit 08dc72473b.

Thanks to both of you!  Closing.

-- 
Maxim