GNU bug report logs - #74055
31.0.50; color-lighten-name not lightening black

Previous Next

Package: emacs;

Reported by: Gerd Möllmann <gerd.moellmann <at> gmail.com>

Date: Mon, 28 Oct 2024 08:29:02 UTC

Severity: normal

Found in version 31.0.50

Fixed in version 31.1

Done: Gerd Möllmann <gerd.moellmann <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: julien <at> danjou.info, mattias.engdegard <at> gmail.com, noah <at> splode.com, 74055 <at> debbugs.gnu.org
Subject: bug#74055: 31.0.50; color-lighten-name not lightening black
Date: Sat, 02 Nov 2024 18:10:51 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,  julien <at> danjou.info,
>>   74055 <at> debbugs.gnu.org,  noah <at> splode.com
>> Date: Tue, 29 Oct 2024 19:27:14 +0100
>> 
>> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>> 
>> > I'd say the old model (percentage points) is better because it results
>> > in changes that are perceptually more uniform. For example, with the
>> > current code,
>> >
>> >   (color-lighten-name C 5)
>> >
>> > has much less effect when C is a dark colour than for a light one.
>> > Therefore the change was probably a mistake in hindsight.
>> 
>> +1
>
> I hope I fixed that now, please take a look.
>
> Noah's original example works as expected, and the comparison with Web
> sites also seems to be working.

Works for me, too. Thanks!
This bug report was last modified 277 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.