GNU bug report logs - #74049
[PATCH v1] gnu: matterbridge: Unbundle most golang.org dependencies.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: bug#74049: closed ([PATCH v1] gnu: matterbridge: Unbundle most
 golang.org dependencies.)
Date: Tue, 19 Nov 2024 12:02:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#74049: [PATCH v1] gnu: matterbridge: Unbundle most golang.org dependencies.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 74049 <at> debbugs.gnu.org.

-- 
74049: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74049
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74049-done <at> debbugs.gnu.org
Subject: [PATCH v1] gnu: matterbridge: Unbundle most golang.org dependencies.
Date: Tue, 19 Nov 2024 12:00:12 +0000

[Message part 3 (text/plain, inline)]

Hi,

I've adjusted the patch a litle by adding embeded file search for
"golang.org/x/net" and fix build with "github.com/russross/blackfriday".

Pushed as cdf968ae86..1dd7a47b65 to master.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: guix-patches <at> gnu.org,
	Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH v1] gnu: matterbridge: Unbundle most golang.org dependencies.
Date: Sun, 27 Oct 2024 19:12:46 +0100

The vendor/golang.org/x/net dependency was kept because removing it redults in
a compilation failure:
    %exception #<&invoke-error program: "go" arguments: ("install" "-v" "-x"
     "-ldflags=-s -w" "-trimpath" "github.com/42wim/matterbridge")
     exit-status: 1 term-signal: #f stop-signal: #f>

* gnu/packages/messaging.scm (matterbridge) [source]:
  Add snippet removing the unbundled dependencies.
  [arguments]: Add new unbundled dependencies.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Change-Id: I67afeff8721833d34a54fd52684a4acbcbcaf179
---
 gnu/packages/messaging.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index c482cd469e..86f6ff0e04 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3302,6 +3302,19 @@ (define-public matterbridge
                     (url "https://github.com/42wim/matterbridge")
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
+              (modules '((guix build utils)))
+              (snippet '(for-each delete-file-recursively
+                                  ;; TODO: unbundle the rest as well
+                                  '("vendor/golang.org/x/crypto"
+                                    "vendor/golang.org/x/image"
+                                    "vendor/golang.org/x/mod"
+                                    "vendor/golang.org/x/oauth2"
+                                    "vendor/golang.org/x/sys"
+                                    "vendor/golang.org/x/term"
+                                    "vendor/golang.org/x/text"
+                                    "vendor/golang.org/x/time"
+                                    "vendor/golang.org/x/tools")))
+
               (sha256
                (base32
                 "0939fiy7z53izznfhlr7c6vaskbmkbj3ncb09fzx5dmz9cjngy80"))))
@@ -3309,6 +3322,15 @@ (define-public matterbridge
     (arguments
      (list
       #:import-path "github.com/42wim/matterbridge"))
+    (inputs (list go-golang-org-x-crypto
+                  go-golang-org-x-image
+                  go-golang-org-x-mod
+                  go-golang-org-x-oauth2
+                  go-golang-org-x-sys
+                  go-golang-org-x-term
+                  go-golang-org-x-text
+                  go-golang-org-x-time
+                  go-golang-org-x-tools))
     (synopsis "Bridge together various messaging networks and protocols")
     (description
      "Relays messages between different channels from various
-- 
2.46.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.