GNU bug report logs - #74033
31.0.50; [PATCH] Improve accuracy of Eshell globbing syntax

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74033 in the body.
You can then email your comments to 74033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [PATCH] Improve accuracy of Eshell globbing syntax
Date: Sat, 26 Oct 2024 15:08:10 -0700

[Message part 1 (text/plain, inline)]

I've been tracking down a few issues with how Eshell parses its globs. 
For example:

  ~ $ echo **/
  # Prints all subdirectories of the current dir (good)
  ~ $ echo '**/'
  **/  # Prints the literal string (also good)
  ~ $ echo \**/
  # Prints all subdirectories (bad!)

There are a few reasons this happens but one of the things that makes 
this code more brittle is that Eshell defaults to treating characters as 
globs, and you have to opt out via an 'escape' text property. By 
inverting this logic, and proactively marking globbing characters with 
'eshell-glob-char', it now means that all the rules for determining 
which characters are globs and which are literals is in em-glob.el, so 
it should be harder to break in the future.

[0001-Improve-correctness-of-Eshell-globs-when-using-escap.patch (text/plain, attachment)]

Message #10 received at 74033-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 74033-done <at> debbugs.gnu.org
Subject: Re: bug#74033: 31.0.50; [PATCH] Improve accuracy of Eshell globbing
 syntax
Date: Thu, 31 Oct 2024 22:40:06 -0700

On 10/26/2024 3:08 PM, Jim Porter wrote:
> I've been tracking down a few issues with how Eshell parses its globs. 

Now merged to the master branch as 9682d385c10, so closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.