From unknown Sun Jun 22 08:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74030: [PATCH] srfi-64: Accept symbols as test group names. Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 26 Oct 2024 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74030 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 74030@debbugs.gnu.org Cc: Tomas Volf <~@wolfsden.cz> X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172995886319306 (code B ref -1); Sat, 26 Oct 2024 16:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Oct 2024 16:07:43 +0000 Received: from localhost ([127.0.0.1]:42344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4jKJ-00051J-44 for submit@debbugs.gnu.org; Sat, 26 Oct 2024 12:07:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:44778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1t4jKH-000519-Ex for submit@debbugs.gnu.org; Sat, 26 Oct 2024 12:07:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1t4jJe-0005Zd-Ps for bug-guile@gnu.org; Sat, 26 Oct 2024 12:07:02 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1t4jJc-0005Em-IN for bug-guile@gnu.org; Sat, 26 Oct 2024 12:07:02 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 53A6432AD58; Sat, 26 Oct 2024 16:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1729958817; bh=KPXO0yW0oLZQzvz0eARK13FQNiEC3+H0f4j2FpxeVe8=; h=From:To:Cc:Subject:Date; b=oS7lPXyazVNkzDhW3cMzKvRw+xXqRWhZJ9OjUSPBMsZUSU7hd1/DLa0XejmKctjvl R8QPSkRzJUxf2hgHoPOfTTxQ697gNSbDzjpslD3exNNCtGInDgJylV++SUJF4S4KTs OBOFl+Cl3nDxEhMngvLBxF1NsVRnp3lMOJJIYgmYbwhqLflQ2hTeXStewEWjYa5QZ6 QRg8aFZIpi6C1XiuvGlZTDPfnxpzHQyVRcfWGwL+kzUaPd2ECrjjrtyjNuS15iP+Ic CKN6yO2yQ6/A8rLmV1INMHty1Wmkj1HyGz4rpZeQyBhon7cdDdCq8kVd20eUnYEAUZ VxLRqbuy4LdV2YNtFdDxiN31ymWCUrDfzB5vDlWTNCdyawEIG9gDWURrX3ckVG8X07 N64vkFzts7KXrAw4X2ZHHgion8hFuNfj1cR4K7QG3/U2iIU22tER/PI+o4wuXF/PZ9 mLPD0LiOQsTPvSxhMPVwJYtw35Iq214V/2u/LpM4eDiKwwLHBeAAMdgO1ZAYqnjTHz kv5Ybw7b3jLHZ1C3GdgLKtqjQRn0uIPfkCY+xWKJJBFH3NHfZ4vf2hByThPTJ5THPp MMtZPkh9hC9k9MyiW5W3SyRi8ZUXMn/YQQ6NmYxGlU9u9N3idlj3wZkHXU2OQs6tCw BaWIwqveyCxvLHvnq9Pz+OQ8= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 6B5CF32B5AA; Sat, 26 Oct 2024 16:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1729958816; bh=KPXO0yW0oLZQzvz0eARK13FQNiEC3+H0f4j2FpxeVe8=; h=From:To:Cc:Subject:Date; b=CHdNFMxyTulKTpEBdagAD9M2LfJROmsnVTiS3+U/YMoaK3l0zv4FWcFftu/+dHN1m d5Z8DNLgbYoAm+GBLLKeXozenYnHaN2bc//XKG0ET+RJUk/KQ+XlL+bTCQdKvPud6U cx+3exJfEYOo7WA7y8Mg4yAZX1SPA6uxWZtolYa1Q6Tw4f0e7e9OHU91yth8dszFeJ R6bpBN8RGCZCgEjl0wHm4r32TTO7d13xhI2JXgormYmCB+AHcl+gSbvUzfbUa6TFIq LvUaaT/eVyiqAt74xjSb9t9oswjRjFi9Z6kdoc4aaywtjE6tiONSrRDvO5g3XoIDYi Soc9nzn4hkHwPt6KcZ5NyoAh9zv4KSwUnFUuCq0CFczTT8iRJoS2ViG6eizLOAqQlc hSnIm7Ad0W2eN2zAMyjwJJ/Xr/LMltiJqCJs92BZtaByNQA/GUC48jokfut/u1Mlvq HqHSFJe45UQhUQ6m1dCs2M/TwuQg8WZViRykTFEx7cEcLG94kmuGIEaP3UwuSKOCtg lXE4DbHY4wgg0WSFPKckAG2AgM69pL8k7piszREqmWRI97+9cuIuNvWVxpq35pNjOK b/U2BwT4Ko5N/iGAjaoslq5NtyAbPIBRKrVEg36mD2Dhh+TDsKBHhYR9zpcvhhN+bf HnunthPfUlgav+mwPeLHqdxk= From: Tomas Volf <~@wolfsden.cz> Date: Sat, 26 Oct 2024 18:06:51 +0200 Message-ID: <20241026160651.20915-1-~@wolfsden.cz> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The specification mandates a string, but with rationale suggesting symbols would be a more natural fit. > In some ways using symbols would be preferable. However, we want > human-readable names, and standard Scheme does not provide a way to include > spaces or mixed-case text in literal symbols. Add support for symbols as implementation extension. * module/srfi/srfi-64.scm (%cmp-group-name): New procedure. (test-end): Use it. --- module/srfi/srfi-64.scm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm index 1f60a72e5..98fcef645 100644 --- a/module/srfi/srfi-64.scm +++ b/module/srfi/srfi-64.scm @@ -522,7 +522,10 @@ returning new test runner. Defaults to @code{test-runner-simple}.") (1+ (group-executed-count group))))))) (define* (test-begin suite-name #:optional count) - "Enter a new test group." + "Enter a new test group. + +As implementation extension, in addition to strings, symbols are also +supported as @var{suite-name}." (let* ((r (test-runner-current)) (r install? (if r (values r #f) @@ -544,6 +547,14 @@ returning new test runner. Defaults to @code{test-runner-simple}.") ((test-runner-on-group-begin r) r suite-name count))) +(define (%cmp-group-name a b) + (match (list a b) + (((? string?) (? string?)) + (string=? a b)) + (((? symbol?) (? symbol?)) + (eq? a b)) + (_ #f))) + (define* (test-end #:optional suite-name) "Leave the current test group." (let* ((r (test-runner-current)) @@ -551,7 +562,7 @@ returning new test runner. Defaults to @code{test-runner-simple}.") (let ((begin-name (car (test-runner-group-stack r))) (end-name suite-name)) - (when (and end-name (not (string=? begin-name end-name))) + (when (and end-name (not (%cmp-group-name begin-name end-name))) ((test-runner-on-bad-end-name r) r begin-name end-name) (raise-exception (make-bad-end-name begin-name end-name)))) -- 2.46.0 From unknown Sun Jun 22 08:03:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tomas Volf <~@wolfsden.cz> Subject: bug#74030: closed (Re: bug#74030: [PATCH] srfi-64: Accept symbols as test group names.) Message-ID: References: <87iktevkzy.fsf@gnu.org> <20241026160651.20915-1-~@wolfsden.cz> X-Gnu-PR-Message: they-closed 74030 X-Gnu-PR-Package: guile X-Gnu-PR-Keywords: patch Reply-To: 74030@debbugs.gnu.org Date: Sat, 26 Oct 2024 17:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1729963322-472-1" This is a multi-part message in MIME format... ------------=_1729963322-472-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74030: [PATCH] srfi-64: Accept symbols as test group names. which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74030@debbugs.gnu.org. --=20 74030: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74030 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1729963322-472-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74030-done) by debbugs.gnu.org; 26 Oct 2024 17:21:41 +0000 Received: from localhost ([127.0.0.1]:42421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4kTs-00006m-Tx for submit@debbugs.gnu.org; Sat, 26 Oct 2024 13:21:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4kTq-00006G-Mz for 74030-done@debbugs.gnu.org; Sat, 26 Oct 2024 13:21:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4kT8-0007tp-R4; Sat, 26 Oct 2024 13:20:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=sGE3YqIG9wTMngS2AMr8ujQyPxNa3bPgyTm5Rmq7coE=; b=hooC/w/tGX6M5KLnJ0Fg KDr/lBI0WEMEXwpO95uQCDKc1SR1vk9qjqPDCGvRyQDsAjzIGBh39vQgxGFIT4SO6w63XhwaVsk/V XZyPndLZATc0fgFHMyhKPdVc7SUAwSwbdG9omN61SxLxAd6n4DcQYiivgGYsbX5x6jytUCxAclRRC pxySGdJfTtdAquTS9UCTrs6XKKkrNWPPgwFiiiG6l0LEeR0n59OHAs/r0HVLiVc5DAjgJ1hW4FpzR ZL0FHFky3bBuihbCTVq1mszTPMqPhTm80JWhBIERwNZ8K8YcJRnpLZGt+z1Ppb3eHkvyGXgaOfP6q NrigOULaPN067Q==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tomas Volf <~@wolfsden.cz> Subject: Re: bug#74030: [PATCH] srfi-64: Accept symbols as test group names. In-Reply-To: <20241026160651.20915-1-~@wolfsden.cz> (Tomas Volf's message of "Sat, 26 Oct 2024 18:06:51 +0200") References: <20241026160651.20915-1-~@wolfsden.cz> Date: Sat, 26 Oct 2024 19:20:49 +0200 Message-ID: <87iktevkzy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74030-done Cc: 74030-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tomas Volf <~@wolfsden.cz> skribis: > The specification mandates a string, but with rationale suggesting symbols > would be a more natural fit. > >> In some ways using symbols would be preferable. However, we want >> human-readable names, and standard Scheme does not provide a way to incl= ude >> spaces or mixed-case text in literal symbols. > > Add support for symbols as implementation extension. > > * module/srfi/srfi-64.scm (%cmp-group-name): New procedure. > (test-end): Use it. I added =E2=80=9Cfor backwards compatibility with the reference implementat= ion=E2=80=9D and credited Daniel for reporting the issue. Applied, thanks! Ludo=E2=80=99. ------------=_1729963322-472-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Oct 2024 16:07:43 +0000 Received: from localhost ([127.0.0.1]:42344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4jKJ-00051J-44 for submit@debbugs.gnu.org; Sat, 26 Oct 2024 12:07:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:44778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1t4jKH-000519-Ex for submit@debbugs.gnu.org; Sat, 26 Oct 2024 12:07:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1t4jJe-0005Zd-Ps for bug-guile@gnu.org; Sat, 26 Oct 2024 12:07:02 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1t4jJc-0005Em-IN for bug-guile@gnu.org; Sat, 26 Oct 2024 12:07:02 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 53A6432AD58; Sat, 26 Oct 2024 16:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1729958817; bh=KPXO0yW0oLZQzvz0eARK13FQNiEC3+H0f4j2FpxeVe8=; h=From:To:Cc:Subject:Date; b=oS7lPXyazVNkzDhW3cMzKvRw+xXqRWhZJ9OjUSPBMsZUSU7hd1/DLa0XejmKctjvl R8QPSkRzJUxf2hgHoPOfTTxQ697gNSbDzjpslD3exNNCtGInDgJylV++SUJF4S4KTs OBOFl+Cl3nDxEhMngvLBxF1NsVRnp3lMOJJIYgmYbwhqLflQ2hTeXStewEWjYa5QZ6 QRg8aFZIpi6C1XiuvGlZTDPfnxpzHQyVRcfWGwL+kzUaPd2ECrjjrtyjNuS15iP+Ic CKN6yO2yQ6/A8rLmV1INMHty1Wmkj1HyGz4rpZeQyBhon7cdDdCq8kVd20eUnYEAUZ VxLRqbuy4LdV2YNtFdDxiN31ymWCUrDfzB5vDlWTNCdyawEIG9gDWURrX3ckVG8X07 N64vkFzts7KXrAw4X2ZHHgion8hFuNfj1cR4K7QG3/U2iIU22tER/PI+o4wuXF/PZ9 mLPD0LiOQsTPvSxhMPVwJYtw35Iq214V/2u/LpM4eDiKwwLHBeAAMdgO1ZAYqnjTHz kv5Ybw7b3jLHZ1C3GdgLKtqjQRn0uIPfkCY+xWKJJBFH3NHfZ4vf2hByThPTJ5THPp MMtZPkh9hC9k9MyiW5W3SyRi8ZUXMn/YQQ6NmYxGlU9u9N3idlj3wZkHXU2OQs6tCw BaWIwqveyCxvLHvnq9Pz+OQ8= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 6B5CF32B5AA; Sat, 26 Oct 2024 16:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1729958816; bh=KPXO0yW0oLZQzvz0eARK13FQNiEC3+H0f4j2FpxeVe8=; h=From:To:Cc:Subject:Date; b=CHdNFMxyTulKTpEBdagAD9M2LfJROmsnVTiS3+U/YMoaK3l0zv4FWcFftu/+dHN1m d5Z8DNLgbYoAm+GBLLKeXozenYnHaN2bc//XKG0ET+RJUk/KQ+XlL+bTCQdKvPud6U cx+3exJfEYOo7WA7y8Mg4yAZX1SPA6uxWZtolYa1Q6Tw4f0e7e9OHU91yth8dszFeJ R6bpBN8RGCZCgEjl0wHm4r32TTO7d13xhI2JXgormYmCB+AHcl+gSbvUzfbUa6TFIq LvUaaT/eVyiqAt74xjSb9t9oswjRjFi9Z6kdoc4aaywtjE6tiONSrRDvO5g3XoIDYi Soc9nzn4hkHwPt6KcZ5NyoAh9zv4KSwUnFUuCq0CFczTT8iRJoS2ViG6eizLOAqQlc hSnIm7Ad0W2eN2zAMyjwJJ/Xr/LMltiJqCJs92BZtaByNQA/GUC48jokfut/u1Mlvq HqHSFJe45UQhUQ6m1dCs2M/TwuQg8WZViRykTFEx7cEcLG94kmuGIEaP3UwuSKOCtg lXE4DbHY4wgg0WSFPKckAG2AgM69pL8k7piszREqmWRI97+9cuIuNvWVxpq35pNjOK b/U2BwT4Ko5N/iGAjaoslq5NtyAbPIBRKrVEg36mD2Dhh+TDsKBHhYR9zpcvhhN+bf HnunthPfUlgav+mwPeLHqdxk= From: Tomas Volf <~@wolfsden.cz> To: bug-guile@gnu.org Subject: [PATCH] srfi-64: Accept symbols as test group names. Date: Sat, 26 Oct 2024 18:06:51 +0200 Message-ID: <20241026160651.20915-1-~@wolfsden.cz> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The specification mandates a string, but with rationale suggesting symbols would be a more natural fit. > In some ways using symbols would be preferable. However, we want > human-readable names, and standard Scheme does not provide a way to include > spaces or mixed-case text in literal symbols. Add support for symbols as implementation extension. * module/srfi/srfi-64.scm (%cmp-group-name): New procedure. (test-end): Use it. --- module/srfi/srfi-64.scm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm index 1f60a72e5..98fcef645 100644 --- a/module/srfi/srfi-64.scm +++ b/module/srfi/srfi-64.scm @@ -522,7 +522,10 @@ returning new test runner. Defaults to @code{test-runner-simple}.") (1+ (group-executed-count group))))))) (define* (test-begin suite-name #:optional count) - "Enter a new test group." + "Enter a new test group. + +As implementation extension, in addition to strings, symbols are also +supported as @var{suite-name}." (let* ((r (test-runner-current)) (r install? (if r (values r #f) @@ -544,6 +547,14 @@ returning new test runner. Defaults to @code{test-runner-simple}.") ((test-runner-on-group-begin r) r suite-name count))) +(define (%cmp-group-name a b) + (match (list a b) + (((? string?) (? string?)) + (string=? a b)) + (((? symbol?) (? symbol?)) + (eq? a b)) + (_ #f))) + (define* (test-end #:optional suite-name) "Leave the current test group." (let* ((r (test-runner-current)) @@ -551,7 +562,7 @@ returning new test runner. Defaults to @code{test-runner-simple}.") (let ((begin-name (car (test-runner-group-stack r))) (end-name suite-name)) - (when (and end-name (not (string=? begin-name end-name))) + (when (and end-name (not (%cmp-group-name begin-name end-name))) ((test-runner-on-bad-end-name r) r begin-name end-name) (raise-exception (make-bad-end-name begin-name end-name)))) -- 2.46.0 ------------=_1729963322-472-1--