GNU bug report logs - #7403
Unused variable `$source' in the depcomp script?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7403 in the body.
You can then email your comments to 7403 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: Unused variable `$source' in the depcomp script?
Date: Mon, 15 Nov 2010 01:03:04 +0100

Hello automakers.

In the git master branch:
 $ grep '\<source\>' lib/depcomp 
   source      Source file read by `PROGRAMS ARGS'.
 if test -z "$depmode" || test -z "$source" || test -z "$object"; then
   echo "depcomp: Variables source, object and depmode must be set" 1>&2
     # the object too, otherwise makedepend will parse it as a source file.

Does this mean that the `$source' variable is really not required
by depcomp, or am I missing something?

Regards,
  Stefano

Message #8 received at 7403 <at> debbugs.gnu.org (full text, mbox):

From: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 7403 <at> debbugs.gnu.org
Subject: Re: bug#7403: Unused variable `$source' in the depcomp script?
Date: Sat, 20 Nov 2010 13:29:10 +0100

* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 01:03:04AM CET:
>  $ grep '\<source\>' lib/depcomp 
>    source      Source file read by `PROGRAMS ARGS'.
>  if test -z "$depmode" || test -z "$source" || test -z "$object"; then
>    echo "depcomp: Variables source, object and depmode must be set" 1>&2
>      # the object too, otherwise makedepend will parse it as a source file.
> 
> Does this mean that the `$source' variable is really not required
> by depcomp, or am I missing something?

It seems that $source is indeed not required.

I'd still be wary of removing it: users might have modified depcomp
scripts which use the variable.  Yes, I consider that public API,
documented in 'depcomp --help', and with example usage in the manual.

In a sort of transposed way, there are packages using depcomp (plus some
custom macros) which do not use Automake; we should not break them
either.

Thanks,
Ralf

Message #11 received at 7403 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>
Cc: 7403 <at> debbugs.gnu.org
Subject: Re: bug#7403: Unused variable `$source' in the depcomp script?
Date: Sat, 20 Nov 2010 14:10:41 +0100

On Saturday 20 November 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 01:03:04AM CET:
> >  $ grep '\<source\>' lib/depcomp 
> >    source      Source file read by `PROGRAMS ARGS'.
> >  if test -z "$depmode" || test -z "$source" || test -z "$object"; then
> >    echo "depcomp: Variables source, object and depmode must be set" 1>&2
> >      # the object too, otherwise makedepend will parse it as a source file.
> > 
> > Does this mean that the `$source' variable is really not required
> > by depcomp, or am I missing something?
> 
> It seems that $source is indeed not required.
> 
> I'd still be wary of removing it: users might have modified depcomp
> scripts which use the variable.  Yes, I consider that public API,
> documented in 'depcomp --help', and with example usage in the manual.
> 
> In a sort of transposed way, there are packages using depcomp (plus some
> custom macros) which do not use Automake; we should not break them
> either.
> 
Makes sense.  You can close the bug if you want (maybe with tag "wontfix"?)

Thanks,
   Stefano

Message #14 received at 7403 <at> debbugs.gnu.org (full text, mbox):

From: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 7403 <at> debbugs.gnu.org
Subject: Re: bug#7403: Unused variable `$source' in the depcomp script?
Date: Sat, 20 Nov 2010 15:27:39 +0100

tags 7403 wontfix
close 7403

* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 02:10:41PM CET:
> Makes sense.  You can close the bug if you want (maybe with tag "wontfix"?)

You can also do that yourself if you like.  Just put control at debbugs
in Bcc: for commands like above.

Cheers,
Ralf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.