GNU bug report logs - #74019
[PATCH] Optionally preserve selected candidate across *Completions* update

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74019: closed ([PATCH] Optionally preserve selected candidate
 across *Completions* update)
Date: Thu, 14 Nov 2024 17:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 Nov 2024 12:09:09 -0500
with message-id <jwv7c95spy3.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#74019: [PATCH] Optionally preserve selected candidate across *Completions* update
has caused the debbugs.gnu.org bug report #74019,
regarding [PATCH] Optionally preserve selected candidate across *Completions* update
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74019: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74019
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Juri Linkov <juri <at> linkov.net>
Subject: [PATCH] Optionally preserve selected candidate across *Completions*
 update
Date: Fri, 25 Oct 2024 17:32:38 -0400

[Message part 3 (text/plain, inline)]

Tags: patch


Add completion-preserve-selection, a defcustom which allows keeping the
same selected candidate after *Completions* is updated by
minibuffer-completion-help.

This works correctly with choose-completion-deselect-if-after: If point
is after a completion (such that choose-completion-deselect-if-after=t
means it won't be treated as selected), point will still be after that
completion after updating the list.

This feature is primarily motivated by the fact that some other
completion UIs (e.g. ido, vertico, etc) effectively have this behavior:
whenever they update the list of completions, they preserve whatever
candidate is selected.

Since the default UI doesn't (yet) have support for auto-updating the
list of completions, preserving the selected candidate is less
significant.  But it might be an interesting feature on its own, and
it's very non-invasive, so maybe we can turn it on by default.

In GNU Emacs 29.2.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2024-10-15 built on
 igm-qws-u22796a
Repository revision: 16a2e41014c6ea0f3cf268be8d37fe09aeac231e
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.10 (Green Obsidian)

Configured using:
 'configure --with-x-toolkit=lucid --without-gpm --without-gconf
 --without-selinux --without-imagemagick --with-modules --with-gif=no
 --with-tree-sitter --with-native-compilation=aot
 PKG_CONFIG_PATH=/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib/pkgconfig/'

[0001-Optionally-preserve-selected-candidate-across-Comple.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 74019-done <at> debbugs.gnu.org
Subject: Re: bug#74019: [PATCH] Optionally preserve selected candidate
 across *Completions* update
Date: Thu, 14 Nov 2024 12:09:09 -0500

> Thanks, pushed to `master`.

Closing,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.