From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 16:31:15 2024 Received: (at submit) by debbugs.gnu.org; 25 Oct 2024 20:31:15 +0000 Received: from localhost ([127.0.0.1]:39584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4Qxm-0007S9-SL for submit@debbugs.gnu.org; Fri, 25 Oct 2024 16:31:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:41912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4Qxk-0007Rv-Js for submit@debbugs.gnu.org; Fri, 25 Oct 2024 16:31:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4QxB-0001p8-OC for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2024 16:30:38 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4Qx9-0004ai-32 for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2024 16:30:37 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5869D100180; Fri, 25 Oct 2024 16:30:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1729888231; bh=PeMsA3z+40m5WYFZgyOjG0MOQt377bi0ShK1a8QinZ4=; h=From:To:Subject:Date:From; b=cvu9ryp68BCaT/KVz/2BEXU5DG2IqOggWkx3/Q734rPzJwPl+9mo+hkWRGbJYotO2 NMGMHtH7O/b/oAAD2DtkNK6hfhxRMI8mEUv+03rK16p1COSMCR3iFc6G510+UF7wq0 x7EuPeJa3CiBwVkKgR3TwfTPXBurGQSfO56yJDUcy7VG7zz/M0uqCCig1t15tWUG1p JBCy+uhk97BwaSggB7Kh22Kqz3+S9TUcluXFUzj9Kuc08Bt3c3ZV440D4Om65ynWmw dYSAiypz2y0H+vzfb5h5lb+AWw9L3++di/VffVZvqDYiBCDs5bDhpoyeDJtkDZc7m7 t6ogavfSeEGgg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9CAB7100043; Fri, 25 Oct 2024 16:30:31 -0400 (EDT) Received: from pastel (69-196-161-60.dsl.teksavvy.com [69.196.161.60]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7865612090E; Fri, 25 Oct 2024 16:30:31 -0400 (EDT) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Issue with define-peg-ruleset? Message-ID: X-Debbugs-Cc: monnier@iro.umontreal.ca Date: Fri, 25 Oct 2024 16:30:30 -0400 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Package: Emacs Version: 31.0.50 Augusto pointed out a bug in `peg.el` when you have code like: (define-peg-ruleset myrules (sign () (or "+" "-" "")) (digit () [0-9]) (nat () digit (* digit)) (int () sign digit (* digit)) (float () int "." nat)) (with-peg-rules (myrules (complex float "+i" float)) (peg-parse nat "," nat "," complex) ) where the macroexpanded code is wrong and leads to errors like: Debugger entered--Lisp error: (void-function peg-rule\ nat) I was about to install the bugfix below to `master` but noticed that it probably belongs to `emacs-30` instead since the bug makes `define-peg-ruleset` basically unusable and PEG is new in Emacs-30. Any objection? Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=peg.patch diff --git a/lisp/progmodes/peg.el b/lisp/progmodes/peg.el index 96334162195..b18d68c69c5 100644 --- a/lisp/progmodes/peg.el +++ b/lisp/progmodes/peg.el @@ -412,6 +412,7 @@ define-peg-ruleset (full-rname (format "%s %s" name rname))) (push `(define-peg-rule ,full-rname . ,(cdr rule)) defs) (push `(,(peg--rule-id rname) #',(peg--rule-id full-rname)) aliases))) + (require 'cl-lib) `(cl-flet ,aliases ,@defs (eval-and-compile (put ',name 'peg--rules ',aliases))))) @@ -432,7 +432,8 @@ (progn (push rule rulesets) nil) (cons (car rule) (peg-normalize `(and . ,(cdr rule)))))) rules))) - (ctx (assq :peg-rules macroexpand-all-environment))) + (ctx (assq :peg-rules macroexpand-all-environment)) + (body (macroexpand-all `(cl-labels ,(mapcar (lambda (rule) @@ -444,6 +445,15 @@ ,@body) `((:peg-rules ,@(append rules (cdr ctx))) ,@macroexpand-all-environment)))) + (if (null rulesets) + body + `(cl-flet ,(mapcan (lambda (ruleset) + (let ((aliases (get ruleset 'peg--rules))) + (unless aliases + (message "Unknown PEG ruleset: %S" ruleset)) + (copy-sequence aliases))) + rulesets) + ,body)))) ;;;;; Old entry points --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 17:02:02 2024 Received: (at 74018) by debbugs.gnu.org; 25 Oct 2024 21:02:02 +0000 Received: from localhost ([127.0.0.1]:39616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4RRX-0000QT-S1 for submit@debbugs.gnu.org; Fri, 25 Oct 2024 17:02:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4RRW-0000QE-PQ for 74018@debbugs.gnu.org; Fri, 25 Oct 2024 17:01:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4RQt-0008J6-Vm; Fri, 25 Oct 2024 17:01:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=2TANGox1IifhUDzk4GVaxRq3MksWA03izJR5ydhuKh8=; b=WgBEkFyqjjiDW0nhdgms jUOTVZCrAGqL/2s2DbFnMEBNQsIUsS3PGo9YVNty/hUZzvhvK6bo/eO9riHAbMJEcGlnqCS0gC6IQ hxPsI+u5SwZ9+gf2/OEskA/4NFpC+ijO2NOhwxkjjkTc4VgeqzzKAWpwrXqhfPT0cn3LQyqPSebgN gCs7+9mZHcKA8yD5mfeMTl3HobzjGWf6BkR30cdHvl6r72YOlW2m6Cm45P5OkYk8S8/8aKH02eOMr UPLY5Mf1O80upgKyRH11w0ajCXGzNVJsaChacUImNKiulauiBBYJOPhVhYxtJVHZLA5V0pSbBAR8j tcedb7yqCW7Ldw==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1t4RQs-00082U-5k; Fri, 25 Oct 2024 17:01:19 -0400 From: Andrea Corallo To: 74018@debbugs.gnu.org Subject: Re: bug#74018: 31.0.50; Issue with define-peg-ruleset? In-Reply-To: (Stefan Monnier via's message of "Fri, 25 Oct 2024 16:30:30 -0400") References: Date: Fri, 25 Oct 2024 17:01:18 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74018 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Package: Emacs > Version: 31.0.50 > > > Augusto pointed out a bug in `peg.el` when you have code like: > > (define-peg-ruleset myrules > (sign () (or "+" "-" "")) > (digit () [0-9]) > (nat () digit (* digit)) > (int () sign digit (* digit)) > (float () int "." nat)) > > (with-peg-rules > (myrules > (complex float "+i" float)) > (peg-parse nat "," nat "," complex) ) > > where the macroexpanded code is wrong and leads to errors like: > > Debugger entered--Lisp error: (void-function peg-rule\ nat) > > I was about to install the bugfix below to `master` but noticed that it > probably belongs to `emacs-30` instead since the bug makes > `define-peg-ruleset` basically unusable and PEG is new in Emacs-30. > > Any objection? No objections on my side. Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 02:19:04 2024 Received: (at 74018) by debbugs.gnu.org; 26 Oct 2024 06:19:04 +0000 Received: from localhost ([127.0.0.1]:40360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4a8d-00026C-KA for submit@debbugs.gnu.org; Sat, 26 Oct 2024 02:19:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4a8b-00025g-DV for 74018@debbugs.gnu.org; Sat, 26 Oct 2024 02:19:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4a5r-0003tm-Hy; Sat, 26 Oct 2024 02:16:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8VeZXgW7xRomjtEvDHZYOx09VEG4mQud+SPs7mWxZAs=; b=ZyOoA9sNo0tM N674O6t1HGYbo43UUdx2X8vPxCavgj+WPBJJN5U+R78tPc3wDtiX35iFDLz7LUX+M84KWJIMEFsX7 +U9b/9OP2kGG43kOPgHWDMZOUndcRHxIru6qQh3c9bYIMHqscLiAIkBFiXf5G4T1zpI3s1ra1fFM3 Hkk6kd4QK7WPf0j9DugCcaCZWKQmZeipj4SeP0GgO4avy3fvjqSG2QcEyb3PLczKzUi0iWhff2bX2 cfMRIeW+uBxG0FcxfCndKJtdj17a22o/imz+y/zpBex2hXp3tCIDHaqSN086f6X3r0EyiUBBoVXUO oNeH3hFKkZOWc6dhCbCN6w==; Date: Sat, 26 Oct 2024 09:16:07 +0300 Message-Id: <86cyjnbd94.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier , Stefan Kangas , Andrea Corallo In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#74018: 31.0.50; Issue with define-peg-ruleset? References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74018 Cc: 74018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: monnier@iro.umontreal.ca > Date: Fri, 25 Oct 2024 16:30:30 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Version: 31.0.50 ^^^^^^^ Given what you say below, this is inaccurate. > Augusto pointed out a bug in `peg.el` when you have code like: > > (define-peg-ruleset myrules > (sign () (or "+" "-" "")) > (digit () [0-9]) > (nat () digit (* digit)) > (int () sign digit (* digit)) > (float () int "." nat)) > > (with-peg-rules > (myrules > (complex float "+i" float)) > (peg-parse nat "," nat "," complex) ) > > where the macroexpanded code is wrong and leads to errors like: > > Debugger entered--Lisp error: (void-function peg-rule\ nat) > > I was about to install the bugfix below to `master` but noticed that it > probably belongs to `emacs-30` instead since the bug makes > `define-peg-ruleset` basically unusable and PEG is new in Emacs-30. > > Any objection? I know nothing about peg.el, and you haven't explained the root cause for the bug for me to understand why it "makes `define-peg-ruleset' basically unusable", so let's hear from Stefan and Andrea first. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 10:25:18 2024 Received: (at 74018) by debbugs.gnu.org; 26 Oct 2024 14:25:18 +0000 Received: from localhost ([127.0.0.1]:42219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4hjB-0000PV-GB for submit@debbugs.gnu.org; Sat, 26 Oct 2024 10:25:17 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4hj9-0000PG-N7 for 74018@debbugs.gnu.org; Sat, 26 Oct 2024 10:25:16 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D9CB5100126; Sat, 26 Oct 2024 10:24:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1729952675; bh=CG02caAE+Uf1qqLGfv/bqqbDD2jZVZhS8ONdxKUAukU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W686GnwSKzv6XZDYlnXzD7NYLzdYa8FVmNRmgbc2oljn/g0End+ETO92AME4OnPzT SsEWEQh1ai6Lt/d5a9czYF0gnbfR8w1Y8X/+j3gUzfjDNjqLhbPnhrokm1wBWF5qk7 YqqL58/TsEz488S5tGcc1LFcXxY5trbypYWpKJfwqJ0K/2kLXYVY9lAeSfMOORHU0h IaLx1J1RMxuyQ8RwvcfOLvPiIudSMWQaQkv8uvMgQ5FdBdVmdN9LOZEsQrb/dDRjm2 YXQf6n3YxzJPE+Ih3d3j9AhxydiCbVhVgi06MWSHlrFjX7XSjstdM2PjqJmSV8wEXQ OIp6pVB0deByg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EDD18100042; Sat, 26 Oct 2024 10:24:34 -0400 (EDT) Received: from pastel (69-196-161-60.dsl.teksavvy.com [69.196.161.60]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B7252120280; Sat, 26 Oct 2024 10:24:34 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#74018: 31.0.50; Issue with define-peg-ruleset? In-Reply-To: <86cyjnbd94.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Oct 2024 09:16:07 +0300") Message-ID: References: <86cyjnbd94.fsf@gnu.org> Date: Sat, 26 Oct 2024 10:24:33 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74018 Cc: Andrea Corallo , Stefan Kangas , 74018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain >> Version: 31.0.50 > ^^^^^^^ > Given what you say below, this is inaccurate. Indeed, sorry, I forgot to erase that info. >> Augusto pointed out a bug in `peg.el` when you have code like: >> >> (define-peg-ruleset myrules >> (sign () (or "+" "-" "")) >> (digit () [0-9]) >> (nat () digit (* digit)) >> (int () sign digit (* digit)) >> (float () int "." nat)) >> >> (with-peg-rules >> (myrules >> (complex float "+i" float)) >> (peg-parse nat "," nat "," complex) ) >> >> where the macroexpanded code is wrong and leads to errors like: >> >> Debugger entered--Lisp error: (void-function peg-rule\ nat) >> >> I was about to install the bugfix below to `master` but noticed that it >> probably belongs to `emacs-30` instead since the bug makes >> `define-peg-ruleset` basically unusable and PEG is new in Emacs-30. >> >> Any objection? > > I know nothing about peg.el, and you haven't explained the root cause > for the bug for me to understand why it "makes `define-peg-ruleset' > basically unusable", so let's hear from Stefan and Andrea first. Here's a more complete description. Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-with-peg-rules-Fix-references-to-rulesets-bug-74018.patch >From b9d3b8537418985a99dc8e6a513f8dd28d262339 Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Sat, 26 Oct 2024 10:23:01 -0400 Subject: [PATCH] (with-peg-rules): Fix references to rulesets (bug#74018) PEG rules get "compiled" to functions with name `peg-rule `. `define-peg-ruleset` instead defines it PEG rules with name `peg-rule `, so that they can be made visible by `with-peg-rules` simply by adding local aliases from `peg-rule ` to `peg-rule `. Apparently when I added `define-peg-ruleset` I somehow failed to install some of the corresponding code in `with-peg-rules`, so the aliases were not installed, making it "impossible" to use rulesets. [ I still have no idea how this happened and/or where the missing code went, so I recreated it. ] * lisp/progmodes/peg.el (with-peg-rules): Install the aliases for the rulesets. --- lisp/progmodes/peg.el | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/peg.el b/lisp/progmodes/peg.el index 96334162195..0e6ba9318e3 100644 --- a/lisp/progmodes/peg.el +++ b/lisp/progmodes/peg.el @@ -412,6 +412,7 @@ define-peg-ruleset (full-rname (format "%s %s" name rname))) (push `(define-peg-rule ,full-rname . ,(cdr rule)) defs) (push `(,(peg--rule-id rname) #',(peg--rule-id full-rname)) aliases))) + (require 'cl-lib) `(cl-flet ,aliases ,@defs (eval-and-compile (put ',name 'peg--rules ',aliases))))) @@ -432,7 +433,8 @@ with-peg-rules (progn (push rule rulesets) nil) (cons (car rule) (peg-normalize `(and . ,(cdr rule)))))) rules))) - (ctx (assq :peg-rules macroexpand-all-environment))) + (ctx (assq :peg-rules macroexpand-all-environment)) + (body (macroexpand-all `(cl-labels ,(mapcar (lambda (rule) @@ -444,6 +446,15 @@ with-peg-rules ,@body) `((:peg-rules ,@(append rules (cdr ctx))) ,@macroexpand-all-environment)))) + (if (null rulesets) + body + `(cl-flet ,(mapcan (lambda (ruleset) + (let ((aliases (get ruleset 'peg--rules))) + (unless aliases + (message "Unknown PEG ruleset: %S" ruleset)) + (copy-sequence aliases))) + rulesets) + ,body)))) ;;;;; Old entry points -- 2.39.5 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 11:48:45 2024 Received: (at 74018) by debbugs.gnu.org; 26 Oct 2024 15:48:45 +0000 Received: from localhost ([127.0.0.1]:42322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4j1w-0004BD-Lt for submit@debbugs.gnu.org; Sat, 26 Oct 2024 11:48:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4j1u-0004Aq-8c for 74018@debbugs.gnu.org; Sat, 26 Oct 2024 11:48:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4j1F-0007vb-FB; Sat, 26 Oct 2024 11:48:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1i2lkDqPnZCP8Ls3VsGfC9twvTFCFMwyvzVxfcbFgpU=; b=ChcEv1TSZIvI hm0OB8DXLFMeLL0eipjoRk1bXwwwJBrssvJgxXRQ8J8GyDPlA5j/s7ay8oveR4lYpeZs1l5sAki2H o4yZEhFEi4kNs9kRE4U5mmZD3jPTz+ISyAOEP+uS1HniaN4Cq8oxDGElSr9P7kV/xMOulOuj3DhqE Md8JtZj5JSXJWFq+epOlsp/BmI6pHu8rJ+kusgzzk0qEek0AfzLDW3AtZMQWkMLPns5zFKUpmt80a gir4s6/nq37if1JdVBOX21KjVU9M9aR35exmaYVfUdXZuV3pOlXaFRlz0pMRp3J6RmFKmmswTWh1F p+Ulj/ADNxptG4kJxPs7OA==; Date: Sat, 26 Oct 2024 18:47:57 +0300 Message-Id: <86ldya50ia.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 26 Oct 2024 10:24:33 -0400) Subject: Re: bug#74018: 31.0.50; Issue with define-peg-ruleset? References: <86cyjnbd94.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74018 Cc: acorallo@gnu.org, stefankangas@gmail.com, 74018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Stefan Kangas , Andrea Corallo > , 74018@debbugs.gnu.org > Date: Sat, 26 Oct 2024 10:24:33 -0400 > > >> I was about to install the bugfix below to `master` but noticed that it > >> probably belongs to `emacs-30` instead since the bug makes > >> `define-peg-ruleset` basically unusable and PEG is new in Emacs-30. > >> > >> Any objection? > > > > I know nothing about peg.el, and you haven't explained the root cause > > for the bug for me to understand why it "makes `define-peg-ruleset' > > basically unusable", so let's hear from Stefan and Andrea first. > > Here's a more complete description. Thanks. Andrea already agreed with installing this on the release branch. I hope Stefan Kangas will respond soon. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 18:56:02 2024 Received: (at 74018) by debbugs.gnu.org; 28 Oct 2024 22:56:02 +0000 Received: from localhost ([127.0.0.1]:55089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5YeY-0001QU-2h for submit@debbugs.gnu.org; Mon, 28 Oct 2024 18:56:02 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:60569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5YeV-0001Pp-MB for 74018@debbugs.gnu.org; Mon, 28 Oct 2024 18:56:00 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5cbb0900c86so3943713a12.0 for <74018@debbugs.gnu.org>; Mon, 28 Oct 2024 15:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730156094; x=1730760894; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=2qcm1BXAJgfFAi1uQUWWlU2k2xsxbejBEhS+o9Hdcjo=; b=Pi/AyxBMkKHojooomdTw1AFBsJY/PmF0aOdLA7ATV4BEA01H6ukeBwiypmI0diF8cO 3ejt0QrbqtzWysUZ4QO7poH0yIyJBSWhla1017oDXIjU8hSWhb6X6SUHNMDYGghrtM/7 iGpp6Ry08z/un/yZdnlVueVmtUJHcHi/TzG9vbAlGapQ5Qn2mOuJnQj0hNFNdzhAb+kB eL9Uf0qiTm06eF5zzbMlz1WcIK4ND0djylI9qOQnG8HBS+r3Kwqdx3VXriNuUHXlAeQq EDVYNfEdOwocIUraML23TQi/wDRvnF1kzM/uBTikUcnqCj2bUUDVuSP0THes+wMZivbU /Dqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730156094; x=1730760894; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2qcm1BXAJgfFAi1uQUWWlU2k2xsxbejBEhS+o9Hdcjo=; b=rKo92gZl5G2uCwnQ9/j+WRxXZGdMQi/8aud5WtHyVk2YeyIi3CeEOqJVHGUsd8y9o3 r35l/WQdtVkXK/U9JXd8LQeXS8sqwD8WC4qh6tECviiG4YwY53M6XnrYqmRprXVuIQnq zwwZiJwU2pdBAAcpU+WtQeXs/9NFZwx6YRJs3LHMvyzaAv90xak4aJmNUWS5JxWlHVxH gvI2nqUiVP9FqDw61c55qhEu3OGWTAqiI69ZFMqvgqgcxUqBZP7Tj0R3z7zsoGQpPWbH GmJ37OcSbe6vhDLpwd6DQzYbwurPIaP5ulbUVHUS0CUcZkpy0qX+sYVFNOpamNg8ZEQU 0omw== X-Forwarded-Encrypted: i=1; AJvYcCU0lv5kQfQHh/YcpnSuoGOJ9bWkSHDMRONBN47Y9IhIZThKcU0lYO1oEHuZgdbIUgSQ2iqWWQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyMhv9YziENEBvPIavIaJ1G4iLS6Ti0ZFaSwbo89zC/jLTVXWzx yQbTNcrjcdwBcIhRO6ezYYthWi31brv3DemE7jKOoQ4Ei9EkbMaIMRRpxCds62y7JeaTTJwDgdN QG68D7CEdgoR8bH185U4QwZmjZlAvaw== X-Google-Smtp-Source: AGHT+IHllPjDPSeOYU9ftweeW8amaVqyh1OhXjRJmlSPA4xXNnUrjjS5bLv73P1fSzXe4we5srIDmACkhf+xajt/D+k= X-Received: by 2002:a05:6402:4305:b0:5c9:3818:35e8 with SMTP id 4fb4d7f45d1cf-5cbbfa6ef44mr7754042a12.28.1730156093730; Mon, 28 Oct 2024 15:54:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 28 Oct 2024 15:54:53 -0700 From: Stefan Kangas In-Reply-To: <86ldya50ia.fsf@gnu.org> References: <86cyjnbd94.fsf@gnu.org> <86ldya50ia.fsf@gnu.org> MIME-Version: 1.0 Date: Mon, 28 Oct 2024 15:54:53 -0700 Message-ID: Subject: Re: bug#74018: 31.0.50; Issue with define-peg-ruleset? To: Eli Zaretskii , Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74018 Cc: acorallo@gnu.org, 74018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: Stefan Kangas , Andrea Corallo >> , 74018@debbugs.gnu.org >> Date: Sat, 26 Oct 2024 10:24:33 -0400 >> >> >> I was about to install the bugfix below to `master` but noticed that it >> >> probably belongs to `emacs-30` instead since the bug makes >> >> `define-peg-ruleset` basically unusable and PEG is new in Emacs-30. >> >> >> >> Any objection? >> > >> > I know nothing about peg.el, and you haven't explained the root cause >> > for the bug for me to understand why it "makes `define-peg-ruleset' >> > basically unusable", so let's hear from Stefan and Andrea first. >> >> Here's a more complete description. > > Thanks. Andrea already agreed with installing this on the release > branch. I hope Stefan Kangas will respond soon. No objections from me either, please go ahead. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 22:15:54 2024 Received: (at 74018-done) by debbugs.gnu.org; 29 Oct 2024 02:15:54 +0000 Received: from localhost ([127.0.0.1]:55336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5bly-000212-J3 for submit@debbugs.gnu.org; Mon, 28 Oct 2024 22:15:54 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5blw-00020o-Uq for 74018-done@debbugs.gnu.org; Mon, 28 Oct 2024 22:15:53 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 645FC4443D7; Mon, 28 Oct 2024 22:15:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1730168145; bh=pI1XwsTTQB8iJpstYDq/JyiYJkZeTVaYtAZJDsdK14o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X7DvVlaa38dO/pKXFNEacpBQPv88bH9kF60O65rrVwUVqdXQ3IWLPn3pxw5K6wrvZ sBbJC7caqBD772C6NSQlZ2fahm1lg44DPNm38pF+Es2m/qT2OOiwz8xxDwVi+nu6AR NKzpEujE/qApEWMkYC9XFHeQ6obF8FjP0/LM/q/G2VNMvuUSuT+GwSn07vHloA0qDK jJ6AexsP6eVGKYdltzTvLizm1glwO9Dg/Eo/AqFQUOb6QR6yLcdtlDTXkuwqSZ+xv0 zqUciAdNr36F25BnANgk/sMV+5ybfDG9k5dstSabMdv5FvgQDUcWzKgHnXxJnBi2T0 +hs3SIWaY+8IQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BAD104443D2; Mon, 28 Oct 2024 22:15:45 -0400 (EDT) Received: from pastel (69-196-161-60.dsl.teksavvy.com [69.196.161.60]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8267A1202D5; Mon, 28 Oct 2024 22:15:45 -0400 (EDT) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#74018: 31.0.50; Issue with define-peg-ruleset? In-Reply-To: (Stefan Kangas's message of "Mon, 28 Oct 2024 15:54:53 -0700") Message-ID: References: <86cyjnbd94.fsf@gnu.org> <86ldya50ia.fsf@gnu.org> Date: Mon, 28 Oct 2024 22:15:43 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.141 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74018-done Cc: 74018-done@debbugs.gnu.org, Eli Zaretskii , acorallo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > No objections from me either, please go ahead. Pushed to `emacs-30`, thanks, Stefan From unknown Sat Jun 21 10:41:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Nov 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator