From unknown Tue Aug 19 09:32:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73993 <73993@debbugs.gnu.org> To: bug#73993 <73993@debbugs.gnu.org> Subject: Status: [PATCH] gnu: git-sizer: Pin git version. Reply-To: bug#73993 <73993@debbugs.gnu.org> Date: Tue, 19 Aug 2025 16:32:18 +0000 retitle 73993 [PATCH] gnu: git-sizer: Pin git version. reassign 73993 guix-patches submitter 73993 Greg Hogan severity 73993 normal tag 73993 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 24 15:13:59 2024 Received: (at submit) by debbugs.gnu.org; 24 Oct 2024 19:13:59 +0000 Received: from localhost ([127.0.0.1]:36206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t43HT-0003RJ-34 for submit@debbugs.gnu.org; Thu, 24 Oct 2024 15:13:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:36010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t43HQ-0003R6-6M for submit@debbugs.gnu.org; Thu, 24 Oct 2024 15:13:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t43Eo-0007Hb-WA for guix-patches@gnu.org; Thu, 24 Oct 2024 15:11:15 -0400 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t43Em-0003fR-QB for guix-patches@gnu.org; Thu, 24 Oct 2024 15:11:14 -0400 Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-460a415633fso7099161cf.2 for ; Thu, 24 Oct 2024 12:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1729797071; x=1730401871; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZYWZdyr1hDTcU570gLsWNaDeau6QOyXWjJUxdXCO7YQ=; b=p1q7g3DA57Jp0luDLPUhP6dqd4Xvsm/rSJM95521urbBqgJRKOCT4d2alYkfn+Mc0S 6ikGJzrYfhjoOy84Djcyio3KHvTKL3nZ4flJqxziFLOcM6MfM15Q25v8dpOr2EGVdeBS 4ngdKLlp3i9mjoWkRJu/DZqLM1StcovUUSTAoRMdus6xkz5AuxpqEhzqGAEPAfPTeZNO +Z6A4gbwxsZJjDV7mNgkEAfWwzI9C5iyRy4B+X2tmB64dCUFZ1regaS6zd8oM0QgOuPP iy98x8IPZVA/HjcKjhFGpC4dxUlsdF8qh8mpDqJCtgrscmBxqcJZX+qzt2sIITt38zj5 JAVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729797071; x=1730401871; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZYWZdyr1hDTcU570gLsWNaDeau6QOyXWjJUxdXCO7YQ=; b=pj+zQ6bC5gkmXE4RmdvawxXQsyNNFSI3YRb7ZsX4p4ok2JtmZSiV8oozpfZxLhfKSB F3fcGFZc1QcjEz6mc0f7b5EM/3194KfnYLgMev+B0NJawHT4Y8KSNPUYcLsyd/DMnCqq EjN7JfbJin+U1F9f7hQiCuLc3sVe1YjGYGry1L1+FUxlkhqj+h92PMaBWfEeSstuIBRD zdLgXrHnzcXNgeqieQzE6t63KZfKzzm4JWuU5yZ2KUSKqSBN0YbcajriSBdtWcbCGbO8 7jqnN4ACbJcf/upMWErU2eaOn78JJmITYwooZoYOIfJfBiPxtAIfNs8Ex/MjL0XsQ5DE E8LA== X-Gm-Message-State: AOJu0YztvIB3PgTyxUAdqMsF2AKDylgPSC8mu6lW0r1pQzGevZzVEynn tgxWb5DqhEYdsOxRCQb80NZbijTTwMrYKtB/0OUX0FVCiIuvdhfr0eoz2qDS9o5qivmbtTF7kow N4fs= X-Google-Smtp-Source: AGHT+IEfKRJucqolftQ3nzkDlc6Laix09xWn26q8NifegtBTL9yLwJ2iOswpBWPHRM6ssPSENb+aVA== X-Received: by 2002:ac8:5802:0:b0:461:2146:3aaf with SMTP id d75a77b69052e-46121463c9cmr59103361cf.0.1729797071087; Thu, 24 Oct 2024 12:11:11 -0700 (PDT) Received: from ip-10-114-89-186.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460d3da210csm54559131cf.81.2024.10.24.12.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 12:11:10 -0700 (PDT) From: Greg Hogan To: guix-patches@gnu.org Subject: [PATCH] gnu: git-sizer: Pin git version. Date: Thu, 24 Oct 2024 19:05:07 +0000 Message-ID: <12475749a8d371488d9ae1fa331ad10dd24aa644.1729796653.git.code@greghogan.com> X-Mailer: git-send-email 2.46.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2607:f8b0:4864:20::834; envelope-from=code@greghogan.com; helo=mail-qt1-x834.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) When I submitted this package the placement of git in native-inputs was incorrect. This patch switches that dependency to the pinned version of git in inputs and therefore hard-codes the path. * gnu/packages/version-control.scm (git-sizer) [arguments]<#:phases>: Use gexps and hard-code git path in 'fix-paths. [propagated-inputs]: Remove git. [native-inputs]: Add git-minimal/pinned. Change-Id: Ide0c5a3df7c0cf0ecdaa5446b5d13970dae96560 --- gnu/packages/version-control.scm | 44 +++++++++++++++++--------------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 6bd37fee82..78342fbe31 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -4364,26 +4364,30 @@ (define-public git-sizer "1b4sl4djnfaxwph41y4bh9yal4bpd1nz4403ryp7nzna7h2x0zis")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/github/git-sizer" - #:install-source? #f - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'fix-paths - (lambda* (#:key outputs #:allow-other-keys) - (substitute* '("src/github.com/github/git-sizer/git_sizer_test.go") - (("bin/git-sizer") - (string-append (assoc-ref outputs "out") - "/bin/git-sizer"))))) - (replace 'check - (lambda* (#:key tests? import-path #:allow-other-keys) - (when tests? - (for-each (lambda (test) - (invoke "go" "test" "-v" "-run" test import-path)) - ;; TestExec and TestSubmodule require a copy of the - ;; Git repository. - '("TestBomb" "TestFromSubdir" "TestRefgroups" - "TestRefSelections" "TestTaggedTags")))))))) - (native-inputs (list git)) + (list + #:import-path "github.com/github/git-sizer" + #:install-source? #f + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda _ + (let ((git #$git-minimal/pinned)) + (substitute* '("src/github.com/github/git-sizer/git_sizer_test.go") + (("bin/git-sizer") + (string-append #$output "/bin/git-sizer"))) + (substitute* '("src/github.com/github/git-sizer/git/git.go") + (("gitBin, err := findGitBin\\(\\)") + (string-append "gitBin := \"" git "/bin/git\"\n\tvar err error")))))) + (replace 'check + (lambda* (#:key tests? import-path #:allow-other-keys) + (when tests? + (for-each (lambda (test) + (invoke "go" "test" "-v" "-run" test import-path)) + ;; TestExec and TestSubmodule require a copy of the + ;; Git repository. + '("TestBomb" "TestFromSubdir" "TestRefgroups" + "TestRefSelections" "TestTaggedTags")))))))) + (inputs (list git-minimal/pinned)) (propagated-inputs (list go-github-com-cli-safeexec go-github-com-davecgh-go-spew base-commit: ac19ae37b5000c224c4cd167b239cc3027d01b30 -- 2.46.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:24 2024 Received: (at 73993) by debbugs.gnu.org; 29 Nov 2024 09:41:24 +0000 Received: from localhost ([127.0.0.1]:41065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV6-0005tm-1M for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:24 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUi-0005qn-LO for 73993@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:02 -0500 Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-38241435528so770880f8f.2 for <73993@debbugs.gnu.org>; Fri, 29 Nov 2024 01:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732873200; x=1733478000; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=aS2tYVc+IScllmW9NiKZCe3OkJrY1oo8ODMKA37UA08=; b=L42zcdvNhOBmhKtlrtJ7m16OLIXOPCxtbEsnKRvgKIHFMy2iqCZq5rK57dsSydxR9/ y6AcSPl/Dtq8ETQUdEesaULhpmf53wy67gWElKiFgi81ms6q5FU3yB6hQ5+gQC66aaC3 Sp2n00S6I5tj6bTSFRvu9N//5l5wJUAps2AdZVwq/cp+xDS4QdXdMi7MjO5bm+dcTl8o p7l4i0nNvcd9uLNXRki+w5beGAElHSRUqUwLunTXzk5fn2qffEFHrbF8rGhrQwfZaNN+ A/w8JkGZXFkauLJ7pvJbgtuhkXMq5gVGGNfYZyVOfpXzPnmWRM9MizjREtZoDcLmfu4n zjsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732873200; x=1733478000; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aS2tYVc+IScllmW9NiKZCe3OkJrY1oo8ODMKA37UA08=; b=RH8sFVdhiCjRI0GttDXBAOXB8TVwO6e/dQ4dp18eHq1UHX2LlfVRT71h0HRKCSsbqR JBWdNRKhekBNi4xJ6v3xK/0Bg7La7p6uKfn40V1FF0DEtlyALEWWlJfWIyiuCvGoj5zZ mrJnmrU0danZsgRnMZaagmQcNmIR7CBArzxKJVpUojwgDtKT90NLh/KpVskf4GVxcRi6 4isAjNoVOY9urSgM3Mh9UcjTh6fzpDfjSwfsvIWr9K+BilV2UzxSQBq1DTEB2A2GIW+S pkOxcO9w5i/AQQC2L9L9T13rOkvy8DfQFJVZAg5Uhodyoi6arLfVxOcIuQiqrvY9HqKc H3ug== X-Forwarded-Encrypted: i=1; AJvYcCUYh73CHLp9oCIHd+Y2radAC6JXP307urpSjlvCRVM3l9uNADQlWd8gukWrTd3z0H/SSkhgtA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyJaSD0d/FXu55S1HtZigNFxjjJ76eLB6yx5AxUmyM9QnmUq07X jMaLa0iF/iCBrhteAjUh2N3HloPK9BNFL/R3sZMjh8Q4AW0248EF X-Gm-Gg: ASbGncv7CUGOoUwGbE6GqcNCkhTT0qZgrNFwNToTQgLG58MZ0Kw0tAM6oLbIYMmJaOE J01LuZpE+NhaOyrejkTd5CicUlSEm98mym5Uue6Fm8cmwcfdbEwhcaVIczkcdn5cvKfQcwaQ053 dyZu2Iqh4yzaxiiiHmxy57+3X1MIua3uFIDuNPilWfXV4zSRYxnB2hWOKvUmfvEst3Y3BKT7DvS MWW+uXjfZFzGPWdNBs32DJLUin81UChY8XtLzNl1cgZPXYOpNXlOQs7JttAyZLgPAXuDh+v2f4o 97sByzWX5rWGwCChjxkkSjSuGA== X-Google-Smtp-Source: AGHT+IFcU6k/MZfCBFRg67rKvLU+dRVzAwr18Ymmd9DMAn8xiQ1z3Gu56zRB+h5v7uEV92QIyeKhGA== X-Received: by 2002:a05:6000:186c:b0:382:22d6:1ce8 with SMTP id ffacd0b85a97d-385c6ebb951mr8733397f8f.22.1732873199638; Fri, 29 Nov 2024 01:39:59 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a7aesm3956510f8f.59.2024.11.29.01.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 01:39:59 -0800 (PST) Message-ID: <48353def5b5c7b3eae7fd7101a42a36ef1e13225.camel@gmail.com> Subject: Re: [PATCH] gnu: git-sizer: Pin git version. From: Liliana Marie Prikler To: Greg Hogan , 73993@debbugs.gnu.org Date: Fri, 29 Nov 2024 10:40:40 +0100 In-Reply-To: <12475749a8d371488d9ae1fa331ad10dd24aa644.1729796653.git.code@greghogan.com> References: <12475749a8d371488d9ae1fa331ad10dd24aa644.1729796653.git.code@greghogan.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 24.10.2024 um 19:05 +0000 schrieb Greg Hogan: > When I submitted this package the placement of git in native-inputs > was incorrect. This patch switches that dependency to the pinned > version of git in inputs and therefore hard-codes the path. >=20 > * gnu/packages/version-control.scm (git-sizer) > [arguments]<#:phases>: Use gexps and hard-code git path in 'fix- > paths. > [propagated-inputs]: Remove git. > [native-inputs]: Add git-minimal/pinned. The ChangeLog here is wrong. git is removed from native-inputs and git-minimal/pinned added to inputs. I would suggest making the change to G-Expressions in a separate patch for easier review. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 16:05:57 2024 Received: (at 73993) by debbugs.gnu.org; 5 Dec 2024 21:05:57 +0000 Received: from localhost ([127.0.0.1]:41156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2r-0003PM-8q for submit@debbugs.gnu.org; Thu, 05 Dec 2024 16:05:57 -0500 Received: from mail-qv1-f54.google.com ([209.85.219.54]:45439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2o-0003PC-J4 for 73993@debbugs.gnu.org; Thu, 05 Dec 2024 16:05:55 -0500 Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6d888c38841so11112636d6.3 for <73993@debbugs.gnu.org>; Thu, 05 Dec 2024 13:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733432694; x=1734037494; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9LpTYTpwg/UZGr7BRFRECfzJEu3+H7+beBZx1EHLz+Y=; b=fyjZqRhXAKphqO8TXnk3mrmhxWT/BFp9WVmnUC/zZ/rXyBKmB101eY3acylo29emgt tTNcsPXK1zSLkf46y54QChKh7/M9HqWMYw7GOTYJ4/lZcd0hp0FcUYJWXhaqfGO0E9aN bSYuOoRm/6zYu7gWpixcovoDh0ACASmsxYwXQ5tWSroZCCPE/rfp0iynCfkemYpDIYat MTxkW0NcEReGh4e4kC55Bp3ONF3kghxSfzomR1zDkR2GhMj76/xvrNEiqGnIEZMVVPJB SDhHTiGzUC28SbfkNmxyxpozS7KZ/lQd188yDIpcGIscg5/ZLEtjiasV0AjfTgA3zIxe uyew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733432694; x=1734037494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9LpTYTpwg/UZGr7BRFRECfzJEu3+H7+beBZx1EHLz+Y=; b=D5OgGHhvHBkDPMbyB3v+oHNWoymBToXlaqvtuX44eek2ojCGofR6Hu3R5JcL4zDO0i Og1wEv7Cx08Dgu0vjt9L/qWAjgXdmvioASOnXPu1ovUlxWtjevZNWrj9q9bJVFY5PbkG 9/7CvzcMiUtEaVDXHEjHk86+5z1IX+Tw1A2gPJkyXrp+lnJMb37LqMGbDYvgZ7bWOzIM EDaeg6JbxPiAoG/uyZXdxrWbjq6NdA0FhAbSn3C8G6u3OALS1CcHHleu+fK7kCiLiZG4 16Yqpu/Kk/E81zg7jg3AZkxOvheYa4SlnACZQOUwRnrh7TEEN68GrOGFWCvu4NyetGLj cfig== X-Gm-Message-State: AOJu0YzORrO0a/4F3ifGa72+TgPxQp5iXgbyaA/YzV7TC10Izda6l+2a 0rC8iVxziqOqjMkNMt6qy62N7rxBikT8Vq1Y6hsesNUAFrJBChdH+v327JkGHdJIM4NJ6w5a+Tj x X-Gm-Gg: ASbGncvYaBtJN6njdFFG4kn6kzh5bxNppIkqN216xNN5T8SBZBPpKWbY2i3Qv4w+vbO ZxVURNUk4DVx5MN9AYDxGz7yHESVLGTObDUg3y+9llL/yAs/4kA7hlhDkImG6XnafI6KqFgPpH6 M36k7pbBeJP7WH1pSE2HCCdNyxLG6hqgIqCDdkUlv/gf5A1oul5lGwtJ8rP3LIBUdgBWSxp1KXM TZxI7NsLGMPUiwyuhq7EwCReWtF25bjdcy/2E58Ie9gcM7Vn0uJ2xE5UKZSpavl2f+JF4LRj0l4 CmAkrkY958D6a7EGSn/O4U0i7ixgXFEU0r2UD7qafnwUFLNN8w== X-Google-Smtp-Source: AGHT+IHT5QqnehdeIaexmDoKhUm5RdR45LLj9JZ2obB9xqeE4mW52Oztc5vrhmawQLa26WLv39smPA== X-Received: by 2002:a05:6214:1d2e:b0:6d8:8256:41d4 with SMTP id 6a1803df08f44-6d8e71648b7mr6233506d6.19.1733432693908; Thu, 05 Dec 2024 13:04:53 -0800 (PST) Received: from ip-10-114-89-186.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6b5a83c80sm96497885a.72.2024.12.05.13.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 13:04:53 -0800 (PST) From: Greg Hogan To: 73993@debbugs.gnu.org Subject: [PATCH v2 3/3] gnu: git-sizer: Pin git version. Date: Thu, 5 Dec 2024 21:04:33 +0000 Message-ID: <8ab694342d0e9668dec24cf24170ce89276d440d.1733430615.git.code@greghogan.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/version-control.scm (git-sizer) [arguments]<#:phases>: Hard-code git path in 'fix-paths. [propagated-inputs]: Remove git. [inputs]: Add git-minimal/pinned. Change-Id: Icc21f92e0261ff05f3411970e6f4792763a94f80 --- gnu/packages/version-control.scm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 37ee819688..8c7d817523 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -4468,10 +4468,13 @@ (define-public git-sizer #~(modify-phases %standard-phases (add-after 'unpack 'fix-paths (lambda _ - (let ((git #$git)) + (let ((git #$git-minimal/pinned)) (substitute* '("src/github.com/github/git-sizer/git_sizer_test.go") (("bin/git-sizer") - (string-append #$output "/bin/git-sizer")))))) + (string-append #$output "/bin/git-sizer"))) + (substitute* '("src/github.com/github/git-sizer/git/git.go") + (("gitBin, err := findGitBin\\(\\)") + (string-append "gitBin := \"" git "/bin/git\"\n\tvar err error")))))) (replace 'check (lambda* (#:key tests? import-path #:allow-other-keys) (when tests? @@ -4481,9 +4484,9 @@ (define-public git-sizer ;; Git repository. '("TestBomb" "TestFromSubdir" "TestRefgroups" "TestRefSelections" "TestTaggedTags")))))))) + (inputs (list git-minimal/pinned)) (propagated-inputs - (list git - go-github-com-cli-safeexec + (list go-github-com-cli-safeexec go-github-com-davecgh-go-spew go-github-com-pmezard-go-difflib go-github-com-spf13-pflag -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 16:05:58 2024 Received: (at 73993) by debbugs.gnu.org; 5 Dec 2024 21:05:59 +0000 Received: from localhost ([127.0.0.1]:41160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2s-0003Pb-JQ for submit@debbugs.gnu.org; Thu, 05 Dec 2024 16:05:58 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]:42316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2r-0003P3-Dr for 73993@debbugs.gnu.org; Thu, 05 Dec 2024 16:05:58 -0500 Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6d88cb85987so12964286d6.1 for <73993@debbugs.gnu.org>; Thu, 05 Dec 2024 13:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733432692; x=1734037492; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=o5PGCIkFbyC1ViTRnxRVs+N19SPLHYPoWQbjMrtG+NM=; b=ji+VPR/ThHr0NDMniLsJoky/IXuxbLF8OlhdjOiS4a75YzW90/yp7UT+QDTO/KbqBx eChXN/G9gjLI3+i+RQoZ43WEKMrYdcs+6wuDdEOBL8ciPtFe4GOFlULmQTpY3/BIlfAy JXK8tYn4fDaR4Zo6S1kDzoVeqiJYSzffSd0RRM042jKuQCg1UdE9egBKrVnfnoJczd+j fEb6W3fTZYpLbqgYwEOfVsN+ayDqA9PlPDLuQ5ds0HutIqiQYaSLdTnh337gl80Fh9lF 7lqQi8Uo8ijlTTAQBT7ip/comCkuT/rgBIEHI9cAcIeAwdS0ARL+K1Ytvoz9/cHQ+Frw eIMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733432692; x=1734037492; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o5PGCIkFbyC1ViTRnxRVs+N19SPLHYPoWQbjMrtG+NM=; b=NwWr5+YL5uKmiRVRAKXt20/wJN0KRnnDtRC8q8QsIza7dQBiIbGhnWHtxhl6f3SMsS hX0KmVmnPS+Ys9HJrfgRC35gZghTvaFhHh21z164+l+/hUlobxgmbSbfWANSQHHwxrXm QKkC8TZe81Y+uePYPwZDkx4YQ1lxKFrGzHv/Nk5O44v54PKjuLtr7DrmtzajXLJba3PH R3i0KqbnDXE3NPo8YhJ/Fu+7hoZIBk7O1diQ8CZwgssIlh3Npf7PWDBtZp41aAqn/mSJ 79vvckxUxgXkSeoRtJl5mX01f7t77jR8jx3wylWgLA4EEUxcTWsgXfUGADYTFLPV7KBN Jf9g== X-Gm-Message-State: AOJu0Yx/SJ7jIuTE3wK54KO6ts5okJssUiePr49HKHbAcN1pwxlxrKWH l0WXbkIw5BneOFKIRdhMfCa8bPcfVUjZTU5787PmpA1Cqq+V3KU2Uny31SjFtRC9GqOSn1eIr/q S X-Gm-Gg: ASbGnctqr/Vd7XLSAP2Zsc/3Ge0ze107AboLaajamISZlL/LKXX3tTg/N7buzfYK0T0 gDIgHSPSKZkAyHtAjGfVBewC4rI6UfDe3VbGLuZrMAt8yNJ4oLfwojDjz0RdROdrrd/t5c182fy rqSxx5tHtLkWrZYK+e1ktSi94Cs5od6kAx3LaTYy2ayBF6ETTsgHaF7cwCMbA0bcHLz1mNW/3Cc A3N5W9GTYiGcPCbUq8CWqG8NnvOGJ04IN0/jnkdqKscvsnqe9M8PboLQJgnHS0JM84sCRbBNKVH WK9GWZzBzxlAp6aV1KmybWXr0X+LGg4hkEYQjhYlyP8X54FCsA== X-Google-Smtp-Source: AGHT+IFB6TiHrAlbNLAtNxEpVFdqAM6imdJ0XMnvx1RLFE3d8wWcoCnR9/UgC3tAfed5xvcCgPj5yA== X-Received: by 2002:a05:6214:21c1:b0:6d8:a9a6:83ef with SMTP id 6a1803df08f44-6d8e6660a21mr13803846d6.20.1733432691784; Thu, 05 Dec 2024 13:04:51 -0800 (PST) Received: from ip-10-114-89-186.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6b5a83c80sm96497885a.72.2024.12.05.13.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 13:04:51 -0800 (PST) From: Greg Hogan To: 73993@debbugs.gnu.org Subject: [PATCH v2 0/3] Pin git for git-sizer. Date: Thu, 5 Dec 2024 21:04:30 +0000 Message-ID: X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The git package can be updated more readily if we reduce the number of dependent packages. As in this patchset, we can depend on the pinned version of git if we hard-code the location of the git executable and do not propagate the dependency, which could cause profile conflicts. The first patch fixes the issue where git was neither hard-coded nor propagated and only worked because git is typically available in a user profile. This can be tested with "guix shell --container git-sizer". Greg Hogan (3): gnu: git-sizer: Propagate git. gnu: git-sizer: Use gexps. gnu: git-sizer: Pin git version. gnu/packages/version-control.scm | 44 +++++++++++++++++--------------- 1 file changed, 24 insertions(+), 20 deletions(-) base-commit: 006679d1e6ca7acea0629b4f019c8cf89cde08be -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 16:06:02 2024 Received: (at 73993) by debbugs.gnu.org; 5 Dec 2024 21:06:02 +0000 Received: from localhost ([127.0.0.1]:41163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2v-0003QA-U1 for submit@debbugs.gnu.org; Thu, 05 Dec 2024 16:06:02 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:59805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2s-0003P4-43 for 73993@debbugs.gnu.org; Thu, 05 Dec 2024 16:05:58 -0500 Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b66d20e9ccso75376685a.3 for <73993@debbugs.gnu.org>; Thu, 05 Dec 2024 13:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733432692; x=1734037492; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z4OR9kA38aM6QWCk6WjFwFkKrOMX7RktcHfB+NrU7GA=; b=gb6k+r2L4eAHVQh7Slhw0Uu3VwivsRKl3DTuueZaZ0q9qYHHhCmHxJTdO124arMC7j Fu3eIqVqjWkViM8Cn0gSl1NHpWd7Lpp4iOCri/KnIl/kMNN2236P8kduNe2JoSo89tJj yqaYhwCJH30HJ6mUntLDtbskWl54lYx9PBOdQ4Qh/v+4dSTL49T6EvauaGGzOV9nbSdn KBoffL7q0vOCeBclhZ/uFF5s7/NVxZXKsSIT5q0xAehnljD/rj/q8lRt9n9Z3X99BrmL zT3wEJLqawG/2ZfjaKWturQ9bJ3BGIfsOms41pYVYsJwwdHBn9KAlMaDixEGijFU8LIZ ab/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733432692; x=1734037492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z4OR9kA38aM6QWCk6WjFwFkKrOMX7RktcHfB+NrU7GA=; b=kNZ31GRKx9hPDZPyRIdCMlhUpkRsdNH/L1EeozeszPZ7aTOmr3KaQzsDgPV/CDrpXj YCYJzS4JQecruxctouYNR6tQUOuFy0uaFDQxO/FCVOd2vuki9psJNiw+aJwWukN1GYhW gKyebpv2NAJMp2idylOulNpwr8poAFNcWUZXWOsai4peUTZm/fqomDbu7v6WogCUVBcJ Pqe1PoMcRo32u0+y2Nj8tlZHQUKMqKoO5T3bEAg+GL4hELmc4szWOfQ+hhvS3U2+A2QM qPs+YJiV9jBMpHLZ7zWHyvw2wl7PxqotgcVfDcxY7325A3dm1JNZfrykBqgxABIJdq1T y8tQ== X-Gm-Message-State: AOJu0Yzly5kFtWOJbjaJyzFg5KruD/d7k5SqqNbPNdxck7S0aHhxeN7V IdPGYGP+Gd8K9ipreB+zqCxlKJXXoIlx23v83Lm1iWAa4elIRb3mFzbYzb0COUJRFlDETy8oTgp e X-Gm-Gg: ASbGncteeebiUuA3zuhE9mTBKCSCpwwaOhQClsrFTInN9osSWMUFPyQiR2Yj+laKu8S kYx4eP+ccFLlnTOlFxYIrd/ywfh8LHOY1ggoxyUL/jONbk9WlyURthSWI/ZzleE2gucHhLt8MAs npstl096goJ7pr0KYIq1mpFd9rARWG7ecAn1RPSPmbzBBk72jiE6AY5xswI312gNbK+gzZjDokP RqFMZV3jOYWW8xdsJ4KPCrQ4ndyWJR7da4hA8izV7MSgjbAx4+bGC7M5DHiNd4qEHcjGqHgdSQr a6bqR+llBs/UaQORpcgDJ5Uoq2b2yXwdIW1HyahLzhlegbNGWQ== X-Google-Smtp-Source: AGHT+IE4H9lFXEaR5zB8ySxOGrpKpyUq6AoK+Lmsl+fI0jQhjea1OQEUt6Y4Qvb5PAtvdQs++nrxrw== X-Received: by 2002:a05:620a:488f:b0:7b6:6b88:cbec with SMTP id af79cd13be357-7b6bcabfae8mr94265485a.4.1733432692508; Thu, 05 Dec 2024 13:04:52 -0800 (PST) Received: from ip-10-114-89-186.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6b5a83c80sm96497885a.72.2024.12.05.13.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 13:04:52 -0800 (PST) From: Greg Hogan To: 73993@debbugs.gnu.org Subject: [PATCH v2 1/3] gnu: git-sizer: Propagate git. Date: Thu, 5 Dec 2024 21:04:31 +0000 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fix the current version of this package, which depends on git from PATH. * gnu/packages/version-control.scm (git-sizer) [native-inputs]: Move git ... [propagated-inputs]: ... to here. Change-Id: Iea70a16845e93f5c3740da5596e61cc2d7fd17b9 --- gnu/packages/version-control.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 289b981911..86e241ad27 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -4480,9 +4480,9 @@ (define-public git-sizer ;; Git repository. '("TestBomb" "TestFromSubdir" "TestRefgroups" "TestRefSelections" "TestTaggedTags")))))))) - (native-inputs (list git)) (propagated-inputs - (list go-github-com-cli-safeexec + (list git + go-github-com-cli-safeexec go-github-com-davecgh-go-spew go-github-com-pmezard-go-difflib go-github-com-spf13-pflag -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 16:06:03 2024 Received: (at 73993) by debbugs.gnu.org; 5 Dec 2024 21:06:03 +0000 Received: from localhost ([127.0.0.1]:41166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2w-0003QI-BI for submit@debbugs.gnu.org; Thu, 05 Dec 2024 16:06:02 -0500 Received: from mail-qk1-f179.google.com ([209.85.222.179]:50209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ2s-0003P7-Nc for 73993@debbugs.gnu.org; Thu, 05 Dec 2024 16:05:59 -0500 Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7b6681e92b1so168671885a.0 for <73993@debbugs.gnu.org>; Thu, 05 Dec 2024 13:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733432693; x=1734037493; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nLzple0QNcf2eEhDa3qI8DM80dyRng7AH+Yt/GNd7s8=; b=hvsCK+bAh1Cypfn3e6OeDM7mB6sbU72oeKqG4NyAYmMf4kL0b1+5BPj5WUzDrMO9Yk uV/RGtTdfxZTIgdY0oJd7Tmix6mFuygVjZFnBQsbSg1N0h5pS6QIzBpy3quFeqaHNY3d w7qwwQuDVxr/m4LZUH2AZ29zENhCru2E0rxbjaMsTtEbniicMAKRD6xN95kKm47PSWJv kK4WcfgjAf49vRnAFw0GYdTNKK7iVgncFUTpXf+FvRQO0U8DIPpAeGZb+qLs1e5RC4hS uhikPz0zNqAnacKTi6gEGL3Y+XBSCtUhpvElKhhWY+5RGSEDw64DkIkYukxWgoyDnCP2 0zIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733432693; x=1734037493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nLzple0QNcf2eEhDa3qI8DM80dyRng7AH+Yt/GNd7s8=; b=H/o9HsWercEfsng4NsVxpc/fDk4dU5GFHTfn9F2I1hgU44CmqZcTxYMouIan57wWP+ b0r9koYcG/C3nrKulEmY2qrciWDEaZZrbykZ9LVXh8OEgGb7/JllsHuESWjNXohYAOFy XVXt7O1dpHx6FvXhrv4VN7NmsdZSUgjbdeHgftcchOkbdb8eP4jbgf6/RufOLFJI7MpN 1u9gTpOtD63d/3TK+SxiVH3O5j8j/wqSAuLdi1NqWt9BpBXWy/lPXscd+Ysp1fy0MqGj 93dnRK1qkgG91vf0KrZEJ+A1L7Gh0+bmuilyLL40Z/8ZN2h+TbpzLFGbZMlFgqSrlu3G RYDg== X-Gm-Message-State: AOJu0YzJhJ1NK/96Xsral3eyxTCkj1g3Qebp6puYAeHWEhef8BN2F+0V usodgz1KMIYEN+iN5+hWprcZ2xCsMObvpuqYOsfUyk/qOe6McBSOqaEO3Thfv/hfzepXFTjf1JE z X-Gm-Gg: ASbGnctemsUZ5tSayAUsBM1KLyzI/Sq9xsWwgp65gX4kxd99gi/KsXNBrci7I1x68ea BPLh3WspGYpO5+av+zncO4HYfQXZOav/zgdgD2WJkO/IeT40w2qTybuRqOsJ0cA5J4cgVBsEgGK NSNftWcMV9ySYYOu+/KJyxzIe5LTiHu53DUZ8BUSMN0Oq6dxXKfwjslFqLvByhDSOeMGuUcaJ6J 0GjrWRm6or/I8ijutJKueaJpk9ah84Mf5RSwjoPtYMvoayMaue/QcaY0aXs2Qh0KXtSNbR15qhW oaEhJ7dci3NpwbZLNtih7+L8/eDymQvt/1CmZs8F9G5i6ShiMw== X-Google-Smtp-Source: AGHT+IFAP+IqlwhPy8DZ+dAM0LhBR1slICjFWQ/zj7i9gTLSRz60gtw350tGTs2B6f+pyIPDkXit/g== X-Received: by 2002:a05:620a:1a94:b0:7b6:7a87:744a with SMTP id af79cd13be357-7b6bcac1c53mr111686485a.5.1733432693186; Thu, 05 Dec 2024 13:04:53 -0800 (PST) Received: from ip-10-114-89-186.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6b5a83c80sm96497885a.72.2024.12.05.13.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 13:04:52 -0800 (PST) From: Greg Hogan To: 73993@debbugs.gnu.org Subject: [PATCH v2 2/3] gnu: git-sizer: Use gexps. Date: Thu, 5 Dec 2024 21:04:32 +0000 Message-ID: <5fb143fe5d3b981106d71d9d029d026a732982c2.1733430615.git.code@greghogan.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/version-control.scm (git-sizer) [arguments]<#:phases>: Use gexps. Change-Id: Ic2c797c59b7f5f0d30b4b799eb293be4973f7e13 --- gnu/packages/version-control.scm | 39 ++++++++++++++++---------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 86e241ad27..37ee819688 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -4461,25 +4461,26 @@ (define-public git-sizer "1b4sl4djnfaxwph41y4bh9yal4bpd1nz4403ryp7nzna7h2x0zis")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/github/git-sizer" - #:install-source? #f - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'fix-paths - (lambda* (#:key outputs #:allow-other-keys) - (substitute* '("src/github.com/github/git-sizer/git_sizer_test.go") - (("bin/git-sizer") - (string-append (assoc-ref outputs "out") - "/bin/git-sizer"))))) - (replace 'check - (lambda* (#:key tests? import-path #:allow-other-keys) - (when tests? - (for-each (lambda (test) - (invoke "go" "test" "-v" "-run" test import-path)) - ;; TestExec and TestSubmodule require a copy of the - ;; Git repository. - '("TestBomb" "TestFromSubdir" "TestRefgroups" - "TestRefSelections" "TestTaggedTags")))))))) + (list + #:import-path "github.com/github/git-sizer" + #:install-source? #f + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda _ + (let ((git #$git)) + (substitute* '("src/github.com/github/git-sizer/git_sizer_test.go") + (("bin/git-sizer") + (string-append #$output "/bin/git-sizer")))))) + (replace 'check + (lambda* (#:key tests? import-path #:allow-other-keys) + (when tests? + (for-each (lambda (test) + (invoke "go" "test" "-v" "-run" test import-path)) + ;; TestExec and TestSubmodule require a copy of the + ;; Git repository. + '("TestBomb" "TestFromSubdir" "TestRefgroups" + "TestRefSelections" "TestTaggedTags")))))))) (propagated-inputs (list git go-github-com-cli-safeexec -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 16:08:08 2024 Received: (at 73993) by debbugs.gnu.org; 5 Dec 2024 21:08:08 +0000 Received: from localhost ([127.0.0.1]:41172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ4y-0003UW-5o for submit@debbugs.gnu.org; Thu, 05 Dec 2024 16:08:08 -0500 Received: from mail-ot1-f45.google.com ([209.85.210.45]:45060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJJ4v-0003UN-MD for 73993@debbugs.gnu.org; Thu, 05 Dec 2024 16:08:06 -0500 Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-71d50b89132so588749a34.2 for <73993@debbugs.gnu.org>; Thu, 05 Dec 2024 13:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733432825; x=1734037625; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=D1/GtH/WxnULgLS/c/ud4vTSBiYt7VqQgQf99++vdQ0=; b=ToqTgVotXJU0+uxYVLAFWbT8UJcTmnwDKyjnMgqRiDc5GuOrAsEbu8Ru3K7kzbuyOf zSQFr9Xs5zfHckYDDx8Vl3TrQ88xbi+VSlvs7bOflKxrDMhgUrLq0U0KnjVnm2BmnYFB 9C2GEQNi97Vmci9hWWppDQMLK469XeBDA2mP+LZ5cQDyb5mRVk65xNC8njhZnqU7NM2T BTYCM9+yEZ4tL8N/g/2L0gG5m0edthu0UJmFwq7LJ/9DOF6B0QITTarEm/UfbBNYFb4y Vn+q2FQbO1ml0V88IHmNgKEN7h2kD8yoIIIL1UP1XJAzjP2QImehtOJpNyvMTl1eq1Of JUjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733432825; x=1734037625; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D1/GtH/WxnULgLS/c/ud4vTSBiYt7VqQgQf99++vdQ0=; b=kxST7wOcS9BBLApM7I/IP+U0gTIHoXGsIhTy9sqvxyD8i7JjXDSkoZE+HZ//2IV00I KhdI+plcG97BPaZbP5Qq4zlSzd6QdSDMWkf4jORNq00JOWFeEE3SsR9bCYBneeYQoPMe 6duEl7nZB4YPhCplKtlwNUFI2C3xQDpsNfWqovn54efMwpTtTMsLExBX25hoZZjvl60I vCBUYfR3PWUOMM7tSxDBQ6NL8wpCDu+ELtOZesOiNfCYCXbFsBxeLSQsClqIvZnrawDk N8r2Hh12Wp3ENGFPi5XhjhNlSvjy9DWEzljfE9DNJvGPX9eEC6vudHlVon29z1s7UCN1 uBWw== X-Gm-Message-State: AOJu0YyAXfCT4nn/UkCDn9dZXWEC0koazUT1FIBI5VzibC/AQrsOyynH jIGOQKIGFaTZf4NUd7BOqQAxiz3DveVIDSo1KQPVlqCJm9Wz2QO9VLunwGzy05DGUBQXE25Rlw+ sAbwkya/JQuFPstENmRntkbWdc4Bqsr5rORCKkqlvpKE48WCP X-Gm-Gg: ASbGncv5mLTkK+tNcJEBpiKKQ7s7ctJxGm/IQmj4og6c7lTsyx1HxGFHeuJQ+cEGepl 421i2H5/CsxR7yg95K9tMqAiKhpCx3tM= X-Google-Smtp-Source: AGHT+IEH06wt0YC0oZTczc+BIvtqfJuZsk/fVU+JZBPOiTenXtIJrir0zuXzaOQ9CSAHKDKCPCxTrSVrCrr2snTHBs0= X-Received: by 2002:a05:6830:6319:b0:71d:415a:5d18 with SMTP id 46e09a7af769-71dcf4ac198mr303109a34.3.1733432825098; Thu, 05 Dec 2024 13:07:05 -0800 (PST) MIME-Version: 1.0 References: <12475749a8d371488d9ae1fa331ad10dd24aa644.1729796653.git.code@greghogan.com> <48353def5b5c7b3eae7fd7101a42a36ef1e13225.camel@gmail.com> In-Reply-To: <48353def5b5c7b3eae7fd7101a42a36ef1e13225.camel@gmail.com> From: Greg Hogan Date: Thu, 5 Dec 2024 16:06:54 -0500 Message-ID: Subject: Re: [PATCH] gnu: git-sizer: Pin git version. To: Liliana Marie Prikler Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: 73993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Nov 29, 2024 at 4:40=E2=80=AFAM Liliana Marie Prikler wrote: > > Am Donnerstag, dem 24.10.2024 um 19:05 +0000 schrieb Greg Hogan: > > When I submitted this package the placement of git in native-inputs > > was incorrect. This patch switches that dependency to the pinned > > version of git in inputs and therefore hard-codes the path. > > > > * gnu/packages/version-control.scm (git-sizer) > > [arguments]<#:phases>: Use gexps and hard-code git path in 'fix- > > paths. > > [propagated-inputs]: Remove git. > > [native-inputs]: Add git-minimal/pinned. > The ChangeLog here is wrong. git is removed from native-inputs and > git-minimal/pinned added to inputs. > > I would suggest making the change to G-Expressions in a separate patch > for easier review. > > Cheers Thanks for reviewing and catching the errors in the commit message. I have split v2 into three commits because the current package is broken as git needs to be either propagated or hard-coded. The git dependency should have been in propagated-inputs, and is now in inputs. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 16:19:22 2024 Received: (at 73993) by debbugs.gnu.org; 6 Dec 2024 21:19:22 +0000 Received: from localhost ([127.0.0.1]:44478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJfjN-0007NL-Rx for submit@debbugs.gnu.org; Fri, 06 Dec 2024 16:19:22 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:50462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJfjL-0007NC-Gn for 73993@debbugs.gnu.org; Fri, 06 Dec 2024 16:19:20 -0500 Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-386329da1d9so250679f8f.1 for <73993@debbugs.gnu.org>; Fri, 06 Dec 2024 13:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733519898; x=1734124698; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=tvIjMPY8g7WFoD8eLXKtXhTsHkPoiEyVcbnII1+fdTU=; b=i6J5cgJKsSF2OK3OEsbJfGGH23yJmK3HluvYpAANDwbI2m8OvDrmPI5ernHUaRMzEY 0UErL6F91DQQkZgycUqx7m7DLNRMIKCKRpP2blsY73WGu7N7pwi/U0LoeT+Sm6SxWEqH lpk7ShJTvAMwON45MuytXnuebRJK74sH3QTCJ17kFUVcjcwGv6N++0wgIrS7NHEKxV+U fy7VpVT+y4/b7hikWJfubISc0OWKu0b+OlTuq+SSMA0QyN726ztCcY4Ti8FAzVjpOsic ruARHCbjTKb/H5BiuUYn7gJGALz+LUdOIfmp4/qVNdxtVID9GKxhqtSrtHSCXUk+YQ4G Qfbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733519898; x=1734124698; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tvIjMPY8g7WFoD8eLXKtXhTsHkPoiEyVcbnII1+fdTU=; b=tikOsQnIdPXu2yxqmgkxGosy9KyoflI4rAeeKa+66tfGf/3/LWMRiasUFHyoQ+yz+Y eP1plRLRRmW9iHUSNLQ/PMGeHMv6b8F8NZLRs7vLNlokhfjXgPJ9xjMchqEZdU0VpO9K 9CprFFjn0KCxxFktXuStL24Rtzt0Bvm1ewhRHO/QLj9AJfq2BM7BmGzY5jyntVFyBWEV Xk8HGudhMekK/n8Xps0b8U5TsYD3isqB6nBIH1WqIydu/I5aBDpfuOFM5bsdspKWD5mt BExqcEklqcg9QP6InZfRy4zTECeGXFIM7oQXVs0Q2Ojzg2ZHSNk1LtqMAZ8baMw9S1fp Q+lg== X-Forwarded-Encrypted: i=1; AJvYcCW4evsumaNWCjyrroLJJ6thX7Eexv0C3weINaX7PO4kWM7XQ6TexDvW7yMT0EAS0Ej+1+BRKw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzV2IHcQQWUxAQ+l4xfbFVjJ6mVycPCzDMCtTYgc2FxCDcTRHYi 9/4ZXOkleIYztNK88Ud3lxVdl/UTKQxVFQxV2iG1VcO9B+U1lKPk X-Gm-Gg: ASbGncvb/s9g7df/pktP+IRDRRBUQNBxY6Obg1fE+piP7wUEmCagM0HfnWzW1kL6vYi IoM3S0c8ikhEeOmcHtmTKkXfDFaXR0Ab6Ap/o8N9xVqDzojCXV+HZxTVOxgQLht3XjPqXkAxQIi QzcPAtvVCSq7LfDG0hhLWunw+WDD3DqdvQHOj/cbDPR0FLlTWyjQK1Qut/2FpcyT6IC1dlVWvAW yNx6ZSYKET93M2efppF6sLjKI4KrI162KQrTHglxAK1gFJCeSiiPqkg96IeNvfCnKy0025RjrwZ ury0B9txpx0PpsBS/CR3vP5iLw== X-Google-Smtp-Source: AGHT+IG4G/lJaOAUqFDL+pkSWGmhbfOvizUqJZFyO6Qc4CP8dwW418N+SgTR6oRshTR6zsYV4NcdZQ== X-Received: by 2002:a05:6000:1448:b0:385:e38f:8dd with SMTP id ffacd0b85a97d-3862b3d5c13mr3967016f8f.46.1733519898237; Fri, 06 Dec 2024 13:18:18 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3861ecf3efasm5414243f8f.17.2024.12.06.13.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 13:18:17 -0800 (PST) Message-ID: <7aa919a4b5bdcd5a6c855ab4e6dcafa732dfedb9.camel@gmail.com> Subject: Re: [PATCH v2 3/3] gnu: git-sizer: Pin git version. From: Liliana Marie Prikler To: Greg Hogan , 73993@debbugs.gnu.org Date: Fri, 06 Dec 2024 22:19:08 +0100 In-Reply-To: <8ab694342d0e9668dec24cf24170ce89276d440d.1733430615.git.code@greghogan.com> References: <8ab694342d0e9668dec24cf24170ce89276d440d.1733430615.git.code@greghogan.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRG9ubmVyc3RhZywgZGVtIDA1LjEyLjIwMjQgdW0gMjE6MDQgKzAwMDAgc2NocmllYiBHcmVn IEhvZ2FuOgo+ICogZ251L3BhY2thZ2VzL3ZlcnNpb24tY29udHJvbC5zY20gKGdpdC1zaXplcikK PiBbYXJndW1lbnRzXTwjOnBoYXNlcz46IEhhcmQtY29kZSBnaXQgcGF0aCBpbiAnZml4LXBhdGhz Lgo+IFtwcm9wYWdhdGVkLWlucHV0c106IFJlbW92ZSBnaXQuCj4gW2lucHV0c106IEFkZCBnaXQt bWluaW1hbC9waW5uZWQuCj4gCj4gQ2hhbmdlLUlkOiBJY2MyMWY5MmUwMjYxZmYwNWYzNDExOTcw ZTZmNDc5Mjc2M2E5NGY4MAo+IC0tLQpHZW5lcmFsIG5vdGU6IHdoZW4gc29tZW9uZSBjb21tZW50 cyBvbiB5b3VyIHBhdGNoLCBkb24ndCBmb3JnZXQgdG8gQ0MKdGhlbSBpbiB1cGNvbWluZyByZXZp c2lvbnMgOikKCj4gwqBnbnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbSB8IDExICsrKysr KystLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbSBiL2du dS9wYWNrYWdlcy92ZXJzaW9uLQo+IGNvbnRyb2wuc2NtCj4gaW5kZXggMzdlZTgxOTY4OC4uOGM3 ZDgxNzUyMyAxMDA2NDQKPiAtLS0gYS9nbnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbQo+ ICsrKyBiL2dudS9wYWNrYWdlcy92ZXJzaW9uLWNvbnRyb2wuc2NtCj4gQEAgLTQ0NjgsMTAgKzQ0 NjgsMTMgQEAgKGRlZmluZS1wdWJsaWMgZ2l0LXNpemVyCj4gwqDCoMKgwqDCoMKgICN+KG1vZGlm eS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIChhZGQtYWZ0 ZXIgJ3VucGFjayAnZml4LXBhdGhzCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsYW1iZGEg Xwo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobGV0ICgoZ2l0ICMkZ2l0KSkKPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxldCAoKGdpdCAjJGdpdC1taW5pbWFsL3Bpbm5lZCkp CkknZCByYXRoZXIgYXZvaWQgYmluZGluZyBnaXQgcGVyIGdleHAgaGVyZS4KPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKHN1YnN0aXR1dGUqICcoInNyYy9naXRodWIuY29tL2dpdGh1 Yi9naXQtCj4gc2l6ZXIvZ2l0X3NpemVyX3Rlc3QuZ28iKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKCgiYmluL2dpdC1zaXplciIpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKHN0cmluZy1hcHBlbmQgIyRvdXRwdXQgIi9iaW4vZ2l0LXNpemVyIikp KSkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzdHJpbmctYXBwZW5k ICMkb3V0cHV0ICIvYmluL2dpdC1zaXplciIpKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAoc3Vic3RpdHV0ZSogJygic3JjL2dpdGh1Yi5jb20vZ2l0aHViL2dpdC0KPiBzaXplci9n aXQvZ2l0LmdvIikKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKCgiZ2l0Qmlu LCBlcnIgOj0gZmluZEdpdEJpblxcKFxcKSIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgKHN0cmluZy1hcHBlbmQgImdpdEJpbiA6PSBcIiIgZ2l0Cj4gIi9iaW4vZ2l0XCJc blx0dmFyIGVyciBlcnJvciIpKSkpKSkKWW91IGNhbiB1c2UgKHNlYXJjaC1pbnB1dC1maWxlIOKA pikgaW5zdGVhZC4KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoCAocmVwbGFjZSAnY2hlY2sKPiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxhbWJkYSogKCM6a2V5IHRlc3RzPyBpbXBvcnQtcGF0aCAj OmFsbG93LW90aGVyLWtleXMpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAod2hlbiB0 ZXN0cz8KPiBAQCAtNDQ4MSw5ICs0NDg0LDkgQEAgKGRlZmluZS1wdWJsaWMgZ2l0LXNpemVyCj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBH aXQgcmVwb3NpdG9yeS4KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgICcoIlRlc3RCb21iIiAiVGVzdEZyb21TdWJkaXIiCj4gIlRlc3RSZWZncm91 cHMiCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgIlRlc3RSZWZTZWxlY3Rpb25zIgo+ICJUZXN0VGFnZ2VkVGFncyIpKSkpKSkpKQo+ICvC oMKgwqAgKGlucHV0cyAobGlzdCBnaXQtbWluaW1hbC9waW5uZWQpKQo+IMKgwqDCoMKgIChwcm9w YWdhdGVkLWlucHV0cwo+IC3CoMKgwqDCoCAobGlzdCBnaXQKPiAtwqDCoMKgwqDCoMKgwqDCoMKg wqAgZ28tZ2l0aHViLWNvbS1jbGktc2FmZWV4ZWMKPiArwqDCoMKgwqAgKGxpc3QgZ28tZ2l0aHVi LWNvbS1jbGktc2FmZWV4ZWMKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvLWdpdGh1Yi1jb20t ZGF2ZWNnaC1nby1zcGV3Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnby1naXRodWItY29tLXBt ZXphcmQtZ28tZGlmZmxpYgo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ28tZ2l0aHViLWNvbS1z cGYxMy1wZmxhZwpJIGRvbid0IHNlZSBhIGdvb2QgcmVhc29uIHRvIG1vdmUgZ2l0IGZpcnN0IHRv IHByb3BhZ2F0ZWQtaW5wdXRzIGFuZAp0aGVuIHRvIGlucHV0cy4gIEkgd291bGQgc3F1YXNoIHRo aXMgYW5kIDEvMyBpbnRvIG9uZSBwYXRjaCB0aGF0CmRvZXNuJ3QgbmVjZXNzYXJpbHkgcmVseSBv biBHLUV4cHJlc3Npb25zIGluIHRoZSBtaWRkbGUgOikKCkNoZWVycwo= From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 10:39:37 2024 Received: (at 73993) by debbugs.gnu.org; 9 Dec 2024 15:39:37 +0000 Received: from localhost ([127.0.0.1]:55217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKfrF-0003Za-Bi for submit@debbugs.gnu.org; Mon, 09 Dec 2024 10:39:37 -0500 Received: from mail-qk1-f182.google.com ([209.85.222.182]:46183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKfrD-0003ZI-ID for 73993@debbugs.gnu.org; Mon, 09 Dec 2024 10:39:36 -0500 Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7b6c2bc1d21so174978685a.0 for <73993@debbugs.gnu.org>; Mon, 09 Dec 2024 07:39:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733758710; x=1734363510; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mbw3nqv6MzmgExm++hR7AQCxv20vbdKLNkyY5moZ0zo=; b=2Ym6Lxg6cpD9cENFg3MQ9OIp0urB23OIXEKEPvPpCn+s0cs4aYgutBXVV0Cat2m7wj y1C/Ll5a6/DXqj8yx2AbC4TZPdmIKTVn4q7RkYkOExh+J8ZigUX1x98y+CKDKUe6bu0f slun8SXJYkCj/Q+ynstZZezeL7F38fr2LZjVuNEZXF/1gQAn5fGqf6ELXuQ+oU5RovdM H4Cee5sfzcur0OrSdlWJFoI9CI1lzJsjTDOTfuIxuvZ6WpdFzHBU0JL/resrOiAvs84u PJIr6lTo/82FEWtH7FrdeOBXKrdhD5b+nDfWAaoe5vMOG2J53v2T9dfThcj+dm28tOk6 WwVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733758710; x=1734363510; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mbw3nqv6MzmgExm++hR7AQCxv20vbdKLNkyY5moZ0zo=; b=A5Z+wVYLk7L1X9167LGY3bxVI2hnk5wMmpwIOgKZS/ape4TEGg1Lz6Adlp7CZQR9BJ DAockkkT4wXZc9/GXoEIc4duKQ9Ii96MGjPXYtP/9gIZ1jpjnc1Bvj0OZ07nXGmsL7o2 oPMEUqcbigYt7Dv0L/72NpQjS9AJKLdtjZjAkNRYIci/JgLSk9OyLtYeeritzDmfp+MK /mcQhNupOxBg9J+jyt6SBPiSu4CKMAohZ0WJqyIHmzGNFViWdPIhzcNMoXLZ+vZzzoAt TMFnJX4WaMU7SKeN5xqXh69V9zcX2+OxByOmMd3ixJd81SMPcOyV06ajwHLkZmysS248 32EA== X-Gm-Message-State: AOJu0YzSlln3Z73GNqB1/c82hAejPvGLMn+1zOdmLbQ7r3b0AJPAu1g8 5hi2JfBBLqhce/oADJLfAkeeadKD5ZRs8xeGyUPxxp6aJJZb+F2cGdXwa1+0Bx0H+qL8657OwEc M X-Gm-Gg: ASbGncvcxPvywtystdBD2qsuSkQE0SXcTzp0MCbxRQ+4rkatXHtdEjh1pX5XnJinHdQ rlk5IOULGLcaHcN14DvlnWQdYgkrYvMxnriu9QOvbD/wCuZmMvVYhUv2tKTuRISaV/P5Mo+Q3oF 2MAwc03XlR4CVHW5zv5lkKIGeQDiDiyq+IMghfJMNcER7b9kdSVwbdQX+o9xAksJB1wE5IIhIm2 HZkKTvpKlTIicNs1H05EIWl1Bq/2+ph6goH6+fymfpGpsvdWw6Xa5v2EqVrCDQN1uw5kY4oh8Hw oTNCAVyUz+aI4Cu2M+qHAPDcO5V0OtBqEcfidqWRGFmtp9pMtg== X-Google-Smtp-Source: AGHT+IENr32tZ6U1bFYYr1DJspGqOGf7agDQ9MwSNEDTwwkp2dZXwGEiMOuzLC3z7ZHNjJlxq+aZnA== X-Received: by 2002:a05:620a:8806:b0:7b6:d9b6:b53 with SMTP id af79cd13be357-7b6dcee33b7mr116644985a.60.1733758709560; Mon, 09 Dec 2024 07:38:29 -0800 (PST) Received: from ip-10-114-89-186.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6ce23a3fdsm192353385a.99.2024.12.09.07.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 07:38:29 -0800 (PST) From: Greg Hogan To: 73993@debbugs.gnu.org Subject: [PATCH v3] gnu: git-sizer: Pin git version. Date: Mon, 9 Dec 2024 15:30:52 +0000 Message-ID: <98c9da16b8fe18f553d46262e2292fcca7bf4699.1733758114.git.code@greghogan.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: liliana.prikler@gmail.com, Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/version-control.scm (git-sizer) [arguments]<#:phases>: Hard-code git path in 'fix-paths. [native-inputs]: Remove git. [inputs]: Add git-minimal/pinned. Change-Id: If6178a0e1c453ea47a1f70cd507639b5be2142b0 --- gnu/packages/version-control.scm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 3339e79390..eb9dcfa198 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -4479,7 +4479,12 @@ (define-public git-sizer #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-paths - (lambda* (#:key outputs #:allow-other-keys) + (lambda* (#:key inputs outputs #:allow-other-keys) + (substitute* '("src/github.com/github/git-sizer/git/git.go") + (("gitBin, err := findGitBin\\(\\)") + (string-append "gitBin := \"" + (search-input-file inputs "bin/git") + "\"\n\tvar err error"))) (substitute* '("src/github.com/github/git-sizer/git_sizer_test.go") (("bin/git-sizer") (string-append (assoc-ref outputs "out") @@ -4493,7 +4498,7 @@ (define-public git-sizer ;; Git repository. '("TestBomb" "TestFromSubdir" "TestRefgroups" "TestRefSelections" "TestTaggedTags")))))))) - (native-inputs (list git)) + (inputs (list git-minimal/pinned)) (propagated-inputs (list go-github-com-cli-safeexec go-github-com-davecgh-go-spew base-commit: 9d09b0cf841fb657a1aec12e9bab68e00c2b493c -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 06:02:46 2024 Received: (at 73993) by debbugs.gnu.org; 18 Dec 2024 11:02:46 +0000 Received: from localhost ([127.0.0.1]:33634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNrp9-0004fc-Vb for submit@debbugs.gnu.org; Wed, 18 Dec 2024 06:02:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNrp7-0004fL-EL for 73993@debbugs.gnu.org; Wed, 18 Dec 2024 06:02:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNrp2-0000vr-6Q; Wed, 18 Dec 2024 06:02:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=RuZFtLQcmSPLGJR4GuOE8ZD65Nh86kUWr5uG5d5N9Tk=; b=qpif4dhT/DYSTfw39tXH gWv1vo6PER+GqJ7A6xNJmJmzuNTp/NzpuIyjXdlCECOsRavSY9g9f3jDGwfij0YkG7/Bw2jpTGIPY 8AIBYKimZcdZD12CG5CN+wP5ckFAh0wVGiM9R2eAlZxT7feeYyn2Lm0TH/pQXLbp/gmoPot0JLJv7 oWkysmfhwqMAs+nQsax6eNkEraU4MJCyrPQZ3IXYbWJIYhm0uDj/4/HHigYSiWk7mOvVWH34DUGmt GS8NxRCwAlR/nRMavbnc7UgbWWCOGmdKWuofooKVkc+DqYpJO30kr/ijjqoqvq1PkNlteQFMCw6Ph ODxGMaJl2qGzIQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Greg Hogan Subject: Re: [bug#73993] [PATCH v2 1/3] gnu: git-sizer: Propagate git. In-Reply-To: (Greg Hogan's message of "Thu, 5 Dec 2024 21:04:31 +0000") References: Date: Wed, 18 Dec 2024 12:02:26 +0100 Message-ID: <87a5ctmeyl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73993 Cc: 73993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Greg Hogan skribis: > Fix the current version of this package, which depends on git from PATH. > > * gnu/packages/version-control.scm (git-sizer) > [native-inputs]: Move git ... > [propagated-inputs]: ... to here. > > Change-Id: Iea70a16845e93f5c3740da5596e61cc2d7fd17b9 [...] > (propagated-inputs > - (list go-github-com-cli-safeexec > + (list git Instead of propagating, it would be nice to record the absolute file name in the source. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 06:03:33 2024 Received: (at 73993) by debbugs.gnu.org; 18 Dec 2024 11:03:34 +0000 Received: from localhost ([127.0.0.1]:33639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNrq1-0004hc-Dl for submit@debbugs.gnu.org; Wed, 18 Dec 2024 06:03:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNrq0-0004hM-H3 for 73993@debbugs.gnu.org; Wed, 18 Dec 2024 06:03:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNrpv-0001BF-9O; Wed, 18 Dec 2024 06:03:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=B/ll7aB/exhhooZwDeca9o364DVLZfOeESqOUlvzJ5g=; b=BOw07FENxlDLc6WZoQ+h NS0dMkPGBqlFbRYnd1ME8htE4H8vCN/R3AVUkGzsx4WvehH8w+TYBwGF7swBnIYIUE2UlNGEQAQCd OeyM+NEQNCHnzs2019ZuqYHGygpluQJLisFUqWpr561m3xxW4r7vWvQaLdUohKC1mFmdPcnIIwFmN SDq18gE67pA2JvGRyTnHKYXen1sNkRgnSzsrU6g9L72M5qkJKKAfMR/AQFXH16VFJDxSJ01l418XU EGkhMupLZV8FGgXrGl+zUGLcByIhMrK4Xho7Fggs4eOLvJeLiFmOHszTT+2BPYJSKZqWFEqrTOWtc ck9uXZVZ7tTSVg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Greg Hogan Subject: Re: [bug#73993] [PATCH v2 2/3] gnu: git-sizer: Use gexps. In-Reply-To: <5fb143fe5d3b981106d71d9d029d026a732982c2.1733430615.git.code@greghogan.com> (Greg Hogan's message of "Thu, 5 Dec 2024 21:04:32 +0000") References: <5fb143fe5d3b981106d71d9d029d026a732982c2.1733430615.git.code@greghogan.com> Date: Wed, 18 Dec 2024 12:03:13 +0100 Message-ID: <875xnhmexa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73993 Cc: 73993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Greg Hogan skribis: > * gnu/packages/version-control.scm (git-sizer) > [arguments]<#:phases>: Use gexps. > > Change-Id: Ic2c797c59b7f5f0d30b4b799eb293be4973f7e13 [...] > + (add-after 'unpack 'fix-paths > + (lambda _ > + (let ((git #$git)) This variable is unused. If it were used, it should instead be: (let ((git #$(this-package-input "git"))) =E2=80=A6) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 14:36:51 2024 Received: (at 73993) by debbugs.gnu.org; 26 Dec 2024 19:36:51 +0000 Received: from localhost ([127.0.0.1]:42266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQtf9-0006Fj-5c for submit@debbugs.gnu.org; Thu, 26 Dec 2024 14:36:51 -0500 Received: from mail-ot1-f52.google.com ([209.85.210.52]:50207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQtf7-0006Fa-G4 for 73993@debbugs.gnu.org; Thu, 26 Dec 2024 14:36:50 -0500 Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-71e1e051e50so1668322a34.0 for <73993@debbugs.gnu.org>; Thu, 26 Dec 2024 11:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1735241748; x=1735846548; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=84qWPxK1DDun4lvH1NxnZw5VG7DfZeltRUn3AZ/0wRE=; b=fO+ZmG9iQJZ2vV48flS/wvhokU3kLMAdHGsbL4d1v8rLdou1lvk9ywR24I+CSJbBH/ ouMsh0irwcb69V7XByoisva+Zo+oZ6T5KKYfD2o5jbp9C5gXuHU//oXnEg9g2NERORJW 5n47ZrAyYQfb1auWaiSpHlLJZfSUSo5DnwJGeI44nHZvqH4DyPyIiJ1BXicfZQef95cT bH5PlK7vemuHgCxtFRuMmBdiyMNfcgi38ofs7bMILJ1M+EFikE7hTmu3KP9cwMn6GMhv KcdIkK4O2IQFjUyib4pCVpbj+UNZbSBCIg/C/pMowE2BZlFZlZvewvqvfMFM4C8Lm6Tq YrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735241748; x=1735846548; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=84qWPxK1DDun4lvH1NxnZw5VG7DfZeltRUn3AZ/0wRE=; b=pQtG8TlPWxkgPzz4ZRiYCOKxcAlPPJySXMVqJXiBcYyPTDm67VJis7HAB0yZsokV5u 1NtQSpe0nJS11fMJ/fdeTOiekyoQhBY595s7BslQ1XOB8PoqrRgiBQ4C3A9wedI6frPW mBLZ9O/j4/5bYVD/jDTXb9S6itxaXLEduOTD3vY2b0fFjBTkpFROBdR+KuA8PD1PNI3j 88DLaOZEgUUrTUU89Noga3Yfw0Bk7w8ewV/QF3oletKbaLSrz90wjciEx8K7i2gCzI2f TpybFqq3BAiIxwkv6WSMig9/DCtsgDcZ+tOA5ZOwJlfuwrwmfHH9Gj0lCpaODEA0aHRo ldww== X-Gm-Message-State: AOJu0YzFC4OUscaj+9V4sfZLBjbK9hIbLUb2dzLYZ9NULA9Rnxl2r863 0xpiUxSyZQG19OSpN1WNNHVd6k4KO2ETuIDPMKc6RElRTPZ+CCmmeXrk7Dzh8s1hQIg/SY4Or+w yS231jWL1+ozok2c/Kvy0Ydf1kMZFMRer39DfPA== X-Gm-Gg: ASbGncvauyQdPmZNkYh7YHjZKLqvITDRa5uJqrTlSvN5iBL6FfvPckUMYWyfsbhAdL9 29554bRaYYdwTwc2iij4m6x46zdpNzYKwuCXcbQ== X-Google-Smtp-Source: AGHT+IHvL+0dlFpT78z/L3HblkGyTrLA/XuR1BFlHiMyUrWexCNsSB2JOA+7YcYQ+SDbDdOXANDKLkK9HOgf1U3NGrU= X-Received: by 2002:a05:6830:411f:b0:71d:5043:1026 with SMTP id 46e09a7af769-720ff840fd9mr13759334a34.9.1735241748230; Thu, 26 Dec 2024 11:35:48 -0800 (PST) MIME-Version: 1.0 References: <87a5ctmeyl.fsf@gnu.org> In-Reply-To: <87a5ctmeyl.fsf@gnu.org> From: Greg Hogan Date: Thu, 26 Dec 2024 14:35:37 -0500 Message-ID: Subject: Re: [bug#73993] [PATCH v2 1/3] gnu: git-sizer: Propagate git. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73993 Cc: 73993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Dec 18, 2024 at 6:02=E2=80=AFAM Ludovic Court=C3=A8s = wrote: > > Greg Hogan skribis: > > > Fix the current version of this package, which depends on git from PATH= . > > > > * gnu/packages/version-control.scm (git-sizer) > > [native-inputs]: Move git ... > > [propagated-inputs]: ... to here. > > > > Change-Id: Iea70a16845e93f5c3740da5596e61cc2d7fd17b9 > > [...] > > > (propagated-inputs > > - (list go-github-com-cli-safeexec > > + (list git > > Instead of propagating, it would be nice to record the absolute file > name in the source. Ludo', Thanks for reviewing this. There was already a v3 which consolidated the patches (I had separated the bugfix from the patch) and is greatly simplified per Liliana's recommendations. Greg From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 17:07:08 2024 Received: (at control) by debbugs.gnu.org; 26 Dec 2024 22:07:08 +0000 Received: from localhost ([127.0.0.1]:42579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQw0a-00050q-Bd for submit@debbugs.gnu.org; Thu, 26 Dec 2024 17:07:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQw0N-000508-OX for control@debbugs.gnu.org; Thu, 26 Dec 2024 17:07:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQw0I-0000pk-Ih for control@debbugs.gnu.org; Thu, 26 Dec 2024 17:06:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=0LyS7ZdHw5HTQ61Ot/TGhsPS4B23Dr6sH2BXJaN3VsA=; b=irXMbBDgxOGepe BlIbVFR/KIkT10zo3JhPSYBVVxVIwuu6xcbpRgXXMIZGLVWn3cQM5fSEwcY4zYjGb6NL4wpYDNCpc IRhHan3WeTZ3GfWVYTQb2wXg8qI5DoTxV2HENpw9ajGMWUEwAZSBLgozygbzNgcGy1846DuqGGA0a YDYqzjfCGu5BIwB0sYVOxosCb7zG4sG5jGaQzET3fQYCjLPIBEFI44si2MwFLTM30DHKa1bUGzFyG vuCLfjDPmcQUMOm33WfirhyisNfoQ+dyhbZlt+FI8Sq88p+yK09JBeVFWIFV3NZS0j4GJxl7GSnv/ 8yyp+oEtG9zuHMN7FhHA==; Date: Thu, 26 Dec 2024 23:06:49 +0100 Message-Id: <87h66qyu86.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #73993 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 73993 quit From unknown Tue Aug 19 09:32:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 24 Jan 2025 12:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator