Subject: bug#73985: fix: charset.max_char may be used before being set

From: Eli Zaretskii <[email-masked]>
Date: Thu, 24 Oct 2024 17:12:13 +0300

> Date: Thu, 24 Oct 2024 11:46:17 +0000
> From:  altermo31 via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> Problem:
> If the value to be set to charset.max_char is invalid, an error occurs, but the error uses the yet unset charset.max_char.
> 
> Solution:
> Use the value that charset.max_char would be set to if the value wasn't invalid.

Thanks.  You are right that the original code is incorrect, but the
code you propose has a subtle problem: the sum

  i + charset.code_offset

could overflow.  So we need to find a safer way of explaining the
problem.