GNU bug report logs - #73981
[PATCH 0/4] gnu: update modem-manager and deps.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 73981 <at> debbugs.gnu.org
Subject: [bug#73981] [PATCH 1/4] gnu: libmbim: Update to 1.30.0.
Date: Mon, 11 Nov 2024 23:22:19 +0900

Hi Zheng,

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:

Apologies, it seems I've duplicated your work in my just submitted
#74306!  Some comments below.

> * gnu/packages/freedesktop.scm (libmbim): Update to 1.30.0.
> [source]: Switch to git-fetch.
> [build-system]: Switch to meson-build-system.
> [native-inputs]: Add gobject-introspection, bash-completion, help2man. Replace
> python-wrapper with python-minimal.
>
> Change-Id: I607bff667a057e58bebb2f706d7021a4d1c8d763
> ---
>  gnu/packages/freedesktop.scm | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index 0ab0bb51044..a7c740f3d05 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -1900,19 +1900,24 @@ (define-public accountsservice
>  (define-public libmbim
>    (package
>      (name "libmbim")
> -    (version "1.26.4")
> +    (version "1.30.0")
>      (source (origin
> -              (method url-fetch)
> -              (uri (string-append
> -                    "https://www.freedesktop.org/software/libmbim/"
> -                    "libmbim-" version ".tar.xz"))
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.freedesktop.org/mobile-broadband/libmbim")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "1ncaarl4lgc7i52rwz50yq701wk2rr478cjybxbifsjqqk2cx27n"))))
> -    (build-system gnu-build-system)
> +                "00kbjvpka51zrfjigzd3rk6r4x8hkg1xfj7d9zl9lccysnxyjx5h"))))
> +    (build-system meson-build-system)
>      (native-inputs
>       (list `(,glib "bin") ; for glib-mkenums
> -           pkg-config python-wrapper))
> +           pkg-config
> +           python-minimal
> +           gobject-introspection
> +           bash-completion
> +           help2man))

Here it would be nice to keep the inputs sorted alphabetically.
Shouldn't bash-completion be an 'input' instead of a 'native-input' ?

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.