Subject: bug#73965: closed (Re: [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 23 Oct 2024 16:10:03 +0000

Your bug report

#73965: [PATCH] gnu: phonon-backend-vlc: Enable QT6.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73965: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73965
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
From: Zheng Junjie <[email-masked]>
To: Sughosha via Guix-patches via <[email-masked]>
Cc: [email-masked], Sughosha <[email-masked]>
Date: Thu, 24 Oct 2024 00:08:35 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Sughosha via Guix-patches via <[email-masked]> writes:

> This is just a VLC backend for phonon, not the phonon itself. Currently this package is used only by dragon
> and none other, which does not have a qt5 version packaged yet.

ok, push it, and i use ON/OFF replace 1/0. close.

>
> On 23 October 2024 8:09:04 pm IST, Zheng Junjie <[email-masked]> wrote:
>
>  Sughosha via Guix-patches via <[email-masked]> writes:
>
>   * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
>  [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
>  "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
>  [native-inputs]: Replace qttools-5 with qttools.
>  [inputs]: Replace qtbase-5 with qtbase.
>
>  Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
> -------------------------------------------------------------------------------------------
>   gnu/packages/kde-frameworks.scm | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
>  diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
>  index 13d4e24726..a14ba1ffb0 100644
>  --- a/gnu/packages/kde-frameworks.scm
>  +++ b/gnu/packages/kde-frameworks.scm
>  @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>       (build-system cmake-build-system)
>       (arguments
>        (list #:configure-flags
>  -           #~(list "-DPHONON_BUILD_QT6=OFF")))
>  +           #~(list "-DPHONON_BUILD_QT5=0"
>  +                    "-DPHONON_BUILD_QT6=1")))
>       (native-inputs
>  -     (list extra-cmake-modules qttools-5))
>  +     (list extra-cmake-modules qttools))
>       (inputs
>  -     (list phonon qtbase-5 vlc))
>  +     (list phonon qtbase vlc))
>       (home-page "https://community.kde.org/Phonon")
>       (synopsis "Phonon backend which uses VLC")
>       (description "Phonon makes use of backend libraries to provide sound.
>
>  base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
>
> i think maybe also add a qt5 version? some package use phonon with qt5.
>
> Sughosha

Subject: [PATCH] gnu: phonon-backend-vlc: Enable QT6.
From: Sughosha <[email-masked]>
To: [email-masked]
Cc: Sughosha <[email-masked]>
Date: Wed, 23 Oct 2024 19:43:38 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
[arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
"-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
[native-inputs]: Replace qttools-5 with qttools.
[inputs]: Replace qtbase-5 with qtbase.

Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
---
 gnu/packages/kde-frameworks.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 13d4e24726..a14ba1ffb0 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
     (build-system cmake-build-system)
     (arguments
      (list #:configure-flags
-           #~(list "-DPHONON_BUILD_QT6=OFF")))
+           #~(list "-DPHONON_BUILD_QT5=0"
+                    "-DPHONON_BUILD_QT6=1")))
     (native-inputs
-     (list extra-cmake-modules qttools-5))
+     (list extra-cmake-modules qttools))
     (inputs
-     (list phonon qtbase-5 vlc))
+     (list phonon qtbase vlc))
     (home-page "https://community.kde.org/Phonon")
     (synopsis "Phonon backend which uses VLC")
     (description "Phonon makes use of backend libraries to provide sound.

base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
-- 
2.46.0