GNU bug report logs - #73965
[PATCH] gnu: phonon-backend-vlc: Enable QT6.

Previous Next

Package: guix-patches;

Reported by: Sughosha <sughosha <at> disroot.org>

Date: Wed, 23 Oct 2024 14:18:02 UTC

Severity: normal

Tags: patch

Done: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73965 in the body.
You can then email your comments to 73965 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#73965; Package guix-patches. (Wed, 23 Oct 2024 14:18:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sughosha <sughosha <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 23 Oct 2024 14:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH] gnu: phonon-backend-vlc: Enable QT6.
Date: Wed, 23 Oct 2024 19:43:38 +0530

* gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
[arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
"-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
[native-inputs]: Replace qttools-5 with qttools.
[inputs]: Replace qtbase-5 with qtbase.

Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
---
 gnu/packages/kde-frameworks.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 13d4e24726..a14ba1ffb0 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
     (build-system cmake-build-system)
     (arguments
      (list #:configure-flags
-           #~(list "-DPHONON_BUILD_QT6=OFF")))
+           #~(list "-DPHONON_BUILD_QT5=0"
+                    "-DPHONON_BUILD_QT6=1")))
     (native-inputs
-     (list extra-cmake-modules qttools-5))
+     (list extra-cmake-modules qttools))
     (inputs
-     (list phonon qtbase-5 vlc))
+     (list phonon qtbase vlc))
     (home-page "https://community.kde.org/Phonon")
     (synopsis "Phonon backend which uses VLC")
     (description "Phonon makes use of backend libraries to provide sound.

base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
-- 
2.46.0
Information forwarded to guix-patches <at> gnu.org:
bug#73965; Package guix-patches. (Wed, 23 Oct 2024 14:41:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: Sughosha <sughosha <at> disroot.org>, 73965 <at> debbugs.gnu.org
Subject: Re: [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
Date: Wed, 23 Oct 2024 22:39:04 +0800

[Message part 1 (text/plain, inline)]
Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
> [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
> "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
> [native-inputs]: Replace qttools-5 with qttools.
> [inputs]: Replace qtbase-5 with qtbase.
>
> Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
> ---
>  gnu/packages/kde-frameworks.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 13d4e24726..a14ba1ffb0 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>      (build-system cmake-build-system)
>      (arguments
>       (list #:configure-flags
> -           #~(list "-DPHONON_BUILD_QT6=OFF")))
> +           #~(list "-DPHONON_BUILD_QT5=0"
> +                    "-DPHONON_BUILD_QT6=1")))
>      (native-inputs
> -     (list extra-cmake-modules qttools-5))
> +     (list extra-cmake-modules qttools))
>      (inputs
> -     (list phonon qtbase-5 vlc))
> +     (list phonon qtbase vlc))
>      (home-page "https://community.kde.org/Phonon")
>      (synopsis "Phonon backend which uses VLC")
>      (description "Phonon makes use of backend libraries to provide sound.
>
> base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1

i think maybe also add a qt5 version? some package use phonon with qt5.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#73965; Package guix-patches. (Wed, 23 Oct 2024 14:41:03 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#73965; Package guix-patches. (Wed, 23 Oct 2024 15:17:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>,
 Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73965 <at> debbugs.gnu.org
Subject: Re: [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
Date: Wed, 23 Oct 2024 20:45:36 +0530

[Message part 1 (text/plain, inline)]
This is just a VLC backend for phonon, not the phonon itself. Currently this package is used only by dragon and none other, which does not have a qt5 version packaged yet.

On 23 October 2024 8:09:04 pm IST, Zheng Junjie <zhengjunjie <at> iscas.ac.cn> wrote:
>Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
>> [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
>> "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
>> [native-inputs]: Replace qttools-5 with qttools.
>> [inputs]: Replace qtbase-5 with qtbase.
>>
>> Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
>> ---
>>  gnu/packages/kde-frameworks.scm | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
>> index 13d4e24726..a14ba1ffb0 100644
>> --- a/gnu/packages/kde-frameworks.scm
>> +++ b/gnu/packages/kde-frameworks.scm
>> @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>>      (build-system cmake-build-system)
>>      (arguments
>>       (list #:configure-flags
>> -           #~(list "-DPHONON_BUILD_QT6=OFF")))
>> +           #~(list "-DPHONON_BUILD_QT5=0"
>> +                    "-DPHONON_BUILD_QT6=1")))
>>      (native-inputs
>> -     (list extra-cmake-modules qttools-5))
>> +     (list extra-cmake-modules qttools))
>>      (inputs
>> -     (list phonon qtbase-5 vlc))
>> +     (list phonon qtbase vlc))
>>      (home-page "https://community.kde.org/Phonon")
>>      (synopsis "Phonon backend which uses VLC")
>>      (description "Phonon makes use of backend libraries to provide sound.
>>
>> base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
>
>i think maybe also add a qt5 version? some package use phonon with qt5.

Sughosha
[Message part 2 (text/html, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#73965; Package guix-patches. (Wed, 23 Oct 2024 15:17:02 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#73965; Package guix-patches. (Wed, 23 Oct 2024 16:10:02 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73965-done <at> debbugs.gnu.org, Sughosha <sughosha <at> disroot.org>
Subject: Re: [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
Date: Thu, 24 Oct 2024 00:08:35 +0800

[Message part 1 (text/plain, inline)]
Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:

> This is just a VLC backend for phonon, not the phonon itself. Currently this package is used only by dragon
> and none other, which does not have a qt5 version packaged yet.

ok, push it, and i use ON/OFF replace 1/0. close.

>
> On 23 October 2024 8:09:04 pm IST, Zheng Junjie <zhengjunjie <at> iscas.ac.cn> wrote:
>
>  Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>   * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
>  [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
>  "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
>  [native-inputs]: Replace qttools-5 with qttools.
>  [inputs]: Replace qtbase-5 with qtbase.
>
>  Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
> -------------------------------------------------------------------------------------------
>   gnu/packages/kde-frameworks.scm | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
>  diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
>  index 13d4e24726..a14ba1ffb0 100644
>  --- a/gnu/packages/kde-frameworks.scm
>  +++ b/gnu/packages/kde-frameworks.scm
>  @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>       (build-system cmake-build-system)
>       (arguments
>        (list #:configure-flags
>  -           #~(list "-DPHONON_BUILD_QT6=OFF")))
>  +           #~(list "-DPHONON_BUILD_QT5=0"
>  +                    "-DPHONON_BUILD_QT6=1")))
>       (native-inputs
>  -     (list extra-cmake-modules qttools-5))
>  +     (list extra-cmake-modules qttools))
>       (inputs
>  -     (list phonon qtbase-5 vlc))
>  +     (list phonon qtbase vlc))
>       (home-page "https://community.kde.org/Phonon")
>       (synopsis "Phonon backend which uses VLC")
>       (description "Phonon makes use of backend libraries to provide sound.
>
>  base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
>
> i think maybe also add a qt5 version? some package use phonon with qt5.
>
> Sughosha

[signature.asc (application/pgp-signature, inline)]
Reply sent to Zheng Junjie <zhengjunjie <at> iscas.ac.cn>:
You have taken responsibility. (Wed, 23 Oct 2024 16:10:03 GMT) Full text and rfc822 format available.
Notification sent to Sughosha <sughosha <at> disroot.org>:
bug acknowledged by developer. (Wed, 23 Oct 2024 16:10:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 21 Nov 2024 12:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 210 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.