GNU bug report logs - #73963
[PATCH] gnu: povray: Fix test run requiring interaction.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73963 in the body.
You can then email your comments to 73963 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: povray: Fix test run requiring interaction.
Date: Wed, 23 Oct 2024 14:00:30 +0200

[Message part 1 (text/plain, inline)]

The test render required pressing a key after it was done, which caused the
package build to get stuck.  Also disable the render display window, which
did not cause issues but was pointless.

* gnu/packages/graphics.scm (povray)[args]: Patch test render not to pause nor
display a window.

Change-Id: Ia9527b3a67896972b399464b97dda464365d41ea
---
 gnu/packages/graphics.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index c12516383b..8d309cac33 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -37,6 +37,7 @@
 ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
 ;;; Copyright © 2023 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2023, 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
+;;; Copyright © 2024 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1656,7 +1657,9 @@ (define-public povray
               (setenv "HOME" (getcwd))
               (with-directory-excursion "unix"
                 (substitute* "prebuild.sh"
-                  (("/bin/sh") (which "sh")))
+                  (("/bin/sh") (which "sh"))
+                  ;; Make test run non-interactive.
+                  (("biscuit.pov -f \\+d \\+p \\+v") "biscuit.pov -f +v"))
                 (invoke "sh" "prebuild.sh"))))
           ;; The bootstrap script is run by the prebuild script in the
           ;; "run-prebuild" phase.

base-commit: b8f8699a1f6e23fec46be7e086abde1270331ac9
-- 
2.46.0


-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 73963-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 73963-done <at> debbugs.gnu.org
Subject: Re: [bug#73963] [PATCH] gnu: povray: Fix test run requiring
 interaction.
Date: Mon, 02 Dec 2024 22:10:38 +0100

Ivan Vilata i Balaguer <ivan <at> selidor.net> skribis:

> The test render required pressing a key after it was done, which caused the
> package build to get stuck.  Also disable the render display window, which
> did not cause issues but was pointless.
>
> * gnu/packages/graphics.scm (povray)[args]: Patch test render not to pause nor
> display a window.
>
> Change-Id: Ia9527b3a67896972b399464b97dda464365d41ea

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.