GNU bug report logs - #73955
[PATCH 0/2] Improve customizability of WireGuard service

Previous Next

Package: guix-patches;

Reported by: Richard Sent <richard <at> freakingpenguin.com>

Date: Tue, 22 Oct 2024 21:25:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Richard Sent <richard <at> freakingpenguin.com>
Subject: bug#73955: closed (Re: [PATCH v4 1/3] services: wireguard: Make
 the private-key field optional.)
Date: Fri, 06 Dec 2024 20:40:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#73955: [PATCH 0/2] Improve customizability of WireGuard service

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73955 <at> debbugs.gnu.org.

-- 
73955: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73955
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: 73955-done <at> debbugs.gnu.org
Subject: Re: [PATCH v4 1/3] services: wireguard: Make the private-key field
 optional.
Date: Fri, 06 Dec 2024 21:36:04 +0100
Hello Richard,

I have pushed the series,

Thanks for your patience,

Mathieu

[Message part 3 (message/rfc822, inline)]
From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: othacehe <at> gnu.org, Richard Sent <richard <at> freakingpenguin.com>,
 guix <at> twilken.net, maxim.cournoyer <at> gmail.com, eu <at> euandre.org
Subject: [PATCH 0/2] Improve customizability of WireGuard service
Date: Tue, 22 Oct 2024 17:21:47 -0400
Hi all,

The goal for this patch series is to improve wireguard-service's
customizability, primarily by supporting gexps evaluating to strings in most
fields. Prior to this patch, lists of gexp's were not serialized to strings,
preventing certain constructs from being used.

This was prompted from an issue I ran into a while back. [1]

I tested the serialization of several config records and did not notice any
issues. I would greatly appreciate if any users of wireguard-service could
confirm their existing configurations still serialize correctly. You can do so
via these guix REPL commands:

$ guix repl -L /path/to/guix/clone/with/patches
,use (guix)
,use (gnu services vpn)
,build ((@@ (gnu services vpn) wireguard-configuration-file)
        <paste-your-wireguard-configuration>)

I took the liberty of CCing a few people who previously committed to
WireGuard. Apologies if I committed a faux pas. :)

[1]: https://lists.gnu.org/archive/html/help-guix/2024-01/msg00204.html

Richard Sent (2):
  services: wireguard: Make the private-key field optional.
  services: wireguard: Support lists of gexps for most fields.

 doc/guix.texi        |  5 ++-
 gnu/services/vpn.scm | 74 +++++++++++++++++++++++---------------------
 2 files changed, 43 insertions(+), 36 deletions(-)


base-commit: bd26815cf8ce38a3b03676a6e3fc482bb74247cb
-- 
2.46.0




This bug report was last modified 169 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.