GNU bug report logs - #73948
[PATCH 0/2] 'derivation-build-plan' returns builds in topological order

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Tue, 22 Oct 2024 13:22:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73948: closed ([PATCH 0/2] 'derivation-build-plan' returns
 builds in topological order)
Date: Tue, 12 Nov 2024 23:04:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 13 Nov 2024 00:03:26 +0100
with message-id <87ttccqcld.fsf <at> gnu.org>
and subject line Re: [bug#73948] [PATCH 0/2] 'derivation-build-plan' returns builds in topological order
has caused the debbugs.gnu.org bug report #73948,
regarding [PATCH 0/2] 'derivation-build-plan' returns builds in topological order
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73948: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73948
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/2] 'derivation-build-plan' returns builds in topological
 order
Date: Tue, 22 Oct 2024 15:21:05 +0200
Hello,

There’s one situation in ‘cuirass remote-worker’ where I found that it
would be more convenient for ‘derivation-build-plan’ to return the list of
builds in topological order, so a worker can perform them sequentially
in the right order.

From a UI viewpoint, it also seems to make more sense to display the
list of things to build in topological order.

Thoughts?

Ludo’.

Ludovic Courtès (2):
  derivations: ‘derivation-build-plan’ returns builds in topological
    order.
  ui: ‘show-what-to-build’ displays builds in topological order.

 guix/derivations.scm  | 74 +++++++++++++++++++++++++------------------
 guix/ui.scm           |  2 +-
 tests/derivations.scm | 31 ++++++++++++++++--
 3 files changed, 73 insertions(+), 34 deletions(-)


base-commit: 42612e3bdfb201dbd47d6b8ffc75345199a96a80
-- 
2.46.0



[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: <janneke <at> gnu.org>
Cc: 73948-done <at> debbugs.gnu.org, Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#73948] [PATCH 0/2] 'derivation-build-plan' returns builds
 in topological order
Date: Wed, 13 Nov 2024 00:03:26 +0100
Hello,

<janneke <at> gnu.org> skribis:

> Ludovic Courtès writes:
>
> Hi,
>
>> There’s one situation in ‘cuirass remote-worker’ where I found that it
>> would be more convenient for ‘derivation-build-plan’ to return the list of
>> builds in topological order, so a worker can perform them sequentially
>> in the right order.
>>
>> From a UI viewpoint, it also seems to make more sense to display the
>> list of things to build in topological order.
>>
>> Thoughts?
>
> LGTM, and lovely.
>
> Having this sorted would be a big help, I'm often trying to figure this
> out by traversing drvs!

Thanks for your feedback.  Pushed as
f7a0be4d736a56403fd9bd630dc723f59f348453!

Ludo’.


This bug report was last modified 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.