Subject: Re: [bug#73936] [PATCH v2] gnu: Add tuner.

From: "Ashish SHUKLA" <[email-masked]>
Date: Tue, 31 Dec 2024 13:49:26 +0000

El 2024-12-31 21:40, Zheng Junjie escribió:
> Ashish SHUKLA via Guix-patches via <[email-masked]> writes:
>
> > * gnu/packages/music.scm (tuner): New variable.
> >
> > Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1
> > ---
> >  gnu/packages/music.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> >
> > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> > index 6825f14dcc..77922d9576 100644
> > --- a/gnu/packages/music.scm
> > +++ b/gnu/packages/music.scm
> > @@ -59,6 +59,7 @@
> >  ;;; Copyright © 2024 Parnikkapore <[email-masked]>
> >  ;;; Copyright © 2024 hapster <[email-masked]>
> >  ;;; Copyright © 2024 Nikita Domnitskii <[email-masked]>
> > +;;; Copyright © 2024 Ashish SHUKLA <[email-masked]>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -168,6 +169,7 @@ (define-module (gnu packages music)
> >    #:use-module (gnu packages ncurses)
> >    #:use-module (gnu packages netpbm)
> >    #:use-module (gnu packages networking)
> > +  #:use-module (gnu packages pantheon)
> >    #:use-module (gnu packages pcre)
> >    #:use-module (gnu packages pdf)
> >    #:use-module (gnu packages perl)
> > @@ -2868,6 +2870,58 @@ (define-public bristol
> >  is subjective.")
> >      (license license:gpl3+)))
> >  
> > +(define-public tuner
> > +  (package
> > +    (name "tuner")
> > +    (version "1.5.6")
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                     (url "https://github.com/louis77/tuner")
> > +                     (commit (string-append "v" version))))
> > +              (file-name (git-file-name name version))
> > +              (sha256 (base32 "0zz91n56vdwhjwqscl21016i4l4lx3m6ja0fnrapmf16bdl0rrai"))))
> > +    (build-system meson-build-system)
> > +    (native-inputs
> > +     (list desktop-file-utils ; update-desktop-database
> > +           gettext-minimal
> > +           `(,glib "bin") ; glib-compile-schemas
> > +           ; for org.gnome.system.proxy schema
> > +           gsettings-desktop-schemas
> > +           `(,gtk "bin") ; gtk-update-icon-cache
> > +           pkg-config
> > +           vala))
> > +    (inputs
> > +      (list bash-minimal
> > +            glib
> > +            granite-6
> > +            gtk+
> > +            libgee
> > +            gstreamer
> > +            gst-plugins-base   ; for gstreamer 'playbin'
> > +            gst-plugins-good   ; for gstreamer 'scaletempo'
> > +            gst-plugins-bad
> > +            libsoup
> > +            json-glib-minimal))
> > +    (arguments
> > +      (list
> > +        #:glib-or-gtk? #t
> > +        #:phases
> > +        #~(modify-phases %standard-phases
> > +            (add-after 'install 'wrap-tuner
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (let ((out             (assoc-ref outputs "out"))
>                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>                         please remove it.
> > +                     (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> > +                 (wrap-program (string-append out "/bin/com.github.louis77.tuner")
>                                                  ^^^ for gexp, just use #$output
>
> And this application's bin is com.github.louis77.tuner, maybe add a
> soft link called tuner? Of course, this comment can be ignored.

It's upstream's preference to have their executable named like this, so I'm not in the opinion of changing it.

Thanks!
-- 
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)