From unknown Fri Jun 20 07:15:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73930 <73930@debbugs.gnu.org> To: bug#73930 <73930@debbugs.gnu.org> Subject: Status: [PATCH] gnu: git-repo: Update to 2.29.7 Reply-To: bug#73930 <73930@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:15:24 +0000 retitle 73930 [PATCH] gnu: git-repo: Update to 2.29.7 reassign 73930 guix-patches submitter 73930 Do=C4=9Fan =C3=87e=C3=A7en severity 73930 normal tag 73930 patch moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 09:49:37 2024 Received: (at submit) by debbugs.gnu.org; 21 Oct 2024 13:49:37 +0000 Received: from localhost ([127.0.0.1]:50700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2smu-0002IX-BB for submit@debbugs.gnu.org; Mon, 21 Oct 2024 09:49:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:38200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2s2P-0008Ny-RH for submit@debbugs.gnu.org; Mon, 21 Oct 2024 09:01:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2s1t-0000S8-0R for guix-patches@gnu.org; Mon, 21 Oct 2024 09:01:01 -0400 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2s1r-0005cX-9T for guix-patches@gnu.org; Mon, 21 Oct 2024 09:01:00 -0400 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 742701140289; Mon, 21 Oct 2024 09:00:56 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Mon, 21 Oct 2024 09:00:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm3; t=1729515656; x=1729602056; bh=jUE05eYXHefmhUb52YEam +1rMqWRmuCTydxP/oqsEBg=; b=bj5wVl/0RI2oSiQh9ZnqPzECsd2Unl5Lp+bid z9Frd3jSa3ovQoWr5eZ+9rtERgT3QS2JLa5NiAKJKujtquOAuWeljFjdU4CuLfXV FsmT4SCP9XEyr9Q0yyhWo1BRgIA2LN1MEylUVVuP3ADj6rmHHrGofd3POJaZjqOE fRVgql/bcJUxGZGFu75gItmdA9aFDlRM/VIND6Ck0PG+hSOS9RECwBc3cwV+BG4P RwcQetlM1WQ79W3SdQOnmtcdqKISL7pS+MxWZ+q3iC7ptZ+tqTG5lh+oJTo9gjrY EjO6p0pSYFh9xT5u27SdCjAP5T9uwPdxq0bxZLAv90WynQqNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729515656; x=1729602056; bh=jUE05eYXHefmhUb52YEam+1rMqWR muCTydxP/oqsEBg=; b=RKD8D5l8LOAaPwNuxw97ANthSbcZW6cCCe81o6uPszmF cSWlnM5UKGNvdbpqyd0fG635JjGHxcmIJ7enTwr8/RIpNYstJTDiCMr90n95/JTB COWaI6MiULiHRQrnHC6cEk6Oc4Va2Oyn2dlmNcG6K8+JY2pDYWgJjnIF9iRPXYok 4rfYn/CiMphFoOitT5gYUjhFK7hUbWAD9Z72vzRvLFFWrRoXxU/kkc6rJY9Ei0vi +mPLp8uO4ygZ9egomCsyjD3GIj6c6t+17lnlIa+mE7c/gqY1+kqBeqZ0Mbk/bgDQ Cnh9jKvwPfJ6G3iW6asDVPR9SLstzDzRtvs2raEYWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehledgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffoggfgsedtkeertdertdejnecuhfhrohhmpeffohhgrghnucmrvgopvghnuceoshgv phgvthhhsehfrghsthhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepieehvdegle eghfevieeugfevudffiedvieelhfelkeelhfekhefflefhtdeikedvnecuffhomhgrihhn pehgohhoghhlvgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsvghpvghthhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphht thhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehguhhigidqphgrthgthh gvshesghhnuhdrohhrghdprhgtphhtthhopehsvghpvghthhesfhgrshhtmhgrihhlrdgt ohhm X-ME-Proxy: Feedback-ID: i57994943:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Oct 2024 09:00:54 -0400 (EDT) From: =?UTF-8?q?Do=C4=9Fan=20=C3=87e=C3=A7en?= To: guix-patches@gnu.org Subject: [PATCH] gnu: git-repo: Update to 2.29.7 Date: Mon, 21 Oct 2024 15:00:11 +0200 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=103.168.172.159; envelope-from=sepeth@fastmail.com; helo=fhigh-a8-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 21 Oct 2024 09:49:25 -0400 Cc: =?UTF-8?q?Do=C4=9Fan=20=C3=87e=C3=A7en?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Fixes ModuleNotFoundError: No module named 'formatter'. This module was deprecated, and removed in Python 3.10. * gnu/packages/android.scm (git-repo): Update to 2.29.7 Change-Id: I74d48fd9a8afc76c18d866b252a139f77b7ab838 --- gnu/packages/android.scm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index 11e05dced9..0f41fa8695 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -919,7 +919,7 @@ (define-public etc1tool (define-public git-repo (package (name "git-repo") - (version "2.4.1") + (version "2.29.7") (source (origin (method git-fetch) @@ -928,7 +928,7 @@ (define-public git-repo (commit (string-append "v" version)))) (file-name (string-append "git-repo-" version "-checkout")) (sha256 - (base32 "0khg1731927gvin73dcbw1657kbfq4k7agla5rpzqcnwkk5agzg3")))) + (base32 "01sl9bz9rnhf9s3h7nlhkpxm0ggc5jzs30n11vlvnv2mqp8r1jvq")))) (build-system python-build-system) (arguments `(#:phases @@ -1000,12 +1000,11 @@ (define-public git-repo (symlink (string-append repo-dir "/repo") (string-append bin-dir "/repo")) #t)))))) - (inputs ;; TODO: Add git-remote-persistent-https once it is available in guix - `(("git" ,git) - ("ssh" ,openssh))) + (inputs + (list git openssh gnupg)) (native-inputs - `(("pytest" ,python-pytest))) + (list python-pytest)) (home-page "https://code.google.com/p/git-repo/") (synopsis "Helps to manage many Git repositories") (description "Repo is a tool built on top of Git. Repo helps manage many base-commit: 59b2a60d0041882d732e1766e28f0df5a1ef1ac1 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 23 08:49:57 2024 Received: (at 73930) by debbugs.gnu.org; 23 Oct 2024 12:49:57 +0000 Received: from localhost ([127.0.0.1]:58942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3aoG-00026E-SE for submit@debbugs.gnu.org; Wed, 23 Oct 2024 08:49:57 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:54387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3aoE-000265-Pf for 73930@debbugs.gnu.org; Wed, 23 Oct 2024 08:49:55 -0400 Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-20c6f492d2dso78056725ad.0 for <73930@debbugs.gnu.org>; Wed, 23 Oct 2024 05:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729687704; x=1730292504; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5PciGbH9jro5HDO3/VRRuCz8GWjfeyiZn6tmxQy7sjc=; b=ByjPfP+bSZJ3awGA0+1QmhfZrVAM3XGtrI4RfH2vN41bnu5jPLN3csCTL0wdMVUo+U WGr0j8j639be21g84+HkX5Ye3NypOzEujU20jEuAiELbKAraYJS5OByp8xCZkQkC92ra Q7Vv6FB+OjCxO9T6pg06C+7DvVQADcUa5+0BsIwcGfVNNzvwKKiPcMo87QQuHsqPEYGx Pp/ZrRDZ4QnxnWToiT6qyTGZAlUYZNnb0D1hhfR9SZ7p4Rm8XAkAueGhPZTj6mUoFxAR bUj8uTaoSC7k4liy4OIK4lRlYLfh+9ZAtGwtdQJI2iKD+xztbXGoHOHMrnZw0Pv3rOtS bNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729687704; x=1730292504; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5PciGbH9jro5HDO3/VRRuCz8GWjfeyiZn6tmxQy7sjc=; b=ITujLsxNI+WlXaFJe2l8Z6oac/Z5mX+dfYNxIq7QkUXGthKc/pmXWuHPrlqcLObvfm 2E25xDPsGT/4lGqUVF+G+N3Jdu9AVi19b6lXIMRc1y7ow1VKqF7Ysz6H1VuEVAj/KF76 GdY5xDrJX7OCxkBikoL/k79Cg1wHajDbsMxtC2dWAF4UVg2fDqC0xctgc7viyVHGoLvD B60ZpJ2fpSkv5ai8YqmrBBAlxfRvK7oRJD0P5LnREONfI8yyevqgEW/Ktex/KJ37OnEt TQZQg9uvjPMEzcuoQQ5tVW5kmtYxR1hEAulmmh85jNpt1aNOHOjw60lhbirbZ3hOfnT2 mIMA== X-Gm-Message-State: AOJu0YzIGdZYR9oFSyKgRGTfem44u+pvVDv6kAN2PbJ7495q1sJ3jZ5q M1wQEmRkabSnbk7FyaR80TairV4dajRt2gdjdMJVdTiJLHmGNPjTqTsLlQ== X-Google-Smtp-Source: AGHT+IHHZRzotlEFjxLxuESPUTX1zxY+4pZXStL5RL8/eFWWl6H0N5mznlx14I6t6EEryr2SB5HVlQ== X-Received: by 2002:a17:90b:885:b0:2e2:b41b:854e with SMTP id 98e67ed59e1d1-2e76b60d3e4mr2648753a91.20.1729687704088; Wed, 23 Oct 2024 05:48:24 -0700 (PDT) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e76e05b780sm1289525a91.42.2024.10.23.05.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 05:48:23 -0700 (PDT) From: Maxim Cournoyer To: =?utf-8?B?RG/En2FuIMOHZcOnZW4=?= Subject: Re: [bug#73930] [PATCH] gnu: git-repo: Update to 2.29.7 In-Reply-To: (=?utf-8?B?IkRvxJ9hbiDDh2XDp2VuIidz?= message of "Mon, 21 Oct 2024 15:00:11 +0200") References: Date: Wed, 23 Oct 2024 21:48:17 +0900 Message-ID: <8734kn0yum.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73930 Cc: 73930@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Do=C4=9Fan =C3=87e=C3=A7en writes: > Fixes ModuleNotFoundError: No module named 'formatter'. > This module was deprecated, and removed in Python 3.10. > > * gnu/packages/android.scm (git-repo): Update to 2.29.7 > > Change-Id: I74d48fd9a8afc76c18d866b252a139f77b7ab838 > --- > gnu/packages/android.scm | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm > index 11e05dced9..0f41fa8695 100644 > --- a/gnu/packages/android.scm > +++ b/gnu/packages/android.scm > @@ -919,7 +919,7 @@ (define-public etc1tool > (define-public git-repo > (package > (name "git-repo") > - (version "2.4.1") > + (version "2.29.7") > (source > (origin > (method git-fetch) > @@ -928,7 +928,7 @@ (define-public git-repo > (commit (string-append "v" version)))) > (file-name (string-append "git-repo-" version "-checkout")) > (sha256 > - (base32 "0khg1731927gvin73dcbw1657kbfq4k7agla5rpzqcnwkk5agzg3"))= )) > + (base32 "01sl9bz9rnhf9s3h7nlhkpxm0ggc5jzs30n11vlvnv2mqp8r1jvq"))= )) > (build-system python-build-system) > (arguments > `(#:phases > @@ -1000,12 +1000,11 @@ (define-public git-repo > (symlink (string-append repo-dir "/repo") > (string-append bin-dir "/repo")) > #t)))))) > - (inputs > ;; TODO: Add git-remote-persistent-https once it is available in gu= ix > - `(("git" ,git) > - ("ssh" ,openssh))) > + (inputs > + (list git openssh gnupg)) > (native-inputs > - `(("pytest" ,python-pytest))) > + (list python-pytest)) > (home-page "https://code.google.com/p/git-repo/") > (synopsis "Helps to manage many Git repositories") > (description "Repo is a tool built on top of Git. Repo helps manage= many This looks too simple to be true, given the complex patching going on in phases (in retrospect this should have been done via a real patch to avoid silent breakage like is probably happening here). The idea of the patch was to ensure 'git-repo' wouldn't update itself when run, as that defeats the immutable principle of Guix packages. Could you test this property is preserved? The addition of gnupg makes me suspect it isn't. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 23 16:38:24 2024 Received: (at 73930) by debbugs.gnu.org; 23 Oct 2024 20:38:24 +0000 Received: from localhost ([127.0.0.1]:60936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3i7b-00078d-PM for submit@debbugs.gnu.org; Wed, 23 Oct 2024 16:38:24 -0400 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]:57683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3i7Y-00078M-HB for 73930@debbugs.gnu.org; Wed, 23 Oct 2024 16:38:21 -0400 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 600B61380232; Wed, 23 Oct 2024 16:37:45 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-10.internal (MEProxy); Wed, 23 Oct 2024 16:37:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1729715865; x=1729802265; bh=XGd1AK0dXVw7owv43BHp09KH3Gfn/qKwgUTdJohcWvQ=; b= f8qJlCcE0l0KYHcgZoRyX9nTsiF5VXqM57N64X4smqrnoFxVF5LAcdOqqBaziq/A mkQxwm24Nx8HhZAMQiePrEH0+ujGj2YSARTYTvo1Jro2a0lUheb9TObIT8dNpZtW NNKFC2dlO98uPqeJDuOhoIjVvJQ3HlAI3bn6B142soi6hjbRLVCIOi73UKBAFd8k iNARtldXBtqNpWulr3pMU+y8zLiPIcZIivd3o5tYiImD1lwQrCwJhSYCLu5Ww4Mj AiTMjjES1H81qxNtIu4FT21OOTnxFGbVE+yDxLWYU32nK+Co5cuGOMU5n8J58zST AEpmDrMziSmS4+C+v6j78g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729715865; x= 1729802265; bh=XGd1AK0dXVw7owv43BHp09KH3Gfn/qKwgUTdJohcWvQ=; b=o Cx+1iVNHSylymN4dtFIeIoSz0Oy9noZvTfv71zJFuI8ZNjdf7p7rDDSXW4vxt7JH iRvS/IZOT/Yg6OosisooDmZ2bKw1g5MsTX5zjdWTCJGb1jqPvZpwyIbNj12z8R0y 4VemJNPYHmIX3Pdh6yC5XPBDKTGKRpU1xSrYRMIQAVQr8Jewu1EIsuzBOrFfJK7S plKg5hV33o8INBIEFkRNd+2MBrzfpV+b1YEvT8He8zjeKl3jobPOtISG99gOrewF 0SZcEEMu6vBQmXbdHiIA8BhwdmP4v0YNwOX5Mq0+WyvHP7GZoGhDqjXJi7Bs6dKq Sdl5WqbdAVAsgQB1r9J0g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeijedgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt jeenucfhrhhomhepffhoghgrnhcurmgvpogvnhcuoehsvghpvghthhesfhgrshhtmhgrih hlrdgtohhmqeenucggtffrrghtthgvrhhnpeetkedtheelffeigfdvuefhueejudevfeeg uddvuedvkeelgfettdegleethfelfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehsvghpvghthhesfhgrshhtmhgrihhlrdgtohhmpdhnsggp rhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeejfeelfedtse guvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepmhgrgihimhdrtghouhhrnhho higvrhesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i57994943:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 05CFD3020080; Wed, 23 Oct 2024 16:37:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Wed, 23 Oct 2024 20:37:24 +0000 From: =?UTF-8?Q?Do=C4=9Fan_=C3=87e=C3=A7en?= To: "Maxim Cournoyer" Message-Id: In-Reply-To: <8734kn0yum.fsf@gmail.com> References: <8734kn0yum.fsf@gmail.com> Subject: Re: [bug#73930] [PATCH] gnu: git-repo: Update to 2.29.7 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73930 Cc: 73930@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Maxim, Thanks for looking into this. > This looks too simple to be true, given the complex patching going on in > phases (in retrospect this should have been done via a real patch to > avoid silent breakage like is probably happening here). Sorry, I am not following. What do you mean by the complex patching going on in phases and the silent breakage? > The idea of the patch was to ensure 'git-repo' wouldn't update itself > when run, as that defeats the immutable principle of Guix packages. >From what I can tell, it doesn't do that. Or, at least, it reports repeatedly the same version when I run `repo --version`, and it says the version I upgraded to, 2.29.7. And, I was able to use the tool successfully after the upgrade. Note that this is not the latest version of repo tool. The latest version is 2.48, but that failed during the check phase, and 2.30 and upwards fails with the same reason IIRC. I couldn't get to the latest version without upgrading some core python packages. Even though repo now needs python-black, and it didn't work with the version we currently have in Guix. I tried upgrading that and some more but went into the rabbit hole of upgrading some core packages such as python-build and python-packaging-bootstrap etc, then I stopped. > Could you test this property is preserved? The addition of gnupg makes > me suspect it isn't. No problem, I tried the following and reported the same result, but I am not exactly sure if this is right way to test what you meant: ``` $ ./pre-inst-env guix build --check --no-offload --source --rounds=2 git-repo ... warning: rewriting hashes in `/gnu/store/agzslk3pvakz9vf66pr49dc7v2xjkf1j-git-repo-2.29.7-checkout'; cross fingers successfully built /gnu/store/8vwzck1s9d6siph4w3x62w0xdmk95yl8-git-repo-2.29.7-checkout.drv successfully built /gnu/store/8vwzck1s9d6siph4w3x62w0xdmk95yl8-git-repo-2.29.7-checkout.drv /gnu/store/agzslk3pvakz9vf66pr49dc7v2xjkf1j-git-repo-2.29.7-checkout ``` Many thanks, Dogan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 18:01:40 2024 Received: (at control) by debbugs.gnu.org; 29 Dec 2024 23:01:40 +0000 Received: from localhost ([127.0.0.1]:56527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS2I0-0002KV-Do for submit@debbugs.gnu.org; Sun, 29 Dec 2024 18:01:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS2Hy-0002KG-TD for control@debbugs.gnu.org; Sun, 29 Dec 2024 18:01:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tS2Ht-0006NT-GS for control@debbugs.gnu.org; Sun, 29 Dec 2024 18:01:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=BVp/f5zJlz8nNGyIGmd8AtR/R/sV0qJLY++6GhGK+uA=; b=DpdbZqckD8/2BW NyKaz49og9k+4zDU0R56MvVBhdQjXGbRiuKHi9OEgEainaBVDTYkiB2LvGJkKTLgLL0dsNLlm/TgM wzCr9naoBI9PegRbks6a3SS7M948YnWadZoro5dPSP7EEyBaZ5we/JKQcXopt4qM4UDURhVhaBWVK jCH9Fw5poqlnEBe5gbwygvCVEna1dY3MKnv/GfLntUZA/kG4nY60aIzz+qqVSnohGaWob09hacHHO W5D1SMvwd2xMyHRkDBS9JitegqMITFkuXGR8ZkV2RbXhGDVJgqBYjCNpjW/Ik7pau0V87SYHjHksg MXigfkucSSe7+WR0gDiA==; Date: Mon, 30 Dec 2024 00:01:16 +0100 Message-Id: <87h66mnlfn.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #73930 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 73930 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon May 26 20:18:10 2025 Received: (at 73930-done) by debbugs.gnu.org; 27 May 2025 00:18:10 +0000 Received: from localhost ([127.0.0.1]:34001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJi1B-000132-QN for submit@debbugs.gnu.org; Mon, 26 May 2025 20:18:10 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:42284) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uJi19-00012S-3q for 73930-done@debbugs.gnu.org; Mon, 26 May 2025 20:18:07 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-7398d65476eso1683805b3a.1 for <73930-done@debbugs.gnu.org>; Mon, 26 May 2025 17:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748305080; x=1748909880; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uac/dfs9YbNpzmNA0jaR8Q4zQY2+KOiduhSNZuX3B+Q=; b=KgtnLDethFvzanXq+2mMJE7zrO+tK3KPu5H0rH10BNPjPBdv91cgIKOjokY4Luufxq tLq5cEEOI37Ly2iNpj/pHcV8GZn+WIN7blZh3K3ujv/Pi4d/yUpXsrlAUfXoiJhTr1Fw zNPNirDMaeDZfdG2uJy+l+Uo0uvHIt7S/Q6/KvcmAQa8QKd+klWkxDAG7k10oVK0fb42 fqUaeP87fsENLdheoRFb8nC21VKWbd7JF8YUXg/pKOOg/Z70U5dDLFZvs0eSakW+1gHb oA/nPqGHiuuOT8LNGXdrs+mNju2b5b4OIJsql8GtpOBpQvoLrYNu3wK3W1aVU3YbeEz8 xbKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748305080; x=1748909880; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Uac/dfs9YbNpzmNA0jaR8Q4zQY2+KOiduhSNZuX3B+Q=; b=BrAZfVUW5peFxBJbOYwfbZ/aCv46xaGGBKocTbIFxNOLmYhYK2aOYpdTv2EJQapBe/ RT7RQXOuOmFRJYzDgk7D35bthFKDsopWALJwrNZgBPb77GhqHqVYdsQIWXEXhJ5CwlQj xZNU5an9c1LCjpGE0Be2ApsJQeDaNg/C53s2Wxo3AERIPIiA/U6sEzW02HLwADESBmxX f0TpMVh1OTJNlTCwcCSbvtwPUU8JF3Tr/IUefCwjfKmruLQRXT9aPed7K8ZlSF5WXYt4 uXgjihJQs+uu8wGQQj93dIKv1Qffu4NXos3ey62qI19PrFwshiaOV7uns+a0HQT8vQlR FAuQ== X-Gm-Message-State: AOJu0YxMtC1LOQcY0zfFxDVmDcRVVT2k8b8bYcz/niJPbJ22sU+huPf9 Y5C4fUcA/778eXrJ0ZN+ga/OghcGcflYudoFHVfEiTKhuq7gDsG9H9Pmg+uRI8goLc0= X-Gm-Gg: ASbGncsC00lfjntl+KsavhcO0JFOP/+nkShbT/nqA+BhwROzv+etI3Ghh0QSSfV5MdA o1X/kSJ3+6zcNES0SfWl1dwys5nXeie38IT7fTUq1XKsKegW5vg2FAYZ++9kn0DCcUmuR6SYbkR 2b7RWhWUmg1sbUgINTC+rkOoRgJujBzJwJF7jJk2IiWdxTChRmcb22AfDV6WVvhADX4PYInGHC7 f+RIAeuD2J0s2c96WLtxo/OELJHkdxzoLl4/x2Ju5WK6kf39T1ZGKE18RlK/djLHKTZmI1d2LTO 9XaeYWXiletyoJuWrL1nS0QaJ7/Kk+mz6unWlAVEB8TyhY2eAA== X-Google-Smtp-Source: AGHT+IHiK0O/3mIX8H9yJnDHvNkNgKydHQZY21mhkvRz1DbHFL3cIx0mJyfvlanrKBi/IY1bbSWO7w== X-Received: by 2002:a05:6a00:391e:b0:742:ae7e:7da1 with SMTP id d2e1a72fcca58-745fdb50dfamr16285503b3a.0.1748305080350; Mon, 26 May 2025 17:18:00 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7462185fc0esm887919b3a.38.2025.05.26.17.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 17:17:59 -0700 (PDT) From: Maxim Cournoyer To: =?utf-8?B?RG/En2FuIMOHZcOnZW4=?= Subject: Re: [bug#73930] [PATCH] gnu: git-repo: Update to 2.29.7 In-Reply-To: (=?utf-8?B?IkRvxJ9hbgnDh2XDp2VuIidz?= message of "Wed, 23 Oct 2024 20:37:24 +0000") References: <8734kn0yum.fsf@gmail.com> Date: Tue, 27 May 2025 09:17:57 +0900 Message-ID: <87jz62gb4a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73930-done Cc: 73930-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Do=C4=9Fan =C3=87e=C3=A7en writes: > Hi Maxim, > > Thanks for looking into this. > >> This looks too simple to be true, given the complex patching going on in >> phases (in retrospect this should have been done via a real patch to >> avoid silent breakage like is probably happening here). > > Sorry, I am not following. What do you mean by the complex patching > going on in phases and the silent breakage? I meant the do-not-self-update phase, which I had painstakingly devised to avoid the tool from self-updating its version at runtime ;-). >> The idea of the patch was to ensure 'git-repo' wouldn't update itself >> when run, as that defeats the immutable principle of Guix packages. > >>>From what I can tell, it doesn't do that. Or, at least, it reports > repeatedly the same version when I run `repo --version`, and it says > the version I upgraded to, 2.29.7. And, I was able to use the tool > successfully after the upgrade. Great. So either the do-not-self-update substitutions still worked, or the tool didn't have a newer version to update to. To make sure, we could run tcpdump or strace to see if it's calling home. But that won't be necessary; apparently there's a new REPO_SKIP_SELF_UPDATE environment variable we set to ensure that, and someone submitted an update to 2.54 utilising it. See commit 6c1cc9e360. Closing. --=20 Thanks, Maxim