GNU bug report logs - #73893
[PATCH] gnu: faust-2: Update to 2.75.7.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73893 in the body.
You can then email your comments to 73893 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH] gnu: faust-2: Update to 2.75.7.
Date: Sun, 20 Oct 2024 00:57:57 +0200

* gnu/packages/audio.scm (faust-2): Update to 2.75.7, update comments
and switch to gexps.
[arguments]<#:configure-flags>: Use it here...
<#:phases>: ...and here in phase 'configure.
[native-inputs]: Remove emacs-minimal and xxd. Update llvm to
llvm-18. Improve style.
---
 gnu/packages/audio.scm | 51 +++++++++++++++++++++---------------------
 1 file changed, 26 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 4fde88d454..0bff16e73b 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2268,7 +2268,7 @@ (define-public faust-0.9.67
 (define-public faust-2
   (package
     (inherit faust)
-    (version "2.41.1")
+    (version "2.75.7")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/grame-cncm/faust/"
@@ -2276,33 +2276,34 @@ (define-public faust-2
                                   "/faust-" version ".tar.gz"))
               (sha256
                (base32
-                "0gk8ifxrbykq7ay0nvjns8fjryhp0wfhv5npgrl8xpgw9wfmw53j"))))
+                "11ww02zmj3vnva1w52hs9wkxvhwwf53agklyzm2c7gysw0jfvkw9"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f ; no tests
-       #:phases
-       (modify-phases %standard-phases
-         ;; The upstream package uses make to run cmake during the build stage.
-         ;; Here we ignore the Makefile and call cmake directly.
-         (replace 'configure
-           (lambda _
-             (chdir "build")
-             (invoke "cmake" "-C" "backends/all.cmake"
-                     (string-append "-DCMAKE_INSTALL_PREFIX="
-                      (assoc-ref %outputs "out")))))
-         ;; The sound2faust tool would be built in the Makefile's "world" target
-         (add-after 'install 'sound2faust
-           (lambda _
-             (chdir "../tools/sound2faust")
-             (setenv "PREFIX" (assoc-ref %outputs "out"))
-             (invoke "make")
-             (invoke "make" "install"))))))
+     (list
+      ;; There are tests, but they are unit/regression tests scattered in 17
+      ;; different test directories, and little information indicating whether
+      ;; they are worth running for Guix.  Ignore tests for now.
+      #:tests? #f
+      #:configure-flags
+      #~(list "-C" "backends/all.cmake"
+              (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))
+      #:phases
+      #~(modify-phases %standard-phases
+          ;; The upstream package uses make to run cmake during the build stage.
+          ;; Here we ignore the Makefile and call cmake directly.
+          (replace 'configure
+            (lambda* (#:key configure-flags #:allow-other-keys)
+              (chdir "build")
+              (apply invoke "cmake" configure-flags)))
+          ;; The sound2faust tool would be built in the Makefile's "world" target
+          (add-after 'install 'sound2faust
+            (lambda _
+              (chdir "../tools/sound2faust")
+              (setenv "PREFIX" #$output)
+              (invoke "make")
+              (invoke "make" "install"))))))
     (native-inputs
-     `(("llvm" ,llvm)
-       ("which" ,which)
-       ("xxd" ,xxd)
-       ("ctags" ,emacs-minimal)  ; for ctags
-       ("pkg-config" ,pkg-config)))
+     (list llvm-18 pkg-config which))
     (inputs
      (list libsndfile libmicrohttpd ncurses openssl zlib))))
 
-- 
2.46.0

Message #10 received at 73893-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 73893-done <at> debbugs.gnu.org
Subject: Re: [bug#73893] [PATCH] gnu: faust-2: Update to 2.75.7.
Date: Wed, 23 Oct 2024 13:15:47 +0200

Nicolas Graves <ngraves <at> ngraves.fr> skribis:

> * gnu/packages/audio.scm (faust-2): Update to 2.75.7, update comments
> and switch to gexps.
> [arguments]<#:configure-flags>: Use it here...
> <#:phases>: ...and here in phase 'configure.
> [native-inputs]: Remove emacs-minimal and xxd. Update llvm to
> llvm-18. Improve style.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.