GNU bug report logs - #73891
[PATCH] Add ability to crossfade between songs in 'mpc'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73891 in the body.
You can then email your comments to 73891 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add ability to crossfade between songs in 'mpc'
Date: Sat, 19 Oct 2024 16:24:36 -0500

Tags: patch

Another small addition for mpc so that you can toggle the
crossfader.

p.s. I noticed the use of (cdr (assq 'etc ...)) throughout and
guessed that was because mpc predates alist-get but if there is a
preference I can change it to match the other mpc-toggle-*
functions.

Message #8 received at 73891 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 73891 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#73891: [PATCH] Add ability to crossfade between songs in 'mpc'
Date: Sat, 19 Oct 2024 16:27:51 -0500

[Message part 1 (text/plain, inline)]

And the patch...

[0001-Add-ability-to-crossfade-between-songs-in-mpc.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

john muhl <jm <at> pub.pink> writes:

> Tags: patch
>
> Another small addition for mpc so that you can toggle the
> crossfader.
>
> p.s. I noticed the use of (cdr (assq 'etc ...)) throughout and
> guessed that was because mpc predates alist-get but if there is a
> preference I can change it to match the other mpc-toggle-*
> functions.

Message #11 received at 73891 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 73891 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#73891: [PATCH] Add ability to crossfade between songs in 'mpc'
Date: Sat, 19 Oct 2024 16:40:27 -0500

[Message part 1 (text/plain, inline)]

Err. I guess it should have a NEWS entry too.

Sorry for the flood.

[0001-Add-ability-to-crossfade-between-songs-in-mpc.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

john muhl <jm <at> pub.pink> writes:

> And the patch...
>
> [2. text/x-patch; 0001-Add-ability-to-crossfade-between-songs-in-mpc.patch]...
>
>
>
> john muhl <jm <at> pub.pink> writes:
>
>> Tags: patch
>>
>> Another small addition for mpc so that you can toggle the
>> crossfader.
>>
>> p.s. I noticed the use of (cdr (assq 'etc ...)) throughout and
>> guessed that was because mpc predates alist-get but if there is a
>> preference I can change it to match the other mpc-toggle-*
>> functions.

Message #14 received at 73891 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: john muhl <jm <at> pub.pink>
Cc: 73891 <at> debbugs.gnu.org
Subject: Re: bug#73891: [PATCH] Add ability to crossfade between songs in 'mpc'
Date: Sat, 19 Oct 2024 22:31:10 -0400

john muhl [2024-10-19 16:40:27] wrote:
> p.s. I noticed the use of (cdr (assq 'etc ...)) throughout and
> guessed that was because mpc predates alist-get

That's right.

> but if there is a preference I can change it to match the other
> mpc-toggle-* functions.

No, no, `alist-get` is fine, thanks.

> And the patch...

Pushed to `master`, thanks.


        Stefan

Message #19 received at 73891-done <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 73891-done <at> debbugs.gnu.org
Subject: Re: bug#73891: [PATCH] Add ability to crossfade between songs in 'mpc'
Date: Mon, 21 Oct 2024 13:21:49 -0500

Thanks.

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> writes:

> john muhl [2024-10-19 16:40:27] wrote:
>> p.s. I noticed the use of (cdr (assq 'etc ...)) throughout and
>> guessed that was because mpc predates alist-get
>
> That's right.
>
>> but if there is a preference I can change it to match the other
>> mpc-toggle-* functions.
>
> No, no, `alist-get` is fine, thanks.
>
>> And the patch...
>
> Pushed to `master`, thanks.
>
>
>         Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.