GNU bug report logs - #73887
[PATCH] gnu: stklos: Update to 2.10.

Previous Next

Package: guix-patches;

Reported by: Ashish SHUKLA <ashish.is <at> lostca.se>

Date: Sat, 19 Oct 2024 15:54:02 UTC

Severity: normal

Tags: patch

Done: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73887 in the body.
You can then email your comments to 73887 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#73887; Package guix-patches. (Sat, 19 Oct 2024 15:54:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ashish SHUKLA <ashish.is <at> lostca.se>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 19 Oct 2024 15:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ashish SHUKLA <ashish.is <at> lostca.se>
To: guix-patches <at> gnu.org
Cc: Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: [PATCH] gnu: stklos: Update to 2.10.
Date: Sat, 19 Oct 2024 17:48:46 +0200

* gnu/packages/scheme.scm (stklos): Update to 2.10.
  [inputs]: Add variable. [native-inputs]: Add variable.
  [arguments] Add configure-flags.

Change-Id: Ife374dd60ef17129fa88b7a0940ab914e7b3c396
---
Hi,

Attached patch updates STklos to 2.10. For readline/libedit support, it
relies on rtld, this is accomplished by linking it with readline, so it
gets added to the rpath, and therefore available at runtime.

Thanks!

 gnu/packages/scheme.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 6f9d00e440..c97fab8b93 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -86,6 +86,7 @@ (define-module (gnu packages scheme)
   #:use-module (gnu packages netpbm)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages readline)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages tex)
   #:use-module (gnu packages texinfo)
@@ -1275,7 +1276,7 @@ (define-public emacs-gerbil-mode
 (define-public stklos
   (package
     (name "stklos")
-    (version "1.70")
+    (version "2.10")
     (source (origin
               (method url-fetch)
               ;; TODO: Unbundle pcre, libgc, and libffi.
@@ -1283,12 +1284,18 @@ (define-public stklos
                                   version ".tar.gz"))
               (sha256
                (base32
-                "1iw3pgycjz3kz3jd1855v2ngf8ib2almpf8v058n1mkj1qd2b88m"))))
+                "0hd05r5pr3yhgq44n5sqdmvkpgnhf5fybmis2g3gwj10z52h7gvd"))))
     (build-system gnu-build-system)
+    (native-inputs (list pkg-config))
+    (inputs (list gmp libgc pcre2 libffi readline))
     (arguments
      (list
       #:modules `((ice-9 ftw)
                   ,@%default-gnu-modules)
+      #:configure-flags
+      '(list (string-append "LDFLAGS=-L"
+               (assoc-ref %build-inputs "readline")
+               "/lib -lreadline"))
       #:phases
       #~(modify-phases %standard-phases
           (add-before 'configure 'patch-sh-references

base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
-- 
2.47.0
Information forwarded to guix-patches <at> gnu.org:
bug#73887; Package guix-patches. (Sat, 19 Oct 2024 16:29:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73887 <at> debbugs.gnu.org, Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: Re: [bug#73887] [PATCH] gnu: stklos: Update to 2.10.
Date: Sun, 20 Oct 2024 00:27:23 +0800

[Message part 1 (text/plain, inline)]
Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/scheme.scm (stklos): Update to 2.10.
>   [inputs]: Add variable. [native-inputs]: Add variable.
>   [arguments] Add configure-flags.

[inputs]: Add gmp, libgc, pcre2, libffi and readline.
[native-inputs]: Add pkg-config.
[arguments]<#:configure-flags>: set LDFLAGS flag.

>
> Change-Id: Ife374dd60ef17129fa88b7a0940ab914e7b3c396
> ---
> Hi,
>
> Attached patch updates STklos to 2.10. For readline/libedit support, it
> relies on rtld, this is accomplished by linking it with readline, so it
> gets added to the rpath, and therefore available at runtime.
>
> Thanks!
>
>  gnu/packages/scheme.scm | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
> index 6f9d00e440..c97fab8b93 100644
> --- a/gnu/packages/scheme.scm
> +++ b/gnu/packages/scheme.scm
> @@ -86,6 +86,7 @@ (define-module (gnu packages scheme)
>    #:use-module (gnu packages netpbm)
>    #:use-module (gnu packages pcre)
>    #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages readline)
>    #:use-module (gnu packages sqlite)
>    #:use-module (gnu packages tex)
>    #:use-module (gnu packages texinfo)
> @@ -1275,7 +1276,7 @@ (define-public emacs-gerbil-mode
>  (define-public stklos
>    (package
>      (name "stklos")
> -    (version "1.70")
> +    (version "2.10")
>      (source (origin
>                (method url-fetch)
>                ;; TODO: Unbundle pcre, libgc, and libffi.
> @@ -1283,12 +1284,18 @@ (define-public stklos
>                                    version ".tar.gz"))
>                (sha256
>                 (base32
> -                "1iw3pgycjz3kz3jd1855v2ngf8ib2almpf8v058n1mkj1qd2b88m"))))
> +                "0hd05r5pr3yhgq44n5sqdmvkpgnhf5fybmis2g3gwj10z52h7gvd"))))
>      (build-system gnu-build-system)
> +    (native-inputs (list pkg-config))
> +    (inputs (list gmp libgc pcre2 libffi readline))
>      (arguments
>       (list
>        #:modules `((ice-9 ftw)
>                    ,@%default-gnu-modules)
> +      #:configure-flags
> +      '(list (string-append "LDFLAGS=-L"
> +               (assoc-ref %build-inputs "readline")
> +               "/lib -lreadline"))

i think should

#:configure-flags
  #~(list (string-append "LDFLAGS=-L" #$(this-package-input "readline")
          "/lib -lreadline"))

>        #:phases
>        #~(modify-phases %standard-phases
>            (add-before 'configure 'patch-sh-references
>
> base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#73887; Package guix-patches. (Sat, 19 Oct 2024 16:29:03 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#73887; Package guix-patches. (Sat, 19 Oct 2024 19:05:01 GMT) Full text and rfc822 format available.

Message #14 received at 73887 <at> debbugs.gnu.org (full text, mbox):

From: Ashish SHUKLA <ashish.is <at> lostca.se>
To: 73887 <at> debbugs.gnu.org
Cc: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>, Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: [PATCH v2] gnu: stklos: Update to 2.10.
Date: Sat, 19 Oct 2024 21:02:52 +0200

* gnu/packages/scheme.scm (stklos): Update to 2.10.
[inputs]: Add gmp, libgc, pcre2, libffi, and readline.
[native-inputs]: Add pkg-config.
[arguments]<#:configure-flags>: set LDFLAGS flag.

Change-Id: Ife374dd60ef17129fa88b7a0940ab914e7b3c396
Co-authored-by: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
---
Hi,

Thanks for reviewing the diff. Update diff according to suggestions, and
added credit for the same.

Thanks!

 gnu/packages/scheme.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 6f9d00e440..0d6a662aaa 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -86,6 +86,7 @@ (define-module (gnu packages scheme)
   #:use-module (gnu packages netpbm)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages readline)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages tex)
   #:use-module (gnu packages texinfo)
@@ -1275,7 +1276,7 @@ (define-public emacs-gerbil-mode
 (define-public stklos
   (package
     (name "stklos")
-    (version "1.70")
+    (version "2.10")
     (source (origin
               (method url-fetch)
               ;; TODO: Unbundle pcre, libgc, and libffi.
@@ -1283,12 +1284,18 @@ (define-public stklos
                                   version ".tar.gz"))
               (sha256
                (base32
-                "1iw3pgycjz3kz3jd1855v2ngf8ib2almpf8v058n1mkj1qd2b88m"))))
+                "0hd05r5pr3yhgq44n5sqdmvkpgnhf5fybmis2g3gwj10z52h7gvd"))))
     (build-system gnu-build-system)
+    (native-inputs (list pkg-config))
+    (inputs (list gmp libgc pcre2 libffi readline))
     (arguments
      (list
       #:modules `((ice-9 ftw)
                   ,@%default-gnu-modules)
+      #:configure-flags
+      #~(list (string-append "LDFLAGS=-L"
+                #$(this-package-input "readline")
+                "/lib -lreadline"))
       #:phases
       #~(modify-phases %standard-phases
           (add-before 'configure 'patch-sh-references

base-commit: e951a375a01262dfd470ee343baf7c41dbc6ff58
-- 
2.47.0
Information forwarded to guix-patches <at> gnu.org:
bug#73887; Package guix-patches. (Sun, 20 Oct 2024 14:34:02 GMT) Full text and rfc822 format available.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73887-done <at> debbugs.gnu.org, Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: Re: [bug#73887] [PATCH v2] gnu: stklos: Update to 2.10.
Date: Sun, 20 Oct 2024 22:33:06 +0800

[Message part 1 (text/plain, inline)]
Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/scheme.scm (stklos): Update to 2.10.
> [inputs]: Add gmp, libgc, pcre2, libffi, and readline.
> [native-inputs]: Add pkg-config.
> [arguments]<#:configure-flags>: set LDFLAGS flag.
>
> Change-Id: Ife374dd60ef17129fa88b7a0940ab914e7b3c396
> Co-authored-by: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
> ---
> Hi,
>
> Thanks for reviewing the diff. Update diff according to suggestions, and
> added credit for the same.
>
> Thanks!
>
>  gnu/packages/scheme.scm | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
> index 6f9d00e440..0d6a662aaa 100644
> --- a/gnu/packages/scheme.scm
> +++ b/gnu/packages/scheme.scm
> @@ -86,6 +86,7 @@ (define-module (gnu packages scheme)
>    #:use-module (gnu packages netpbm)
>    #:use-module (gnu packages pcre)
>    #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages readline)
>    #:use-module (gnu packages sqlite)
>    #:use-module (gnu packages tex)
>    #:use-module (gnu packages texinfo)
> @@ -1275,7 +1276,7 @@ (define-public emacs-gerbil-mode
>  (define-public stklos
>    (package
>      (name "stklos")
> -    (version "1.70")
> +    (version "2.10")
>      (source (origin
>                (method url-fetch)
>                ;; TODO: Unbundle pcre, libgc, and libffi.
> @@ -1283,12 +1284,18 @@ (define-public stklos
>                                    version ".tar.gz"))
>                (sha256
>                 (base32
> -                "1iw3pgycjz3kz3jd1855v2ngf8ib2almpf8v058n1mkj1qd2b88m"))))
> +                "0hd05r5pr3yhgq44n5sqdmvkpgnhf5fybmis2g3gwj10z52h7gvd"))))
>      (build-system gnu-build-system)
> +    (native-inputs (list pkg-config))
> +    (inputs (list gmp libgc pcre2 libffi readline))
>      (arguments
>       (list
>        #:modules `((ice-9 ftw)
>                    ,@%default-gnu-modules)
> +      #:configure-flags
> +      #~(list (string-append "LDFLAGS=-L"
> +                #$(this-package-input "readline")
> +                "/lib -lreadline"))
>        #:phases
>        #~(modify-phases %standard-phases
>            (add-before 'configure 'patch-sh-references
>
> base-commit: e951a375a01262dfd470ee343baf7c41dbc6ff58

push, close.

[signature.asc (application/pgp-signature, inline)]
Reply sent to Zheng Junjie <zhengjunjie <at> iscas.ac.cn>:
You have taken responsibility. (Sun, 20 Oct 2024 14:34:04 GMT) Full text and rfc822 format available.
Notification sent to Ashish SHUKLA <ashish.is <at> lostca.se>:
bug acknowledged by developer. (Sun, 20 Oct 2024 14:34:04 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 18 Nov 2024 12:24:14 GMT) Full text and rfc822 format available.
This bug report was last modified 213 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.