From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 18 15:05:59 2024 Received: (at submit) by debbugs.gnu.org; 18 Oct 2024 19:05:59 +0000 Received: from localhost ([127.0.0.1]:40102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1sIQ-0007If-Mg for submit@debbugs.gnu.org; Fri, 18 Oct 2024 15:05:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:54666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1sIM-0007IO-K3 for submit@debbugs.gnu.org; Fri, 18 Oct 2024 15:05:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1sHz-0007Or-0M for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 15:05:31 -0400 Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1sHx-0007CP-6B for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 15:05:30 -0400 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.phl.internal (Postfix) with ESMTP id B486813802C9 for ; Fri, 18 Oct 2024 15:05:25 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Fri, 18 Oct 2024 15:05:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1729278325; x=1729364725; bh=FyWJOBwlWkrDGntG87VhIm5CMrSifYn1 fitlaZiixeQ=; b=FM4OHeDQ4fPEPW8mQgWnaDZWU8F5O74qv5Iab+sgidudH9tE qnBNga793sbkFhwlnsgKgv9VsIBw8gA23FXdz4DOaTgVFTTdKL13AlwRh+4+c3OK WzxrOJCqVWMWU8ogIwP/t/c+y3Ex66mUWevMXR9CcIPRmcubztU5Kp5q0ihdDT1A LesM7l86gy/PaOw8ffisii2Unj7fP6Nl8YOdTSCPkNCF0Q+pWwe1RjdrfcefAYa5 EMDyd7PUzoiGqKy+9yvDmu44i8OKnKzF1OHy58n2PsZ/dwyj6tsOfZGmzZd9ZfRl O/A7tfKF4O9JlP2cRiTR4/iK00FZRH6CIousCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1729278325; x=1729364725; bh=FyWJOBwlWkrDGntG87VhIm5CMrSifYn1fit laZiixeQ=; b=S9bKscT/xSXHoq6ehOo9ndmZj5xQPZkUOvk0BRhCc8iV7pDGjf8 498XYFUmd+Axt8JvpT+V2/OqICufXl5LZqHIIH8T976WeywGRPJZ9rLqEKGo20E4 PDAIUTm+vzVBJE2KmFS4Yff2l+wGbbwQ8S2f3NdJxn4DLD2UWPdpNMnoa0SsHOHD 0yjalExHxwsbfELDnsWSnGbG6ev41Yju6yPUYUNJSed7zIe/F+qfzMaaq7Csw6sO QX/mIo36hlUjHGG8CXVwLM4UPG3LNUMdj0eMUchtoOeKp4VMo+lL+LqIZTxuJG8X DNwoXaOTf4ddbiiomBeoiO6QafTwmi6esmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehfedgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvuf ffkfggtgesmhdtreertddttdenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhu sgdrphhinhhkqeenucggtffrrghtthgvrhhnpeefhfdvfedutdelvddvvdejhfefvdefle eggfeiueeiiedtvddvgfeiuedugeeljeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhope dupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghs sehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 18 Oct 2024 15:05:25 -0400 (EDT) From: john muhl To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix naming of buffers for tags ending in Y in 'mpc' X-Debbugs-Cc: Stefan Monnier Date: Fri, 18 Oct 2024 14:05:24 -0500 Message-ID: <87a5f1p6yz.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=103.168.172.146; envelope-from=jm@pub.pink; helo=fout-a3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Tags: patch While trying to track down bug#41493 I noticed that the buffer for the Directory tag was named *MPC Directorys*. This changes buffer creation to use mpc-tagbrowser-tag-name instead of just adding an S to the end. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-naming-of-buffers-for-tags-ending-in-Y-in-mpc.patch >From e5a1ed0cf2bb8f4826918436bab9babab9d79d41 Mon Sep 17 00:00:00 2001 From: john muhl Date: Tue, 8 Oct 2024 12:24:27 -0500 Subject: [PATCH] Fix naming of buffers for tags ending in Y in 'mpc' * lisp/mpc.el (mpc-tagbrowser-buf): Use 'mpc-tagbrowser-tag-name' to ensure buffers corresponding to tags that end in Y are correctly pluralized; e.g. the tag "Directory" should create a buffer named "*MPC Directories*" not "*MPC Directorys". --- lisp/mpc.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/mpc.el b/lisp/mpc.el index 9c0bbaaa0f2..ae6a40f9983 100644 --- a/lisp/mpc.el +++ b/lisp/mpc.el @@ -1572,9 +1572,10 @@ mpc-tagbrowser-tag-name (t (concat (symbol-name tag) "s")))) (defun mpc-tagbrowser-buf (tag) - (let ((buf (mpc-proc-buffer (mpc-proc) tag))) + (let ((buf (mpc-proc-buffer (mpc-proc) tag)) + (tag-name (mpc-tagbrowser-tag-name tag))) (if (buffer-live-p buf) buf - (setq buf (get-buffer-create (format "*MPC %ss*" tag))) + (setq buf (get-buffer-create (format "*MPC %s*" tag-name))) (mpc-proc-buffer (mpc-proc) tag buf) (with-current-buffer buf (let ((inhibit-read-only t)) @@ -1585,7 +1586,7 @@ mpc-tagbrowser-buf (insert mpc-tagbrowser-all-name "\n")) (forward-line -1) (setq mpc-tag tag) - (setq mpc-tag-name (mpc-tagbrowser-tag-name tag)) + (setq mpc-tag-name tag-name) (mpc-tagbrowser-all-select) (mpc-tagbrowser-refresh) buf)))) -- 2.46.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 18 17:12:45 2024 Received: (at 73868) by debbugs.gnu.org; 18 Oct 2024 21:12:45 +0000 Received: from localhost ([127.0.0.1]:40277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1uH7-0004hD-HJ for submit@debbugs.gnu.org; Fri, 18 Oct 2024 17:12:45 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1uH4-0004gw-Of for 73868@debbugs.gnu.org; Fri, 18 Oct 2024 17:12:43 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 28E36809CE; Fri, 18 Oct 2024 17:12:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1729285933; bh=9RW+qYu3ZDpVw/ZsylCnvKbD11iDBTYJkVcYgU0f8vk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=a6kjMsxGgqaYMueQybAJ/WNhAEmsb1tYjBQJTXIYZanWhZef69Ko601DpzSrrNUvY vrw3WEruUW4KgW2UPH9jFaDapoxNhsQdTlOW3eunBRDfiBsl1pcbnfiVvdRj416g/H oGLE7bLzY8sBUi3F/T4bRc+22qgFP4iR6eRMDios8cJjaycJY5lUMtvFl1KNdl4g+Q CJEZ6xSjTIX/ANYHXr8q25FrZ7+mIwAiU6zUqvgCzzYLSe9k+4yloSTZXI+wbF7wJO 2mATgqtyeWoN63A2FylWTXX/NsJXUF5Fwn/ZaJ7iobsv2I6TdMh8PCZibOZWnW48KL 46/T/l390SkXw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5F83B8076B; Fri, 18 Oct 2024 17:12:13 -0400 (EDT) Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 44AC912014A; Fri, 18 Oct 2024 17:12:13 -0400 (EDT) From: Stefan Monnier To: john muhl Subject: Re: bug#73868: [PATCH] Fix naming of buffers for tags ending in Y in 'mpc' In-Reply-To: <87a5f1p6yz.fsf@pub.pink> (john muhl's message of "Fri, 18 Oct 2024 14:05:24 -0500") Message-ID: References: <87a5f1p6yz.fsf@pub.pink> Date: Fri, 18 Oct 2024 17:12:12 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73868 Cc: 73868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > While trying to track down bug#41493 I noticed that the buffer for > the Directory tag was named *MPC Directorys*. This changes buffer > creation to use mpc-tagbrowser-tag-name instead of just adding an > S to the end. Thanks! Pushed to `master`! Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 12:24:58 2024 Received: (at 73868-done) by debbugs.gnu.org; 19 Oct 2024 16:24:58 +0000 Received: from localhost ([127.0.0.1]:44580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2CGA-0008Jr-5x for submit@debbugs.gnu.org; Sat, 19 Oct 2024 12:24:58 -0400 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]:55983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2CG1-0008JL-VD for 73868-done@debbugs.gnu.org; Sat, 19 Oct 2024 12:24:55 -0400 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 5902113801B1; Sat, 19 Oct 2024 12:24:20 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sat, 19 Oct 2024 12:24:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1729355060; x=1729441460; bh=5K9sGJEd7S 5kTiIhLQ1z6s5fsn3zNXCuoetcM3d4Onw=; b=T2wo0gPtC2p2F3TaIaDX7Z2C6E jI9ZmsM49jgcTKgrkqnIJyrBx1yn6cMQn211Y3VcR8ADWBWSL38dZWclpshfAmay JW+S7Sh1hHeSyT3Q50SL/04UqcGm7wKT3oaHIZ59mUyjlyOIeS8hENDKi26TaQp7 3c+a/jE6vm+uiCoGmCzRpt2wnxMaqkzXd+QJtKNBUArWmI08Z0MbRciaiAC2pXcg qoBm65Lr7Ui/YDLEG5y0TPfhVyrintvtm04F+VViS7grKbYHwmDrwLNOsdfU0bez RilIu2H1YYwef0fWJEnG1j0bHXRy8IcaPH7IpsWYnkDgMadYf1x50yqPp1Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1729355060; x=1729441460; bh=5K9sGJEd7S5kTiIhLQ1z6s5fsn3z NXCuoetcM3d4Onw=; b=RtASgZIM9ziCAKec5neG2PYnrRqfAqO55iEN4i+aVFXl 7a4DtHAInJ2/e6c7aPscyNfJ15boI0cT3gqWT8bW9CR+K/qstELIv4u05leclMhd u+EXh1OsFHC+V4eyW0ydmrdGUy3Q1VgUdct9QDfx5kUzfP6CUlHMnU8/X4lKZ90X kvQcoRC0xLqI5huobukzfMKSVSaKWZuHb88OGWFWceYAT38JXtg9y+4R+g+a/hld OSTG/AKsLBnrPbgYJsHdVFtXkNiQEE9qId8EvBodsDv3u/uu48A2wEnFdibhmr0E hXcZiUPxdrx3J6kA6oJbC2F8lG94JbQ6b7CpRyXy0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehhedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpehjohhhnhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggftrf grthhtvghrnhephfdtveeggfetteekkeffkeevtdeuheetffelvefhvddvveehjeelfeff leffhffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epjhhmsehpuhgsrdhpihhnkhdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphho uhhtpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpd hrtghpthhtohepjeefkeeikedqughonhgvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Oct 2024 12:24:19 -0400 (EDT) From: john muhl To: 73868-done@debbugs.gnu.org Subject: Re: bug#73868: [PATCH] Fix naming of buffers for tags ending in Y in 'mpc' In-Reply-To: (Stefan Monnier via's message of "Fri, 18 Oct 2024 17:12:12 -0400") References: <87a5f1p6yz.fsf@pub.pink> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Sat, 19 Oct 2024 11:24:18 -0500 Message-ID: <875xpo6oy5.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73868-done Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> While trying to track down bug#41493 I noticed that the buffer for >> the Directory tag was named *MPC Directorys*. This changes buffer >> creation to use mpc-tagbrowser-tag-name instead of just adding an >> S to the end. > > Thanks! Pushed to `master`! > > > Stefan Thanks. Closing this one now. From unknown Thu Aug 14 21:50:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 17 Nov 2024 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator