GNU bug report logs - #73862
[PATCH] Add `header-line-active` and `header-line-inactive` faces.

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Aaron Jensen <aaronjensen <at> gmail.com>
Cc: trevor.m.murphy <at> gmail.com, yantar92 <at> posteo.net, me <at> eshelyaron.com, monnier <at> iro.umontreal.ca, 73862 <at> debbugs.gnu.org
Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces.
Date: Tue, 24 Dec 2024 14:44:40 +0200

> From: Aaron Jensen <aaronjensen <at> gmail.com>
> Date: Mon, 23 Dec 2024 21:17:16 -0800
> Cc: me <at> eshelyaron.com, trevor.m.murphy <at> gmail.com, monnier <at> iro.umontreal.ca, 
> 	73862 <at> debbugs.gnu.org, yantar92 <at> posteo.net
> 
>  Are there any tradeoffs with this approach other than additional code complexity? Any
>  performance concerns? 
> 
>  I didn't time the code. It is a bit more expensive, but I don't know by how much. Maybe you could see
>  what happens in a session with lots and lots of faces and report?
> 
> Does the change impact anything more than the infrequent basic face calculation (whatever the thing was
> we were triggering by changing the default face size) or is it in the standard render path?

It affects realization of basic faces and also their lookup (by face
ID, which is what the display engine uses).  But these two operations
are not so rare.  In particular, any change of attributes of a "named
face" (a face identified by its symbol) will usually cause us free and
re-realize all of the frame's faces, including the basic ones.  Given
what current Lisp programs like to do, this happens surprisingly
frequently.  And face look up happens every time a window is
redisplayed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.