GNU bug report logs - #73862
[PATCH] Add `header-line-active` and `header-line-inactive` faces.

Previous Next

Full log

Message #150 received at 73862 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: trevor.m.murphy <at> gmail.com, yantar92 <at> posteo.net, me <at> eshelyaron.com,
 monnier <at> iro.umontreal.ca, 73862 <at> debbugs.gnu.org
Subject: Re: bug#73862: [PATCH] Add `header-line-active` and
 `header-line-inactive` faces.
Date: Mon, 23 Dec 2024 21:17:16 -0800

[Message part 1 (text/plain, inline)]

On Mon, Dec 23, 2024 at 7:30 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> From: Aaron Jensen <aaronjensen <at> gmail.com>
> Date: Mon, 23 Dec 2024 13:19:32 -0800
> Cc: Eli Zaretskii <eliz <at> gnu.org>, trevor.m.murphy <at> gmail.com, monnier <at> iro.
> umontreal.ca, 73862 <at> debbugs.gnu.org, yantar92 <at> posteo.net
>
> On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron <me <at> eshelyaron.com> wrote:
>
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> Please try the patch below. If it gives good results, please run with it
> for awhile, and tell if you see anything unusual or unexpected.
>
> Thanks, so far so good.
>
> Same for me, it's also working so far.
>
> Are there any tradeoffs with this approach other than additional code
> complexity? Any performance concerns?
>
> I didn't time the code. It is a bit more expensive, but I don't know by
> how much. Maybe you could see what happens in a session with lots and lots
> of faces and report?
>

Does the change impact anything more than the infrequent basic face
calculation (whatever the thing was we were triggering by changing the
default face size) or is it in the standard render path?

Aaron

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.