GNU bug report logs - #73862
[PATCH] Add `header-line-active` and `header-line-inactive` faces.

Previous Next

Full log

View this message in rfc822 format

From: Trevor Murphy <trevor.m.murphy <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73862 <at> debbugs.gnu.org
Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces.
Date: Sun, 10 Nov 2024 22:11:30 -0800

[Message part 1 (text/plain, inline)]

Hi!  Thanks for your patience, attached please find the updated patch.
I've added documentation and a NEWS entry modeled off of similar commits.

When I put together the original patch I included a non-trivial value for
the default header-line-inactive (copied from mode-line-inactive) as a
visual indicator for the new face.  Happy to take it out.  In this updated
patch, header-line-inactive just inherits from header-line.  I tested by
looking at selected and not-selected Info buffers with emacs -Q both
patched and unpatched, in both graphical and terminal.

On Sat, Nov 9, 2024 at 1:37 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 73862 <at> debbugs.gnu.org
> > Date: Sun, 27 Oct 2024 12:46:53 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > > From: trevor.m.murphy <at> gmail.com
> > > Date: Fri, 18 Oct 2024 05:56:32 -0700
> > >
> > > Over the years I've put more and more information into the header
> line, and at some point I wanted to get that quick visual indicator of
> selected vs non-selected windows when I glanced at the header as I already
> got from the mode line.
> > >
> > > This was surprisingly hard to achieve!  For a few years I used an ugly
> `buffer-list-update-hook` hack.  Then a few months ago I got adventurous
> and found that it actually wasn't as hard as I'd feared to hack these into
> the C source.
> > >
> > > The new faces both inherit from the current `header-line` face, so
> there shouldn't be any visible impact if users don't customize the new
> faces.  For cases like mine it's easy to customize header-line-inactive to
> inherit from mode-line-inactive.
> > >
> > > Thanks in advance for your attention and feedback,
> >
> > Thanks.  This changeset needs the appropriate changes in the Emacs
> > user manual (which lists the standard faces in "Standard Faces"), and
> > also a NEWS entry that announces the change.
> >
> > Also, did you verify that modes which use header-line and customize
> > the header-line face still work as before after this change, both when
> > the window is selected and non-selected?
>
> Ping! Trevor, could you please answer the above question, and provide
> an updated patch with documentation changes?  I'd like to install this
> as soon as these issues are resolved.
>


-- 
Trevor Murphy

[Message part 2 (text/html, inline)]

[0001-Add-new-header-line-active-and-header-line-inactive-.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.