From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 18 05:24:08 2024 Received: (at submit) by debbugs.gnu.org; 18 Oct 2024 09:24:08 +0000 Received: from localhost ([127.0.0.1]:37073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1jDM-0004yX-C4 for submit@debbugs.gnu.org; Fri, 18 Oct 2024 05:24:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:35370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1jDK-0004yM-FF for submit@debbugs.gnu.org; Fri, 18 Oct 2024 05:24:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1jCy-000664-0G for bug-guix@gnu.org; Fri, 18 Oct 2024 05:23:44 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1jCu-0007fG-Ms for bug-guix@gnu.org; Fri, 18 Oct 2024 05:23:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C7407240027 for ; Fri, 18 Oct 2024 11:23:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1729243415; bh=gdxXelrrSzWzIwFf6G3vRVWP4MxIL4e10znLOvWFSJ4=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding:From; b=TbQIW4Mux7Hq6N10XaD+kHXAJB77CYvEC0qvBqkmhVncztbedwUEVLTTRpq90kb3e h4aKJAKUXGSBc0WxkwIkdbh3F9cgoFAfwZ7GyuKbJPupPygXA24sTSLMLxYRbfXuPz zi2kIou6ZIeccrcve6ZPEOzrm+pNZyykIKqL9W+XLGlk/0ZyLVapg9fgKBsvC0Engt 4/iBLIyTBuFVF5RxvnGU0TXzTOaWfSZt52ltt57ovqAtO6AkvLDJRQHPkRufFjoscE yNdWKm+NtpQ9yC+QAfI2rV544w8/lwAhLCdlobz+zxpDqgTbh0sAJh1n4DU7mVcB8H jWiTXri37d4DA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XVK530Dfzz6tm8 for ; Fri, 18 Oct 2024 11:23:34 +0200 (CEST) Message-ID: <8fe9bf90-158c-4e03-a257-6ebf9da5ad54@posteo.net> Date: Fri, 18 Oct 2024 09:23:32 +0000 MIME-Version: 1.0 Content-Language: en-US To: bug-guix@gnu.org From: Dariqq Subject: lightdm-service-type is almost unusable Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Guix, This is to report some of the issues and workarounds when trying to setup lightdm-service-type. 1. Unable to choose a session (https://issues.guix.gnu.org/68055) This appearently never worked: https://issues.guix.gnu.org/57168#0 This means one currently has to specify the default session with something like (service lightdm-service-type (lightdm-configuration (seats (list (lightdm-seat-configuration (name "*") (user-session "xfce")))))) 2. gtkgreeter chooses the wrong default session This is related to 1. If one already had set the default user session (i.e. from using default configuration => default.xsession) or one wants to use a different session, lightdm gtkgreeter still requests the old one. After a lot of searching I found this https://github.com/Xubuntu/lightdm-gtk-greeter/issues/163 . I.e. lightdm asks the accountsservice for the default-session rather than lightm which still has cashed the old/wrong one. Thus with no option to select a different session one is unable to login. The workaorund here is to delete/modify /var/lib/AccountService/users to make sure accountsservice recreates/updates the configurration. 3. After the lightdms users .Xauthority file is created it has wrong permissions on subsequent boots. this can be "fixed" by manually setting less restrictive permissions on /var/lib/lightdm/.Xauthority This might be fixed by making the lightdm-activiation snippet actually useful: It currently searches for a file named "directory" to fix permissions rather than the content of the variable 'directory'. (find-files "directory" #:directories? #t) vs (find-files directory #:directories? #t) here https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/lightdm.scm#n527 4. tigervnnc default tigervnc is (file-append tigervnc-server "bin/Xvnc") rather than (file-append tigervnc-server "/bin/Xvnc") From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 23 10:50:43 2024 Received: (at 73859) by debbugs.gnu.org; 23 Oct 2024 14:50:43 +0000 Received: from localhost ([127.0.0.1]:60378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ch8-0007tC-Hi for submit@debbugs.gnu.org; Wed, 23 Oct 2024 10:50:43 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:58451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ch1-0007sl-Mn for 73859@debbugs.gnu.org; Wed, 23 Oct 2024 10:50:40 -0400 Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7e9e38dd5f1so5200009a12.0 for <73859@debbugs.gnu.org>; Wed, 23 Oct 2024 07:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729694944; x=1730299744; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lgK8beqzL35+a1ldsMOQTB14NGz+V2BtJ3oX75pNm2Y=; b=NxZvgWBUOYU8tdVtpL6Jo/09e/9kf6ELDCxdixoW+r9clQJ05GQxa7zRz9Jzos8Yhx 1plAy9oss2yMsj+Ya3D6udrLNcu7pm38hLPYmbWODVF4n0uKv84n+AG9hZ+3gGAIGduO AEu/OCf6NjS5ZSbaFHCtL+fBdgKF/OA7K8r3Rkx+Die/dnVARI+pxUhqVOSbLKjoEy84 eROTtGy0jfMAekmMX+3HCS1OJceiv4R6fJcyFWOxAP264xKIvReSMVmBbioX4nSB4CJr F4LzWHKqIteXgGV2tnHcBslC1uQBrA+G0eYOrLJVgry2twwDvNAxy8vXjM6BczT0gYx4 Lteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729694944; x=1730299744; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lgK8beqzL35+a1ldsMOQTB14NGz+V2BtJ3oX75pNm2Y=; b=S3elaHzJfkqPW2di2hj5+fyLSV+ivgSmEVy76AfR6AO0juvBzuBt3vViTgkGAKYfJq 5K4Za1LRgqm9Aiq/XpCb6QiaPccw7plal+hnc+EKFCsEj0XEXgmJNtrGN7V7xjOEJssW SVCnbbDAZxQhCS+IoiwE+coWXcudjULaQVk/Nr83lXawL69I7uXbKBV4m+J2+zc3FnQ1 nj9nPZxotzrSJ+QbxMRzlqbBJPmrwZW2ZTJZICGs733O9AeQlBh5PTCzTyZuCCP8AMZk urx3jmje0TVyqR0EwrHCrtti07RwGlXrikfZiP2LPQRO0E93qpuHBjF0pn4A7RrpNG/A zGgA== X-Gm-Message-State: AOJu0YywnCCubQ5WU4x0i3SPMlXgYteECl9n+niwJTJ8t9BfMdv2NK6V 2+gF6a9wFTxOZhPk58JvS13914DY4YarTbjG8Rz5uF7WogRrIsG03at8lQ== X-Google-Smtp-Source: AGHT+IE4qlbjmZyYXcNdZbnrfRldcVJhdA14Hs4kazdNOsgB4Cb60wu1TfP1a4HvctMgrWVq0OkRGg== X-Received: by 2002:a05:6a21:2d08:b0:1d9:2659:5da9 with SMTP id adf61e73a8af0-1d978b1a15amr3368793637.18.1729694944463; Wed, 23 Oct 2024 07:49:04 -0700 (PDT) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec1332f5fsm6408747b3a.49.2024.10.23.07.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 07:49:03 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: bug#73859: lightdm-service-type is almost unusable In-Reply-To: <8fe9bf90-158c-4e03-a257-6ebf9da5ad54@posteo.net> (dariqq@posteo.net's message of "Fri, 18 Oct 2024 09:23:32 +0000") References: <8fe9bf90-158c-4e03-a257-6ebf9da5ad54@posteo.net> Date: Wed, 23 Oct 2024 23:48:57 +0900 Message-ID: <87ldyezxgm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73859 Cc: 73859@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: > Hi Guix, > > This is to report some of the issues and workarounds when trying to > setup lightdm-service-type. Thank you for taking the time to report these detailed findings! > > 1. Unable to choose a session (https://issues.guix.gnu.org/68055) > > This appearently never worked: https://issues.guix.gnu.org/57168#0 Indeed. This definitely makes the session manager much less useful. I'd really like to find a solution to that; I think the issue is reported upstream here: https://github.com/Xubuntu/lightdm-gtk-greeter/issues/105. Just a hunch: perhaps something in the environment the greeter runs is missing to have d-bus communication properly working? > This means one currently has to specify the default session with > something like > > (service lightdm-service-type > (lightdm-configuration > (seats > (list > (lightdm-seat-configuration > (name "*") > (user-session "xfce")))))) > [...] > This might be fixed by making the lightdm-activiation snippet actually > useful: It currently searches for a file named "directory" to fix > permissions rather than the content of the variable 'directory'. > > (find-files "directory" #:directories? #t) vs > (find-files directory #:directories? #t) > > here > https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/lightdm.scm#n527 Fixed. > 4. tigervnnc > > default tigervnc is (file-append tigervnc-server "bin/Xvnc") rather > than (file-append tigervnc-server "/bin/Xvnc") Also fixed (see commit e4e1e16bc1). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 23 14:16:04 2024 Received: (at 73859) by debbugs.gnu.org; 23 Oct 2024 18:16:04 +0000 Received: from localhost ([127.0.0.1]:60746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ftr-0000f0-6v for submit@debbugs.gnu.org; Wed, 23 Oct 2024 14:16:03 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3fto-0000eQ-96 for 73859@debbugs.gnu.org; Wed, 23 Oct 2024 14:16:01 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2BC01240101 for <73859@debbugs.gnu.org>; Wed, 23 Oct 2024 20:15:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1729707323; bh=BUo16HQc8RfucJrioLmAzHhmh/9H3wq6FEnevh/WZKM=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:From: From; b=YMsV1R6Kr9UTGUeNUzFTElykuoAuaQ5jp4Q50cONa1epSZjB+VBWVKA5KXIaqHidO m+VVXTyk/I4ekeoWTm56gaFtVugsNSnDiNnJMAdptmDW+eF0gDAXZD0Mb8eruDQba6 +op0u3L2f0ycbW/PvgCxQwaSqU0leb0nXH9ZQcr8NNWgXz1AcMJsDKC238SQCKXBOK V/LornQbpLDJbPKI4eriJLR+DC+b6VQpUHs/loIInqLyoeJTOqWEkL9fE4e/qnH0Fd QR4AROIiO4RqrfPpcfR5yhsiFiQSiCx+Tya2uvOKkMHOkqajf4ZQygyswVBczLPXmv X1tcLVaCp/60A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XYcfK6G5hz9rxL; Wed, 23 Oct 2024 20:15:21 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------vYKB1Ymra8UdPNg62iS4O1mq" Message-ID: <7f748427-5276-40e9-b44a-56e9bc445ec3@posteo.net> Date: Wed, 23 Oct 2024 18:15:19 +0000 MIME-Version: 1.0 Subject: Re: bug#73859: lightdm-service-type is almost unusable To: Maxim Cournoyer References: <8fe9bf90-158c-4e03-a257-6ebf9da5ad54@posteo.net> <87ldyezxgm.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87ldyezxgm.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73859 Cc: 73859@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------vYKB1Ymra8UdPNg62iS4O1mq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Maxim On 23.10.24 16:48, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > >> Hi Guix, >> >> This is to report some of the issues and workarounds when trying to >> setup lightdm-service-type. > > Thank you for taking the time to report these detailed findings! > >> >> 1. Unable to choose a session (https://issues.guix.gnu.org/68055) >> >> This appearently never worked: https://issues.guix.gnu.org/57168#0 > > Indeed. This definitely makes the session manager much less useful. > I'd really like to find a solution to that; I think the issue is > reported upstream here: > https://github.com/Xubuntu/lightdm-gtk-greeter/issues/105. > > Just a hunch: perhaps something in the environment the greeter > runs is missing to have d-bus communication properly working? > Found all these while trying to switch from xfce to mate on a 32 bit machine (plus skipping some tests in mates dependency tree to get it to build) and spent way to much time trying to understand how to change the default session. Remotivated by your response I looked into how the greeter actually finds the session: 1. The menu just calls out to lightdm_get_sessions https://github.com/Xubuntu/lightdm-gtk-greeter/blob/master/src/lightdm-gtk-greeter.c#L3186 2. This eventually reaches update_sessions https://github.com/canonical/lightdm/blob/main/liblightdm-gobject/session.c#L181 Could it just be that it is using the "wrong" values for the session dir and not the ones we specified in the lightdm config? From what config files (if any) are we reading here? If this is indeed the issue can we set sysconfdir to /etc and let it read the lightdm config file from /etc/lightdm/lightdm.conf (via config_load_from_standard_locations)? I tried something like this (diff attached) and seems to work. I was able to choose between xfce and mate and log into either of them. (only slightly awkward thing is that wed need to overwrite sysconfdir for 'make install' and should probably rename the lightdm-configuration->greeters-config-dir function). >> This means one currently has to specify the default session with >> something like >> >> (service lightdm-service-type >> (lightdm-configuration >> (seats >> (list >> (lightdm-seat-configuration >> (name "*") >> (user-session "xfce")))))) >> > > [...] > >> This might be fixed by making the lightdm-activiation snippet actually >> useful: It currently searches for a file named "directory" to fix >> permissions rather than the content of the variable 'directory'. >> >> (find-files "directory" #:directories? #t) vs >> (find-files directory #:directories? #t) >> >> here >> https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/lightdm.scm#n527 > > Fixed. > >> 4. tigervnnc >> >> default tigervnc is (file-append tigervnc-server "bin/Xvnc") rather >> than (file-append tigervnc-server "/bin/Xvnc") > > Also fixed (see commit e4e1e16bc1). > Thanks :) --------------vYKB1Ymra8UdPNg62iS4O1mq Content-Type: text/x-patch; charset=UTF-8; name="lightdm.diff" Content-Disposition: attachment; filename="lightdm.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9kaXNwbGF5LW1hbmFnZXJzLnNjbSBiL2dudS9w YWNrYWdlcy9kaXNwbGF5LW1hbmFnZXJzLnNjbQppbmRleCA1MTUyZWI2NDc5Li5iMjEwYjEx YmM2IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZGlzcGxheS1tYW5hZ2Vycy5zY20KKysr IGIvZ251L3BhY2thZ2VzL2Rpc3BsYXktbWFuYWdlcnMuc2NtCkBAIC0zODUsNiArMzg1LDcg QEAgKGRlZmluZS1wdWJsaWMgbGlnaHRkbQogICAgICAgIzpwYXJhbGxlbC10ZXN0cz8gI2Yg ICAgICAgICAgICAgOyBmYWlscyB3aGVuIHJ1biBpbiBwYXJhbGxlbAogICAgICAgIzpjb25m aWd1cmUtZmxhZ3MKICAgICAgICN+KGxpc3QgIi0tbG9jYWxzdGF0ZWRpcj0vdmFyIgorICAg ICAgICAgICAgICAiLS1zeXNjb25mZGlyPS9ldGMiCiAgICAgICAgICAgICAgICItLWVuYWJs ZS1ndGstZG9jIgogICAgICAgICAgICAgICA7OyBPdGhlcndpc2UgdGhlIHRlc3Qgc3VpdGUg ZmFpbHMgb24gc3VjaCBhIHdhcm5pbmcuCiAgICAgICAgICAgICAgICJDRkxBR1M9LVduby1l cnJvcj1taXNzaW5nLXByb3RvdHlwZXMiKQpAQCAtNDEyLDcgKzQxMywxMSBAQCAoZGVmaW5l LXB1YmxpYyBsaWdodGRtCiAgICAgICAgICAgICAgICAgYCgiR0lfVFlQRUxJQl9QQVRIIiAi OiIgcHJlZml4ICgsKGdldGVudiAiR0lfVFlQRUxJQl9QQVRIIikpKSkKICAgICAgICAgICAg ICAgOzsgQXZvaWQgcHJpbnRpbmcgbG9jYWxlIHdhcm5pbmdzLCB3aGljaCB0cmlwIHVwIHRo ZSB0ZXh0CiAgICAgICAgICAgICAgIDs7IG1hdGNoaW5nIHRlc3RzLgotICAgICAgICAgICAg ICAodW5zZXRlbnYgIkxDX0FMTCIpKSkpKSkKKyAgICAgICAgICAgICAgKHVuc2V0ZW52ICJM Q19BTEwiKSkpCisgICAgICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAgICAgKGxh bWJkYSogKCM6a2V5IG1ha2UtZmxhZ3MgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAg ICAgIChhcHBseSBpbnZva2UgIm1ha2UiICJpbnN0YWxsIiAoc3RyaW5nLWFwcGVuZCAic3lz Y29uZmRpcj0iICMkb3V0cHV0ICIvZXRjIikKKyAgICAgICAgICAgICAgICAgICAgbWFrZS1m bGFncykpKSkpKQogICAgIChpbnB1dHMKICAgICAgKGxpc3QgYXVkaXQKICAgICAgICAgICAg YmFzaC1taW5pbWFsICAgICAgICAgICAgICAgICA7Zm9yIGNyb3NzLWNvbXBpbGF0aW9uCmRp ZmYgLS1naXQgYS9nbnUvc2VydmljZXMvbGlnaHRkbS5zY20gYi9nbnUvc2VydmljZXMvbGln aHRkbS5zY20KaW5kZXggNzk4YzEwNjU2My4uOWRmZjI2Mzg1NCAxMDA2NDQKLS0tIGEvZ251 L3NlcnZpY2VzL2xpZ2h0ZG0uc2NtCisrKyBiL2dudS9zZXJ2aWNlcy9saWdodGRtLnNjbQpA QCAtNDAxLDEwICs0MDEsMTEgQEAgKGRlZmluZSAobGlnaHRkbS1jb25maWd1cmF0aW9uLT5n cmVldGVycy1jb25maWctZGlyIGNvbmZpZykKICAgIlJldHVybiBhIGRpcmVjdG9yeSBjb250 YWluaW5nIGFsbCB0aGUgc2VyaWFsaXplZCBncmVldGVyIGNvbmZpZ3VyYXRpb25zCiBmcm9t IENPTkZJRywgYSA8bGlnaHRkbS1jb25maWd1cmF0aW9uPiBvYmplY3QuIgogICAoZmlsZS11 bmlvbiAiZXRjLWxpZ2h0ZG0iCi0gICAgICAgICAgICAgIChhcHBlbmQtbWFwIChsYW1iZGEg KGcpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgYCgoLChncmVldGVyLWNvbmZpZ3Vy YXRpb24tPmNvbmYtbmFtZSBnKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICwo Z3JlZXRlci1jb25maWd1cmF0aW9uLT5maWxlIGcpKSkpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgIChsaWdodGRtLWNvbmZpZ3VyYXRpb24tZ3JlZXRlcnMgY29uZmlnKSkpKQorICAg ICAgICAgICAgICAoY29ucyBgKCJsaWdodGRtLmNvbmYiICwobGlnaHRkbS1jb25maWd1cmF0 aW9uLWZpbGUgY29uZmlnKSkKKyAgICAgICAgICAgICAgIChhcHBlbmQtbWFwIChsYW1iZGEg KGcpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGAoKCwoZ3JlZXRlci1jb25maWd1 cmF0aW9uLT5jb25mLW5hbWUgZykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LChncmVldGVyLWNvbmZpZ3VyYXRpb24tPmZpbGUgZykpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIChsaWdodGRtLWNvbmZpZ3VyYXRpb24tZ3JlZXRlcnMgY29uZmlnKSkpKSkK IAogKGRlZmluZSAobGlnaHRkbS1jb25maWd1cmF0aW9uLT5wYWNrYWdlcyBjb25maWcpCiAg ICJSZXR1cm4gYWxsIHRoZSBncmVldGVyIHBhY2thZ2VzIGFuZCB0aGVpciBhc3NldHMgZGVm aW5lZCBpbiBDT05GSUcsIGEK --------------vYKB1Ymra8UdPNg62iS4O1mq-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 23 20:52:26 2024 Received: (at 73859) by debbugs.gnu.org; 24 Oct 2024 00:52:26 +0000 Received: from localhost ([127.0.0.1]:32976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3m5S-0001un-5S for submit@debbugs.gnu.org; Wed, 23 Oct 2024 20:52:26 -0400 Received: from m16.mail.163.com ([117.135.210.3]:37232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3m5N-0001uX-Dw for 73859@debbugs.gnu.org; Wed, 23 Oct 2024 20:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=Loleq/w+I6c9DYVUcmfN9XVbVWCJNieONC95t57rj8k=; b=p7qL+wHcCkBPmLTLmNAY+N5E4+2hWWUjjBloJRpFYmfQt0Wy7z9IRbUJUjQF7Q PnjuwPdanLywLT13HQ0cc/JLK2kqs6r1Wv6IyXf+dJCJYhsHCmPf8H0Og1l2+r28 P1cbHWcFUCAtWd8wtf4Rv/yt9KcEwS+WcSvct4DxbU1co= Received: from Tumashu (unknown [218.92.14.78]) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDXP8cgmhlnIkDcAA--.26771S2; Thu, 24 Oct 2024 08:51:44 +0800 (CST) From: Feng Shu To: 73859@debbugs.gnu.org Subject: lightdm Date: Thu, 24 Oct 2024 08:51:44 +0800 Message-ID: <8734km1fxb.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: _____wDXP8cgmhlnIkDcAA--.26771S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RZWrAUUUUU X-Originating-IP: [218.92.14.78] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiYBiB1GcZWGOgYQACsr X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73859 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wow, good news. Some month ago, I have spend many times to find why session can not be found, but not success -- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 04:42:40 2024 Received: (at 73859) by debbugs.gnu.org; 25 Oct 2024 08:42:40 +0000 Received: from localhost ([127.0.0.1]:37203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4Fu3-0007hc-UX for submit@debbugs.gnu.org; Fri, 25 Oct 2024 04:42:40 -0400 Received: from m16.mail.163.com ([220.197.31.3]:37754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4Fty-0007hJ-0A for 73859@debbugs.gnu.org; Fri, 25 Oct 2024 04:42:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=DYoQ5j4fwGbkov/9y1DrOx3tFCMyRaHMTlgFTELjowI=; b=Kqs/EfRFo6GRLb54cyZ/gTlfsKsszg99pL//77/lY5oLF/XFhdtlMhy+vVPQH0 TKE350R6+JbNTSgZx0br0VNNGeucSSEzomOkYHsXa0WnP2333u1KfDYx6VSMu+KJ xbzc9jnyPTT8L2HwDT3al1sHjDLTM37F6pF+NPGT7KUa0= Received: from Tumashu (unknown [218.92.14.78]) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wD3vaDUWRtngmkcDQ--.56331S2; Fri, 25 Oct 2024 16:41:56 +0800 (CST) From: Feng Shu To: 73859@debbugs.gnu.org Subject: lightdm Date: Fri, 25 Oct 2024 16:41:55 +0800 Message-ID: <87y12c60bw.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: _____wD3vaDUWRtngmkcDQ--.56331S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RKD7-UUUUU X-Originating-IP: [218.92.14.78] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiRQWD1GcbWDEhnwAAs8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73859 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I have tested and found that: In lightdm-gtk-greeter, the following line run success and return no session. items = lightdm_get_sessions (); But, in lightdm, the following function in liblightdm-gobject/session.c is not called: /** * lightdm_get_sessions: * * Get the available sessions. * * Return value: (element-type LightDMSession) (transfer none): A list of #LightDMSession **/ GList * lightdm_get_sessions (void) { g_debug ("Run lightdm_get_sessions"); update_sessions (); return local_sessions; } I do not know why, seem to very confuse. -- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 06:19:50 2024 Received: (at 73859) by debbugs.gnu.org; 2 Nov 2024 10:19:50 +0000 Received: from localhost ([127.0.0.1]:53171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BEU-0005ZC-4H for submit@debbugs.gnu.org; Sat, 02 Nov 2024 06:19:50 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BES-0005Z1-GO for 73859@debbugs.gnu.org; Sat, 02 Nov 2024 06:19:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0B933240103 for <73859@debbugs.gnu.org>; Sat, 2 Nov 2024 11:19:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730542783; bh=qCGkSp6I75kz4mFUE851jG+Azwcs1G15h2xSNLsIk5M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=GM436Pbhkbr+zY6WkOirmgLZH8Jo8Dj1W0B0c94Mqiv65gkLyZoh3PSNQbgmGP6RC qxAkZGhFH7A/XPkyoVghcGMNnikLkjCAkUpbth4jV7LmQVSwyCcARY/NO9al5gNrUd WHaK2lOW/M14wMrMz1d61YNIH6akhdanVDHOjE2+HVbnXLRHIfT7lnPEcd87gYxCMi Du8R3Vw3iHcklPHnd1w83Ce+Nd5bl/3BUc1K6Yaxqjxp2OrOitKFNeF7ioXrCAqEBS mr28Zh0W4K/5JGjHavrpyOXdpZ9v0XcddIQcH1c/h4+2bj4CbzVC8+6iWnelrTZfcl 8A5l4iHSXAo0A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XgYct1nZHz6tx1; Sat, 2 Nov 2024 11:19:42 +0100 (CET) From: Dariqq To: 73859@debbugs.gnu.org Subject: [PATCH 1/2] gnu: lightdm: Use global sysconfdir. Date: Sat, 2 Nov 2024 10:18:32 +0000 Message-ID: <0e5a2bdf3e072e21c3ddd9a815baa8c032619028.1730541249.git.dariqq@posteo.net> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73859 Cc: Dariqq , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/display-managers.scm (lightm) [#:configure-flags]: Set sysconfdir to /etc. [#:phases]: Overwrite sysconfdir in 'installE. for installing sample config files Change-Id: If9c6ce810c726551bd3bf568d50cad8680829262 --- gnu/packages/display-managers.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm index 5152eb6479..b210b11bc6 100644 --- a/gnu/packages/display-managers.scm +++ b/gnu/packages/display-managers.scm @@ -385,6 +385,7 @@ (define-public lightdm #:parallel-tests? #f ; fails when run in parallel #:configure-flags #~(list "--localstatedir=/var" + "--sysconfdir=/etc" "--enable-gtk-doc" ;; Otherwise the test suite fails on such a warning. "CFLAGS=-Wno-error=missing-prototypes") @@ -412,7 +413,11 @@ (define-public lightdm `("GI_TYPELIB_PATH" ":" prefix (,(getenv "GI_TYPELIB_PATH")))) ;; Avoid printing locale warnings, which trip up the text ;; matching tests. - (unsetenv "LC_ALL")))))) + (unsetenv "LC_ALL"))) + (replace 'install + (lambda* (#:key make-flags #:allow-other-keys) + (apply invoke "make" "install" (string-append "sysconfdir=" #$output "/etc") + make-flags)))))) (inputs (list audit bash-minimal ;for cross-compilation -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 06:19:51 2024 Received: (at 73859) by debbugs.gnu.org; 2 Nov 2024 10:19:51 +0000 Received: from localhost ([127.0.0.1]:53173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BEV-0005ZM-Gz for submit@debbugs.gnu.org; Sat, 02 Nov 2024 06:19:51 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BER-0005Z0-9x for 73859@debbugs.gnu.org; Sat, 02 Nov 2024 06:19:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CA4FE240101 for <73859@debbugs.gnu.org>; Sat, 2 Nov 2024 11:19:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730542780; bh=u60P+tRakziv9RC53dzPU5MaVKif93Nlvia1y2I7E44=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=os/59IbW06QLjJDQhqkm7aMXTZw1iSLQqm90p+jJ8yVOVpHahSeJjt6HlxodRPPZM 9fbnf/hf25b8pP5d/4uLTo95D7/XQl17Uba8pLpDhjcXEVDlbeRmS7mB/ZHCI4+eUp MsLW5SwfEiTz64InJYrIU+9vkN52efhPQHi6iOB5IYLYyNK/Dva0zs4DaipC3BgmCz vVfxo9LdEkWCoJFbOMVb7/QdZUdMEIzZ4GNsbht9wFRYT8lUhn5kIT1V5WEMVTP+Y2 hwzwqVDpwYHUt3sGilwq9au2NtJKWtMJNFqcLULGxJ0xZ0nWduwtt/+doxKOtJiBuF v6sgV1/HfThfQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XgYcr0X1qz6tx1; Sat, 2 Nov 2024 11:19:39 +0100 (CET) From: Dariqq To: 73859@debbugs.gnu.org Subject: [PATCH 0/2] lightdm: Fix empty session list. Date: Sat, 2 Nov 2024 10:18:31 +0000 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73859 Cc: Dariqq , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This changes lightdm and the service to use the config file from a well-known location in /etc/lightdm/lightdm.conf s.t. the gtk-greeter knows about our custom "sessions-directory". I then removed the custom config file from the lightdm servcice and removed passing XDG_CONFIG_DIRS which are no longer neccesary. Renamed lightdm-configuration->greeters-config-dir to just lightdm-configuration-directory (inspired by how the dbus-service names its directory) and also moved the etc-extension into a seperate procedure for consistency with other services. I tested this on my i686 pc and ran 'make check-system TESTS=lightdm' successfully This is also the approach done on NixOS, see * https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/display-managers/lightdm/default.nix#L93 *https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/x11/display-managers/lightdm.nix#L259 Fixes https://issues.guix.gnu.org/68055 Dariqq (2): gnu: lightdm: Use global sysconfdir. gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm. gnu/packages/display-managers.scm | 7 ++++- gnu/services/lightdm.scm | 48 ++++++++++++++----------------- 2 files changed, 27 insertions(+), 28 deletions(-) base-commit: ea11d3608566174c4bae70faa4f9d0c67748d2db -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 06:19:56 2024 Received: (at 73859) by debbugs.gnu.org; 2 Nov 2024 10:19:56 +0000 Received: from localhost ([127.0.0.1]:53176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BEZ-0005Za-Sz for submit@debbugs.gnu.org; Sat, 02 Nov 2024 06:19:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BEX-0005Z4-Ox for 73859@debbugs.gnu.org; Sat, 02 Nov 2024 06:19:54 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B779B240027 for <73859@debbugs.gnu.org>; Sat, 2 Nov 2024 11:19:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730542787; bh=q4yLK6Q1LkKvLBqo5j2fOlUXF8q7yRs5DtWaScSJCDU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=nNZdp50y6uJ3oXB6YqxRh4/NkEkKEQLz3+B6pF3yGpiSXJqFGOWlH6Rt2CMtlIyfx igleq7/5RLjChWpk3bZP8V0YFM3Q9XjuLumr4bMXMQFi2JvamLzDl25anIxgV6jo/z VEsdyEF9VozEmRZjN/8ANYfjSMwrTKlfTzNXTWLDjmypa5raBZ6Cx597QcyxNAwhi6 FdPMmrGNEK0jJdZ1+yYjjSLLjQaoHInHYhctZbWEIEY3JIXrdCpSGQgF5CsPRZwTNF eSl0eg3VPrEmwEyDQQ2C3LblpAKZqv7sR7pt/P8nQc3+RN03cItCDsK2+UfvD0m3b3 u7wBj0vcG5MPg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XgYcz023Xz6tx1; Sat, 2 Nov 2024 11:19:46 +0100 (CET) From: Dariqq To: 73859@debbugs.gnu.org Subject: [PATCH 2/2] gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm. Date: Sat, 2 Nov 2024 10:18:33 +0000 Message-ID: <073c63896dcec5eae8e81df5fc1b6131f33add78.1730541249.git.dariqq@posteo.net> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73859 Cc: Dariqq , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/services/lightdm.scm (lightdm-configuration->greeters-config-dir): Rename to lightdm-configuration-directory and add the lightdm-configuration-file. (lightdm-shepherd-service): Don't pass the configuration file, don't set XDG_CONFIG_DIRS (lightdm-etc-service): New procedure. (lightdm-service-type): Use lightdm-etc-service as the etc-extension. Change-Id: I982ec1f7bdfd085621f45a8a1e4b175ab481202f --- gnu/services/lightdm.scm | 48 ++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm index 798c106563..191cb5635b 100644 --- a/gnu/services/lightdm.scm +++ b/gnu/services/lightdm.scm @@ -397,15 +397,6 @@ (define-configuration/no-serialization lightdm-configuration (list-of-strings '()) "Extra configuration values to append to the LightDM configuration file.")) -(define (lightdm-configuration->greeters-config-dir config) - "Return a directory containing all the serialized greeter configurations -from CONFIG, a object." - (file-union "etc-lightdm" - (append-map (lambda (g) - `((,(greeter-configuration->conf-name g) - ,(greeter-configuration->file g)))) - (lightdm-configuration-greeters config)))) - (define (lightdm-configuration->packages config) "Return all the greeter packages and their assets defined in CONFIG, a object, as well as the lightdm package itself." @@ -496,6 +487,16 @@ (define (lightdm-configuration-file config) lightdm-seat-configuration-fields))) seats)))) +(define (lightdm-configuration-directory config) + "Return a directory containing the serialized lightdm configuration +and all the serialized greeter configurations from CONFIG." + (file-union "etc-lightdm" + (cons `("lightdm.conf" ,(lightdm-configuration-file config)) + (map (lambda (g) + `(,(greeter-configuration->conf-name g) + ,(greeter-configuration->file g))) + (lightdm-configuration-greeters config))))) + (define %lightdm-accounts (list (user-group (name "lightdm") (system? #t)) (user-account @@ -589,9 +590,7 @@ (define (lightdm-shepherd-service config) "/sbin/lightdm") #$@(if (lightdm-configuration-debug? config) #~("--debug") - #~()) - "--config" - #$(lightdm-configuration-file config))) + #~()))) (define lightdm-paths (let ((lightdm (lightdm-configuration-lightdm config))) @@ -601,9 +600,6 @@ (define (lightdm-shepherd-service config) '("/bin" "/sbin" "/libexec")) ":"))) - (define greeters-config-dir - (lightdm-configuration->greeters-config-dir config)) - (define data-dirs ;; LightDM itself needs to be in XDG_DATA_DIRS for the accountsservice ;; interface it provides to be picked up. The greeters must also be in @@ -626,11 +622,7 @@ (define (lightdm-shepherd-service config) ;; Lightdm needs itself in its PATH. #:environment-variables (list - ;; It knows to look for greeter - ;; configurations in XDG_CONFIG_DIRS... - (string-append "XDG_CONFIG_DIRS=" - #$greeters-config-dir) - ;; ... and for greeter .desktop files as + ;; It looks for greeter .desktop files as ;; well as lightdm accountsservice ;; interface in XDG_DATA_DIRS. (string-append "XDG_DATA_DIRS=" @@ -638,6 +630,11 @@ (define (lightdm-shepherd-service config) (string-append "PATH=" #$lightdm-paths)))) (stop #~(make-kill-destructor))))) +(define (lightdm-etc-service config) + "Return a list of FILES for @var{etc-service-type} to build the +/etc/lightdm directory using CONFIG" + (list `("lightdm" ,(lightdm-configuration-directory config)))) + (define lightdm-service-type (handle-xorg-configuration lightdm-configuration @@ -666,13 +663,10 @@ (define lightdm-service-type ;; https://github.com/NixOS/nixpkgs/issues/45059. (service-extension profile-service-type lightdm-configuration->packages) - ;; This is needed for the greeter itself to find its configuration, - ;; because XDG_CONF_DIRS gets overridden by /etc/profile. - (service-extension - etc-service-type - (lambda (config) - `(("lightdm" - ,(lightdm-configuration->greeters-config-dir config))))))) + ;; This is needed for lightdm and greeter + ;; to find their configuration + (service-extension etc-service-type + lightdm-etc-service))) (description "Run @code{lightdm}, the LightDM graphical login manager.")))) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 06:24:30 2024 Received: (at control) by debbugs.gnu.org; 2 Nov 2024 10:24:30 +0000 Received: from localhost ([127.0.0.1]:53185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BIz-0005jY-Og for submit@debbugs.gnu.org; Sat, 02 Nov 2024 06:24:30 -0400 Received: from mout01.posteo.de ([185.67.36.65]:56313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7BIy-0005jR-98 for control@debbugs.gnu.org; Sat, 02 Nov 2024 06:24:28 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6570B240027 for ; Sat, 2 Nov 2024 11:24:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730543062; bh=65zhXgrM0sZ1kjnsdYrehvqUaEslPKRooEDhdNzaazU=; h=Message-ID:Date:MIME-Version:To:Subject:From:Content-Type: Content-Transfer-Encoding:From; b=K5sT8HFxZ6UOc94jvdbigqZ3mlyxh32pOIqkPTgjXhSZZrpYFXFJpNZAyMKpK8hBt Nttj7FbpeDLPVI7FkkIbFmcyPTwicZRNeAS8BF0tzp/uqdmVQhAS3ekJ6N4dRQzOYN Lp/Pq3W6Ly380PJw3458DzwWJd5Z+unj7p7L1AWwMlNMDMji29fW1oyFHMKK0Eu4YE x3qBNikyT/4Wb6klX1Ppr43EwVX8r/SX5qQZsFloRMQmJ2cF6opJ5mqSu/GnyZ6o46 fDUDiprTnk/IEeDzv4xFfvRAb0Sv41S1UZRUoRem626s7KFfzjm4FAcZwwo0BuWb5G 25YUDDusZlxjg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XgYkG09Qtz9rxM for ; Sat, 2 Nov 2024 11:24:21 +0100 (CET) Message-ID: Date: Sat, 2 Nov 2024 10:24:17 +0000 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: control message for bug #73859 Content-Language: en-US From: Dariqq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 73859 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 09:33:19 2024 Received: (at control) by debbugs.gnu.org; 15 Dec 2024 14:33:19 +0000 Received: from localhost ([127.0.0.1]:50035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMpgM-0000R4-NJ for submit@debbugs.gnu.org; Sun, 15 Dec 2024 09:33:19 -0500 Received: from [209.85.214.171] (port=47125 helo=mail-pl1-f171.google.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMpgL-0000Qe-5u for control@debbugs.gnu.org; Sun, 15 Dec 2024 09:33:17 -0500 Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21680814d42so26706035ad.2 for ; Sun, 15 Dec 2024 06:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734273123; x=1734877923; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=OgAbz1hfRU85+GwWHmh4ER5jfHoqjSs0dhJiSQJ5JFU=; b=iWSq9Jkj3ED82uDFR9TYv4axhlo9OqXa246msXutvft5mDOdUbrcfHxXTi36iQL6Z4 s/xS9mPzjSnkxtobSlBpVteQV0YDSQfZhGD3d5cR/CY+OtRf+uq7BgvSw3C5S7QMMI1s w46e01LGvLNzDrRaTrVw5GNb3uwXrT4Bf8ll8v/eWEPPCxcD0FSiPkzd8KhM/IsrX/fe UX0AkdAhoJamBxlTcDtN4Ecx8HGgA7JJb9ol8Pho+KYmwcsq/JEYVbTDbcwyBN8iMaEM Pgm4pixeFySOCaIZmO9xbNd8cp68P+69+FhUTKFbzlWdqcWdGHeMyikaf0vmdMQ3exly wAkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734273123; x=1734877923; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OgAbz1hfRU85+GwWHmh4ER5jfHoqjSs0dhJiSQJ5JFU=; b=PYpjQf8RE8ZzbnUANtleZWtxmAwVMqDKei7wRQSkeSjHVjrgzKg5oQcnRa5QKdfBmu KeFqcziK84xBY+LJpP7foAjSNC2PONd1yPhyosuJV2ufEwYe1YphProznI52vBpIQaZ/ K2ETsOe649xn0QbYAeDOFKOekPgYtkyh86okDJdBRha+R/1+YZrrez1XR/faiFIjEUv+ bg95ZPvPccB+xsncMRTgTR6oTynw7xq9Js3QQlSu3z5glgj7tiRJI9hq9nqP/3cVhjsO XqMz3M9jQA1Hg6ev4QEivDzQuG0X14rBYyTSfP028++J3VYZahINwboFh34ss5p5wY0N +Hng== X-Gm-Message-State: AOJu0Yw86NahsC2DjP+PvK6JuyjCf78KqTjA/kCHKpxTKblUdV0INL1i bH8+Q61cINHW6o65RgrNPj2+VqnBEpnQD6c5SJHs8haHHRg78tjXwalp12h6 X-Gm-Gg: ASbGnctKg6OUA36W0ReeubcM8Uyk6NVQyUQyWfPHDZeNKUGr47eWExfZO+LFZNBWvoc 1Cxi1HzfywFfDYgtO0OmlcYdh0sBjCoGhIhYo6Kk2eO0zRHFiahSpSaUr12MKkbDYuU3PInztNK Fzl3Lq+nAuWFxXlifi6NhHM7NnLaeli5QlPGCG3rc/DVhiE3bl9GmdiQK3xN3UhFUMKil7mCsIH zz6UPCmalYigZ1AZa/GwaNGqjkSFxQL68F+j9NfiH5pB4tXzUR39w== X-Google-Smtp-Source: AGHT+IG+cfC+JL6IlCEJv2tSp8Ui48LzbdEIAfoApC7un3Vt5eSKV/AMn4NmDGtutJ0X97K8qnQIPg== X-Received: by 2002:a17:903:1c4:b0:216:39fa:5cb4 with SMTP id d9443c01a7336-218929fe8d6mr126043405ad.25.1734273123003; Sun, 15 Dec 2024 06:32:03 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e6b887sm26886765ad.251.2024.12.15.06.32.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 06:32:02 -0800 (PST) Date: Sun, 15 Dec 2024 23:31:52 +0900 Message-Id: <87jzc1vwyv.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #73859 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 73859 68055 quit Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.214.171 listed in sa-accredit.habeas.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.214.171 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.214.171 listed in bl.score.senderscore.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maxim.cournoyer[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.214.171 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) merge 73859 68055 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 21:37:20 2024 Received: (at 73859-done) by debbugs.gnu.org; 16 Dec 2024 02:37:20 +0000 Received: from localhost ([127.0.0.1]:52868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN0yx-0002O4-JU for submit@debbugs.gnu.org; Sun, 15 Dec 2024 21:37:19 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:58420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN0ys-0002Np-K7 for 73859-done@debbugs.gnu.org; Sun, 15 Dec 2024 21:37:12 -0500 Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-728ec840a8aso3829287b3a.0 for <73859-done@debbugs.gnu.org>; Sun, 15 Dec 2024 18:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734316569; x=1734921369; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=72MxaGEPbx7P6gROjxMhacOP16G7gTXvgRARuDvuU9U=; b=csChvfxKPqYXNxKBvSEBdPO/N3xbDjkAnEAQpwrCHwzSy3z3jNEcmDhqUxpjUqdyGp D1DjY/d9c/hvTaCvnECQOI/nVoiZ6HIjuDjhbqB+E3bYM78YMmt/ikbnzsBRAfBL+3HA dNGFYFqDLa9AXAzLAMb3E4DKii11ffN96aB5yPOB55v9UFem7rTVaK3pDaZHbSmDXK6C K+upaJgSyMMIdqIMYMS8U9cBexfqVYmbqixVpj5zJg/J8O87nJolsUwxRCGWjLQVT43P hv/e4jv+wlLsYgBb7kXzglyqfdBvFtWkhB+puDJZW8Ea2eBf30Xe/YZw6kLkSLw69Dn3 anGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734316569; x=1734921369; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=72MxaGEPbx7P6gROjxMhacOP16G7gTXvgRARuDvuU9U=; b=wQb27hxjZNVr/S9HxJudlE/3PSq7V62Sa1CBylX9MVDDwgJfg4sE0hnmqwHIGf6Pla E5OkcflsMdENUKShpUjmJ4tMCMpBGd63ctLULc/Re5hND0zVj2lLBcadypcgx5wPUk8K st3H5PkmMtsWEeGlrV+bmMwK/Wkl948yXbcp+HCSgvFBu8snUtamkQoFFMfGREQo6nqG PsdAFrrz8UH5m6zESP2yRcKxCy35rhWmbjEIF6K6AyPN6krWXTPCCT2XEp1wYzdNq5FE Q0YKv/2yXxWhb+N5fdtMF6oTv+ssA93OcKjOf+knOAUNEZdfNFYt66oVQdPTigIgmhQE nM3w== X-Gm-Message-State: AOJu0YyfLp/MUlJs73SuzQVa9TZoxsj2Yn2znNtQQZUffeBWJlJ1jizj ScTdtt9+HEu7X8SFj/UA+M7lw9AfpjEhNvKkojw8tSyCt0H6YOc+haW69lTa X-Gm-Gg: ASbGncul6/slculkwYzbwkruPFoT/A1fPI9YEKqsw/nmEolURG6GOF1lVEvBD7adBgl jvgBx9g/3NB+On2C6CJrbkP9iGcxEnkJEZVK3TdZgMoTyydby4Xr2XeDPlIhog3poy0io7EpW/i n6E5B7uR4n8lx5V3Wm5F/j+YVwv1Byt4GQaMeSPhsctmiTm3XVOSl3AEhixDNvTvjb2VHmmQy2c GndSTe3WWWYHZtnQ0psOU7FaxBZncRdMH9WJJRpfdoTmC9bQyt1ag== X-Google-Smtp-Source: AGHT+IFO6mZHb21pWl3xeFVlwPFIVTZcdXIzShbnyCpAHQ2XH+iXauknimno9ahPhoLIOL0696w5kw== X-Received: by 2002:a05:6a00:6caa:b0:725:f1ca:fd75 with SMTP id d2e1a72fcca58-7290c10fe64mr17162689b3a.2.1734316568627; Sun, 15 Dec 2024 18:36:08 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72918ac53cdsm3723925b3a.23.2024.12.15.18.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 18:36:08 -0800 (PST) From: Maxim Cournoyer To: Dariqq Subject: Re: [PATCH 0/2] lightdm: Fix empty session list. In-Reply-To: (dariqq@posteo.net's message of "Sat, 2 Nov 2024 10:18:31 +0000") References: Date: Mon, 16 Dec 2024 11:35:57 +0900 Message-ID: <87y10guzg2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73859-done Cc: 73859-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: [...] > Dariqq (2): > gnu: lightdm: Use global sysconfdir. > gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm. Finally pushed to master (see commits b9d7e15f9f and 3a8e19a61d), after I had some time to properly review and test it. I've adjusted the commit messages a bit, and used this Scheme trick to reuse more of the install phase arguments: --8<---------------cut here---------------start------------->8--- ;; matching tests. - (unsetenv "LC_ALL")))))) + (unsetenv "LC_ALL"))) + (replace 'install + (lambda* (#:key make-flags #:allow-other-keys #:rest args) + ;; Override the sysconfdir flag only for the installation phase, + ;; as it attempts to write the sample config files to /etc and + ;; fail otherwise. + (define make-flags* + (append make-flags (list (string-append "sysconfdir=" + #$output "/etc")))) + (apply (assoc-ref %standard-phases 'install) + (append args (list #:make-flags make-flags*)))))))) (inputs --8<---------------cut here---------------end--------------->8--- Closing. -- Thanks, Maxim From unknown Sat Sep 20 02:11:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 13 Jan 2025 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator