From unknown Sat Jun 21 03:20:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73846: [PATCH] Make djvused emit UTF-8 encoded text Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: tsdh@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2024 04:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73846 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 73846@debbugs.gnu.org Cc: "Tassilo Horn" X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: "Tassilo Horn" Received: via spool by submit@debbugs.gnu.org id=B.172913851230739 (code B ref -1); Thu, 17 Oct 2024 04:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Oct 2024 04:15:12 +0000 Received: from localhost ([127.0.0.1]:32930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Huq-0007zh-7m for submit@debbugs.gnu.org; Thu, 17 Oct 2024 00:15:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:40324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Hup-0007zZ-17 for submit@debbugs.gnu.org; Thu, 17 Oct 2024 00:15:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1HsN-0004t1-0N for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 00:12:39 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1HsL-000259-AY for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 00:12:38 -0400 Received: by mail-pg1-x543.google.com with SMTP id 41be03b00d2f7-7ea8de14848so390063a12.2 for ; Wed, 16 Oct 2024 21:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729138355; x=1729743155; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=lio7kJiOuA8CmWPW1GWsIYNeZOnOcjvhLIBU1Kjtoyg=; b=Lbip054ejuesVc7pslMHgMMmWIdBcUmcmRTtVBtVkIn2w9BlSChJk0zB0R0vEbn6er hI06CoGkDEPdi8lQDfvBLhkEgtxbBWTNpbvoFVY4+zeBBxmi9qinV/SCr1GGWjMeKIf+ AeU6E88veYJmBm66x4TRZXGqr8Ah+ndG9JiY/6e9tIMi33o1nRU4yX/8u+X34kcNonyY TEo+h1+/SEtObtpBPNb0m8ufBajJzHnyjaUkLyBqRwdy/F++2OI6QDvR/I4BH97PJTd6 KKFnV8D1VA7/1wVX4yJr67IxGWRkIxKHr3HhG7EpqaKBtclimctR8RveZa4nI4IQWUnq o6lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729138355; x=1729743155; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lio7kJiOuA8CmWPW1GWsIYNeZOnOcjvhLIBU1Kjtoyg=; b=KU3XYAwwuHItV0Enar1BUXv8j7Qfb+2dM9erIvTp/J98UqUuaUtMyhAnZn7dwLGmsB dhJYeQ9QIH009GQhqTrnUp+ie2z7qkbX2FSs+FNMKjQRqADv7hOF11o7cw1+FSZQqZpD unsJp3sOYRHQP7MrmEq7fE+fjMQUOrxx2n3NcnDHrbT7mvTigJ5I9ihyfzG4HsJklgVA jSB/XNHMV2ajkkWpp8vUHk4aBE1AvCThnHlDz0mYbAoEv2dQpM+FZTNFKsUOow5Ox8i0 l7fOHZ7217P+tyWUetF1ak33V9mu6YGdSkceg+6E7F0jZZTdEcVPB1ysOz2a6KSw+B+A aBUQ== X-Gm-Message-State: AOJu0Yyz4/v0Qh+jA6gJzmLpIBomYihZPv6EP90XXSLHO1OneaHMDt4R F1IlnBou/7tHku4PJex4t0ddI6iTvM/BY5OcXKhAA45x3RScbVW2XcWjI6KU X-Google-Smtp-Source: AGHT+IHZ9KBfDZirPf0db48YsI2D1KfDE44cNs7yqeODnL4Ck1Vca550fa5ab/C1lZGeEr2+WmryqQ== X-Received: by 2002:a05:6a21:1643:b0:1d5:2f56:9fe5 with SMTP id adf61e73a8af0-1d8bcfb272bmr30208638637.39.1729138354919; Wed, 16 Oct 2024 21:12:34 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e3e094bcafsm721027a91.54.2024.10.16.21.12.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 21:12:34 -0700 (PDT) From: Visuwesh Date: Thu, 17 Oct 2024 09:42:30 +0530 Message-ID: <87y12n1i6p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=visuweshm@gmail.com; helo=mail-pg1-x543.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch Hi Tassilo, This is a small patch to make djvused emit UTF-8 encoded text. In the djvu test file that I sent you, outline in the appendix have non-ASCII characters which are written as octal escapes. Rather than unescaping them on Emacs side, we can request djvused to use UTF-8 directly which this patch does. The attached patch does just that. In GNU Emacs 31.0.50 (build 13, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw scroll bars) of 2024-10-06 built on astatine Repository revision: 500f5da5fb62cd0bbded8df754d93e3147d1d847 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure --with-sound=alsa --with-x-toolkit=lucid --without-xaw3d --without-gconf --without-libsystemd --with-cairo CFLAGS=-g3' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-djvused-emit-UTF-8-encoded-text.patch >From 8e21167c6e01ab76b76e15fa84bd198bc8df59b4 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Thu, 17 Oct 2024 09:40:34 +0530 Subject: [PATCH] Make djvused emit UTF-8 encoded text * lisp/doc-view.el (doc-view--djvu-outline): Pass -u to djvused to make it emit UTF-8 encoded text rather than using octal escapes for non-ASCII string. --- lisp/doc-view.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index bbfbbdec925..018c4eddd34 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -2027,7 +2027,7 @@ doc-view--djvu-outline (unless file-name (setq file-name (buffer-file-name))) (with-temp-buffer (call-process doc-view-djvused-program nil (current-buffer) nil - "-e" "print-outline" file-name) + "-u" "-e" "print-outline" file-name) (goto-char (point-min)) (when (eobp) (setq doc-view--outline 'unavailable) -- 2.45.2 --=-=-=-- From unknown Sat Jun 21 03:20:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73846: [PATCH] Make djvused emit UTF-8 encoded text Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2024 05:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73846 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Visuwesh Cc: tsdh@gnu.org, 73846@debbugs.gnu.org Received: via spool by 73846-submit@debbugs.gnu.org id=B73846.172914282011696 (code B ref 73846); Thu, 17 Oct 2024 05:27:02 +0000 Received: (at 73846) by debbugs.gnu.org; 17 Oct 2024 05:27:00 +0000 Received: from localhost ([127.0.0.1]:33053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1J2K-00032Z-Dp for submit@debbugs.gnu.org; Thu, 17 Oct 2024 01:27:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1J2H-00032J-Or for 73846@debbugs.gnu.org; Thu, 17 Oct 2024 01:26:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1J1r-0004I4-UP; Thu, 17 Oct 2024 01:26:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wTEcbB599vwfW2kYOXweybxCq56lhFjV/gkT9TM8jc8=; b=Qipla0V7uBEm dSAh3C1ViGn+jV0xTWU095d37H7Ohw3s8onZdUmOwGwUReTtbBSuYEHl6Aiwcb8oJ1yqH67UDp4zT G0hpDY+iyJimrWSTKF0mIJRHftnnEwrfQYPz1MAerHJFWpnxwiEbdnl6q4VTLCHnkuNfoq00RNHeh U77fgZwX0Nmonvrp2q/od1owa7vx95dRkn/gBQ4mCwkKcyIeV8BlxseisxMfhgLTwYstXw5Ps7Lt+ L9i/VTB9/lIEVseXyoPJGvCJOrnhYfv4R2Wq5kYwfWwICAwzVFxdIc3BoTqIpg2IlHUryrBw0yDD6 NCDcdJGNG9pHQI0JptKgig==; Date: Thu, 17 Oct 2024 08:26:27 +0300 Message-Id: <86frovpaf0.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87y12n1i6p.fsf@gmail.com> (message from Visuwesh on Thu, 17 Oct 2024 09:42:30 +0530) References: <87y12n1i6p.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: "Tassilo Horn" > From: Visuwesh > Date: Thu, 17 Oct 2024 09:42:30 +0530 > > This is a small patch to make djvused emit UTF-8 encoded text. In the > djvu test file that I sent you, outline in the appendix have non-ASCII > characters which are written as octal escapes. Rather than unescaping > them on Emacs side, we can request djvused to use UTF-8 directly which > this patch does. The attached patch does just that. If you force djvused to emit UTF-8 encoded text, you need to bind coding-system-for-read to 'utf-8, to make sure Emacs decodes that correctly. I'm guessing your locale uses UTF-8 by default, which is why it worked for you. Please also add a comment there explaining what the -u switch does and why we use it there. Thanks. From unknown Sat Jun 21 03:20:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73846: [PATCH] Make djvused emit UTF-8 encoded text Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2024 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73846 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: tsdh@gnu.org, 73846@debbugs.gnu.org Received: via spool by 73846-submit@debbugs.gnu.org id=B73846.172915403211748 (code B ref 73846); Thu, 17 Oct 2024 08:34:02 +0000 Received: (at 73846) by debbugs.gnu.org; 17 Oct 2024 08:33:52 +0000 Received: from localhost ([127.0.0.1]:33327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Lx9-00033O-FL for submit@debbugs.gnu.org; Thu, 17 Oct 2024 04:33:51 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Lx7-00033F-So for 73846@debbugs.gnu.org; Thu, 17 Oct 2024 04:33:50 -0400 Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-71e57d89ffaso509289b3a.1 for <73846@debbugs.gnu.org>; Thu, 17 Oct 2024 01:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729153948; x=1729758748; darn=debbugs.gnu.org; h=mime-version:user-agent:references:message-id:date:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/BDraxecg1556Z/kLk9j4YqrPBrXpoksDr88DD1cKRc=; b=kaHDQvmaDN2/HlNYB6EKwzbBJBe6oJzfbVGD9r1hWi2mNBGVd48LthZ2AJDtHEM1ND ugPaoqUuxgZPNgbZ174AZLfRmem7vGPmN7KnaSJAyZAMC8+H2XtAlqGSx7xw4IGRJrnf 3Mf0/UX7olnn/J0HRUiOUqNnRF/N43r42mxOmTJTnW+ZaabtE9jVvIqo6901RNRlF4j4 1wGQyqz1WYZPifRc3mAuq7VIECrxl6ubzqxUHMJ/oPwS4scd6EiBDRZenVj94OHIZM5A BcbxTwwee0hY505rpKD7963uWDUTDCi++DVJvon0inPTHo2L7rirTTEP8+4xmwkR2/2u 7gJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729153948; x=1729758748; h=mime-version:user-agent:references:message-id:date:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/BDraxecg1556Z/kLk9j4YqrPBrXpoksDr88DD1cKRc=; b=HYl35jUWl0CHmHVSxLPUfociUtVNy8SwhK5Sjv0W7x70/IkuHhYgaFXK+hpw+rdB27 AnwBPWy0DPaOOrW9Ny4b1RQICFNcQI54/PRcO+4uL4rGSIW8rxnsfvEEuxx6f1sDJmet Hilk0CwH3S2TgS1X0aN3cpLs60bfL4XuQKdY9PfoyYM+HQAew4uGp8ASsHRX563mHb9m RkiPy6tEeRJ2ILJ11HaYsP7wkhqCC9uCgukzsTSMwahVLhMnYzWzcDVKbnHqcaKbbt9e zei0Cos76A06M2r1M6gfWYvRJa394UMy86tauVRdPlefUNJXTpUvrdGW1ZQ/Gncz8XA4 ZReA== X-Gm-Message-State: AOJu0Ywzl72iOwzjhpJ2n6VEUDWS+25UWhS524pk5zi6ezAbEc3cWHQK YlEDeVqjg99IxaJBq3Nj37ZbDYWOzNYEu1cMpWWj3wDtkg7MrpOz X-Google-Smtp-Source: AGHT+IFOuXGF2aIDjwbq9wJeraCx1urvfZPThuFW4dWZA5mU/VosdM8I5qq59r37d69HAeWOA65SDg== X-Received: by 2002:a05:6a21:3318:b0:1d9:1789:31f3 with SMTP id adf61e73a8af0-1d917893402mr5614649637.12.1729153948277; Thu, 17 Oct 2024 01:32:28 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e774a2ab2sm4237594b3a.117.2024.10.17.01.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 01:32:27 -0700 (PDT) From: Visuwesh In-Reply-To: <86frovpaf0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Oct 2024 08:26:27 +0300") Date: Thu, 17 Oct 2024 14:01:56 +0530 Message-ID: <87bjzjxh8j.fsf@gmail.com> References: <87y12n1i6p.fsf@gmail.com> <86frovpaf0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=85= =E0=AE=95=E0=AF=8D=E0=AE=9F=E0=AF=8B=E0=AE=AA=E0=AE=B0=E0=AF=8D 17, 2024] E= li Zaretskii wrote: >> Cc: "Tassilo Horn" >> From: Visuwesh >> Date: Thu, 17 Oct 2024 09:42:30 +0530 >>=20 >> This is a small patch to make djvused emit UTF-8 encoded text. In the >> djvu test file that I sent you, outline in the appendix have non-ASCII >> characters which are written as octal escapes. Rather than unescaping >> them on Emacs side, we can request djvused to use UTF-8 directly which >> this patch does. The attached patch does just that. > > If you force djvused to emit UTF-8 encoded text, you need to bind > coding-system-for-read to 'utf-8, to make sure Emacs decodes that > correctly. I'm guessing your locale uses UTF-8 by default, which is > why it worked for you. My locale is a UTF-8 one indeed. I've now let bound coding-system-for-read around everything inside with-temp-buffer. > Please also add a comment there explaining what the -u switch does and > why we use it there. Done in attached patch, I hope it is clear. > Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-djvused-emit-UTF-8-encoded-text.patch >From a39e50a504c9c24f51c7c646f3cfffcec2f34b85 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Thu, 17 Oct 2024 09:40:34 +0530 Subject: [PATCH] Make djvused emit UTF-8 encoded text * lisp/doc-view.el (doc-view--djvu-outline): Pass -u to djvused to make it emit UTF-8 encoded text rather than using octal escapes for non-ASCII string. (bug#73846) --- lisp/doc-view.el | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index bbfbbdec925..4d7d36c8a16 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -2026,13 +2026,16 @@ doc-view--djvu-outline For the format, see `doc-view--pdf-outline'." (unless file-name (setq file-name (buffer-file-name))) (with-temp-buffer - (call-process doc-view-djvused-program nil (current-buffer) nil - "-e" "print-outline" file-name) - (goto-char (point-min)) - (when (eobp) - (setq doc-view--outline 'unavailable) - (imenu-unavailable-error "Unable to create imenu index using `djvused'")) - (nreverse (doc-view--parse-djvu-outline (read (current-buffer)))))) + (let ((coding-system-for-read 'utf-8)) + ;; Pass "-u" to make `djvused' emit UTF-8 encoded text to avoid + ;; unescaping octal escapes for non-ASCII text. + (call-process doc-view-djvused-program nil (current-buffer) nil + "-u" "-e" "print-outline" file-name) + (goto-char (point-min)) + (when (eobp) + (setq doc-view--outline 'unavailable) + (imenu-unavailable-error "Unable to create imenu index using `djvused'")) + (nreverse (doc-view--parse-djvu-outline (read (current-buffer))))))) (defun doc-view--parse-djvu-outline (bookmark &optional level) "Return a list describing the djvu outline from BOOKMARK. -- 2.45.2 --=-=-=-- From unknown Sat Jun 21 03:20:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Visuwesh Subject: bug#73846: closed (Re: bug#73846: [PATCH] Make djvused emit UTF-8 encoded text) Message-ID: References: <87iktq0wqw.fsf@gnu.org> <87y12n1i6p.fsf@gmail.com> X-Gnu-PR-Message: they-closed 73846 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 73846@debbugs.gnu.org Date: Fri, 18 Oct 2024 06:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1729231742-16979-1" This is a multi-part message in MIME format... ------------=_1729231742-16979-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73846: [PATCH] Make djvused emit UTF-8 encoded text which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73846@debbugs.gnu.org. --=20 73846: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73846 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1729231742-16979-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73846-done) by debbugs.gnu.org; 18 Oct 2024 06:08:25 +0000 Received: from localhost ([127.0.0.1]:36760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1g9x-0004Ov-5i for submit@debbugs.gnu.org; Fri, 18 Oct 2024 02:08:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1g9v-0004Og-Fd for 73846-done@debbugs.gnu.org; Fri, 18 Oct 2024 02:08:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1g9U-0003Js-5j; Fri, 18 Oct 2024 02:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Is4T5+9Btf3g/Z0easRVMv3bu52jzJnu68beYse8NW4=; b=dAij+kbphKLx3ZJVS7Um 1u2ZK2Dd5A2H6fQiBViG+Ui3EvIW4Ob3q9RmYAsvJPsEp1BimP3/zJj4dDWL5Ngz0Y7s+RuMsqZOS iKidEy/zes5ZrXRHD6GvKcdUaOpZ4eR8epZTad1WqNEYTbGK6kHdmKZ+XMXezjz+Qbm2vL/LLIz3v vl70SWBFi4RaFnUBzZ+j3MSUcHXcho3eQb4oGvHJDAW50YahMkZroR+zEXJ71f0di5nAy79w+FhQP aG5dHM92jYm9EdC5QVU/AVGmwhEZpOjCU68/d15zOXuncGWGykDhqP8bbrg0ghXmhMmFybvgWbnxX A6YMvXt3G2i4DA==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehvddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepjeefkeegiedqughonhgvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtoh epvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepvhhishhufigvshhhmhesghhmrghi lhdrtghomh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn To: Visuwesh Subject: Re: bug#73846: [PATCH] Make djvused emit UTF-8 encoded text In-Reply-To: <87bjzjxh8j.fsf@gmail.com> (Visuwesh's message of "Thu, 17 Oct 2024 14:01:56 +0530") References: <87y12n1i6p.fsf@gmail.com> <86frovpaf0.fsf@gnu.org> <87bjzjxh8j.fsf@gmail.com> User-Agent: mu4e 1.12.6; emacs 31.0.50 Date: Fri, 18 Oct 2024 08:07:51 +0200 Message-ID: <87iktq0wqw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73846-done Cc: 73846-done@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Visuwesh writes: >> Please also add a comment there explaining what the -u switch does >> and why we use it there. > > Done in attached patch, I hope it is clear. It is. Applied and pushed to master. Thanks again, Tassilo ------------=_1729231742-16979-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Oct 2024 04:15:12 +0000 Received: from localhost ([127.0.0.1]:32930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Huq-0007zh-7m for submit@debbugs.gnu.org; Thu, 17 Oct 2024 00:15:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:40324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Hup-0007zZ-17 for submit@debbugs.gnu.org; Thu, 17 Oct 2024 00:15:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1HsN-0004t1-0N for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 00:12:39 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1HsL-000259-AY for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 00:12:38 -0400 Received: by mail-pg1-x543.google.com with SMTP id 41be03b00d2f7-7ea8de14848so390063a12.2 for ; Wed, 16 Oct 2024 21:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729138355; x=1729743155; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=lio7kJiOuA8CmWPW1GWsIYNeZOnOcjvhLIBU1Kjtoyg=; b=Lbip054ejuesVc7pslMHgMMmWIdBcUmcmRTtVBtVkIn2w9BlSChJk0zB0R0vEbn6er hI06CoGkDEPdi8lQDfvBLhkEgtxbBWTNpbvoFVY4+zeBBxmi9qinV/SCr1GGWjMeKIf+ AeU6E88veYJmBm66x4TRZXGqr8Ah+ndG9JiY/6e9tIMi33o1nRU4yX/8u+X34kcNonyY TEo+h1+/SEtObtpBPNb0m8ufBajJzHnyjaUkLyBqRwdy/F++2OI6QDvR/I4BH97PJTd6 KKFnV8D1VA7/1wVX4yJr67IxGWRkIxKHr3HhG7EpqaKBtclimctR8RveZa4nI4IQWUnq o6lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729138355; x=1729743155; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lio7kJiOuA8CmWPW1GWsIYNeZOnOcjvhLIBU1Kjtoyg=; b=KU3XYAwwuHItV0Enar1BUXv8j7Qfb+2dM9erIvTp/J98UqUuaUtMyhAnZn7dwLGmsB dhJYeQ9QIH009GQhqTrnUp+ie2z7qkbX2FSs+FNMKjQRqADv7hOF11o7cw1+FSZQqZpD unsJp3sOYRHQP7MrmEq7fE+fjMQUOrxx2n3NcnDHrbT7mvTigJ5I9ihyfzG4HsJklgVA jSB/XNHMV2ajkkWpp8vUHk4aBE1AvCThnHlDz0mYbAoEv2dQpM+FZTNFKsUOow5Ox8i0 l7fOHZ7217P+tyWUetF1ak33V9mu6YGdSkceg+6E7F0jZZTdEcVPB1ysOz2a6KSw+B+A aBUQ== X-Gm-Message-State: AOJu0Yyz4/v0Qh+jA6gJzmLpIBomYihZPv6EP90XXSLHO1OneaHMDt4R F1IlnBou/7tHku4PJex4t0ddI6iTvM/BY5OcXKhAA45x3RScbVW2XcWjI6KU X-Google-Smtp-Source: AGHT+IHZ9KBfDZirPf0db48YsI2D1KfDE44cNs7yqeODnL4Ck1Vca550fa5ab/C1lZGeEr2+WmryqQ== X-Received: by 2002:a05:6a21:1643:b0:1d5:2f56:9fe5 with SMTP id adf61e73a8af0-1d8bcfb272bmr30208638637.39.1729138354919; Wed, 16 Oct 2024 21:12:34 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e3e094bcafsm721027a91.54.2024.10.16.21.12.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 21:12:34 -0700 (PDT) From: Visuwesh To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make djvused emit UTF-8 encoded text X-Debbugs-Cc: "Tassilo Horn" Date: Thu, 17 Oct 2024 09:42:30 +0530 Message-ID: <87y12n1i6p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=visuweshm@gmail.com; helo=mail-pg1-x543.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch Hi Tassilo, This is a small patch to make djvused emit UTF-8 encoded text. In the djvu test file that I sent you, outline in the appendix have non-ASCII characters which are written as octal escapes. Rather than unescaping them on Emacs side, we can request djvused to use UTF-8 directly which this patch does. The attached patch does just that. In GNU Emacs 31.0.50 (build 13, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw scroll bars) of 2024-10-06 built on astatine Repository revision: 500f5da5fb62cd0bbded8df754d93e3147d1d847 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure --with-sound=alsa --with-x-toolkit=lucid --without-xaw3d --without-gconf --without-libsystemd --with-cairo CFLAGS=-g3' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-djvused-emit-UTF-8-encoded-text.patch >From 8e21167c6e01ab76b76e15fa84bd198bc8df59b4 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Thu, 17 Oct 2024 09:40:34 +0530 Subject: [PATCH] Make djvused emit UTF-8 encoded text * lisp/doc-view.el (doc-view--djvu-outline): Pass -u to djvused to make it emit UTF-8 encoded text rather than using octal escapes for non-ASCII string. --- lisp/doc-view.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index bbfbbdec925..018c4eddd34 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -2027,7 +2027,7 @@ doc-view--djvu-outline (unless file-name (setq file-name (buffer-file-name))) (with-temp-buffer (call-process doc-view-djvused-program nil (current-buffer) nil - "-e" "print-outline" file-name) + "-u" "-e" "print-outline" file-name) (goto-char (point-min)) (when (eobp) (setq doc-view--outline 'unavailable) -- 2.45.2 --=-=-=-- ------------=_1729231742-16979-1--