GNU bug report logs - #73841
[PATCH] gnu: book-sparc: Update to 2.2.0.

Previous Next

Full log

Message #8 received at 73841 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 73841 <at> debbugs.gnu.org
Subject: Re: [bug#73841] [PATCH] gnu: book-sparc: Update to 2.2.0.
Date: Fri, 18 Oct 2024 14:25:46 +0200

Hi,

"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:

> * gnu/packages/books.scm (book-sparc): Update to 2.2.0.
> [inputs]: Add git, gnu-make, texlive-fancyvrb, and texlive-upquote.
> [native-inputs]: Add autoconf and automake.
>
> Change-Id: Icd19f295b8572428aea39f46c27e22f87d5dc7e1

[...]

>      (inputs
>       (list font-liberation
> +           git
> +           gnu-make

I believe ‘gnu-make’ is unnecessary: it’s included by
‘gnu-build-system’.

> +          #:phases #~(modify-phases %standard-phases
> +                       (add-before 'build 'configure-environment
> +                         (lambda* (#:key inputs make-flags parallel-build?
> +                                   #:allow-other-keys)
> +                           (use-modules (ice-9 regex)
> +                                        (srfi srfi-1))

Please avoid ‘use-modules’ in a non-top-level context: it’s not
guaranteed to work.

Instead, use #:modules.

> +                       (replace 'install
> +                         (lambda _
> +                           (let ((doc-dir (string-append #$output
> +                                                         "/share/doc/sparc/")))
> +                             (mkdir-p doc-dir)
> +                             (copy-file "sparc.pdf"
> +                                        (string-append doc-dir
> +                                                       "sparc.pdf"))))))))

Shorter: (install-file "sparc.pdf" doc-dir).

Otherwise LGTM!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.