GNU bug report logs - #73838
31.0.50; Problems in note_mouse_highlight if -nw

Previous Next

Full log

Message #23 received at 73838 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 73838 <at> debbugs.gnu.org
Subject: Re: bug#73838: 31.0.50; Problems in note_mouse_highlight if -nw
Date: Wed, 16 Oct 2024 21:30:03 +0300

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: 73838 <at> debbugs.gnu.org
> Date: Wed, 16 Oct 2024 18:56:53 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > How can scroll bars happen on TTY frames?
> 
> I'll try to answer this a bit more broadly: I'd like the code to be more
> resilient, and not make implicit assumptions about the absence of of
> features on ttys, which when false, leads to such hard to detect errors.
> 
> Consider the internal border case. In master, FRAME_INTERNAL_BORDER
> happens to return 0 in master. But that might change, if I ever get
> setting internal borders to work for tty child frames, to draw the
> border there.

But then we need to audit a lot more than just these bits.  E.g., who
will guarantee that FRAME_WINDOW_P is always zero on TTY frames?

More seriously, I think we should prefer functional tests to
declarative tests.  Which means not to assume that TTY frames can
never have some display feature.  Thus, IMO your suggestion is in a
sense a step back, because it assumes that TTY frames can never have
these decorations and can never have different cursor types.  So my
suggestion would be to do the opposite: understand why
FRAME_OUTPUT_DATA segfaults when dereferenced on TTY frames, and fix
that so that it doesn't.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.