GNU bug report logs - #73832
[PATCH] Fix misplaced paren in c-ts-mode--anchor-prev-sibling

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73832 in the body.
You can then email your comments to 73832 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix misplaced paren in c-ts-mode--anchor-prev-sibling
Date: Tue, 15 Oct 2024 19:37:00 -0700

[Message part 1 (text/plain, inline)]

Tags: patch


It looks like a parenthesis was misplaced in the recent change to
c-ts-mode--anchor-prev-sibling causing an infinite loop during
indentation.


In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.41, cairo version 1.18.0) of 2024-10-14 built on noah-X580VD
Repository revision: 2a6f1527f6b3080c3879e6159424b824c86801a7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Ubuntu 24.04.1 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-gnutls --with-mailutils --with-jpeg --with-png
--with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick
CC=gcc-13 CXX=gcc-13 CFLAGS= CXXFLAGS= PKG_CONFIG_PATH='

[Message part 2 (text/html, inline)]

[0001-Fix-misplaced-paren-in-c-ts-mode-anchor-prev-sibling.patch (text/x-patch, attachment)]

Message #8 received at 73832 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noah Peart <noah.v.peart <at> gmail.com>, Yuan Fu <casouri <at> gmail.com>
Cc: 73832 <at> debbugs.gnu.org
Subject: Re: bug#73832: [PATCH] Fix misplaced paren in
 c-ts-mode--anchor-prev-sibling
Date: Wed, 16 Oct 2024 08:36:42 +0300

> From: Noah Peart <noah.v.peart <at> gmail.com>
> Date: Tue, 15 Oct 2024 19:37:00 -0700
> 
> Tags: patch
> 
> It looks like a parenthesis was misplaced in the recent change to
> c-ts-mode--anchor-prev-sibling causing an infinite loop during
> indentation.

Thanks, this is bug#73661, which was recently fixed on the emacs-30
branch (the fix will be merged to master in a couple of days).

Yuan, am I right?

Message #11 received at 73832 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Noah Peart <noah.v.peart <at> gmail.com>, 73832 <at> debbugs.gnu.org
Subject: Re: bug#73832: [PATCH] Fix misplaced paren in
 c-ts-mode--anchor-prev-sibling
Date: Tue, 15 Oct 2024 22:53:37 -0700

> On Oct 15, 2024, at 10:36 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Noah Peart <noah.v.peart <at> gmail.com>
>> Date: Tue, 15 Oct 2024 19:37:00 -0700
>> 
>> Tags: patch
>> 
>> It looks like a parenthesis was misplaced in the recent change to
>> c-ts-mode--anchor-prev-sibling causing an infinite loop during
>> indentation.
> 
> Thanks, this is bug#73661, which was recently fixed on the emacs-30
> branch (the fix will be merged to master in a couple of days).
> 
> Yuan, am I right?

Yeah, I fixed it yesterday on emacs-30, sorry for the hurdle guys. And thanks Noah for the patch.

Yuan

Message #16 received at 73832-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: noah.v.peart <at> gmail.com, 73832-done <at> debbugs.gnu.org
Subject: Re: bug#73832: [PATCH] Fix misplaced paren in
 c-ts-mode--anchor-prev-sibling
Date: Wed, 16 Oct 2024 12:03:46 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Tue, 15 Oct 2024 22:53:37 -0700
> Cc: Noah Peart <noah.v.peart <at> gmail.com>,
>  73832 <at> debbugs.gnu.org
> 
> 
> 
> > On Oct 15, 2024, at 10:36 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> >> It looks like a parenthesis was misplaced in the recent change to
> >> c-ts-mode--anchor-prev-sibling causing an infinite loop during
> >> indentation.
> > 
> > Thanks, this is bug#73661, which was recently fixed on the emacs-30
> > branch (the fix will be merged to master in a couple of days).
> > 
> > Yuan, am I right?
> 
> Yeah, I fixed it yesterday on emacs-30, sorry for the hurdle guys. And thanks Noah for the patch.

OK, closing.

Message #19 received at 73832 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 73832 <at> debbugs.gnu.org
Subject: Re: bug#73832: [PATCH] Fix misplaced paren in
 c-ts-mode--anchor-prev-sibling
Date: Wed, 16 Oct 2024 05:37:51 -0700

[Message part 1 (text/plain, inline)]

Thanks guys - sorry I missed the bug.

On Tue, Oct 15, 2024 at 10:53 PM Yuan Fu <casouri <at> gmail.com> wrote:

>
>
> > On Oct 15, 2024, at 10:36 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >> From: Noah Peart <noah.v.peart <at> gmail.com>
> >> Date: Tue, 15 Oct 2024 19:37:00 -0700
> >>
> >> Tags: patch
> >>
> >> It looks like a parenthesis was misplaced in the recent change to
> >> c-ts-mode--anchor-prev-sibling causing an infinite loop during
> >> indentation.
> >
> > Thanks, this is bug#73661, which was recently fixed on the emacs-30
> > branch (the fix will be merged to master in a couple of days).
> >
> > Yuan, am I right?
>
> Yeah, I fixed it yesterday on emacs-30, sorry for the hurdle guys. And
> thanks Noah for the patch.
>
> Yuan

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.