GNU bug report logs - #73827
[ELPA] [PATCH] register-list fails on "Unprintable entity" registers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Bochannek <alex <at> bochannek.com>
Subject: bug#73827: closed (Re: bug#73827: [ELPA] [PATCH] register-list
 fails on "Unprintable entity" registers)
Date: Thu, 13 Feb 2025 10:24:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73827 <at> debbugs.gnu.org.

-- 
73827: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73827
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 73827-done <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, Alex Bochannek <alex <at> bochannek.com>
Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable
 entity" registers
Date: Thu, 13 Feb 2025 02:23:02 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Jeremy Bryant <jb <at> jeremybryant.net> writes:
>
>> Alex Bochannek <alex <at> bochannek.com> writes:
>>
>>> Anything else that's needed from me here? I have another trivial fix for
>>> register-list I would like to submit.
>>
>> Thanks alex for your contribution.
>>
>> Adding Philip, any comments or suggestions on this short ELPA patch?
>
> Ping, Philip and/or Stefan M.

Actually, the patch was quite trivial, and there was already an LGTM, so
I went ahead and pushed it.

Feel free to revert, and so on.  Boldly closing this bug report.

Thanks Alex, for your contribution to Emacs.

[Message part 3 (message/rfc822, inline)]

From: Alex Bochannek <alex <at> bochannek.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers
Date: Tue, 15 Oct 2024 16:14:54 -0700

[Message part 4 (text/plain, inline)]

Hello!

I have not submitted patches against an ELPA package before, so I hope
this format is OK. I tried to follow the instruction on pulling ELPA
from Git, but the make step failed for me.

The register-list mode throws an error on start-up when there are
unknown register types in the register-alist. This can happen with
window configurations and saved session state after a restart. The
reason for this is a simple line flip in the register-list-get-type
function.

[Message part 5 (text/x-patch, inline)]

--- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~	2023-01-10 19:36:23
+++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el	2024-10-15 15:49:37
@@ -483,8 +483,8 @@
 	    (t "error"))
     (cond ((window-configuration-p (car key)) "W")
 	  ((frame-configuration-p (car key)) "F")
-	  ((stringp (car key)) "R")
 	  ((string= "Unprintable entity" (car key)) "?")
+	  ((stringp (car key)) "R")
 	  (t "error"))))
 
 ;;; Edit key/value of the register

[Message part 6 (text/plain, inline)]

Apologies again for the format of this submission. If someone could
point me at instructions for how to make your life easier next time, I'd
appreciate it.

Thanks!

-- 
Alex.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.