GNU bug report logs - #73827
[ELPA] [PATCH] register-list fails on "Unprintable entity" registers

Previous Next

Full log

Message #26 received at 73827 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 73827 <at> debbugs.gnu.org, Alex Bochannek <alex <at> bochannek.com>
Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable
 entity" registers
Date: Tue, 11 Feb 2025 19:04:06 -0500

>> @@ -483,8 +483,8 @@
>>  	    (t "error"))
>>      (cond ((window-configuration-p (car key)) "W")
>>  	  ((frame-configuration-p (car key)) "F")
>> -	  ((stringp (car key)) "R")
>>  	  ((string= "Unprintable entity" (car key)) "?")
>
> The change confuses me, are we sure that (car key) must be a string at
> this point?  If not, should be prefer `equal' over `string='?

The `string=` was wrong (if we get to that branch we know it's not
a string) and should be `equal`, indeed.  It's an orthogonal problem to
the one the OP is solving, tho.

The patch looks fine to me, tho I have no idea how desktop's
"Unprintable entity" can end up in this position: I think this points to
a bug elsewhere.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.