GNU bug report logs - #73820
31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73820 in the body.
You can then email your comments to 73820 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "jixiuf <at> qq.com" <jixiuf <at> qq.com>
To: bug-gnu-emacs <at> gnu.org
Cc: jixiuf <jixiuf <at> qq.com>
Subject: 31.0.50; [Feature Request]how to hide *Completions* buffer when
 icomplete-in-buffer is not nil 
Date: Tue, 15 Oct 2024 19:01:33 +0800

[Message part 1 (text/plain, inline)]

       
I would like to use `icomplete-mode`/`icomplete-vertical-mode` with

 (setq icomplete-in-buffer t)
 
 but I don't want to display the `*Completions*` buffer.
 
 How about adding a new value for `completion-auto-help` to achieve this?
 

[Screenshot_-2024-10-15-18:52:14.png (image/png, attachment)]

Message #8 received at 73820 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: "jixiuf <at> qq.com" <jixiuf <at> qq.com>
Cc: 73820 <at> debbugs.gnu.org
Subject: Re: bug#73820: 31.0.50; [Feature Request]how to hide *Completions*
 buffer when icomplete-in-buffer is not nil
Date: Tue, 15 Oct 2024 19:43:45 +0300

> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with
>
>  (setq icomplete-in-buffer t)
>
>  but I don't want to display the `*Completions*` buffer.
>
>  How about adding a new value for `completion-auto-help` to achieve this?

As suggested in https://debbugs.gnu.org/67661#114
this is currently achievable by

  (advice-add 'completion-at-point :after #'minibuffer-hide-completions)

But adding a new option is also an option.

Message #11 received at 73820 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Juri Linkov <juri <at> linkov.net>
Cc: 73820 <at> debbugs.gnu.org, "jixiuf <at> qq.com" <jixiuf <at> qq.com>
Subject: Re: bug#73820: 31.0.50; [Feature Request]how to hide *Completions*
 buffer when icomplete-in-buffer is not nil
Date: Wed, 16 Oct 2024 09:23:52 +0800

Hello,

On Tue 15 Oct 2024 at 07:43pm +03, Juri Linkov wrote:

>> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with
>>
>>  (setq icomplete-in-buffer t)
>>
>>  but I don't want to display the `*Completions*` buffer.
>>
>>  How about adding a new value for `completion-auto-help` to achieve this?
>
> As suggested in https://debbugs.gnu.org/67661#114
> this is currently achievable by
>
>   (advice-add 'completion-at-point :after #'minibuffer-hide-completions)
>
> But adding a new option is also an option.

Right.  This is also stated in NEWS.

-- 
Sean Whitton

Message #16 received at 73820-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: jixiuf <at> qq.com, 73820-done <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#73820: 31.0.50;
 [Feature Request]how to hide *Completions* buffer when
 icomplete-in-buffer is not nil
Date: Wed, 16 Oct 2024 08:33:12 +0300

> Cc: 73820 <at> debbugs.gnu.org, "jixiuf <at> qq.com" <jixiuf <at> qq.com>
> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Date: Wed, 16 Oct 2024 09:23:52 +0800
> 
> On Tue 15 Oct 2024 at 07:43pm +03, Juri Linkov wrote:
> 
> >> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with
> >>
> >>  (setq icomplete-in-buffer t)
> >>
> >>  but I don't want to display the `*Completions*` buffer.
> >>
> >>  How about adding a new value for `completion-auto-help` to achieve this?
> >
> > As suggested in https://debbugs.gnu.org/67661#114
> > this is currently achievable by
> >
> >   (advice-add 'completion-at-point :after #'minibuffer-hide-completions)
> >
> > But adding a new option is also an option.
> 
> Right.  This is also stated in NEWS.

If this is important enough, it should be in the doc string.  So I've
now added this tip to the doc string, and I'm therefore closing this
bug.

Thanks.

Message #19 received at 73820 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: 73820 <at> debbugs.gnu.org
Cc: Juri Linkov <juri <at> linkov.net>, eliz <at> gnu.org, jixiuf <at> qq.com,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#73820: 31.0.50; [Feature Request]how to hide *Completions*
 buffer when icomplete-in-buffer is not nil
Date: Wed, 16 Oct 2024 09:37:19 +0200

Hi,

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 73820 <at> debbugs.gnu.org, "jixiuf <at> qq.com" <jixiuf <at> qq.com>
>> From: Sean Whitton <spwhitton <at> spwhitton.name>
>> Date: Wed, 16 Oct 2024 09:23:52 +0800
>> 
>> On Tue 15 Oct 2024 at 07:43pm +03, Juri Linkov wrote:
>> 
>> >> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with
>> >>
>> >>  (setq icomplete-in-buffer t)
>> >>
>> >>  but I don't want to display the `*Completions*` buffer.
>> >>
>> >>  How about adding a new value for `completion-auto-help` to achieve this?
>> >
>> > As suggested in https://debbugs.gnu.org/67661#114
>> > this is currently achievable by
>> >
>> >   (advice-add 'completion-at-point :after #'minibuffer-hide-completions)
>> >
>> > But adding a new option is also an option.
>> 
>> Right.  This is also stated in NEWS.
>
> If this is important enough, it should be in the doc string.  So I've
> now added this tip to the doc string, and I'm therefore closing this
> bug.

Hmm, I'm not sure that that's really such a good recommendation.  Adding
this advice breaks M-: completion, for example.  I think a more refined
solution is due, if this is to be considered a supported use case...
Namely, I suggest implementing icomplete-in-buffer as a
completion-in-region-function, like some other in-buffer completion
frontends are implemented.


Best,

Eshel

Message #22 received at 73820 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: juri <at> linkov.net, 73820 <at> debbugs.gnu.org, jixiuf <at> qq.com,
 spwhitton <at> spwhitton.name
Subject: Re: bug#73820: 31.0.50; [Feature Request]how to hide *Completions*
 buffer when icomplete-in-buffer is not nil
Date: Wed, 16 Oct 2024 12:07:27 +0300

> From: Eshel Yaron <me <at> eshelyaron.com>
> Cc: eliz <at> gnu.org,  jixiuf <at> qq.com, Sean Whitton <spwhitton <at> spwhitton.name>,
>  Juri Linkov <juri <at> linkov.net>
> Date: Wed, 16 Oct 2024 09:37:19 +0200
> 
> >> Right.  This is also stated in NEWS.
> >
> > If this is important enough, it should be in the doc string.  So I've
> > now added this tip to the doc string, and I'm therefore closing this
> > bug.
> 
> Hmm, I'm not sure that that's really such a good recommendation.  Adding
> this advice breaks M-: completion, for example.  I think a more refined
> solution is due, if this is to be considered a supported use case...
> Namely, I suggest implementing icomplete-in-buffer as a
> completion-in-region-function, like some other in-buffer completion
> frontends are implemented.

Of course, a better solution, especially if it is not based on
advising functions, are always welcome.  But I'm guessing the solution
you have in mind is not for the release branch, though?

Message #25 received at 73820 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: juri <at> linkov.net, 73820 <at> debbugs.gnu.org, jixiuf <at> qq.com,
 spwhitton <at> spwhitton.name
Subject: Re: bug#73820: 31.0.50; [Feature Request]how to hide *Completions*
 buffer when icomplete-in-buffer is not nil
Date: Wed, 16 Oct 2024 11:36:05 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Eshel Yaron <me <at> eshelyaron.com>
>> Cc: eliz <at> gnu.org,  jixiuf <at> qq.com, Sean Whitton <spwhitton <at> spwhitton.name>,
>>  Juri Linkov <juri <at> linkov.net>
>> Date: Wed, 16 Oct 2024 09:37:19 +0200
>> 
>> >> Right.  This is also stated in NEWS.
>> >
>> > If this is important enough, it should be in the doc string.  So I've
>> > now added this tip to the doc string, and I'm therefore closing this
>> > bug.
>> 
>> Hmm, I'm not sure that that's really such a good recommendation.  Adding
>> this advice breaks M-: completion, for example.  I think a more refined
>> solution is due, if this is to be considered a supported use case...
>> Namely, I suggest implementing icomplete-in-buffer as a
>> completion-in-region-function, like some other in-buffer completion
>> frontends are implemented.
>
> Of course, a better solution, especially if it is not based on
> advising functions, are always welcome.  But I'm guessing the solution
> you have in mind is not for the release branch, though?

Right, it'd probably be too big of a change to make it into Emacs 30.

Message #28 received at 73820 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: eliz <at> gnu.org, 73820 <at> debbugs.gnu.org, jixiuf <at> qq.com,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#73820: 31.0.50; [Feature Request]how to hide *Completions*
 buffer when icomplete-in-buffer is not nil
Date: Wed, 16 Oct 2024 18:13:41 +0800

Hello,

On Wed 16 Oct 2024 at 09:37am +02, Eshel Yaron wrote:

> Hmm, I'm not sure that that's really such a good recommendation.  Adding
> this advice breaks M-: completion, for example.  I think a more refined
> solution is due, if this is to be considered a supported use case...
> Namely, I suggest implementing icomplete-in-buffer as a
> completion-in-region-function, like some other in-buffer completion
> frontends are implemented.

If you were to look into that change, I would be very happy to review.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.