GNU bug report logs - #73817
29.4; Docstring for math-approx-sqrt-e is wrong

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73817 in the body.
You can then email your comments to 73817 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Mattias Engdegård <mattiase <at> acm.org>
Subject: 29.4; Docstring for math-approx-sqrt-e is wrong
Date: Tue, 15 Oct 2024 14:17:21 +0200

[Message part 1 (text/plain, inline)]

math-approx-sqrt-e is a variable defined in ‘calc-ext.el’.

Its value is (float 1648721270700128146849 -21)

An approximation for sqrt(3).

  This variable may be risky if used as a file-local variable.


Obviously this should be sqrt(e) = 1.648..., whereas sqrt(3) = 1.732...

OK to push attached patch to the emacs-30 branch, or should it go to
master?

[0001-lisp-calc-calc-ext.el-math-approx-sqrt-e-Doc-fix.patch (text/plain, inline)]

From ec01569490f2df9999925d4471e627a6370606eb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm <at> gentoo.org>
Date: Tue, 15 Oct 2024 14:06:49 +0200
Subject: [PATCH] * lisp/calc/calc-ext.el (math-approx-sqrt-e): Doc fix.

---
 lisp/calc/calc-ext.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/calc/calc-ext.el b/lisp/calc/calc-ext.el
index 191149892a8..25d2492b277 100644
--- a/lisp/calc/calc-ext.el
+++ b/lisp/calc/calc-ext.el
@@ -2069,7 +2069,7 @@ math-sqrt-two-pi
 
 (defconst math-approx-sqrt-e
   (math-read-number-simple "1.648721270700128146849")
-  "An approximation for sqrt(3).")
+  "An approximation for sqrt(e).")
 
 (math-defcache math-sqrt-e math-approx-sqrt-e
   (math-add-float '(float 1 0) (math-exp-minus-1-raw '(float 5 -1))))
-- 
2.47.0

Message #8 received at 73817 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ulrich Mueller <ulm <at> gentoo.org>
Cc: mattiase <at> acm.org, 73817 <at> debbugs.gnu.org
Subject: Re: bug#73817: 29.4; Docstring for math-approx-sqrt-e is wrong
Date: Tue, 15 Oct 2024 16:07:20 +0300

> Cc: Mattias Engdegård <mattiase <at> acm.org>
> From: Ulrich Mueller <ulm <at> gentoo.org>
> Date: Tue, 15 Oct 2024 14:17:21 +0200
> 
> math-approx-sqrt-e is a variable defined in ‘calc-ext.el’.
> 
> Its value is (float 1648721270700128146849 -21)
> 
> An approximation for sqrt(3).
> 
>   This variable may be risky if used as a file-local variable.
> 
> 
> Obviously this should be sqrt(e) = 1.648..., whereas sqrt(3) = 1.732...
> 
> OK to push attached patch to the emacs-30 branch, or should it go to
> master?

Please install on emacs-30 (documentation changes are always okay on
the release branch).

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.