From unknown Mon Jun 23 02:20:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73804 <73804@debbugs.gnu.org> To: bug#73804 <73804@debbugs.gnu.org> Subject: Status: [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input. Reply-To: bug#73804 <73804@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:20:16 +0000 retitle 73804 [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input. reassign 73804 guix-patches submitter 73804 aurtzy severity 73804 normal tag 73804 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 13:51:01 2024 Received: (at submit) by debbugs.gnu.org; 14 Oct 2024 17:51:01 +0000 Received: from localhost ([127.0.0.1]:44031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0PDg-0004yg-Ou for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:51:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:41520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0PDf-0004yX-1B for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:50:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0PDM-0006PP-Vx for guix-patches@gnu.org; Mon, 14 Oct 2024 13:50:41 -0400 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0PDK-0001ri-3X for guix-patches@gnu.org; Mon, 14 Oct 2024 13:50:40 -0400 Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-835496c8d6fso267210539f.0 for ; Mon, 14 Oct 2024 10:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728928234; x=1729533034; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LDf00oRTKrY7T+oZW3KhjdNBvWUbTZ18VyNxiHADh9Q=; b=RaQ7j1e/eN3nvJ6lsG7frLdFm0glR6FMYj0cl2SqPicZThsO4+VNqT02i+KngNlrhN uGiBWqXiNObUvbfOcMMMeYUS03aUZNCqVkvddE35pEGR7buDylnDdhYCIMEmkSAqqD84 QlGqNvGDWDqjC4Nags5QbiMiMbkk6TUg1L6ebYrUpr35BO33XCm8RRVGmlM0xFuytKc2 OaZQ0zYweREKPillqyPSEymBKykfS8FYIpWdA/ZLRjB0TypQ4VXfrm0zT2svcCMwFFtU ZrGCATBd8bif2y6+5co7wzhDtPMpicv/x47xi8J2gxia96UcuuMi+YHiuXhkNpQV51Ws IyzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728928234; x=1729533034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LDf00oRTKrY7T+oZW3KhjdNBvWUbTZ18VyNxiHADh9Q=; b=kQnLu46NJRbFMllVtS4DRHL0cDUjPtbCg2dmsfmNpL3Vidk8cHKgfc9//xBDoRwdII pk1S11eQHBiTuXqHf6cWYLyHnq9Z8Qkub+l1NwknPogqqXAX0yKZfCvOL6Ujarp6qI0y obIxsiysXOYKdfPDXWTWrtnxWW9k78pDslgGQiPLGyaMKkM2p5AjphxkqcmV8rqn9J0y dzBLfFjSoqNu6YL73AHuFzUyxmgiY6H1sd0/cnZCwrvZPVosYAI8krmi2Xz0dGsOMVS6 uraN1dMKyq58dPHwk0cNl8GJUl1xkOhL9J+GiAL1YdgFDEvI+PpqRdDF2HeejE0dOLEG DWCA== X-Gm-Message-State: AOJu0YxlkMQLjp22duEqIeUOFuFQOKCP2dfvlFtCGjko/h71+GHCJJ4O FRrvBIdtrdN7mlk5U8j8HbhIBNUhhtZWpm/qvcNse74zY44wjoky6mZhJg== X-Google-Smtp-Source: AGHT+IGKvqxAN4UQ5GMUOeeAUbXyHWhtxL15YKgRm92Q/OxatDssR1FSfIFZ2CinGkMOHnc1LUq1/A== X-Received: by 2002:a05:6602:3426:b0:82c:ee6d:a7ee with SMTP id ca18e2360f4ac-83a64cb6568mr499418339f.2.1728928233909; Mon, 14 Oct 2024 10:50:33 -0700 (PDT) Received: from localhost.localdomain ([2600:4808:a053:7600::e413]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbe7c2c951sm3323212173.28.2024.10.14.10.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 10:50:32 -0700 (PDT) From: aurtzy To: guix-patches@gnu.org Subject: [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input. Date: Mon, 14 Oct 2024 13:46:19 -0400 Message-ID: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::d31; envelope-from=aurtzy@gmail.com; helo=mail-io1-xd31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: aurtzy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This remedies an issue where applications like systemsettings and plasma-discover do not completely respect theming (e.g. when dark theme is enabled), with the following notable error message: kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" * gnu/packages/kde-frameworks.scm (qqc2-desktop-style)[inputs]: Add kcolorscheme to fix a theming issue. [arguments]<#:tests?>: Disable failing tests introduced by adding the kcolorscheme input. Change-Id: Ic34da2a2fc788737e543eb3cd2b23edf85a736a4 --- Hi! According to 'guix refresh --list-dependents qqc2-desktop-style', there are 18 dependent packages. I haven't noticed any visible regressions with this change running Plasma, and I can confirm theming in at least systemsettings and plasma-discover is fixed by the change. However, adding kcolorscheme as an input causes the check phase to fail (log included at the end). This appears to be due to tests that are enabled when kcolorscheme is added, one of which fails. The D-Bus error message is present in the current and patched version. I've tried setting the HOME and XDG_CACHE_HOME environment variables as it's done in other Qt/KDE packages, which has some effect on the tests but still results in failure. The Nix packages seem to reveal a partially circular dependency between qqc2-desktop-style and kirigami [1] [2]; I wonder if this is related to the issue? Here's the check phase log: --8<---------------cut here---------------start------------->8--- D-Bus library appears to be incorrectly set up: see the manual page for dbus-uuidgen to correct this issue. (Failed to open "/var/lib/dbus/machine-id": No such file or directory; Failed to open "/etc/machine-id": No such file or directory) Test project /tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/build Start 1: animationspeedmodifiertest 1/2 Test #1: animationspeedmodifiertest .......***Failed 0.11 sec ********* Start testing of IntegrationTest ********* Config: Using QtTest library 6.6.3, Qt 6.6.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.4.0), unknown unknown QWARN : IntegrationTest::initTestCase() kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" PASS : IntegrationTest::initTestCase() QWARN : IntegrationTest::testAnimationSpeedModifier_kconfig() kf.config.core: Couldn't create a new file: "/homeless-shelter/.qttest/config/kdeglobals" . Error: "No such file or directory" FAIL! : IntegrationTest::testAnimationSpeedModifier_kconfig() 'kdeGroup.sync()' returned FALSE. () Loc: [/tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/qqc2-desktop-style-6.5.0/kirigami-plasmadesktop-integration/autotests/animationspeedmodifiertest.cpp(69)] PASS : IntegrationTest::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 26ms ********* Finished testing of IntegrationTest ********* Fontconfig error: No writable cache directories Fontconfig error: No writable cache directories Start 2: TextFieldContextMenuTest 2/2 Test #2: TextFieldContextMenuTest ......... Passed 3.12 sec 50% tests passed, 1 tests failed out of 2 Total Test time (real) = 3.23 sec The following tests FAILED: 1 - animationspeedmodifiertest (Failed) --8<---------------cut here---------------end--------------->8--- [1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/kirigami/default.nix [2] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/qqc2-desktop-style/default.nix Cheers, aurtzy gnu/packages/kde-frameworks.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 974fd1c4dd..e7c8eef775 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -1971,6 +1971,7 @@ (define-public qqc2-desktop-style (build-system qt-build-system) (arguments (list + #:tests? #f ; FIXME: 1/2 tests fail. #:qtbase qtbase #:phases #~(modify-phases %standard-phases (replace 'check @@ -1982,6 +1983,7 @@ (define-public qqc2-desktop-style (list extra-cmake-modules dbus pkg-config qttools)) (inputs (list kauth + kcolorscheme kconfig ; optional kcoreaddons kiconthemes ; optional base-commit: 5a77f79764ccc01eb545e55027d0147e64a81952 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 01:36:09 2024 Received: (at 73804-done) by debbugs.gnu.org; 15 Oct 2024 05:36:09 +0000 Received: from localhost ([127.0.0.1]:52473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0aE5-000479-2X for submit@debbugs.gnu.org; Tue, 15 Oct 2024 01:36:09 -0400 Received: from smtp84.cstnet.cn ([159.226.251.84]:35650 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0aE1-00046I-86 for 73804-done@debbugs.gnu.org; Tue, 15 Oct 2024 01:36:07 -0400 Received: from m (unknown [107.174.64.25]) by APP-05 (Coremail) with SMTP id zQCowAAnL_Mf_w1nVcecBw--.63987S2; Tue, 15 Oct 2024 13:35:34 +0800 (CST) From: Zheng Junjie To: aurtzy Subject: Re: [bug#73804] [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input. In-Reply-To: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> (aurtzy@gmail.com's message of "Mon, 14 Oct 2024 13:46:19 -0400") References: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> Date: Tue, 15 Oct 2024 13:35:10 +0800 Message-ID: <87zfn63p4h.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: zQCowAAnL_Mf_w1nVcecBw--.63987S2 X-Coremail-Antispam: 1UD129KBjvJXoWxZF45Kw15Cw18tFWfGryUJrb_yoW7Jr15pr s3tr1agFZ2kFWktwn2qa1v9F1Yqr98GF1UGw4DAr18t3s09FyUZFZIgF48XFW3JrZrZa43 uF4rKrW7W34vyrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvGb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwV C2z280aVCY1x0267AKxVWxJr0_GcWlnx0Ee4C267I2x7xF54xIwI0E7I0Y6sxI4wAS0I0E 0xvYzxvE52x082IY62kv0487M2AExVA0xI801c8C04v7Mc02F40EFcxC0VAKzVAqx4xG6I 80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCj c4AY6r1j6r4UM4x0Y48IcVAKI48JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r 1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CE b7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0x vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAI cVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa 73UjIFyTuYvjxU6cdbDUUUU X-Originating-IP: [107.174.64.25] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73804-done Cc: 73804-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain aurtzy writes: > This remedies an issue where applications like systemsettings and > plasma-discover do not completely respect theming (e.g. when dark theme is > enabled), with the following notable error message: > > kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" > > * gnu/packages/kde-frameworks.scm (qqc2-desktop-style)[inputs]: Add > kcolorscheme to fix a theming issue. > [arguments]<#:tests?>: Disable failing tests introduced by adding the > kcolorscheme input. > > Change-Id: Ic34da2a2fc788737e543eb3cd2b23edf85a736a4 > --- > > Hi! > > According to 'guix refresh --list-dependents qqc2-desktop-style', there > are 18 dependent packages. > > I haven't noticed any visible regressions with this change running > Plasma, and I can confirm theming in at least systemsettings and > plasma-discover is fixed by the change. However, adding kcolorscheme as > an input causes the check phase to fail (log included at the end). This > appears to be due to tests that are enabled when kcolorscheme is added, > one of which fails. > > The D-Bus error message is present in the current and patched > version. I've tried setting the HOME and XDG_CACHE_HOME environment > variables as it's done in other Qt/KDE packages, which has some effect > on the tests but still results in failure. The Nix packages seem to > reveal a partially circular dependency between qqc2-desktop-style and > kirigami [1] [2]; I wonder if this is related to the issue? > > Here's the check phase log: > > --8<---------------cut here---------------start------------->8--- > D-Bus library appears to be incorrectly set up: see the manual page for dbus-uuidgen to correct this issue. (Failed to open "/var/lib/dbus/machine-id": No such file or directory; Failed to open "/etc/machine-id": No such file or directory) > Test project /tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/build > Start 1: animationspeedmodifiertest > 1/2 Test #1: animationspeedmodifiertest .......***Failed 0.11 sec > ********* Start testing of IntegrationTest ********* > Config: Using QtTest library 6.6.3, Qt 6.6.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.4.0), unknown unknown > QWARN : IntegrationTest::initTestCase() kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" > PASS : IntegrationTest::initTestCase() > QWARN : IntegrationTest::testAnimationSpeedModifier_kconfig() kf.config.core: Couldn't create a new file: "/homeless-shelter/.qttest/config/kdeglobals" . Error: "No such file or directory" > FAIL! : IntegrationTest::testAnimationSpeedModifier_kconfig() 'kdeGroup.sync()' returned FALSE. () > Loc: [/tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/qqc2-desktop-style-6.5.0/kirigami-plasmadesktop-integration/autotests/animationspeedmodifiertest.cpp(69)] > PASS : IntegrationTest::cleanupTestCase() > Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 26ms > ********* Finished testing of IntegrationTest ********* > Fontconfig error: No writable cache directories > Fontconfig error: No writable cache directories > > Start 2: TextFieldContextMenuTest > 2/2 Test #2: TextFieldContextMenuTest ......... Passed 3.12 sec > > 50% tests passed, 1 tests failed out of 2 > > Total Test time (real) = 3.23 sec > > The following tests FAILED: > 1 - animationspeedmodifiertest (Failed) > --8<---------------cut here---------------end--------------->8--- > > [1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/kirigami/default.nix > > [2] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/qqc2-desktop-style/default.nix > > Cheers, > > aurtzy > > gnu/packages/kde-frameworks.scm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm > index 974fd1c4dd..e7c8eef775 100644 > --- a/gnu/packages/kde-frameworks.scm > +++ b/gnu/packages/kde-frameworks.scm > @@ -1971,6 +1971,7 @@ (define-public qqc2-desktop-style > (build-system qt-build-system) > (arguments > (list > + #:tests? #f ; FIXME: 1/2 tests fail. > #:qtbase qtbase > #:phases #~(modify-phases %standard-phases > (replace 'check > @@ -1982,6 +1983,7 @@ (define-public qqc2-desktop-style > (list extra-cmake-modules dbus pkg-config qttools)) > (inputs > (list kauth > + kcolorscheme > kconfig ; optional > kcoreaddons > kiconthemes ; optional > > base-commit: 5a77f79764ccc01eb545e55027d0147e64a81952 Thanks!. push. And i add a commit to fix tests, move check phase after install, and Set QML_IMPORT_PATH, QT_PLUGIN_PATH,HOME environment variables. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmcN/w4ACgkQO1qpk+Gi 3/BoHRAAnpyHxYpEXV2bH3xhjfm7t3cpez3CcercMl1uBtUGDkI+54ibTpxeye0a HnrpggnQ+FaEgkLP2h5/FVkRS/kwC7UcHoe6ZYX8i3slo9Fbwf74tps16a4hQgRb v2NBj/2d78g1ce5/uFACBsGc4GUiAy+4VTiD/Yu3C1mpZrTdhaZJRCj8HQk7Vqdb Km63U9VegCmtEMIrL/pqncBENkUkiSFow7LguFIUyIrtMO5ZQ9ExXS2PBkOHQy9N yKp85E/vVsbbl/ktEsVur4bYYlOIwR72+xRgnMRTZFi7pKGTQox4OFt+8Iv0o6Ip aO7iR/ki29cfB8YJv0JOpYhSVlJHHZvPpFBAEAPaqMWvyEAzp5ZfQuQfvGD32Bjy qf9+OkgO+vEhosPWATzOdF/sZfTgdfi+WU5BtUcRN+5C2yigiMUZ2fMwC/fUG4w3 66Cxpxfdk0odUH065cevfjaMXGYgwAdkoADjPo7Eq2+6bA8X/4bTy4Q3fJOxdUDC wAbcBDMCE7LhJKJLpVmb7/4EFkiYZkBBn7QLvGOhbrTHPi+XTQ76cpeCf4SU+jji Y+gtC0XdttnSy3MvOKFi7MZcgQTz0G2aC4wrElmCK/3u9HIjQCTARnKkh69rmVoR tU58h5xC4g3g2tC1NcgHuKpU7ec2ZvXFvLfM2NYmCStL+ioPn7I= =LTd/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 02:20:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 12 Nov 2024 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator