GNU bug report logs - #73779
30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version.

Previous Next

Full log

Message #22 received at 73779-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 73779-done <at> debbugs.gnu.org
Subject: Re: bug#73779: 30.0.91;
 [PATCH] php-ts-mode: Better indentation and font locking,
 support for the latest grammar version.
Date: Sat, 19 Oct 2024 16:13:43 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 73779 <at> debbugs.gnu.org
> Date: Sat, 19 Oct 2024 14:13:33 +0200
> 
> > I was about to install this, but byte-compiling the modified file
> > yields the following warnings:
> > 
> >     ELC      progmodes/php-ts-mode.elc
> > 
> >   In php-ts-mode--open-statement-group-heuristic:
> >   progmodes/php-ts-mode.el:435:58: Warning: Unused lexical argument `parent'
> > progmodes/php-ts-mode.el:499:50: Warning: argument `_bol' not left unused
> > progmodes/php-ts-mode.el:518:56: Warning: argument `_bol' not left unused
> > 
> > Could you please fix these and resubmit the patch?
> 
> Sorry Eli, it's okay now.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.