GNU bug report logs - #73779
30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Subject: bug#73779: closed (Re: bug#73779: 30.0.91; [PATCH] php-ts-mode:
 Better indentation and font locking, support for the latest grammar
 version.)
Date: Sat, 19 Oct 2024 13:17:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73779 <at> debbugs.gnu.org.

-- 
73779: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73779
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 73779-done <at> debbugs.gnu.org
Subject: Re: bug#73779: 30.0.91;
 [PATCH] php-ts-mode: Better indentation and font locking,
 support for the latest grammar version.
Date: Sat, 19 Oct 2024 16:13:43 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 73779 <at> debbugs.gnu.org
> Date: Sat, 19 Oct 2024 14:13:33 +0200
> 
> > I was about to install this, but byte-compiling the modified file
> > yields the following warnings:
> > 
> >     ELC      progmodes/php-ts-mode.elc
> > 
> >   In php-ts-mode--open-statement-group-heuristic:
> >   progmodes/php-ts-mode.el:435:58: Warning: Unused lexical argument `parent'
> > progmodes/php-ts-mode.el:499:50: Warning: argument `_bol' not left unused
> > progmodes/php-ts-mode.el:518:56: Warning: argument `_bol' not left unused
> > 
> > Could you please fix these and resubmit the patch?
> 
> Sorry Eli, it's okay now.

Thanks, installed on the emacs-30 branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking,
 support for the latest grammar version.
Date: Sat, 12 Oct 2024 22:12:30 +0200

[Message part 4 (text/plain, inline)]

Ciao,
this patch corrects the indentation of the control structure without closing 
brackets (or without the end keyword... in the case of the alternative 
syntax). It supports font locking of the “asymmetric property visibility ” 
introduced with grammar v0.23.3 and so-called magic methods. And others small 
fix. And others small bug I discovered while writing the tests..

Thank you.
Vincenzo

[0001-Fix-php-ts-mode-better-indentation-and-font-locking.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.