From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 12:40:17 2024 Received: (at submit) by debbugs.gnu.org; 12 Oct 2024 16:40:17 +0000 Received: from localhost ([127.0.0.1]:53098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfA5-0003KO-5J for submit@debbugs.gnu.org; Sat, 12 Oct 2024 12:40:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:46146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szeLH-00085T-V6 for submit@debbugs.gnu.org; Sat, 12 Oct 2024 11:47:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szeL3-0001Vr-57 for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 11:47:29 -0400 Received: from mout.gmx.net ([212.227.15.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szeKz-000386-Dc for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 11:47:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1728748040; x=1729352840; i=stephen.berman@gmx.net; bh=nxWy5pgsm/qDaxilb1x4dUtxLp/koZr/kayuELL2AHk=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=cjG46YRjM60+1q6q/OkkLfG1aBKTNIByjHReRwzfT+9+YUQTW5IxFTpp9x2vVvoa 4ltwN19GiWktsT8ss57rotHuexOgG/uP2iz827QaqZ4nSmNUa5U2uU1ysbK5FB3Q7 mVWKpM7RRR+E7GBj9IYRAuSEkmrek1zQocczVw214UhakE8uC0WjsTcHSoAMuU1jL wFgjgYrLY0kdWPFQ+y8r4voscN4xyPrILlL3ta/t3qrrG8mjuELvIZX3P9/cmw9Yp p/duV0dEmH2jBen/+MkCarAzYAFJ7xzPYGqKvtADXK41uUi+6QWcq6X22933NSW2l kmQeJuYCJbDY1Nb8Aw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([88.130.49.41]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MoO6M-1tjibY1l4C-00klaR for ; Sat, 12 Oct 2024 17:47:20 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 31.0.50; void-variable subword-mode in python-mode X-Debbugs-Cc: Date: Sat, 12 Oct 2024 17:47:20 +0200 Message-ID: <87r08ltjav.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:t9qO/VIgOrp3uwgPJ2bjNTiObqsZsBVUucW2h/+u1GtuqsR6Pq4 u8GAk6kLwvA2v/MEC0/ll0UpcAlI6otLGzVzl97d1SSYRtpQyK67EAJ4iIVeZhOKf4RNrtR 9fRQAoMZZ4fvYii2miYokDrk/Kt2l18ATN8ROuNkgt4/pw0juwm0bPo6WlFHm6OTPhSsB61 NdvYF8QsD0eajQ6lpMMsQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HIs1EX2PJlk=;G3mJ5ee4KoDjupFsXNpXorbIsHA lzRxzhmM7AJxYrAlLcjwSntbzCs0TEpm2uZLQ9bRWQXzKPrqYr6BFzVVgC3u4h5V+vRD6D0av bucw96bhmTgn+MIT+89b3CsiaizBAkaH55uCPT/5i+BaO+ej7cRitqJHD6R8sA5+3zHxXq8ID 5eVMe9KQ8vW6HSqcquqltxzhaJD7s7hiev9FU+HVrPPZ7bfVB7Sx0TXBBOKJ4aikIvyEqO/vf 1/Y51ek7ZwCBOo0tpiCdYfPRh5Tx/aoULs9SlUfO2fK8iD39xS3gB38VLz3IkeF7n4+cUEsLZ pT5aAZrVo8wGkdJ2jB1U0VBG/W4hQiwgLkzDNk2USXs7WYMZoCMfAaI2zkePYVtj02smHNHuD iBVyVZZ0pADkbZK6aU/JfJJhPfaSKhSRVV12FF4dADnDxb+zTqG7S83O+nBZj2lSuNnkxJ4lH kmG5rokywp95z8vu3m7PjC/j/IeUyP5bEM9n5d3cCvbAaS16QJ9DUOTwKUdYmRtQk5jWu5LnS P0PKshewdlnCqX/kZKJ59nCHYRdXjd0QlyxP4T48ykeGYxFV8u5VanTmKeOPOvEGxT9/QmXTw y3xkCI2vHQWm2o/cabm+jGqrsG1y7eUT2IRQPe91Aw/+KUMQ4/s6+y4OHp4w1Z+O8BJFn5gBy rZT7B/or5fgcoqksmKjl4DPU3iyamVsFwF67LSB3oieGkaAh/I3Pw/j3odq0ylI4fNlbnwDwx KgRAif1NWZE9gLi8xJvEEwCxxEV+Q+d+IkO02ZXskmE650FzVNv5wbKHrHiOenC/5D8sKoikq GSvfv0YfFs1MQH5c6Pd9uDfXUHGslQ6/p945u7rEZvRT0= Received-SPF: pass client-ip=212.227.15.15; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 0. emacs -Q 1. M-x menu-bar-mode (disable menu bar) 3. Visit a file in python-mode, e.g. modules/modhelp.py in the Emacs sources. 4. Pressing or C-mouse-3 pops up the global menu as usual. 5. M- [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.49.41 listed in zen.spamhaus.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.51.188.17 listed in sa-accredit.habeas.com] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.51.188.17 listed in bl.score.senderscore.com] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 0. emacs -Q 1. M-x menu-bar-mode (disable menu bar) 3. Visit a file in python-mode, e.g. modules/modhelp.py in the Emacs sources. 4. Pressing or C-mouse-3 pops up the global menu as usual. 5. M- [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.51.188.17 listed in sa-trusted.bondedsender.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.49.41 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.51.188.17 listed in bl.score.senderscore.com] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable 0. emacs -Q 1. M-x menu-bar-mode (disable menu bar) 3. Visit a file in python-mode, e.g. modules/modhelp.py in the Emacs sources. 4. Pressing or C-mouse-3 pops up the global menu as usual. 5. M-x toggle-debug-on-error 6. Now pressing or C-mouse-3 does not pop up the global menu but instead a *Backtrace* buffer pops open displaying "Lisp error: (void-variable subword-mode)". This is due to the following commit: commit 29a760711731ce49965079e72d76b26ef3b7bcb4 Author: Stefan Kangas AuthorDate: Sat Sep 21 14:07:29 2024 +0200 Commit: Stefan Kangas CommitDate: Sat Sep 21 14:08:09 2024 +0200 Add subword-mode toggle to python-mode menu * lisp/progmodes/python.el (python-mode-map): Add subword-mode toggle to menu. The attached patch fixes this problem. In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2) of 2024-10-12 built on strobelfssd Repository revision: c3600916b6942b2a9797ec2248d29cb337c7c6fa Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: Linux From Scratch r12.2-17-systemd Configured using: 'configure -C 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt6/lib/pkgconfig= ' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable Content-Description: python.el patch for subword-mode diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index 812e28268c2..4e3b18a327b 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -361,6 +361,11 @@ python-mode-map ;; Utilities " " #'completion-at-point) =20 +;; Define this so invoking menu-bar-open in a python-mode buffer does +;; not cause a void-variable error when subword-mode is not loaded, +;; menu-bar-mode is disabled and debug-on-error is enabled (bug#xxx). +(defvar subword-mode nil) + (easy-menu-define python-menu python-mode-map "Menu used for =C2=B4python-mode'." '("Python" --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 13 05:18:55 2024 Received: (at 73773) by debbugs.gnu.org; 13 Oct 2024 09:18:55 +0000 Received: from localhost ([127.0.0.1]:50186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szukY-0005ZF-RP for submit@debbugs.gnu.org; Sun, 13 Oct 2024 05:18:55 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:49152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szukX-0005Z5-2n for 73773@debbugs.gnu.org; Sun, 13 Oct 2024 05:18:54 -0400 Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c95a962c2bso1593576a12.2 for <73773@debbugs.gnu.org>; Sun, 13 Oct 2024 02:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728811057; x=1729415857; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=w9yKUeF/nNotRdO273c+EGkhoZqQ4Olm2MZstsQ/9yc=; b=AahvcQpDwrBt0EJqW61nnA2v8AfUKDgGVofz2Iw85BalzWE0KurMju0dVKa3EyRsDS BsoxIFgYx4rchL+jpEqkd3zuZIMc/foKMiUiW+mIvPFAVcT0F6QtlyKBN0JiQvR0Cko7 JgEc7o9f0uekMlvNHetYxwpqQLncoX5yMeSb9u3Dgv4rC3pQKZZYgVdgiIwgInz3MVQz wbp+Dpln/Z6gklbZiNLEK9k/wvOxTqzwNRl5E1Pq598ajDXFF+dJ8ZlEWnIpFHsinocO dLiyqttYPffpBlx74f8WkHEZ72q0WYbMPFGqQZniK5EMy+ez0ytw2xEcdrrBrr1Et7B0 /eMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728811057; x=1729415857; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=w9yKUeF/nNotRdO273c+EGkhoZqQ4Olm2MZstsQ/9yc=; b=rjzPGGrVPXMqa3nVp9Pvt11sTo/5S+V1JUh3PjZrOhz+uFn+PfJp0EFmUcI1pNRAht 8CdNQ2dXRM9l1SdLOEiX3GGaYMdCa1qHQG/8aMfouw463bb0rMh84vY6ftlzG42ZBban ev+eZMNbwC1vFMlQP4m4WdMPfDaVcIhdL/dEzfjwJiOIWLFgAA0mL937NB59RxzC5TTD wF84YVcOGSikPg1O+BBgZqgmDigjAQw/nEWPxwCiB3xXpDP3EZ1UjWIJSZWUEBA7fHML O5vomGfS2Th2tudsgopYMBiILmcJ2So5DXU1utGmQSxKHVwhAaz8Q7Ss5Rtk26+GlxWo mNdw== X-Gm-Message-State: AOJu0YxSKpKGseBf1bq2OqP97FH/hhMvyZVji3JMz5uv5C4AqLp2EQ0t xelqI7FWxBYGstq2qLncQOVkM/QlZT1A1vdyoB0pbGVVdc+JUdlg7mVeobtvCW6pgRMu41tnhut wA5kxNJcLtdpSHDaI87cGVMsEx20= X-Google-Smtp-Source: AGHT+IGxp+ADLoRh5K4w9u8e51M/MfzlBL00GviVqXNXJ6/FbpcYLWOFLPuCaz4f+HzYLDkQI5hjoO0VzpFXaUgrGg4= X-Received: by 2002:a05:6402:524a:b0:5c8:bdbe:33a6 with SMTP id 4fb4d7f45d1cf-5c948dac3e9mr5496735a12.31.1728811056946; Sun, 13 Oct 2024 02:17:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 13 Oct 2024 09:17:36 +0000 From: Stefan Kangas In-Reply-To: <87r08ltjav.fsf@gmx.net> (Stephen Berman's message of "Sat, 12 Oct 2024 17:47:20 +0200") References: <87r08ltjav.fsf@gmx.net> MIME-Version: 1.0 Date: Sun, 13 Oct 2024 09:17:36 +0000 Message-ID: Subject: Re: bug#73773: 31.0.50; void-variable subword-mode in python-mode To: Stephen Berman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73773 Cc: 73773@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > 0. emacs -Q > 1. M-x menu-bar-mode (disable menu bar) > 3. Visit a file in python-mode, e.g. modules/modhelp.py in the Emacs > sources. > 4. Pressing or C-mouse-3 pops up the global menu as usual. > 5. M-x toggle-debug-on-error > 6. Now pressing or C-mouse-3 does not pop up the global menu but > instead a *Backtrace* buffer pops open displaying "Lisp error: > (void-variable subword-mode)". > > This is due to the following commit: > > commit 29a760711731ce49965079e72d76b26ef3b7bcb4 > Author: Stefan Kangas > AuthorDate: Sat Sep 21 14:07:29 2024 +0200 > Commit: Stefan Kangas > CommitDate: Sat Sep 21 14:08:09 2024 +0200 > > Add subword-mode toggle to python-mode menu > > * lisp/progmodes/python.el (python-mode-map): Add subword-mode > toggle to menu. > > The attached patch fixes this problem. > > > In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.43, cairo version 1.18.2) of 2024-10-12 built on strobelfssd > Repository revision: c3600916b6942b2a9797ec2248d29cb337c7c6fa > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.1210101= 3 > System Description: Linux From Scratch r12.2-17-systemd > > Configured using: > 'configure -C 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt6/lib/pkgconfi= g' > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG > LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG > RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER > WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index 812e28268c2..4e3b18a327b 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -361,6 +361,11 @@ python-mode-map > ;; Utilities > " " #'completion-at-point) > > +;; Define this so invoking menu-bar-open in a python-mode buffer does > +;; not cause a void-variable error when subword-mode is not loaded, > +;; menu-bar-mode is disabled and debug-on-error is enabled (bug#xxx). > +(defvar subword-mode nil) > + > (easy-menu-define python-menu python-mode-map > "Menu used for =C2=B4python-mode'." > '("Python" Thanks, LGTM. I would move the comment to the commit message though. Please install when you can. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 13 05:33:05 2024 Received: (at 73773-done) by debbugs.gnu.org; 13 Oct 2024 09:33:05 +0000 Received: from localhost ([127.0.0.1]:50240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szuyH-0006QC-2F for submit@debbugs.gnu.org; Sun, 13 Oct 2024 05:33:05 -0400 Received: from mout.gmx.net ([212.227.15.18]:35205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szuyE-0006Pf-7Q for 73773-done@debbugs.gnu.org; Sun, 13 Oct 2024 05:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1728811960; x=1729416760; i=stephen.berman@gmx.net; bh=X8WbWknX7acuybUs1RBCop8r/Z8H5PxggR9HKLykv+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=W1G9v6OAKxnOYr5pEhPzR/xDAp6QQ0I/ZfoSP14nXJmTKpxKVLOtiOGbGhAZ0Oip 5ozHsWOHB9laDs/E6Yie/8yUFYqRlUBVs4sfNG+/F+EkonNhI9Ctn25wfQS9giUdm o7x79w8UWayRHYd1wfteVhcUPDOMjKxBylu7tsyULa7PanivA6FfavgJJQpXr48R+ 5WQofkKXqnAKvlKnnPk19oTIb7X04vBGH97LeyVPxUddgYbQiIVAjMc0+bfq8mbBd g582SbRwngoaq4yQFZB0k+RGb3qWQV6v7+PyEA/B3ZbEByW43hEZWlOAgVBC6YLy6 BuDAfy3bx/0KdKcbPw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([94.134.95.201]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3KPg-1tyvX81p4c-013Jcj; Sun, 13 Oct 2024 11:32:40 +0200 From: Stephen Berman To: Stefan Kangas Subject: Re: bug#73773: 31.0.50; void-variable subword-mode in python-mode In-Reply-To: (Stefan Kangas's message of "Sun, 13 Oct 2024 09:17:36 +0000") References: <87r08ltjav.fsf@gmx.net> Date: Sun, 13 Oct 2024 11:32:40 +0200 Message-ID: <87iktws5zb.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:7KxV2/PxAb+qt9CU6sG1KTfMBChokngzIUpdtcdvUBpVAojT8BQ 8lDi83QcLlA8R/Tt0tlUtFa/AAOzCDnyXu735DmJSFYB4mBHp/LXK7Poe9I6aL3t+uGhha5 QEYnSTcRotunJ8YN5kEArhcBlA1KkrF7+3lOr60LGm4LxgEndmDe658iihKU2cdT8GQn3nl QqS2JgQ/l+bX+3wDU8QCw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QdF1W1N+Zrw=;rF6VcDe1LUk4laT4aiVDdWmfcQo 02L1SuLMG7PTy4muC5MHdrq6a3jMjKQ7eiM6lcYJGpIVmlLr4oDq0N7FSTW5tMZSuZr6eddbo 4TV2jLt4gPHrOPtr7gKjzmLtLz85iH3P8F95U+eHL0307PpaG1V5xpH6ZfBIrLecANkaexFz2 Gn3E2VnARgHUolVSWZeiGNHfjBsgZ6USzWWoIxJpyMT4qAjq/dlLkuzlYIQ5KPANzJaZnZrCm Ay7jpr+fcMZ+Cg2+eXTtYsNh4gkYnnJ04tuYyWhDVBjZ72qNuknGbtZdQ6h9UzZ1gEzUdNHJJ qcMQyaHFgA6MG2vmcR+iIZqImCK/CUrRU04FhI+mcfvrMDoxLUFiOMMlEO/yHCXIO5Y4Pi9Pu 4cwq4ioYmIJtm6nyOmNsPfPkppCQZNCQvcPVqUT096cU3c3WBup2xXsgZeCNkrdX7ZiLFveYj LC1CnuayePZ7z7jvXuLOPIyb/Zn9Zl5LoXWKhcq6VqtB69XF3RhAgVNsefIMhZY2+mUeGL/vD QgJmK/hwHZAJWu406+RALzqFHUkWiP00krCEGlmf44HELDiVwScQ/67qB7HhbU+24927DpGQg f+dEQxD6ioSVnWCJaJ8BMROOydpnWUhLIMoJh5ASQzku/xVdJkbUYLVe6jCYyr793fbVzaBEt uzVmRT6GEP1gu7OPXxxvaPMkGZvB/tEWzDIezRu4mRX+CM2IyD9uWRRmJn7pwy68tVln8IbY9 9/X0QNFixCF8iFyE9XzaaD1BXvbHSGiP9mzG0Sd/6Q5S3kvN+lKpWWntwfFsm/cpPvDB77aTr 3hW00l20kM/zGiSV0YsgSQQg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73773-done Cc: 73773-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 13 Oct 2024 09:17:36 +0000 Stefan Kangas w= rote: > Stephen Berman writes: > >> 0. emacs -Q >> 1. M-x menu-bar-mode (disable menu bar) >> 3. Visit a file in python-mode, e.g. modules/modhelp.py in the Emacs >> sources. >> 4. Pressing or C-mouse-3 pops up the global menu as usual. >> 5. M-x toggle-debug-on-error >> 6. Now pressing or C-mouse-3 does not pop up the global menu but >> instead a *Backtrace* buffer pops open displaying "Lisp error: >> (void-variable subword-mode)". >> >> This is due to the following commit: >> >> commit 29a760711731ce49965079e72d76b26ef3b7bcb4 >> Author: Stefan Kangas >> AuthorDate: Sat Sep 21 14:07:29 2024 +0200 >> Commit: Stefan Kangas >> CommitDate: Sat Sep 21 14:08:09 2024 +0200 >> >> Add subword-mode toggle to python-mode menu >> >> * lisp/progmodes/python.el (python-mode-map): Add subword-mode >> toggle to menu. >> >> The attached patch fixes this problem. >> >> >> In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version >> 3.24.43, cairo version 1.18.2) of 2024-10-12 built on strobelfssd >> Repository revision: c3600916b6942b2a9797ec2248d29cb337c7c6fa >> Repository branch: master >> Windowing system distributor 'The X.Org Foundation', version 11.0.121010= 13 >> System Description: Linux From Scratch r12.2-17-systemd >> >> Configured using: >> 'configure -C 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt6/lib/pkgconf= ig' >> >> Configured features: >> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG >> LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG >> RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER >> WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB >> >> diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el >> index 812e28268c2..4e3b18a327b 100644 >> --- a/lisp/progmodes/python.el >> +++ b/lisp/progmodes/python.el >> @@ -361,6 +361,11 @@ python-mode-map >> ;; Utilities >> " " #'completion-at-point) >> >> +;; Define this so invoking menu-bar-open in a python-mode buffer does >> +;; not cause a void-variable error when subword-mode is not loaded, >> +;; menu-bar-mode is disabled and debug-on-error is enabled (bug#xxx). >> +(defvar subword-mode nil) >> + >> (easy-menu-define python-menu python-mode-map >> "Menu used for =C2=B4python-mode'." >> '("Python" > > Thanks, LGTM. I would move the comment to the commit message though. Sure, done. > Please install when you can. Thanks, done in commit 9a110c390dc and closing the bug. Steve Berman From unknown Mon Aug 18 14:25:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Nov 2024 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator