GNU bug report logs - #73770
[PATCH 0/2] Add freedisksysrom

Previous Next

Full log

Message #25 received at 73770-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 73770-done <at> debbugs.gnu.org, 宋文武 <iyzsong <at> envs.net>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#73770] [PATCH 0/2] Add freedisksysrom
Date: Sat, 19 Oct 2024 21:58:30 +0900

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Freitag, dem 18.10.2024 um 17:18 +0900 schrieb Maxim Cournoyer:
>> Hi Liliana,
>> 
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> 
>> > Am Samstag, dem 12.10.2024 um 22:09 +0900 schrieb Maxim Cournoyer:
>> > > This is a free BIOS implementation of the old Nintendo Famicom
>> > > (NES) that replaces the nonfree, firmware blob 'disksys.rom'
>> > > (extracted from the actual device).  It is useful with NES
>> > > emulators such as jg-nestopia.
>> > Perhaps we should add some dashes to make it "free-disksys-rom"?  I
>> > wouldn't split "disk" and "sys" despite the camel case, but I'm in
>> > the mood for kebab otherwise.
>> 
>> According to our naming convention (info '(guix) Package Naming'):
>> 
>>    [...] correspond to the lowercase conversion of the project name
>>    chosen upstream, with underscores replaced with hyphens.  For
>>    instance, GNUnet is available as ‘gnunet’, and SDL_net as ‘sdl-
>> net’.
>> 
>> "freedisksysrom" is the correct name (camel case upstream names are
>> simply converted to lower case)
>> 
>> > More importantly, is it expected that users can just install the
>> > package and run with it or are extra steps needed to import it into
>> > jg et al.?
>> 
>> Currently when you run for example jg-nestopia via jollygood (from
>> the rgrf package), if you try loading a ROM that requires
>> disksys.rom, it will let you know where it expects to find it
>> ('~/.local/share/jollygood/bios/disksys.rom'), and you must manually
>> copy/link such a file there.  I plan on making the integration
>> between jg-nestopia and freedisksysrom seamless in a future
>> (upstream) contribution to jg-nestopia.
> SGTM then

I've retested and sadly it seems my previous findings were incorrect; I
wasn't able to use freedisksysrom as sysdisk.rom with jg-nestopia to
play a vintage plumber's game.

I've detailed that it's still incomplete in its description and may not
be able to play all FDS games yet as a disclaimer, and otherwise pushed
with commit 7b6ab9ebe7 ("gnu: Add freedisksysrom.").

Closing; thanks for the review.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.