GNU bug report logs - #73769
[PATCH] automake: distribute local gnulib directory modules

Previous Next

Full log

View this message in rfc822 format

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Karl Berry <karl <at> freefriends.org>
Cc: mcpratt <at> pm.me, bruno <at> clisp.org, 73769 <at> debbugs.gnu.org
Subject: [bug#73769] [PATCH] automake: distribute local gnulib directory modules
Date: Sat, 12 Oct 2024 15:12:59 -0700

Hi Karl,

Karl Berry <karl <at> freefriends.org> writes:

> What do others think? Bruno, would you mind taking a look at Michael's
> message? https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73769

I'm not Bruno, but I feel like I know a bit about gnulib-tool. :)

I disagree with the patch since it doesn't work for every package that
uses Gnulib. Specifically, it assumes the Makefile name 'gnulib.mk'
which is used by Coreutils.

In Coreutils' bootstrap.conf file we have:

gnulib_tool_option_extras="--tests-base=gnulib-tests --with-tests --symlink\
 --makefile-name=gnulib.mk --automake-subdir
"

The --makefile-name option is explained in gnulib-tool --help:

    --makefile-name=NAME  Name of makefile in the source-base and tests-base
                          directories (default "Makefile.am", or
                          "Makefile.in" if --gnu-make).

> Wouldn't it be cleaner if the packages that use gnulib take care to
> include the gl/modules directory (and anything else needed)? Just like
> anything else.

This would be the correct way to do it, in my opinion.

Collin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.