From unknown Sat Sep 20 09:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 04:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 73763@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17287070542438 (code B ref -1); Sat, 12 Oct 2024 04:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Oct 2024 04:24:14 +0000 Received: from localhost ([127.0.0.1]:35977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szTfp-0000dF-Nw for submit@debbugs.gnu.org; Sat, 12 Oct 2024 00:24:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:45740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szTfn-0000d7-Sj for submit@debbugs.gnu.org; Sat, 12 Oct 2024 00:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szTfV-0006Gf-Vh for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 00:23:56 -0400 Received: from ns.lapseofthought.com ([50.0.39.240] helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szTfT-0000NH-RY for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 00:23:53 -0400 Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:1c26:90a6:82d0:13b6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XQTt96b0qz3pfG8 for ; Fri, 11 Oct 2024 20:45:53 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com From: Alex Bochannek Date: Fri, 11 Oct 2024 20:45:53 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello! I am using the SRC back end to VC and noticed `^J' after the revision number in the mode line. This appears to be due to the way the output of the `src list' command is converted to a string, which keeps the newline. The following patch has been tested under macOS Sequoia 15.0.1 and should be equally applicable to other platforms. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Remove-unnecessary-trailing-white-space-from-SRC-rev.patch >From 37d0c418b633f588c8162704630e422afecbf5df Mon Sep 17 00:00:00 2001 From: Alex Bochannek Date: Fri, 11 Oct 2024 20:32:41 -0700 Subject: [PATCH] Remove unnecessary trailing white space from SRC revision number --- lisp/vc/vc-src.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/vc/vc-src.el b/lisp/vc/vc-src.el index 27f58cb3369..ff19b0f7696 100644 --- a/lisp/vc/vc-src.el +++ b/lisp/vc/vc-src.el @@ -222,8 +222,9 @@ vc-src-command (defun vc-src-working-revision (file) "SRC-specific version of `vc-working-revision'." (let ((result (ignore-errors - (with-output-to-string - (vc-src-command standard-output file "list" "-f{1}" "@"))))) + (string-trim-right + (with-output-to-string + (vc-src-command standard-output file "list" "-f{1}" "@")))))) (if (zerop (length result)) "0" result))) ;;; -- 2.39.5 (Apple Git-154) --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From unknown Sat Sep 20 09:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Bochannek , Dmitry Gutov Cc: 73763@debbugs.gnu.org Received: via spool by 73763-submit@debbugs.gnu.org id=B73763.172873857921944 (code B ref 73763); Sat, 12 Oct 2024 13:10:02 +0000 Received: (at 73763) by debbugs.gnu.org; 12 Oct 2024 13:09:39 +0000 Received: from localhost ([127.0.0.1]:42981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szbsI-0005hq-Ug for submit@debbugs.gnu.org; Sat, 12 Oct 2024 09:09:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szbsE-0005hU-UF for 73763@debbugs.gnu.org; Sat, 12 Oct 2024 09:09:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szbQY-0005JZ-Pn; Sat, 12 Oct 2024 08:40:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cH/6V1h7eq+3zxg51nvGjIZ/1pTmREpNjI//Abd59VI=; b=YeLqwWKaMpSd hd9JLdzlrE/0cO5M6zvEIQUO4XHV1FwOrZNx5DzTO1Tnu/nav20tf4Z5TCwK2dO0Rcz0+RDoPBqCm z4iOvGD4nrfqUgzsm6HJBIweyb1aq5lQ0hWKUWg3pZnNzX4BI7DTyZwzGTnUbOaN5fqXVbRIPqZmH MjrGO28sL+OkpRxds6MM1U6RzjnIHwp4f2E5kly9ERNi/k4eGU54qLlKa21a33Fi1HKOJhRXOhueq TZp7O5IMpQ4jgvmM/3TnGCzap5YWsVOYrogeu4xnKgbXZ9YyazMKl9R+E5faUDdC6tdqV9lSNfyFb evd/gNdyHaNwJTKapEjA2g==; Date: Sat, 12 Oct 2024 15:40:55 +0300 Message-Id: <868qutwl2g.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Alex Bochannek on Fri, 11 Oct 2024 20:45:53 -0700) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alex Bochannek > Date: Fri, 11 Oct 2024 20:45:53 -0700 > > I am using the SRC back end to VC and noticed `^J' after the revision > number in the mode line. This appears to be due to the way the output of > the `src list' command is converted to a string, which keeps the > newline. > > The following patch has been tested under macOS Sequoia 15.0.1 and > should be equally applicable to other platforms. Looks correct to me. Dmitry? From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 09:40:08 2024 Received: (at control) by debbugs.gnu.org; 12 Oct 2024 13:40:08 +0000 Received: from localhost ([127.0.0.1]:44054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szcLo-0007pk-77 for submit@debbugs.gnu.org; Sat, 12 Oct 2024 09:40:08 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:46378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szcFG-0007S9-1u for control@debbugs.gnu.org; Sat, 12 Oct 2024 09:33:22 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5c948c41edeso1934480a12.1 for ; Sat, 12 Oct 2024 06:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728739927; x=1729344727; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=4JTZqx44zpWXyANMZzmLR/RF2L7kfV2mbKcltaY9mHA=; b=XuevpvXcvSP+vnYkVHSy0+WVoPNyj9AILGXqsasSd9KuHjMxanT3AI1KKDDSWhWjre f3xjvPvH5OS2ArN7en8nIsQbdkwwx05zRdXLelt4+bLJqpIg8oHy1wPOll6by/XdV3f2 bg1ZbGpFfxOw8mX/3jKfke1vaRtH0JHMUc6P4S1XOBIkPgRFhxkhJKjDTgEnUE3fOJR/ bZwvIZaFAm9Pm2cDl1dxcyxxF1MccOqfCwX/G5Rq0ac6JIz4HEd4gFpoKSGHuMw3/Vdn XkjGfAJ9gpyumBm2t5sktYTFoxcSDqw/Ed18B4mRq+YG0bG6WEH7MLapZpBsR4fSo75m 6Lfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728739927; x=1729344727; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4JTZqx44zpWXyANMZzmLR/RF2L7kfV2mbKcltaY9mHA=; b=u7faUToe6p0AvERiifkzKEIRLwBj4pHB7LyCWY+pBozaqPjxcPgBdYRDvivBgfWDiz Rv+e9VLF0TSTQ7rWJ2dfwopwUAstILZ58DF9YEqRSgIxD4la5EKg8c0Ae+f3GACBbIjV Ftx7dX7ljABUM55WcptIZyOKPaHyqGnRkFat6tswlicC2p7M/BUilxHfiuuTie1HW7bC JzPPhVb2Kc4dVlAiYttaOZUthmxyBGpYxM8llV/1oAWwssBOAeeaSsZ6ZaHVcsgF2xa4 HiuS1s2A+q3VZWErkWdomS8j5f4YoYT5MTXlBmqbFF06Dfic5cmws8xv5JRhmqr4xDNL UnLQ== X-Gm-Message-State: AOJu0YyfChPJazq48mEj3fiVoHnAKkce//Lan3H9OaIjUGgQ0IlQsYrr cVEzBrBeDmokEVgZ3yq/rvlHykBCV1jqKaHSlHSU/8kXMaEVgxIn7VXqrrta5romOM0u0m+I02P cA/HNhKIFgZhX69Pf1XfI2wY0oEnIDw== X-Google-Smtp-Source: AGHT+IEZbtprJErEiLv5Ck6lCRJgQgv9l7UMGa26HV9UWIJAUKzn14Uh6Xf39ySjprUqmsJJKgVhvSoqwbhp3KP356g= X-Received: by 2002:a05:6402:42c9:b0:5c9:6bd9:68db with SMTP id 4fb4d7f45d1cf-5c96bd96bd1mr242092a12.3.1728739926925; Sat, 12 Oct 2024 06:32:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Oct 2024 08:32:06 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Sat, 12 Oct 2024 08:32:06 -0500 Message-ID: Subject: control message for bug #73763 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 73763 minor quit From unknown Sat Sep 20 09:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Resent-From: "Dmitry Gutov" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 17:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Eli Zaretskii" , "Alex Bochannek" Cc: 73763@debbugs.gnu.org Received: via spool by 73763-submit@debbugs.gnu.org id=B73763.172875380823513 (code B ref 73763); Sat, 12 Oct 2024 17:24:03 +0000 Received: (at 73763) by debbugs.gnu.org; 12 Oct 2024 17:23:28 +0000 Received: from localhost ([127.0.0.1]:53567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfpv-00067A-NQ for submit@debbugs.gnu.org; Sat, 12 Oct 2024 13:23:28 -0400 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]:60417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfpq-00066g-2S for 73763@debbugs.gnu.org; Sat, 12 Oct 2024 13:23:25 -0400 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 5CB17114007F; Sat, 12 Oct 2024 13:23:02 -0400 (EDT) Received: from phl-imap-04 ([10.202.2.82]) by phl-compute-06.internal (MEProxy); Sat, 12 Oct 2024 13:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1728753782; x=1728840182; bh=fUCGxpE2Sx K5ppD6De2RbvrQOKgafxl3/K9mdqWk38U=; b=eJHyeu8J1Tmio351hfFgmsm8tt q5GYVq29rVl9fA16BDmFCFNP8fwzHIAk5d9qRDv53HIa2vrxK/0LCmLmOSZQfHc7 oG1+zwEx/2Ik+766COeQr8lF4pKKpOEGGMyND4u+JNV5ODK5nWk9o1RF6/rsBjWL UqjiZk7+N7OuyRXfSWtqbp/NHMq2LP/x6jd6SuLHqjXJ9B9mLJOgotIFcqp0saCh yWQo59fSL3L3LFygIGuiKGfIn9sjw442VBRmOUe3vRHqnNEZdM1h4nhiGauh+yNk Iork5zsWsRmANUlHkBwWFO4tpCTM33B58UZx/v7aEJiDRkCjJ1s0mGFmQv9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1728753782; x=1728840182; bh=fUCGxpE2SxK5ppD6De2RbvrQOKga fxl3/K9mdqWk38U=; b=GNsHTmqgF+NR/waIB3OwcrLtVDztUhprjpsR6/MdRtak yTK6RuqKlvRn621D2wqLrrLYYA0so3XW+r9csBpwUAtzyjASHTRQQce4CNfVyzqz Rc3KM0yh4KQsgcSirCLF4foFmd0nBAecLPBBvtIz5vmPV3i3qGseS3TJ+Gfpdalw GtmJAm4UF3iUn3OeLT5PDK96A0U26viWC8IYid+9yzYX/KhbSQr1rkESM0vWPOkf P7ntgw0T64pXLaXUOy0o2Ud3r/FQRrYFaxWQBAeoNE7FXOxWaKUM5WCRVqNuhAZ1 nOswLr1re5mGu+y709V7j8Q5heXTaIhwaTMACntjtQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeguddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtsegrtderreertddt necuhfhrohhmpedfffhmihhtrhihucfiuhhtohhvfdcuoegumhhithhrhiesghhuthhovh druggvvheqnecuggftrfgrthhtvghrnheptdfgffekheefueehvddtvdevgfetveehhfei tdeiheekiedthfekjedtheeiudetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphht thhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrlhgvgiessghotghhrg hnnhgvkhdrtghomhdprhgtphhtthhopeejfeejieefseguvggssghughhsrdhgnhhurdho rhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id C4E1A2E60084; Sat, 12 Oct 2024 13:23:01 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Sat, 12 Oct 2024 19:22:39 +0200 From: "Dmitry Gutov" Message-Id: <8aa3c45c-7e41-4511-8054-cb7ecac7b15f@app.fastmail.com> In-Reply-To: <868qutwl2g.fsf@gnu.org> References: <868qutwl2g.fsf@gnu.org> Content-Type: multipart/alternative; boundary=d131c179a46846f08bc4453469ff2e74 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --d131c179a46846f08bc4453469ff2e74 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sat, Oct 12, 2024, at 2:40 PM, Eli Zaretskii wrote: > > From: Alex Bochannek > > Date: Fri, 11 Oct 2024 20:45:53 -0700 > > > > I am using the SRC back end to VC and noticed `^J' after the revision > > number in the mode line. This appears to be due to the way the output of > > the `src list' command is converted to a string, which keeps the > > newline. > > > > The following patch has been tested under macOS Sequoia 15.0.1 and > > should be equally applicable to other platforms. > > Looks correct to me. > > Dmitry? Looks reasonable to me too, though as discussed, it might be better to ping Sean. If the patch is already tested on a live program, great. Note that it has a .local email. --d131c179a46846f08bc4453469ff2e74 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Sat, Oct 12,= 2024, at 2:40 PM, Eli Zaretskii wrote:
> From: Alex Bochannek <alex@bochannek.com>
> D= ate: Fri, 11 Oct 2024 20:45:53 -0700
> 
<= div>> I am using the SRC back end to VC and noticed `^J' after the re= vision
> number in the mode line. This appears to be du= e to the way the output of
> the `src list' command is = converted to a string, which keeps the
> newline.
> 
> The following patch has been test= ed under macOS Sequoia 15.0.1 and
> should be equally a= pplicable to other platforms.

Looks correct= to me.

Dmitry?
= Looks reasonable to me too, though as discussed, it might be better to p= ing Sean.

If the patch is already tested on= a live program, great. Note that it has a .local email.
--d131c179a46846f08bc4453469ff2e74-- From unknown Sat Sep 20 09:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 18:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Dmitry Gutov" , Sean Whitton Cc: alex@bochannek.com, 73763@debbugs.gnu.org Received: via spool by 73763-submit@debbugs.gnu.org id=B73763.17287584129620 (code B ref 73763); Sat, 12 Oct 2024 18:41:03 +0000 Received: (at 73763) by debbugs.gnu.org; 12 Oct 2024 18:40:12 +0000 Received: from localhost ([127.0.0.1]:56652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szh2C-0002V1-8B for submit@debbugs.gnu.org; Sat, 12 Oct 2024 14:40:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szh27-0002Th-V3 for 73763@debbugs.gnu.org; Sat, 12 Oct 2024 14:40:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szgkp-0005zX-TS; Sat, 12 Oct 2024 14:22:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cirxJY1sS4q9/9eE/y2MK3ukZ+COy/XJ4OvKayr3IY8=; b=dNiV5RlyltOz ip6tRumeZgh4wy9X0WdBzCNP7W68Qa1BlPP2Y+wY+kM4AMwQn0yikwwAANyjp2KeU8mwOO+DqlPSe eiIXKZUdh146ui9XxnMU9F6ileXjNOjhRwAIxLE4V9TlKy9yHZnK0gNBOjYLh51d+q0nzCWhCvUJO ueJIbBZ6hvWJP04VtXGvLE195ya9LAfMkdk0qWDxVkjAr2y0PXRctf6KhV+46SeJM+cQwHB8xqUMv kkbmZk1+hN9fhAjgMzlukosPNnKLn8O4Wlpk3QjCf70EIfOu8vn86+WvLoo7V3+YefiQkeoR0UK3X XtPEwtq6oKXlL66uzW7Utg==; Date: Sat, 12 Oct 2024 21:22:12 +0300 Message-Id: <86msj9uqp7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8aa3c45c-7e41-4511-8054-cb7ecac7b15f@app.fastmail.com> (dmitry@gutov.dev) References: <868qutwl2g.fsf@gnu.org> <8aa3c45c-7e41-4511-8054-cb7ecac7b15f@app.fastmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 12 Oct 2024 19:22:39 +0200 > From: "Dmitry Gutov" > Cc: 73763@debbugs.gnu.org > > On Sat, Oct 12, 2024, at 2:40 PM, Eli Zaretskii wrote: > > > From: Alex Bochannek > > Date: Fri, 11 Oct 2024 20:45:53 -0700 > > > > I am using the SRC back end to VC and noticed `^J' after the revision > > number in the mode line. This appears to be due to the way the output of > > the `src list' command is converted to a string, which keeps the > > newline. > > > > The following patch has been tested under macOS Sequoia 15.0.1 and > > should be equally applicable to other platforms. > > Looks correct to me. > > Dmitry? > > Looks reasonable to me too, though as discussed, it might be better to ping Sean. > > If the patch is already tested on a live program, great. Note that it has a .local email. Adding Sean. From unknown Sat Sep 20 09:29:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Bochannek Subject: bug#73763: closed (Re: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number) Message-ID: References: <87set0xuur.fsf@melete.silentflame.com> X-Gnu-PR-Message: they-closed 73763 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 73763@debbugs.gnu.org Date: Sun, 13 Oct 2024 08:38:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1728808682-12975-1" This is a multi-part message in MIME format... ------------=_1728808682-12975-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC r= evision number which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73763@debbugs.gnu.org. --=20 73763: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73763 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1728808682-12975-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73763-done) by debbugs.gnu.org; 13 Oct 2024 08:37:04 +0000 Received: from localhost ([127.0.0.1]:50126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szu64-0003Lx-6M for submit@debbugs.gnu.org; Sun, 13 Oct 2024 04:37:04 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:40340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szu62-0003LR-3p for 73763-done@debbugs.gnu.org; Sun, 13 Oct 2024 04:37:03 -0400 DKIM-Signature: a=rsa-sha256; b=ObkgCkcR18F8gAvivLNT9JPGy8E0GftR/fRVyZLlYTsMv0+sCucz2m7YU2Id2enIKNIFIKUcVq9UszCg6IC3o0RJhDQq++wvyrSS4ZiF6AX114LYtP6mCgLYX8yldR0mVpRSq5XHdn0uiUFh/VS6xDpcfxEBlhcf5SjmrYNQP259BAW34AcqjQBXU07huMaBsuipBvPcpdWkT379GjV1jkwkoWulaF7iilLqRoiNBuvS7t6/8Q3YHMf6yemNPqewnkVfvn+hVSBmh7+OmJidE094wMJ3D0CV8sVU0AO+LaiQFjM/5YiNDLnItY4tOTOsIwmdf9HyXQcnTf+1pyrpbA==; s=purelymail3; d=spwhitton.name; v=1; bh=XbZQI3lFxxZJJMfaAKNTWN2pQImssIhqrp2S0MIj7cY=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=GixLk78yEsABSH1VAlnlofXiGZEsP3hpz9N1kbaej4OHtT0g0/rfo/SlQVv4nfeFEne2hiOoMGWHGHEhK7EOpMNyr6zhYzhTL9Ud3JWe4S+ZWl1lDYWuft1m1neFX9dJYC7moXgn2RN6sbCL5Qg2/dMb9ylp8uQfrFHIUkkmzOp9Ni/1OivWeqi9nIQe0PWYjpEQrKyMSl7OUEr6WMWzQ58/dR+KNsOdJc4KYAS3VqvPy7fp4QFO2+dMftiUn2GO58Tf3Zv5FRfcUZ1bHAuZ0FzCDrAB+nFs7+a1WzQH3vdMiSthmmnpyZdMxlEFXfWyR88jljiO9rhmcCL6GkzloQ==; s=purelymail3; d=purelymail.com; v=1; bh=XbZQI3lFxxZJJMfaAKNTWN2pQImssIhqrp2S0MIj7cY=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73763-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -276544464; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 13 Oct 2024 08:36:32 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id F41CB7E9AA4; Sun, 13 Oct 2024 16:36:28 +0800 (CST) From: Sean Whitton To: Alex Bochannek Subject: Re: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number In-Reply-To: (Alex Bochannek's message of "Fri, 11 Oct 2024 20:45:53 -0700") References: Date: Sun, 13 Oct 2024 16:36:28 +0800 Message-ID: <87set0xuur.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73763-done Cc: 73763-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Thank you, installed on master. -- Sean Whitton ------------=_1728808682-12975-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Oct 2024 04:24:14 +0000 Received: from localhost ([127.0.0.1]:35977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szTfp-0000dF-Nw for submit@debbugs.gnu.org; Sat, 12 Oct 2024 00:24:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:45740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szTfn-0000d7-Sj for submit@debbugs.gnu.org; Sat, 12 Oct 2024 00:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szTfV-0006Gf-Vh for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 00:23:56 -0400 Received: from ns.lapseofthought.com ([50.0.39.240] helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szTfT-0000NH-RY for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 00:23:53 -0400 Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:1c26:90a6:82d0:13b6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XQTt96b0qz3pfG8 for ; Fri, 11 Oct 2024 20:45:53 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com From: Alex Bochannek To: bug-gnu-emacs@gnu.org Subject: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Date: Fri, 11 Oct 2024 20:45:53 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello! I am using the SRC back end to VC and noticed `^J' after the revision number in the mode line. This appears to be due to the way the output of the `src list' command is converted to a string, which keeps the newline. The following patch has been tested under macOS Sequoia 15.0.1 and should be equally applicable to other platforms. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Remove-unnecessary-trailing-white-space-from-SRC-rev.patch >From 37d0c418b633f588c8162704630e422afecbf5df Mon Sep 17 00:00:00 2001 From: Alex Bochannek Date: Fri, 11 Oct 2024 20:32:41 -0700 Subject: [PATCH] Remove unnecessary trailing white space from SRC revision number --- lisp/vc/vc-src.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/vc/vc-src.el b/lisp/vc/vc-src.el index 27f58cb3369..ff19b0f7696 100644 --- a/lisp/vc/vc-src.el +++ b/lisp/vc/vc-src.el @@ -222,8 +222,9 @@ vc-src-command (defun vc-src-working-revision (file) "SRC-specific version of `vc-working-revision'." (let ((result (ignore-errors - (with-output-to-string - (vc-src-command standard-output file "list" "-f{1}" "@"))))) + (string-trim-right + (with-output-to-string + (vc-src-command standard-output file "list" "-f{1}" "@")))))) (if (zerop (length result)) "0" result))) ;;; -- 2.39.5 (Apple Git-154) --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- ------------=_1728808682-12975-1-- From unknown Sat Sep 20 09:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Sean Whitton Cc: 73763-done@debbugs.gnu.org Received: via spool by 73763-done@debbugs.gnu.org id=D73763.172884751426468 (code D ref 73763); Sun, 13 Oct 2024 19:26:02 +0000 Received: (at 73763-done) by debbugs.gnu.org; 13 Oct 2024 19:25:14 +0000 Received: from localhost ([127.0.0.1]:56083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t04DJ-0006sj-LL for submit@debbugs.gnu.org; Sun, 13 Oct 2024 15:25:14 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:58336 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t03xg-0005r4-VH for 73763-done@debbugs.gnu.org; Sun, 13 Oct 2024 15:09:05 -0400 Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:6d67:5771:8da6:e19c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XRSZP1r8Xz3pvPw; Sun, 13 Oct 2024 10:50:37 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com From: Alex Bochannek In-Reply-To: <87set0xuur.fsf@melete.silentflame.com> (Sean Whitton's message of "Sun, 13 Oct 2024 16:36:28 +0800") References: <87set0xuur.fsf@melete.silentflame.com> Date: Sun, 13 Oct 2024 10:50:33 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Hello, > > Thank you, installed on master. Thanks! -- Alex.