Subject: bug#73760: closed (Re: [bug#73760] [PATCH v2] gnu: googlebenchmark: Upgrade to v1.9.1.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 21 Mar 2025 19:46:02 +0000

Your bug report

#73760: [PATCH] gnu: Upgrade googlebenchmark

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73760: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73760
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#73760] [PATCH v2] gnu: googlebenchmark: Upgrade to v1.9.1.
From: Greg Hogan <[email-masked]>
To: Aaron Covrig <[email-masked]>
Cc: [email-masked]
Date: Fri, 21 Mar 2025 15:45:16 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, Mar 21, 2025 at 1:26 PM Aaron Covrig via Guix-patches via
<[email-masked]> wrote:
>
> From: Aaron Covrig <[email-masked]>
>
> * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.1.
> ---
>  gnu/packages/check.scm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 4994a10f11..38c10c91be 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -1104,7 +1104,7 @@ (define-public googletest-1.8
>  (define-public googlebenchmark
>    (package
>      (name "googlebenchmark")
> -    (version "1.8.3")
> +    (version "1.9.1")
>      (home-page "https://github.com/google/benchmark")
>      (source (origin
>                (method git-fetch)
> @@ -1113,15 +1113,14 @@ (define-public googlebenchmark
>                (file-name (git-file-name "google-benchmark" version))
>                (sha256
>                 (base32
> -                "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
> +                "1ky51j4hbqcaxp7i7sfiyh1435mgyijgbfgc48bbmi52vgay0477"))))
>      (build-system cmake-build-system)
>      (arguments
>       '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
>                                 (string-append
>                                  "-DGOOGLETEST_PATH="
>                                  (assoc-ref %build-inputs "googletest")))))
> -    (inputs
> -     `(("googletest" ,(package-source googletest))))
> +    (inputs `(("googletest" ,(package-source googletest))))
>      (synopsis "C++ library to support the benchmarking of functions")
>      (description
>       "The googlebenchmark C++ library support the benchmarking of functions,
>
> base-commit: efac1498c15198afc4f9a2bc700408bde1b3b3ed
> --
> 2.48.1

Pushed as 5bf7d80535720077aec104a9904480d08b9b4f2b.

Subject: [PATCH] gnu: Upgrade googlebenchmark
From: Aaron Covrig <[email-masked]>
To: [email-masked]
Cc: Aaron Covrig <[email-masked]>
Date: Fri, 11 Oct 2024 21:41:43 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0
---
 gnu/packages/check.scm | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 8d41996c71..e0bd71e6d3 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -105,6 +105,7 @@ (define-module (gnu packages check)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages time)
   #:use-module (gnu packages xml)
+  #:use-module (gnu packages version-control)
   #:use-module (guix utils)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -1098,24 +1099,25 @@ (define-public googletest-1.8
 (define-public googlebenchmark
   (package
     (name "googlebenchmark")
-    (version "1.8.3")
+    (version "1.9.0")
     (home-page "https://github.com/google/benchmark")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference (url home-page)
-                                  (commit (string-append "v" version))))
-              (file-name (git-file-name "google-benchmark" version))
-              (sha256
-               (base32
-                "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name "google-benchmark" version))
+       (sha256
+        (base32 "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5"))))
     (build-system cmake-build-system)
     (arguments
      '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
-                               (string-append
-                                "-DGOOGLETEST_PATH="
-                                (assoc-ref %build-inputs "googletest")))))
-    (inputs
-     `(("googletest" ,(package-source googletest))))
+                               (string-append "-DGOOGLETEST_PATH="
+                                              (assoc-ref %build-inputs
+                                                         "googletest")))))
+    (inputs `(("git" ,git)
+              ("googletest" ,(package-source googletest))))
     (synopsis "C++ library to support the benchmarking of functions")
     (description
      "The googlebenchmark C++ library support the benchmarking of functions,

base-commit: b8fd792ea267cb920da0651074a533d8abf00488
-- 
2.46.0