From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 21:42:33 2024 Received: (at submit) by debbugs.gnu.org; 12 Oct 2024 01:42:33 +0000 Received: from localhost ([127.0.0.1]:35816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szR9M-0000ht-Py for submit@debbugs.gnu.org; Fri, 11 Oct 2024 21:42:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:40308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szR9K-0000hh-Iz for submit@debbugs.gnu.org; Fri, 11 Oct 2024 21:42:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szR96-00029Q-RI for guix-patches@gnu.org; Fri, 11 Oct 2024 21:42:16 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szR94-00082M-Sx for guix-patches@gnu.org; Fri, 11 Oct 2024 21:42:16 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-460407b421bso20041341cf.3 for ; Fri, 11 Oct 2024 18:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1728697332; x=1729302132; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2g556+A9Ab2xTQbdyne8IlUVlQABuMQeYT0fvLcezyM=; b=Y6SCKKkVCV8rNGvNPt9HivFcuC3Gudd/lPG4FiSfl2rGv9kN9287SF2LXkifXHWhsh lkYLCe6xZnh80F9wqsj8qU8ULgc+Gv4URgEYFLZ5XTLL0xt3yoGlAo3b04FUuvL3BYky ALtNWVPZ1ZR00awf8gAeL+8UG8DU3mOE/5Mic= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728697332; x=1729302132; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2g556+A9Ab2xTQbdyne8IlUVlQABuMQeYT0fvLcezyM=; b=VcqB/rQyCqjn7HYM9pM7yOUYONJiF6Bz6waNHWzLqG7PsYsCSFv6JKnaZwDH8khVYG pU2va/16peQi4fq46lIQqcTyfPwpcJRzZtyuz6EOI3ORbFfxL0KBOkT4lxchljuasaRC s8U438IvBO7VpBRELSDMEBaPQD11AoL1huEbLo65nQdWxs4xM+xG8APQMOg4FdRnjlGa 0PRBaikQknBL/ggr5XwpcStTuV80h2EwFAGVAE1rxEJZFy7cByRxhaIpz+REg7l27EXe hjjYB+YzFQ5jOI0nbUKi0ed5AEkual7lTSjmlb+Te5kdvltIERuRSpRHV+sZKZBZouCd n2Ag== X-Gm-Message-State: AOJu0YzEFcWhO8t83PNOpe3jJe/BBN3B24DWr4Oj84kHDbFTsChnnB94 ZcJT36lITy3UOg9gxtrNYbxlayDIlxT3qSSPMVzpl/3Bekw6eDdOk2/AtrDt4iTwiOSqZVFWPuc n9GRgLiiJsR1BHhJ7RNGiTM5TUFtEcKl2y+G2CO1unmkaWKMZc0afYbEPf2CIZItv9K0RznKZFS gTrZcv/fwkhpTl0GPESowVSPGq1ct4k4CgUlWMNA== X-Google-Smtp-Source: AGHT+IFzx+PwQ4sZjEukyREqrxEOJNE+xxC3GvcSXLO32UrEzjIZqEBPQ87apE/VVOebDCubn95VJQ== X-Received: by 2002:a05:622a:4108:b0:458:5fd0:964c with SMTP id d75a77b69052e-4604bc490b7mr72314291cf.50.1728697332548; Fri, 11 Oct 2024 18:42:12 -0700 (PDT) Received: from mobile-dev.lan ([73.172.106.204]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460427d50efsm21003511cf.22.2024.10.11.18.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 18:42:11 -0700 (PDT) From: Aaron Covrig To: guix-patches@gnu.org Subject: [PATCH] gnu: Upgrade googlebenchmark Date: Fri, 11 Oct 2024 21:41:43 -0400 Message-ID: <20241012014207.130885-1-aaron.covrig.us@ieee.org> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82a; envelope-from=aaron.covrig.us@ieee.org; helo=mail-qt1-x82a.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.15, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Aaron Covrig X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0 --- gnu/packages/check.scm | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 8d41996c71..e0bd71e6d3 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -105,6 +105,7 @@ (define-module (gnu packages check) #:use-module (gnu packages texinfo) #:use-module (gnu packages time) #:use-module (gnu packages xml) + #:use-module (gnu packages version-control) #:use-module (guix utils) #:use-module ((guix licenses) #:prefix license:) #:use-module (guix packages) @@ -1098,24 +1099,25 @@ (define-public googletest-1.8 (define-public googlebenchmark (package (name "googlebenchmark") - (version "1.8.3") + (version "1.9.0") (home-page "https://github.com/google/benchmark") - (source (origin - (method git-fetch) - (uri (git-reference (url home-page) - (commit (string-append "v" version)))) - (file-name (git-file-name "google-benchmark" version)) - (sha256 - (base32 - "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3")))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url home-page) + (commit (string-append "v" version)))) + (file-name (git-file-name "google-benchmark" version)) + (sha256 + (base32 "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5")))) (build-system cmake-build-system) (arguments '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON" - (string-append - "-DGOOGLETEST_PATH=" - (assoc-ref %build-inputs "googletest"))))) - (inputs - `(("googletest" ,(package-source googletest)))) + (string-append "-DGOOGLETEST_PATH=" + (assoc-ref %build-inputs + "googletest"))))) + (inputs `(("git" ,git) + ("googletest" ,(package-source googletest)))) (synopsis "C++ library to support the benchmarking of functions") (description "The googlebenchmark C++ library support the benchmarking of functions, base-commit: b8fd792ea267cb920da0651074a533d8abf00488 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 09:56:19 2025 Received: (at 73760) by debbugs.gnu.org; 21 Mar 2025 13:56:20 +0000 Received: from localhost ([127.0.0.1]:37614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvcrC-0007aN-MM for submit@debbugs.gnu.org; Fri, 21 Mar 2025 09:56:19 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:58532) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tvcr8-0007Vy-Qk for 73760@debbugs.gnu.org; Fri, 21 Mar 2025 09:56:16 -0400 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-726819aa3fcso1277173a34.0 for <73760@debbugs.gnu.org>; Fri, 21 Mar 2025 06:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1742565368; x=1743170168; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sB6MrWFnLytrPorgb7WV/EWgeQuVAROuoOiIrNi7rdM=; b=cvPI+PBJ8nH0z5Woo9Z3P9gHfI/ia2QgaUtfiWSB79N5nhCQ3SAfyEAz0/M5qnjRdX +Uh+uQ/T77dbWJCixbP17Hj12riQD/iAwfqOwdLSb9OmuVRV1N8tm8sT5qJZJvP2UONL pJNDkz1tasKyhHmyt1Ws2pt4hFUSSDwMztP2mmZsPgfAa51qDxfJPhoBj0xOg5421bQt A+3eBDYGFQEQJJJ9PO/H9zgzutFPcdEpTPqpd8jVaez9rh3Y60+uWNgtPo/u6bpohKX6 SR9qLWwl4ugOVdICKzC9MdY1PPxIGayzWyKwUXaCWtZp7fCZPLExq5tBqycLY8ZAXw7T U5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742565368; x=1743170168; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sB6MrWFnLytrPorgb7WV/EWgeQuVAROuoOiIrNi7rdM=; b=r3vDQjlF6q0axc6mJJGTwvgQXTZ4tMZDenUU5HifiSQz3KQLbTaCXMboP6B6ZIVj1I ezsiMUej7j/NvBXDVyaoi2fG0h9gRK3x1ZHgYbXUDSF5wMREyxL9caxM4j3scY14QdsG 8I29GTbKXHjy1WjiBqItjbZodE5S6sek6SIwh7OW/wIsHVhqi/LPppjeJGlBYFM7+HIg Dg9kfM1IQuuh52keD9hvQ9UTZjwtOnecW7EXVIJU1SdkBWs2MlWeLk/iujWOjw5xY77j L5/ysp4saDsz/Fl2oYKgH/MJNQ1qg9xmJ3mH+07Q02aqCg6BN2xlLkoZYR9ZOL6wbgBK e6Ng== X-Gm-Message-State: AOJu0YwDfy+ob67lQj/Uz2r0lNWTuzkwUajpTaKaS1uw6sK54rKFjGtU LBI5HTPw4aCn2MD+mdRrZufksSRMUvdGS1aO6yAMSbzYAlEL1550EElQ6wlRJrAblTPBbyTO4FZ vEV9CJv5aUHKx3xVDgcbb18xRMgtTA+pBdy7OSA== X-Gm-Gg: ASbGncvCgEV2VhZ43lhVXCPiIdeD2jEngbKwfjiHkVU6l6Gxsad/0hcPLKLQfY0/lke XMVKWb3PixUWx1VZA55MkgOPr6SO+c/WdiWKRpYb/m79W4dP62i3ZOva+1elGyI0cV5mwetB11l eKFImeviLCcOCWXBfenulb2U4V1Q== X-Google-Smtp-Source: AGHT+IGiMBYep2QH7TJ7K7q2JXj2WSS6G2qab+dHL50quC28DfvUb1lZ0IUpOfKS52io/fS1HUr39yBqviFY6ojqLME= X-Received: by 2002:a05:6830:380e:b0:72a:18a6:d431 with SMTP id 46e09a7af769-72c0ae99824mr2332158a34.14.1742565368348; Fri, 21 Mar 2025 06:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20241012014207.130885-1-aaron.covrig.us@ieee.org> In-Reply-To: <20241012014207.130885-1-aaron.covrig.us@ieee.org> From: Greg Hogan Date: Fri, 21 Mar 2025 09:55:56 -0400 X-Gm-Features: AQ5f1Jr2w96YPcJtly42ST6d8TtuCDL5fv19rFN_niWPFMAMDz48hAkdAOIhlbk Message-ID: Subject: Re: [bug#73760] [PATCH] gnu: Upgrade googlebenchmark To: Aaron Covrig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73760 Cc: 73760@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Oct 11, 2024 at 9:43=E2=80=AFPM Aaron Covrig via Guix-patches via wrote: > > * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0 > --- > gnu/packages/check.scm | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm > index 8d41996c71..e0bd71e6d3 100644 > --- a/gnu/packages/check.scm > +++ b/gnu/packages/check.scm > @@ -105,6 +105,7 @@ (define-module (gnu packages check) > #:use-module (gnu packages texinfo) > #:use-module (gnu packages time) > #:use-module (gnu packages xml) > + #:use-module (gnu packages version-control) > #:use-module (guix utils) > #:use-module ((guix licenses) #:prefix license:) > #:use-module (guix packages) > @@ -1098,24 +1099,25 @@ (define-public googletest-1.8 > (define-public googlebenchmark > (package > (name "googlebenchmark") > - (version "1.8.3") > + (version "1.9.0") > (home-page "https://github.com/google/benchmark") > - (source (origin > - (method git-fetch) > - (uri (git-reference (url home-page) > - (commit (string-append "v" version)))) > - (file-name (git-file-name "google-benchmark" version)) > - (sha256 > - (base32 > - "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))= )) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url home-page) > + (commit (string-append "v" version)))) > + (file-name (git-file-name "google-benchmark" version)) > + (sha256 > + (base32 "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5"))= )) > (build-system cmake-build-system) > (arguments > '(#:configure-flags (list "-DBUILD_SHARED_LIBS=3DON" > - (string-append > - "-DGOOGLETEST_PATH=3D" > - (assoc-ref %build-inputs "googletest")))= )) > - (inputs > - `(("googletest" ,(package-source googletest)))) > + (string-append "-DGOOGLETEST_PATH=3D" > + (assoc-ref %build-inputs > + "googletest")))= )) > + (inputs `(("git" ,git) > + ("googletest" ,(package-source googletest)))) > (synopsis "C++ library to support the benchmarking of functions") > (description > "The googlebenchmark C++ library support the benchmarking of functi= ons, > > base-commit: b8fd792ea267cb920da0651074a533d8abf00488 > -- > 2.46.0 Hi Aaron, I see there is now a 1.9.1 release. Why was git added as an input? If it's for the project version parsing, git is not required for tagged releases: -- Could NOT find Git (missing: GIT_EXECUTABLE) -- Google Benchmark version: v1.9.1, normalized to 1.9.1 Also, I think we prefer to leave the formatting unchanged when making simple changes like this. Greg From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 13:24:37 2025 Received: (at 73760) by debbugs.gnu.org; 21 Mar 2025 17:24:38 +0000 Received: from localhost ([127.0.0.1]:39354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvg6n-0001cj-C9 for submit@debbugs.gnu.org; Fri, 21 Mar 2025 13:24:37 -0400 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:54669) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tvg6h-0001cO-O3 for 73760@debbugs.gnu.org; Fri, 21 Mar 2025 13:24:33 -0400 Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-476a57a9379so30955401cf.1 for <73760@debbugs.gnu.org>; Fri, 21 Mar 2025 10:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1742577866; x=1743182666; darn=debbugs.gnu.org; h=mime-version:organization:references:in-reply-to:message-id:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LWYwZivlp9Iqz3bRgZATwMK6ewa/CuGKruilCLkY9sU=; b=SDZFdbaD73ZtaL7209Q5H9RIowa08hevsrDFexwDAA8WrQhlTN7UGDr1SCfKNab8tD peqSvz63YIDXwesqzBehlaL/El+rRuZ0rpIhOpB4p6H3qldak5oBnCsLwVHzhEzwUq99 L9aunEHKwZ856lce85IlIn8GR94/+Ia2CJkR0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742577866; x=1743182666; h=mime-version:organization:references:in-reply-to:message-id:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LWYwZivlp9Iqz3bRgZATwMK6ewa/CuGKruilCLkY9sU=; b=wsuY/BDaa34m2B6JjDFenDncJYyn1QvPNlfoEW70kBll7YA++NIIqFGWh04+YfqzFc +zqz6/eKVAraHh5GI2aYCOqkEfOqUUGeZC1SLfAPYwMru5kccZS3+fufR24SHmdcoH2R xaZLDU8SvM46JvMeK4pqt/VHaOhmGBi08KRHuQl+aOUrC2ONs/OoFCiwRLL1QfONigUo axLIfkaR2aU0UAK7GFGQPgNQ3/ypEpS65KevsNt0kwzw2q+wHkTUoebcyWz+qEw1zB0N PQPW8s039o6yy+y8RoCqDRY3X8bl+g7ZRSAuhd93u6APvfHpDJO9QfmWONgjjaCjyA7C Y+ww== X-Gm-Message-State: AOJu0YxuVkdTQNaHXeWJsrhejOmMBu2pnz8yV7+SVjSYr7r/935Jn6Xj qQpYbgVs6JU35PZBwlX4xepg0TBfZ8tA/IHU4iLIChHzVlPn+mhoUHbMmManXA== X-Gm-Gg: ASbGncumd6TuWgkmjckIqwvllNv15YHy/OoopdRmSTfCUbBEQ9qw/iGrCBiQ6wVNDfd JG4wqJHJFvKnmCpknNAn6Fm0BLyksrlLRx5hLp5AK+48uA9sLrxxQIKORqA4sH2BehViBGU6Tqa /sVwYWpNcz23TZ1nq/v+rxLMI4ajQH/XYzpwJ4eU2cHyvGjsrUDzs9NoD0n1+Kg7b5XaLqj3PHg VsX5rldyCxtZGAIjc7YP02UgL4PH70gesDVeVIuPR7hmBCz0l6D6J0zOVjecU1YFxqYAsbuQNqG AVQo9iLOOGQ5WNYBfdizhZB8rxLHSbMCGPJUV/YGyF23v4TQFVif8V70Qhp9nlDzPl3+So8FFpx cmV9GNUgUBjse8gnp9mZRTiY= X-Google-Smtp-Source: AGHT+IFMLVBim128nungBjHRivn3qoBi+pSSgENmr2OX7FTjhQ34DEPC8Mixni3Xa/JVc8jirRYFzA== X-Received: by 2002:a05:622a:5c05:b0:476:6189:4f30 with SMTP id d75a77b69052e-4771de5cc6dmr66075481cf.36.1742577865447; Fri, 21 Mar 2025 10:24:25 -0700 (PDT) Received: from mobile-dev (pool-71-244-152-222.bltmmd.fios.verizon.net. [71.244.152.222]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4771d192d84sm14503221cf.48.2025.03.21.10.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 10:24:24 -0700 (PDT) Date: Fri, 21 Mar 2025 13:24:21 -0400 From: Aaron Covrig To: Greg Hogan Subject: Re: [bug#73760] [PATCH] gnu: Upgrade googlebenchmark Message-ID: <20250321132421.7c34b7b1@mobile-dev> In-Reply-To: References: <20241012014207.130885-1-aaron.covrig.us@ieee.org> Organization: IEEE X-Mailer: Claws Mail 4.3.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/OjmDGW3CirJxKc0l3fnil6D"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73760 Cc: 73760@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/OjmDGW3CirJxKc0l3fnil6D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 21 Mar 2025 09:55:56 -0400 Greg Hogan wrote: > On Fri, Oct 11, 2024 at 9:43=E2=80=AFPM Aaron Covrig via Guix-patches via > wrote: > > > > * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0 > > --- > > gnu/packages/check.scm | 30 ++++++++++++++++-------------- > > 1 file changed, 16 insertions(+), 14 deletions(-) > > > > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm > > index 8d41996c71..e0bd71e6d3 100644 > > --- a/gnu/packages/check.scm > > +++ b/gnu/packages/check.scm > > @@ -105,6 +105,7 @@ (define-module (gnu packages check) > > #:use-module (gnu packages texinfo) > > #:use-module (gnu packages time) > > #:use-module (gnu packages xml) > > + #:use-module (gnu packages version-control) > > #:use-module (guix utils) > > #:use-module ((guix licenses) #:prefix license:) > > #:use-module (guix packages) > > @@ -1098,24 +1099,25 @@ (define-public googletest-1.8 > > (define-public googlebenchmark > > (package > > (name "googlebenchmark") > > - (version "1.8.3") > > + (version "1.9.0") > > (home-page "https://github.com/google/benchmark") > > - (source (origin > > - (method git-fetch) > > - (uri (git-reference (url home-page) > > - (commit (string-append "v" > > version)))) > > - (file-name (git-file-name "google-benchmark" > > version)) > > - (sha256 > > - (base32 > > - > > "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3")))) > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url home-page) > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name "google-benchmark" version)) > > + (sha256 > > + (base32 > > "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5")))) > > (build-system cmake-build-system) (arguments > > '(#:configure-flags (list "-DBUILD_SHARED_LIBS=3DON" > > - (string-append > > - "-DGOOGLETEST_PATH=3D" > > - (assoc-ref %build-inputs > > "googletest"))))) > > - (inputs > > - `(("googletest" ,(package-source googletest)))) > > + (string-append "-DGOOGLETEST_PATH=3D" > > + (assoc-ref > > %build-inputs > > + > > "googletest"))))) > > + (inputs `(("git" ,git) > > + ("googletest" ,(package-source googletest)))) > > (synopsis "C++ library to support the benchmarking of > > functions") (description > > "The googlebenchmark C++ library support the benchmarking of > > functions, > > > > base-commit: b8fd792ea267cb920da0651074a533d8abf00488 > > -- > > 2.46.0 =20 >=20 > Hi Aaron, >=20 > I see there is now a 1.9.1 release. >=20 > Why was git added as an input? If it's for the project version > parsing, git is not required for tagged releases: >=20 > -- Could NOT find Git (missing: GIT_EXECUTABLE) > -- Google Benchmark version: v1.9.1, normalized to 1.9.1 >=20 > Also, I think we prefer to leave the formatting unchanged when making > simple changes like this. >=20 > Greg It's been a while, but I believe I added it for the project version; I can push up an update for v1.9.1 that excludes git and uses the internal project version. As for the formatting, that is likely from running `guix style` before submitting, I can also drop it though for the submission. v/r, Aaron --Sig_/OjmDGW3CirJxKc0l3fnil6D Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSPXVwROJGaYSBOwhhfTkc5aZTD/QUCZ92gxQAKCRBfTkc5aZTD /U1YAQC9kZIz5HlnZm8tODFCsbgum1yjR5my2X81qQz05f4ptwD/Yl8DiLfrcEXw fp3KTSG2dG+k7WzQirGE9TLG+jOVww0= =2FiB -----END PGP SIGNATURE----- --Sig_/OjmDGW3CirJxKc0l3fnil6D-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 13:25:58 2025 Received: (at 73760) by debbugs.gnu.org; 21 Mar 2025 17:25:58 +0000 Received: from localhost ([127.0.0.1]:39364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvg86-0001lD-7u for submit@debbugs.gnu.org; Fri, 21 Mar 2025 13:25:58 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:58499) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tvg83-0001ky-An for 73760@debbugs.gnu.org; Fri, 21 Mar 2025 13:25:55 -0400 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-6e8f94c2698so11962706d6.0 for <73760@debbugs.gnu.org>; Fri, 21 Mar 2025 10:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1742577949; x=1743182749; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GS96ZOpZ56PlQY4AchGcevgHARHOjLSX6483IFchQis=; b=dowCMNws7xTNEpI6pO5ZIhz8Z9S4hfjZszJEDYTUO5yf4IZMwPgmw4AKCqt/t4sg4h uNFAJ4sfdxPk99+Nl9qGhom2+ThsuJ+6ROwVp7U0YPHA/fdz6cbQ7yqc4rYaXH+k+RC9 xy4uZ/yN/vge6GWtSZ/Lxlfa0k+L1w/D0r2as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742577949; x=1743182749; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GS96ZOpZ56PlQY4AchGcevgHARHOjLSX6483IFchQis=; b=FAHDqH0hmYk04wBftWvkgksr12MSUynY/DgbtnCsXyuGJM6zmx6Yq6EakEDEqIkKwt MNbTzPjHU8gvXUvUhfiL13I1AImJrhzz5VXK92/b6zuhMC/mv8rdBr4V+cpwRnq9WoVG TFUCX2GzIQr2244GA0KuT32pHbnS5+U2KxL9i0+6ylSje7ABAEbzN5rrAmMgFosN8XVU v4di2sTomlnchNRoyrVfmYTQ5OZ1vGTPPdakZJOifhT6KpnB4O5itunYL7bRYexNJOix +922gSr05EuKaYS0/Tc6ACyNWiz0YFus6+cpbF5RFGALHLz3Qu+HE/oOTcy7wUjMGDFE S6FQ== X-Gm-Message-State: AOJu0YzLyAtNgh3PcsCTW3lQmm0SBv5jstp0DboZmXkrmtqfZ0pfY0I7 ODBt7H9vDH8Tc/d8qNf8TprEcsA/uaPjV0WIzLTpV8lTwmOVag+EnkxFAgV71qIDjmIrxLDKslF 7E4NPzTTwsRKEKbsnPtrNUi/z2PCoGknD/uaqyvowC8S2YPNdlgajtnVK504uRVk75kLujYrvpk KjxDjJoFIEfVw8nVuFOKintr+GktVTAuXEqSeh82I= X-Gm-Gg: ASbGnct0X/YsRVuajyidqfLwTgb5k29O8DjL/pYh0du7YIY+G90DtGWSH8jeiWp5SrT WXdDMy2ziCdtY8gR8QAuz1N/JgSvrrnWrl35f6Yln5w0k6gERdSsJhwCk46UoGf1cE5EPJmZnh6 E1ucDcGtGjnhiDtbUVqwirxnaQkWXgcLQZbz99WvAgdwdvV7NUh3bKobJyysaqY6pGg7vb22jcT CvkramyXJieQSBbyMB7GkjVVBLr45aR4Ycv/rahv3DOY3Mt5qPkKrucRmOr20XDOJMzQ+P0j4JW 5vAxQb119Pit/Dnch2BZ09IwX6VWhaWMOrsiJbmfyHQlpILjF9l7WrmRfXoHDPUv66hNWn8of4Q x9x0Vnw2AfWaSSOVgjuEifIFSkJ6osRL3bWo= X-Google-Smtp-Source: AGHT+IGfIfVjOsUdonj1lPcj9VoUZqPJMmEmjIlorRqBZLgo+xI4VxUMcrCxQRG8kU7T7hbCr/QDdg== X-Received: by 2002:a05:6214:1c0c:b0:6e2:43d1:5fd0 with SMTP id 6a1803df08f44-6eb3f33d4f0mr55668526d6.31.1742577948641; Fri, 21 Mar 2025 10:25:48 -0700 (PDT) Received: from mobile-dev.fios-router.home (pool-71-244-152-222.bltmmd.fios.verizon.net. [71.244.152.222]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eb3ef0f03dsm13294396d6.2.2025.03.21.10.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 10:25:48 -0700 (PDT) From: Aaron Covrig X-Google-Original-From: Aaron Covrig To: 73760@debbugs.gnu.org Subject: [PATCH v2] gnu: googlebenchmark: Upgrade to v1.9.1. Date: Fri, 21 Mar 2025 13:25:25 -0400 Message-ID: <20250321172542.73122-1-aarcov@gmail.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73760 Cc: Aaron Covrig X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Aaron Covrig * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.1. --- gnu/packages/check.scm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 4994a10f11..38c10c91be 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1104,7 +1104,7 @@ (define-public googletest-1.8 (define-public googlebenchmark (package (name "googlebenchmark") - (version "1.8.3") + (version "1.9.1") (home-page "https://github.com/google/benchmark") (source (origin (method git-fetch) @@ -1113,15 +1113,14 @@ (define-public googlebenchmark (file-name (git-file-name "google-benchmark" version)) (sha256 (base32 - "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3")))) + "1ky51j4hbqcaxp7i7sfiyh1435mgyijgbfgc48bbmi52vgay0477")))) (build-system cmake-build-system) (arguments '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON" (string-append "-DGOOGLETEST_PATH=" (assoc-ref %build-inputs "googletest"))))) - (inputs - `(("googletest" ,(package-source googletest)))) + (inputs `(("googletest" ,(package-source googletest)))) (synopsis "C++ library to support the benchmarking of functions") (description "The googlebenchmark C++ library support the benchmarking of functions, base-commit: efac1498c15198afc4f9a2bc700408bde1b3b3ed -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 15:45:36 2025 Received: (at 73760-done) by debbugs.gnu.org; 21 Mar 2025 19:45:37 +0000 Received: from localhost ([127.0.0.1]:39627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tviJE-0008Sa-KU for submit@debbugs.gnu.org; Fri, 21 Mar 2025 15:45:36 -0400 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:58568) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tviJB-0008SD-F5 for 73760-done@debbugs.gnu.org; Fri, 21 Mar 2025 15:45:34 -0400 Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-726819aa3fcso1498983a34.0 for <73760-done@debbugs.gnu.org>; Fri, 21 Mar 2025 12:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1742586327; x=1743191127; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7oOlRtUyrXiyz7nF5NPBexFSmYcYsfJXcyXGiOSngnk=; b=R7XrRjZIrmdypOSQA4K/9hnKuzgYuVL0l+OdRhDfy1kHDIn68El2zH/Q8lX8vTvqys jXuD5ySBk2ciGAghTSsr9deteXOJjkhY5QNz9bLO5xeaA7/A2yVw2GHPORrp3c3NQnte sqw9vRBuEMoiwNUzrU8Mxcx6qRWQfHgV4pgyPv3GiWycZag/OFlOcB6LhqYNpglIVQIr 4wQ2A1nQ+mWxOuje7DmjEOzCpUZc8SjAE2xUGMqOUXvqOyIf7fPBb+j4zsJcUc+vziMw NhCdiiOO9O5u6YAzpVOL7xJGtRPl+/0BOmfl24NB1awsWJ41nf68wXN76IQRU+gXvzGA 2KTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742586327; x=1743191127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7oOlRtUyrXiyz7nF5NPBexFSmYcYsfJXcyXGiOSngnk=; b=mqgLjSLXh14hZUZgEGvMn6oP725VcHORK64beLAZ6wg+z+PL4mSz4EyCL8v7mBbzq/ +rcrmkBoQQ/2DOw7XtXxNlnPJzoA2mOO1ct86oKkgBHJjwXSBF1qUHUvBhyncnra3krf +WpB3ALtvYcP0eiSXzZGHxsrVq5aNmMHBFoSPCHoW/Tji+ehiPy5L0di1yL9LEq7ZeZZ hUs2EHTXsOU+FvW+nPXdYWOGrdxhCnuBtAratYeedM+c0HEEbDWJFC7j3//iUNYW9RnQ G5tcRcqE8n+uGkY1R3SW5oL5tzs+al9f6FRPip3XMp8tzJm3pooxn0UR6X1upJ70WkV3 vwBQ== X-Gm-Message-State: AOJu0YxoFt1uA6lEIvLTxoakTOjNbzTufT7Hw04RwtR/oOa+MhzB6+To sYFQBJrRqKDWQRxPnUWcgt/lvEj7p6stzqVkYtjPJ9pLrLDPrzAiIU2vpMef4b6HbQA6E80s9Kw rn2+cYS94aGxcKxverCwjTk6uR6LY1eptaXP21A== X-Gm-Gg: ASbGncvzCcc/cSBVOXWZXhXBIN0dU58lHenu20sRkPBbnX8XmVpSMS5fD4/sHbYvloa IOOCLOAJWROuCTfA5v3bmeSu0ojs/HJorGBgK3VnlI+o/6KDvuUXX+Cw2UwOh4tYbNrbI6gUKwh 5sBkLU+PDJwo11hCSZCXnEnv3ziAsyWmNLJV1D X-Google-Smtp-Source: AGHT+IGx/PberZRJPHbvmVRbwUbQeIx/2fyFZilULRUomrh7PfrxDSWW25nZa9p8UgKCd56sElkk9rF7CwCfF7UGoIQ= X-Received: by 2002:a05:6830:6587:b0:72b:81cd:e123 with SMTP id 46e09a7af769-72c0ae99a09mr3812147a34.16.1742586327347; Fri, 21 Mar 2025 12:45:27 -0700 (PDT) MIME-Version: 1.0 References: <20241012014207.130885-1-aaron.covrig.us@ieee.org> <20250321172542.73122-1-aarcov@gmail.com> In-Reply-To: <20250321172542.73122-1-aarcov@gmail.com> From: Greg Hogan Date: Fri, 21 Mar 2025 15:45:16 -0400 X-Gm-Features: AQ5f1Jo2OFHg1PJXWMNV9eP3yUwsph0wkHc7KsaDLFos4Sh2JjauFL7BQKru4bs Message-ID: Subject: Re: [bug#73760] [PATCH v2] gnu: googlebenchmark: Upgrade to v1.9.1. To: Aaron Covrig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73760-done Cc: 73760-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Mar 21, 2025 at 1:26=E2=80=AFPM Aaron Covrig via Guix-patches via wrote: > > From: Aaron Covrig > > * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.1. > --- > gnu/packages/check.scm | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm > index 4994a10f11..38c10c91be 100644 > --- a/gnu/packages/check.scm > +++ b/gnu/packages/check.scm > @@ -1104,7 +1104,7 @@ (define-public googletest-1.8 > (define-public googlebenchmark > (package > (name "googlebenchmark") > - (version "1.8.3") > + (version "1.9.1") > (home-page "https://github.com/google/benchmark") > (source (origin > (method git-fetch) > @@ -1113,15 +1113,14 @@ (define-public googlebenchmark > (file-name (git-file-name "google-benchmark" version)) > (sha256 > (base32 > - "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))= )) > + "1ky51j4hbqcaxp7i7sfiyh1435mgyijgbfgc48bbmi52vgay0477"))= )) > (build-system cmake-build-system) > (arguments > '(#:configure-flags (list "-DBUILD_SHARED_LIBS=3DON" > (string-append > "-DGOOGLETEST_PATH=3D" > (assoc-ref %build-inputs "googletest")))= )) > - (inputs > - `(("googletest" ,(package-source googletest)))) > + (inputs `(("googletest" ,(package-source googletest)))) > (synopsis "C++ library to support the benchmarking of functions") > (description > "The googlebenchmark C++ library support the benchmarking of functi= ons, > > base-commit: efac1498c15198afc4f9a2bc700408bde1b3b3ed > -- > 2.48.1 Pushed as 5bf7d80535720077aec104a9904480d08b9b4f2b. From unknown Sat Sep 20 07:39:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Apr 2025 11:24:57 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator